Re: [ovs-dev] [PATCH] ovsdb-cs: fix 'cs_db' lock flag not free error.

2023-04-06 Thread 0-day Robot
Bleep bloop. Greetings 汪翰林, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 12 error: could not build fake ancestor hint: Use 'git am

[ovs-dev] [PATCH] ovsdb-cs: fix 'cs_db' lock flag not free error.

2023-04-06 Thread 汪翰林
When 'cs' is not connected to a server, then ovsdb_cs_db_compose_lock_request__ will update 'cs_db' lock flag, but the lock flag will not be free next. Signed-off-by: wanghanlin ---  lib/ovsdb-cs.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovsdb-cs.c

[ovs-dev] [PATCH v3] util: fix an issue that thread name cannot be set

2023-04-06 Thread Songtao Zhan
To: d...@openvswitch.org, i.maxim...@ovn.org The name of the current thread consists of a name with a maximum length of 16 bytes and a thread ID. The final name may be longer than 16 bytes. If the name is longer than 16 bytes, the thread name will fail to be set Signed-off-by: Songtao Zhan

Re: [ovs-dev] [PATCH net v3] net: openvswitch: fix race on port output

2023-04-06 Thread Jakub Kicinski
On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote: > assume the following setup on a single machine: > 1. An openvswitch instance with one bridge and default flows > 2. two network namespaces "server" and "client" > 3. two ovs interfaces "server" and "client" on the bridge > 4. for each ovs

Re: [ovs-dev] [PATCH v2] util: fix an issue that thread name cannot be set

2023-04-06 Thread Songtao Zhan
On Thu, Apr 06, 2023 at 10:37:50PM +0200, Ilya Maximets wrote: > On 4/6/23 13:08, zhanst1 wrote: > > On Wed, Apr 05, 2023 at 03:13:47PM +0200, Eelco Chaudron wrote: > >> > >> > >> On 31 Mar 2023, at 10:11, Songtao Zhan wrote: > >> > >>> To: d...@openvswitch.org, > >>> i.maxim...@ovn.org > >>>

Re: [ovs-dev] [PATCH 0/6] ovsdb: conversion: Bug fixes & Optimizations.

2023-04-06 Thread Ilya Maximets
On 4/6/23 16:31, Dumitru Ceara wrote: > On 3/27/23 21:42, Ilya Maximets wrote: >> This patch set aims to solve the issue of database conversion for >> reasonably sized databases in high-scale OVN setups discussed here: >> >>

Re: [ovs-dev] [PATCH v2] github: Test building Fedora RPMs.

2023-04-06 Thread Ilya Maximets
On 4/6/23 12:00, Eelco Chaudron wrote: > > > On 5 Apr 2023, at 21:41, Ilya Maximets wrote: > >> Testing that RPMs can be built to catch possible spec file >> issues like missing dependencies. >> >> GitHub seems to have an agreement with Docker Hub about rate >> limiting of image downloads, so

Re: [ovs-dev] [PATCH v3] ovs-dpctl: Add new command dpctl/ct-[sg]et-sweep-interval.

2023-04-06 Thread Ilya Maximets
On 4/6/23 15:17, Simon Horman wrote: > On Thu, Apr 06, 2023 at 12:10:22PM +0200, Paolo Valerio wrote: >> Since 3d9c1b855a5f ("conntrack: Replace timeout based expiration lists >> with rculists.") the sweep interval changed as well as the constraints >> related to the sweeper. >> Being able to

Re: [ovs-dev] [PATCH v3] ovs-tcpdump: Stdout is shutdown before ovs-tcpdump exit

2023-04-06 Thread Ilya Maximets
On 4/4/23 05:16, Songtao Zhan wrote: > > To: d...@openvswitch.org, > i.maxim...@ovn.org > > If there is a pipe behind ovs-tcpdump(such as ovs-tcpdump -i eth0 > | grep "192.168.1.1"), the child process (grep "192.168.1.1") may > exit first and close the pipe when received SIGTERM. When

Re: [ovs-dev] [PATCH ovn branch-22.09] ci: ovn-kubernetes: Pin ovn-k8s version.

2023-04-06 Thread Ilya Maximets
On 4/6/23 21:57, Dumitru Ceara wrote: > Recently, ovn-k8s started using the new OVN Northbound database table > Chassis_Template_Var that was added in v22.12.0. Unfortunately, > ovn-k8s (libovsdb) became incompatible with OVN 22.09 as it doesn't > support connecting to servers that don't contain

Re: [ovs-dev] [PATCH v2] util: fix an issue that thread name cannot be set

2023-04-06 Thread Ilya Maximets
On 4/6/23 13:08, zhanst1 wrote: > On Wed, Apr 05, 2023 at 03:13:47PM +0200, Eelco Chaudron wrote: >> >> >> On 31 Mar 2023, at 10:11, Songtao Zhan wrote: >> >>> To: d...@openvswitch.org, >>> i.maxim...@ovn.org >>> >>> The name of the current thread consists of a name with a maximum >>> length

[ovs-dev] [PATCH ovn branch-22.09] ci: ovn-kubernetes: Pin ovn-k8s version.

2023-04-06 Thread Dumitru Ceara
Recently, ovn-k8s started using the new OVN Northbound database table Chassis_Template_Var that was added in v22.12.0. Unfortunately, ovn-k8s (libovsdb) became incompatible with OVN 22.09 as it doesn't support connecting to servers that don't contain this table in their schema. It's still

Re: [ovs-dev] [PATCH ovn v7 2/2] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ales Musil
On Thu, Apr 6, 2023 at 5:31 PM Ilya Maximets wrote: > On 4/6/23 16:53, Ales Musil wrote: > > > > > > On Thu, Apr 6, 2023 at 4:48 PM Ilya Maximets > wrote: > > > > On 4/6/23 16:37, Ales Musil wrote: > > > There are essentially three problems with the current >

[ovs-dev] [PATCH ovn v8 2/2] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ales Musil
There are essentially three problems with the current combination of DGP + SNAT + LB: 1) The first packet is being SNATed in common zone due to a problem with pinctrl not preserving ct_mark/ct_label. The commit would create a SNAT entry within the same with DNAT entry. 2) The unSNAT for reply

[ovs-dev] [PATCH ovn v8 1/2] northd: Update the is_stateless helper for rotuer nat

2023-04-06 Thread Ales Musil
The stateless can be applied only to "snat_and_dnat" nat type. Update the helper to reflect that. Fixes: cc87c4827f47 ("OVN: Use ip4.src and ip4.dst actions for NAT rules") Signed-off-by: Ales Musil --- v8: No change since v7. --- northd/northd.c | 31 --- 1 file

Re: [ovs-dev] [PATCH ovn v7 2/2] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ilya Maximets
On 4/6/23 16:53, Ales Musil wrote: > > > On Thu, Apr 6, 2023 at 4:48 PM Ilya Maximets > wrote: > > On 4/6/23 16:37, Ales Musil wrote: > > There are essentially three problems with the current > > combination of DGP + SNAT + LB: > > > > 1) The

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-06 Thread Dumitru Ceara
On 4/6/23 14:45, Simon Horman wrote: > On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote: >> On 4/5/23 14:43, Simon Horman wrote: >>> On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote: Similar to qos_max_rate and qos_burst, take into account qos_min_rate in

[ovs-dev] [PATCH ovn v3] controller: Clear tunnels from old integration bridge

2023-04-06 Thread Ales Musil
After integration bridge change the tunnels would stay on the old bridge preventing new tunnels creation and disrupting traffic. Detect the bridge change and clear the tunnels from the old integration bridge. Reported-at: https://bugzilla.redhat.com/2173635 Signed-off-by: Ales Musil --- v2: Make

Re: [ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.2.

2023-04-06 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.2.

2023-04-06 Thread Ilya Maximets
On 4/6/23 16:30, Ilya Maximets wrote: > On 4/6/23 15:25, Aaron Conole wrote: >> Ilya Maximets writes: >> >>> Signed-off-by: Ilya Maximets >>> --- >> >> Acked-by: Aaron Conole >> > > Thanks, Aaron! I'm waiting for CI on the CVE fix to finish, > then I'll apply these patches and tag releases.

Re: [ovs-dev] [PATCH branch-3.1 1/2] Set release date for 3.1.1.

2023-04-06 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH ovn v7 2/2] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ales Musil
On Thu, Apr 6, 2023 at 4:48 PM Ilya Maximets wrote: > On 4/6/23 16:37, Ales Musil wrote: > > There are essentially three problems with the current > > combination of DGP + SNAT + LB: > > > > 1) The first packet is being SNATed in common zone due > > to a problem with pinctrl not preserving

Re: [ovs-dev] [PATCH ovn v7 2/2] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ilya Maximets
On 4/6/23 16:37, Ales Musil wrote: > There are essentially three problems with the current > combination of DGP + SNAT + LB: > > 1) The first packet is being SNATed in common zone due > to a problem with pinctrl not preserving ct_mark/ct_label. > The commit would create a SNAT entry within the

Re: [ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ales Musil
On Thu, Apr 6, 2023 at 4:42 PM Dumitru Ceara wrote: > On 4/6/23 16:26, Ales Musil wrote: > > On Thu, Apr 6, 2023 at 1:17 PM Dumitru Ceara wrote: > > > >> On 3/29/23 16:57, Numan Siddique wrote: > >>> On Wed, Mar 29, 2023 at 6:15 AM Dumitru Ceara > wrote: > > On 3/29/23 11:20, Ales

Re: [ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Dumitru Ceara
On 4/6/23 16:26, Ales Musil wrote: > On Thu, Apr 6, 2023 at 1:17 PM Dumitru Ceara wrote: > >> On 3/29/23 16:57, Numan Siddique wrote: >>> On Wed, Mar 29, 2023 at 6:15 AM Dumitru Ceara wrote: On 3/29/23 11:20, Ales Musil wrote: > There are essentially three problems with the

[ovs-dev] [PATCH ovn v7 1/2] northd: Update the is_stateless helper for rotuer nat

2023-04-06 Thread Ales Musil
The stateless can be applied only to "snat_and_dnat" nat type. Update the helper to reflect that. Fixes: cc87c4827f47 ("OVN: Use ip4.src and ip4.dst actions for NAT rules") Signed-off-by: Ales Musil --- northd/northd.c | 31 --- 1 file changed, 12 insertions(+), 19

[ovs-dev] [PATCH ovn v7 2/2] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ales Musil
There are essentially three problems with the current combination of DGP + SNAT + LB: 1) The first packet is being SNATed in common zone due to a problem with pinctrl not preserving ct_mark/ct_label. The commit would create a SNAT entry within the same with DNAT entry. 2) The unSNAT for reply

Re: [ovs-dev] [PATCH 0/6] ovsdb: conversion: Bug fixes & Optimizations.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:42, Ilya Maximets wrote: > This patch set aims to solve the issue of database conversion for > reasonably sized databases in high-scale OVN setups discussed here: > https://mail.openvswitch.org/pipermail/ovs-discuss/2022-December/052140.html > > The general approach is described

Re: [ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.2.

2023-04-06 Thread Ilya Maximets
On 4/6/23 15:25, Aaron Conole wrote: > Ilya Maximets writes: > >> Signed-off-by: Ilya Maximets >> --- > > Acked-by: Aaron Conole > Thanks, Aaron! I'm waiting for CI on the CVE fix to finish, then I'll apply these patches and tag releases. Best regards, Ilya Maximets.

Re: [ovs-dev] [PATCH ovn v2] controller: Clear tunnels from old integration bridge

2023-04-06 Thread Ales Musil
On Thu, Apr 6, 2023 at 3:05 PM Simon Horman wrote: > On Mon, Apr 03, 2023 at 11:50:26AM +0200, Ales Musil wrote: > > After integration bridge change the tunnels would > > stay on the old bridge preventing new tunnels creation > > and disrupting traffic. Detect the bridge change > > and clear the

Re: [ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Ales Musil
On Thu, Apr 6, 2023 at 1:17 PM Dumitru Ceara wrote: > On 3/29/23 16:57, Numan Siddique wrote: > > On Wed, Mar 29, 2023 at 6:15 AM Dumitru Ceara wrote: > >> > >> On 3/29/23 11:20, Ales Musil wrote: > >>> There are essentially three problems with the current > >>> combination of DGP + SNAT + LB:

Re: [ovs-dev] [PATCH v1 2/2] netdev-dpdk: add netdev-dpdk ingress pkts policer.

2023-04-06 Thread lin huang
> -Original Message- > From: Ilya Maximets > Sent: Thursday, April 6, 2023 8:21 PM > To: lin huang ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; Lin Huang ; Simon > Horman > Subject: Re: [PATCH v1 2/2] netdev-dpdk: add netdev-dpdk ingress pkts > policer. > > On 4/4/23 19:24, Ilya

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-06 Thread lin huang
> -Original Message- > From: Simon Horman > Sent: Thursday, April 6, 2023 8:48 PM > To: Ilya Maximets > Cc: lin huang ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress > and egress pkts policer. > > On Thu, Apr 06, 2023 at 02:13:00PM

[ovs-dev] [PATCH] ofproto-dpif-xlate: Always mask ip proto field.

2023-04-06 Thread Ilya Maximets
From: Aaron Conole The ofproto layer currently treats nw_proto field as overloaded to mean both that a proper nw layer exists, as well as the value contained in the header for the nw proto. However, this is incorrect behavior as relevant standards permit that any value, including '0' should be

Re: [ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.5.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.1 1/2] Set release date for 3.1.1.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.9.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.9.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.10.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.12.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.4.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.7.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.8.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.6.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.2.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.7.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.11.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.8.

2023-04-06 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH branch-3.1 1/2] Set release date for 3.1.1.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 58a52120b..b6286e0b2 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v3.1.1 - xx xxx +v3.1.1 - 06 Apr 2023

[ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.2.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b6286e0b2..e59f9530b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.1.2 - xx xxx

[ovs-dev] [PATCH branch-3.1 0/2] Release patches for v3.1.1.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 3.1.1. Prepare for 3.1.2. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

[ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.5.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 89f780311..05fc07e4f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.0.5 - xx xxx

[ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.4.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ff46fef3a..89f780311 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v3.0.4 - xx xxx +v3.0.4 - 06 Apr 2023

[ovs-dev] [PATCH branch-3.0 0/2] Release patches for v3.0.4.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 3.0.4. Prepare for 3.0.5. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

[ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.6.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 45b974ed2..1253723dd 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v2.17.6 - xx xxx +v2.17.6 - 06 Apr 2023

[ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.7.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1253723dd..095b0574f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.17.7 - xx xxx

[ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.6.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 2.17.6. Prepare for 2.17.7. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

[ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.9.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 42516cad1..4626d2b81 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.15.9 - xx xxx

[ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.8.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8f914f0cd..074729038 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.16.8 - xx xxx

[ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.8.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 2.15.8. Prepare for 2.15.9. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

[ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.7.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ee3855978..8f914f0cd 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v2.16.7 - xx xxx +v2.16.7 - 06 Apr 2023

[ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.7.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 2.16.7. Prepare for 2.16.8. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

[ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.10.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2d23f0fb4..973338798 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.14.10 - xx xxx

[ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.8.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 8a34fbf5f..42516cad1 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v2.15.8 - xx xxx +v2.15.8 - 06 Apr 2023

[ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.9.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 8b4c64ae4..2d23f0fb4 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v2.14.9 - xx xxx +v2.14.9 - 06 Apr 2023

[ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.9.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 2.14.9. Prepare for 2.14.10. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

[ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.12.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1501daf53..130cf031e 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.13.12 - xx xxx

[ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.11.

2023-04-06 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 7e80b57dc..1501daf53 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v2.13.11 - xx xxx +v2.13.11 - 06 Apr 2023

Re: [ovs-dev] [PATCH v3] ovs-dpctl: Add new command dpctl/ct-[sg]et-sweep-interval.

2023-04-06 Thread Simon Horman
On Thu, Apr 06, 2023 at 12:10:22PM +0200, Paolo Valerio wrote: > Since 3d9c1b855a5f ("conntrack: Replace timeout based expiration lists > with rculists.") the sweep interval changed as well as the constraints > related to the sweeper. > Being able to change the default reschedule time may be

[ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.11.

2023-04-06 Thread Ilya Maximets
A few bug fixes accumulated over the last few months + security fixes. Ilya Maximets (2): Set release date for 2.13.11. Prepare for 2.13.12. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.39.2

Re: [ovs-dev] [PATCH ovn v2] controller: Clear tunnels from old integration bridge

2023-04-06 Thread Simon Horman
On Mon, Apr 03, 2023 at 11:50:26AM +0200, Ales Musil wrote: > After integration bridge change the tunnels would > stay on the old bridge preventing new tunnels creation > and disrupting traffic. Detect the bridge change > and clear the tunnels from the old integration bridge. > > Reported-at:

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-06 Thread Simon Horman
On Thu, Apr 06, 2023 at 02:13:00PM +0200, Ilya Maximets wrote: > On 4/6/23 08:38, Simon Horman wrote: > > On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote: > >> Hi Simon, > >> > >> : ) > >> Thanks for your reply. > >> > >> There are some explanations about your comments. > >> > >> Best

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-06 Thread Simon Horman
On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote: > On 4/5/23 14:43, Simon Horman wrote: > > On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote: > >> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in > >> port_has_qos_params routine. > >> > >>

Re: [ovs-dev] [PATCH ovn v2] controller: Clear tunnels from old integration bridge

2023-04-06 Thread Ales Musil
On Thu, Apr 6, 2023 at 1:43 PM Dumitru Ceara wrote: > On 4/5/23 15:18, Ihar Hrachyshka wrote: > > Thank you for v2! All good now. > > > > Acked-By: Ihar Hrachyshka > > > > > Thanks, Ales and Ihar! I have a comment below. If you're OK with that > I can fold the suggested change in and apply

Re: [ovs-dev] [PATCH v1 2/2] netdev-dpdk: add netdev-dpdk ingress pkts policer.

2023-04-06 Thread Ilya Maximets
On 4/4/23 19:24, Ilya Maximets wrote: > On 4/4/23 19:08, lin huang wrote: >> Hi Ilya, >> >> Thanks for looking at this patch and for your feedback. >> There are some explanations about your comments. >> >>> -Original Message- >>> From: Ilya Maximets >>> Sent: Tuesday, April 4, 2023 11:08

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-06 Thread Ilya Maximets
On 4/6/23 08:38, Simon Horman wrote: > On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote: >> Hi Simon, >> >> : ) >> Thanks for your reply. >> >> There are some explanations about your comments. >> >> Best regards, Huang Lin. >> >>> -Original Message- >>> From: Simon Horman >>>

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-06 Thread Dumitru Ceara
On 4/5/23 14:43, Simon Horman wrote: > On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote: >> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in >> port_has_qos_params routine. >> >> Fixes: dbf12e5fe1f7 ("qos: add support for port minimum bandwidth guarantee")

Re: [ovs-dev] [PATCH v9] netdev-dpdk: add control plane protection support

2023-04-06 Thread Kevin Traynor
On 06/04/2023 09:47, Robin Jarry wrote: Kevin Traynor, Mar 23, 2023 at 15:27: Hi Robin, Regarding having both features enabled, I think it's an issue that it's chronological based if they are enabled while running. It introduces another variable that might confuse things. For example, the

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-06 Thread Dumitru Ceara
On 4/4/23 23:10, Ihar Hrachyshka wrote: > Thanks for the fix! > > Acked-by: Ihar Hrachyshka > > On Tue, Apr 4, 2023 at 5:01 PM Lorenzo Bianconi > wrote: >> >> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in >> port_has_qos_params routine. >> >> Fixes: dbf12e5fe1f7

Re: [ovs-dev] [PATCH ovn v2] controller: Clear tunnels from old integration bridge

2023-04-06 Thread Dumitru Ceara
On 4/5/23 15:18, Ihar Hrachyshka wrote: > Thank you for v2! All good now. > > Acked-By: Ihar Hrachyshka > Thanks, Ales and Ihar! I have a comment below. If you're OK with that I can fold the suggested change in and apply the patch. Regards, Dumitru > On Mon, Apr 3, 2023 at 5:50 AM Ales

Re: [ovs-dev] [PATCH ovn] northd: rever ct.inv drop flows

2023-04-06 Thread Dumitru Ceara
On 4/6/23 13:24, Ilya Maximets wrote: > On 4/4/23 20:13, Lorenzo Bianconi wrote: >> Partially revert the following commit since it introduces a regression >> when we want to directly connect to a backend ip from a client outside >> the cluster for gw-router-port scenario. > > I didn't review the

Re: [ovs-dev] [PATCH ovn] northd: rever ct.inv drop flows

2023-04-06 Thread Ilya Maximets
On 4/4/23 20:13, Lorenzo Bianconi wrote: > Partially revert the following commit since it introduces a regression > when we want to directly connect to a backend ip from a client outside > the cluster for gw-router-port scenario. I didn't review the code, but I think, this patch needs a more

Re: [ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

2023-04-06 Thread Dumitru Ceara
On 3/29/23 16:57, Numan Siddique wrote: > On Wed, Mar 29, 2023 at 6:15 AM Dumitru Ceara wrote: >> >> On 3/29/23 11:20, Ales Musil wrote: >>> There are essentially three problems with the current >>> combination of DGP + SNAT + LB: >>> >>> 1) The first packet is being SNATed in common zone due >>>

Re: [ovs-dev] [PATCH v2] util: fix an issue that thread name cannot be set

2023-04-06 Thread zhanst1
On Wed, Apr 05, 2023 at 03:13:47PM +0200, Eelco Chaudron wrote: > > > On 31 Mar 2023, at 10:11, Songtao Zhan wrote: > > > To: d...@openvswitch.org, > > i.maxim...@ovn.org > > > > The name of the current thread consists of a name with a maximum > > length of 16 bytes and a thread ID. The

[ovs-dev] [PATCH v3] ovs-dpctl: Add new command dpctl/ct-[sg]et-sweep-interval.

2023-04-06 Thread Paolo Valerio
Since 3d9c1b855a5f ("conntrack: Replace timeout based expiration lists with rculists.") the sweep interval changed as well as the constraints related to the sweeper. Being able to change the default reschedule time may be convenient in some conditions, like debugging. This patch introduces new

Re: [ovs-dev] [PATCH v2] github: Test building Fedora RPMs.

2023-04-06 Thread Eelco Chaudron
On 5 Apr 2023, at 21:41, Ilya Maximets wrote: > Testing that RPMs can be built to catch possible spec file > issues like missing dependencies. > > GitHub seems to have an agreement with Docker Hub about rate > limiting of image downloads, so it should not affect us. > We may switch to quay.io

Re: [ovs-dev] [PATCH 6/6] ovsdb: monitor: Keep and maintain the initial change set.

2023-04-06 Thread Dumitru Ceara
On 4/6/23 10:47, Ilya Maximets wrote: > On 4/6/23 10:43, Ilya Maximets wrote: >> On 4/6/23 10:21, Dumitru Ceara wrote: >>> On 3/27/23 21:43, Ilya Maximets wrote: Change sets in OVSDB monitor are storing all the changes that happened between a particular transaction ID and now. Initial

Re: [ovs-dev] [PATCH v9] netdev-dpdk: add control plane protection support

2023-04-06 Thread Robin Jarry
Kevin Traynor, Mar 23, 2023 at 15:27: > Hi Robin, > > Regarding having both features enabled, I think it's an issue that it's > chronological based if they are enabled while running. It introduces > another variable that might confuse things. > > For example, the operation could be changed from

Re: [ovs-dev] [PATCH 6/6] ovsdb: monitor: Keep and maintain the initial change set.

2023-04-06 Thread Ilya Maximets
On 4/6/23 10:43, Ilya Maximets wrote: > On 4/6/23 10:21, Dumitru Ceara wrote: >> On 3/27/23 21:43, Ilya Maximets wrote: >>> Change sets in OVSDB monitor are storing all the changes that happened >>> between a particular transaction ID and now. Initial change set >>> basically contains all the

Re: [ovs-dev] [PATCH 6/6] ovsdb: monitor: Keep and maintain the initial change set.

2023-04-06 Thread Ilya Maximets
On 4/6/23 10:21, Dumitru Ceara wrote: > On 3/27/23 21:43, Ilya Maximets wrote: >> Change sets in OVSDB monitor are storing all the changes that happened >> between a particular transaction ID and now. Initial change set >> basically contains all the data. >> >> On each monitor request a new

Re: [ovs-dev] [PATCH 5/6] ovsdb: Avoid converting database twice on an initiator.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:43, Ilya Maximets wrote: > Cluster member, that initiates the schema conversion, converts the > database twice. First time while verifying the possibility of the > conversion, and the second time after reading conversion request > back from the storage. > > Keep the converted

Re: [ovs-dev] [PATCH 6/6] ovsdb: monitor: Keep and maintain the initial change set.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:43, Ilya Maximets wrote: > Change sets in OVSDB monitor are storing all the changes that happened > between a particular transaction ID and now. Initial change set > basically contains all the data. > > On each monitor request a new initial change set is created by creating > an

Re: [ovs-dev] [PATCH 4/6] ovsdb: Perform conversion with no data for clustered databases.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:42, Ilya Maximets wrote: > Currently, database schema conversion in case of clustered database > produces a transaction record with both new schema and converted > database data. So, the sequence of events is following: > > 1. Get the new schema. > 2. Convert the database to a

Re: [ovs-dev] [PATCH 3/6] ovsdb: Allow conversion records with no data in a clustered storage.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:42, Ilya Maximets wrote: > If the schema with no data was read from the clustered storage, it > should mean a database conversion request. In general, we can get: > > 1. Just data --> Transaction record. > 2. Schema + Data --> Database conversion or raft snapshot install. > 3. Just

Re: [ovs-dev] [PATCH 2/6] ovsdb: Check for ephemeral columns before writing a new schema.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:42, Ilya Maximets wrote: > Clustered databases do not support ephemeral columns, but ovsdb-server > checks for them after the conversion result is read from the storage. > It's much easier to recover if this constraint is checked before writing > to the storage instead. > > It's not

Re: [ovs-dev] [PATCH 1/6] ovsdb-tool: Fix cluster-to-standalone for DB conversion records.

2023-04-06 Thread Dumitru Ceara
On 3/27/23 21:42, Ilya Maximets wrote: > If database conversion happens, both schema and the new data are > present in the database record. However, the schema is just silently > ignored by ovsdb-tool cluster-to-standalone. This creates data > inconsistency if the new data contains new columns,

Re: [ovs-dev] [PATCH v2] github: Test building Fedora RPMs.

2023-04-06 Thread David Marchand
On Wed, Apr 5, 2023 at 9:41 PM Ilya Maximets wrote: > > Testing that RPMs can be built to catch possible spec file > issues like missing dependencies. > > GitHub seems to have an agreement with Docker Hub about rate > limiting of image downloads, so it should not affect us. > We may switch to

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-06 Thread Simon Horman
On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote: > Hi Simon, > > : ) > Thanks for your reply. > > There are some explanations about your comments. > > Best regards, Huang Lin. > > > -Original Message- > > From: Simon Horman > > Sent: Wednesday, April 5, 2023 8:28 PM > > To: