Re: [ovs-dev] [PATCH v2] bridge ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling fix unexpected values

2023-07-03 Thread Sayali Naval (sanaval) via dev
As per the Open vSwitch Manual (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge IPFIX parameters can be passed as follows: ovs-vsctl -- set Bridge br0 ipfix=@i \ -- --id=@i create IPFIX targets=\"192.168.0.34:4739\" obs_do‐ main_id=123

Re: [ovs-dev] [PATCH v1] bridge ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling fix unexpected values

2023-07-03 Thread 0-day Robot
Bleep bloop. Greetings Sayali Naval (sanaval), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Sayali Naval \(sanaval\) needs to sign off. WARNING: Unexpected

[ovs-dev] [PATCH v1] bridge ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling fix unexpected values

2023-07-03 Thread Sayali Naval (sanaval) via dev
As per the Open vSwitch Manual (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge IPFIX parameters can be passed as follows: ovs-vsctl -- set Bridge br0 ipfix=@i \ -- --id=@i create IPFIX targets=\"192.168.0.34:4739\" obs_do‐ main_id=123

Re: [ovs-dev] [PATCH v2] ovs-vsctl: Exit with error if postdb checks report errors.

2023-07-03 Thread Ilya Maximets
On 6/30/23 18:33, Flavio Leitner wrote: > > On 6/30/23 12:31, Aaron Conole wrote: >> Flavio Leitner writes: >> >>> Today the exit code refers to the execution of the change >>> in the database. However, when not using parameter --no-wait >>> (default), the ovs-vsctl also checks if OVSDB

Re: [ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2023-07-03 Thread Ilya Maximets
On 7/2/23 11:59, Tao Liu wrote: > Commit 02f31a1262fc has fixed the row references when insertion and > deletion execute in one IDL run. However, we can still hit ovn-controller > crash in pressure test where pb->datapath == NULL. It is triggered by > reference dst deletion in same IDL run: > >

Re: [ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-07-03 Thread Ilya Maximets
On 7/3/23 18:10, David Marchand wrote: > On Thu, Jun 29, 2023 at 9:43 PM Ilya Maximets wrote: >> >> On 6/20/23 13:26, David Marchand wrote: >>> At some point in OVS history, some virtio features were announced as >>> supported (ECN and UFO virtio features). >>> >>> The userspace TSO code, which

Re: [ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-07-03 Thread David Marchand
On Thu, Jun 29, 2023 at 9:43 PM Ilya Maximets wrote: > > On 6/20/23 13:26, David Marchand wrote: > > At some point in OVS history, some virtio features were announced as > > supported (ECN and UFO virtio features). > > > > The userspace TSO code, which has been added later, does not support > >

[ovs-dev] OVN Website update proposal

2023-07-03 Thread Mark Michelson
Hi everyone, I have created a new github repo to house scripts for updating and maintaining the OVN website. You can find that repo here: https://github.com/putnopvut/ovn-website-scripts.git The justification is that automating website updates is going to be necessary since the OVN team

[ovs-dev] OVS "soft freeze" for 3.2 is in effect.

2023-07-03 Thread Ilya Maximets
Hi. As described in Documentation/internals/release-process.rst, we are in a "soft freeze" state: During the freeze, we ask committers to refrain from applying patches that add new features unless those patches were already being publicly discussed and reviewed before the freeze began.

Re: [ovs-dev] [PATCH] ovsdb: raft: Support pre-vote mechanism to deal with disruptive server.

2023-07-03 Thread Ilya Maximets
On 7/1/23 04:43, Han Zhou wrote: > > > On Fri, Jun 30, 2023 at 4:30 PM Ilya Maximets > wrote: >> >> On 6/25/23 19:35, Han Zhou wrote: >> > When a server becomes unstable due to overloading or intermittent >> > partitioning, it may miss some heartbeats and then starts

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

2023-07-03 Thread Alin Serdean
Thanks for taking care of it Ilya! Alin. Sent from phone > On 3 Jul 2023, at 14:59, Ilya Maximets wrote: > > On 7/1/23 01:55, Ilya Maximets wrote: >>> On 7/1/23 01:43, Ilya Maximets wrote: >>> On 6/8/23 12:07, Alin Serdean wrote: Ack, I will try to see if I can get GH actions. It

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

2023-07-03 Thread Ilya Maximets
On 7/1/23 01:55, Ilya Maximets wrote: > On 7/1/23 01:43, Ilya Maximets wrote: >> On 6/8/23 12:07, Alin Serdean wrote: >>> Ack, I will try to see if I can get GH actions. >>> It would also be better to have everything integrated in one place. >>> >>> I remember the discussion and the PR… I had some

[ovs-dev] [PATCH] ovs-tcpdump: Bugfix-of-ovs-tcpdump

2023-07-03 Thread 冮晔维
From: gangyewei Fix bug of ovs-tcpdump, which will cause megaflow action wrong. As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6 address by default. For vxlan topology, mipxxx will be treated as tunnel port, and will got error actions. For detail discuss, refer email of ovs-discuss

Re: [ovs-dev] [PATCH 1/6] dpif-netdev: Rename pmd-maxsleep config option.

2023-07-03 Thread David Marchand
On Thu, Jun 29, 2023 at 4:30 PM Simon Horman wrote: > > On Wed, Jun 14, 2023 at 02:36:39PM +0100, Kevin Traynor wrote: > > other_config:pmd-maxsleep is a config option to allow > > PMD thread cores to sleep under low or no load conditions. > > > > Rename it to 'pmd-sleep-max' to allow a more

Re: [ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-07-03 Thread Ilya Maximets
On 7/3/23 10:45, Simon Horman wrote: > On Thu, Jun 29, 2023 at 04:55:25PM +0200, Simon Horman wrote: >> On Thu, Jun 29, 2023 at 04:15:09PM +0200, Ilya Maximets wrote: >>> On 6/6/23 13:35, Ivan Malov wrote: Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. >>> >>> AFAICT, not

Re: [ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-07-03 Thread Simon Horman
On Thu, Jun 29, 2023 at 04:55:25PM +0200, Simon Horman wrote: > On Thu, Jun 29, 2023 at 04:15:09PM +0200, Ilya Maximets wrote: > > On 6/6/23 13:35, Ivan Malov wrote: > > > Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. > > > > AFAICT, not all drivers moved to a REPRESENTED_PORT