Re: [ovs-dev] [PATCH] ovs-tcpdump: Bugfix-of-ovs-tcpdump

2023-07-04 Thread Simon Jones
Ok, I will fix these. Simon Jones Ilya Maximets 于2023年7月4日周二 21:35写道: > On 7/3/23 05:46, 冮晔维 wrote: > > From: gangyewei > > Hi. Thanks for the update! Please, add a version number while > sending new versions though, e.g. [PATCH v2]. Otherwise, it's > hard to track which version is

Re: [ovs-dev] [PATCH v3 2/2] userspace: Add Generic Segmentation Offloading.

2023-07-04 Thread Ilya Maximets
On 6/21/23 22:36, Mike Pattrick wrote: > From: Flavio Leitner > > This provides a software implementation in the case > the egress netdev doesn't support segmentation in hardware. > > The challenge here is to guarantee packet ordering in the > original batch that may be full of TSO packets.

[ovs-dev] [PATCH v3] ovs-vsctl: Exit with error if postdb checks report errors.

2023-07-04 Thread Flavio Leitner
Today the exit code refers to the execution of the change in the database. However, when not using parameter --no-wait (default), the ovs-vsctl also checks if OVSDB transactions are successfully recorded and reload by ovs-vswitchd. In this case, an error message is printed if there is a problem

[ovs-dev] [PATCH v14] netdev-dpdk: Add custom rx-steering configuration.

2023-07-04 Thread Robin Jarry
Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the configured Rx queues. When a signaling packet of such protocols is dropped, it can cause

Re: [ovs-dev] [PATCH v13] netdev-dpdk: Add custom rx-steering configuration.

2023-07-04 Thread Ilya Maximets
On 7/1/23 18:21, Robin Jarry wrote: Thanks for the update. Looks fine in general, see some small comments inline. Best rgeards, Ilya Maximets. > Some control protocols are used to maintain link status between > forwarding engines (e.g. LACP). When the system is not sized properly, > the PMD

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-07-04 Thread Roberto Bartzen Acosta via dev
I'm interested in attending this meet, Frode. Please include me in the invite list. Thanks Em ter., 4 de jul. de 2023 às 13:06, Numan Siddique escreveu: > On Tue, Jul 4, 2023, 8:00 PM Frode Nordahl > wrote: > > > On Tue, Jul 4, 2023 at 4:16 PM Dumitru Ceara wrote: > > > > > > On 6/30/23

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-07-04 Thread Numan Siddique
On Tue, Jul 4, 2023, 8:00 PM Frode Nordahl wrote: > On Tue, Jul 4, 2023 at 4:16 PM Dumitru Ceara wrote: > > > > On 6/30/23 23:07, Terry Wilson wrote: > > > On Fri, Jun 30, 2023 at 2:26 AM Frode Nordahl > > > wrote: > > >> > > >> Hello all, > > >> > > >> On Tue, May 30, 2023 at 5:16 PM Felix

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-07-04 Thread Frode Nordahl
On Tue, Jul 4, 2023 at 4:16 PM Dumitru Ceara wrote: > > On 6/30/23 23:07, Terry Wilson wrote: > > On Fri, Jun 30, 2023 at 2:26 AM Frode Nordahl > > wrote: > >> > >> Hello all, > >> > >> On Tue, May 30, 2023 at 5:16 PM Felix Huettner > >> wrote: > >>> > >>> Hi Dumitru, > >>> > >>> On Fri, May

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-07-04 Thread Robin Jarry
Dumitru Ceara, Jul 04, 2023 at 16:16: > Given that July 5th is tomorrow I'm assuming there won't be a community > meeting as it seems quite short notice. > > Frode, is Tuesday July 11th 13:30 UTC still an option for you? If I'm > not wrong this was the slot that worked for everyone that replied.

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-07-04 Thread Dumitru Ceara
On 6/30/23 23:07, Terry Wilson wrote: > On Fri, Jun 30, 2023 at 2:26 AM Frode Nordahl > wrote: >> >> Hello all, >> >> On Tue, May 30, 2023 at 5:16 PM Felix Huettner >> wrote: >>> >>> Hi Dumitru, >>> >>> On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote: On 5/24/23 09:37, Felix

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-04 Thread Ilya Maximets
On 7/2/23 17:19, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > The icmp_id maybe conflicts in snat > Description: > If multiple devices send icmp packets with the same icmp_id, > the sip of the packets changes to the same source ip address after the snat > operation, > and the packets

Re: [ovs-dev] [PATCH] ovs-tcpdump: Bugfix-of-ovs-tcpdump

2023-07-04 Thread Ilya Maximets
On 7/3/23 05:46, 冮晔维 wrote: > From: gangyewei Hi. Thanks for the update! Please, add a version number while sending new versions though, e.g. [PATCH v2]. Otherwise, it's hard to track which version is the most recent one. > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > As

Re: [ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-07-04 Thread Simon Horman
On Mon, Jul 03, 2023 at 01:28:06PM +0200, Ilya Maximets wrote: > On 7/3/23 10:45, Simon Horman wrote: > > On Thu, Jun 29, 2023 at 04:55:25PM +0200, Simon Horman wrote: > >> On Thu, Jun 29, 2023 at 04:15:09PM +0200, Ilya Maximets wrote: > >>> On 6/6/23 13:35, Ivan Malov wrote: > Action PORT_ID

[ovs-dev] [PATCH] vswitchd: Wait for a bridge exit before replying to exit unixctl.

2023-07-04 Thread Ilya Maximets
Before the cleanup option, the bridge_exit() call was fairly fast, because it didn't include any particularly long operations. However, with the cleanup flag, this function destroys a lot of datapath resources freeing a lot of memory, waiting on RCU and talking to the kernel. That may take a

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-07-04 Thread Dumitru Ceara
On 7/1/23 02:19, Han Zhou wrote: > On Fri, Jun 30, 2023 at 6:35 AM Lucas Martins wrote: >> >> Hi all, >> >> On Thu, Apr 27, 2023 at 7:08 PM Han Zhou wrote: >>> >>> >>> >>> On Thu, Apr 27, 2023 at 10:15 AM Ihar Hrachyshka > wrote: On Wed, Apr 19, 2023 at 5:17 AM Lucas Martins >

Re: [ovs-dev] [PATCH ovn] tests: fixed userspace-system tests not properly cleaned up

2023-07-04 Thread Ales Musil
On Tue, Jul 4, 2023 at 12:08 PM Xavier Simonart wrote: > Usually, when cleaning up a system test we dexecute (for the ovn-vswitchd > process): > - OVS_TRAFFIC_VSWITCHD_STOP (i.e. ovs-appctl -t $1 exit --cleanup, wait up > to 30 seconds > and report failure if not properly cleaned up). > -

[ovs-dev] [PATCH ovn] tests: fixed "ovn-controller port security OF flows"

2023-07-04 Thread Xavier Simonart
The order of Port Binding key generation is not guaranteed, and it might happen that sw0p1 and sw0p2 get different value than the hardcoded 1 and 2 (e.g. 2 and 1). Get the value from DB instead. In addition, move "check_port_sec_offlows" definition before it is being used the first time. Fixes:

Re: [ovs-dev] [PATCH ovn] system-tests: Do not hardcode DP key for the flows

2023-07-04 Thread Xavier Simonart
Looks good to me, thanks. Acked-by: Xavier Simonart On Tue, Jul 4, 2023 at 12:33 PM Ales Musil wrote: > The order of DP key generation is not guaranteed, and > it might happen that the R2 router gets different value than > the hardcoded 2. Get the value from DB instead. > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn] tests: fixed userspace-system tests not properly cleaned up

2023-07-04 Thread Ales Musil
On Tue, Jul 4, 2023 at 12:08 PM Xavier Simonart wrote: > Usually, when cleaning up a system test we dexecute (for the ovn-vswitchd > process): > - OVS_TRAFFIC_VSWITCHD_STOP (i.e. ovs-appctl -t $1 exit --cleanup, wait up > to 30 seconds > and report failure if not properly cleaned up). > -

Re: [ovs-dev] [PATCH ovn v3 2/2] ci: Run the new check-system-dpdk tests as part of the ci.

2023-07-04 Thread Ales Musil
On Tue, Jul 4, 2023 at 12:53 PM Eelco Chaudron wrote: > > > On 4 Jul 2023, at 11:00, Ales Musil wrote: > > > On Mon, Jun 19, 2023 at 11:32 AM Eelco Chaudron > wrote: > > > >> This patch includes changes made earlier by David in the > >> ovs branch to cache the dpdk builds. > >> > >>

Re: [ovs-dev] [PATCH ovn v3 2/2] ci: Run the new check-system-dpdk tests as part of the ci.

2023-07-04 Thread Eelco Chaudron
On 4 Jul 2023, at 11:00, Ales Musil wrote: > On Mon, Jun 19, 2023 at 11:32 AM Eelco Chaudron wrote: > >> This patch includes changes made earlier by David in the >> ovs branch to cache the dpdk builds. >> >> Co-authored-by: David Marchand >> Signed-off-by: David Marchand >> Signed-off-by:

Re: [ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2023-07-04 Thread Tao Liu
Hi, Ilya. Thanks for your comment. On 7/4/23 4:10 AM, Ilya Maximets wrote: On 7/2/23 11:59, Tao Liu wrote: Commit 02f31a1262fc has fixed the row references when insertion and deletion execute in one IDL run. However, we can still hit ovn-controller crash in pressure test where pb->datapath ==

Re: [ovs-dev] [PATCH v6 0/9] Add vxlan gbp offload with TC

2023-07-04 Thread Eelco Chaudron
On 27 Jun 2023, at 12:48, Roi Dayan wrote: > Hi, > > This series adds TC offload support for filtering vxlan tunnels with gbp > option. > First 4 patches do some refactoring and the later patches adds the feature. > > Thanks, > Roi Thanks for following up on the series! I’ve applied the

[ovs-dev] [PATCH ovn] system-tests: Do not hardcode DP key for the flows

2023-07-04 Thread Ales Musil
The order of DP key generation is not guaranteed, and it might happen that the R2 router gets different value than the hardcoded 2. Get the value from DB instead. Signed-off-by: Ales Musil --- tests/system-ovn-kmod.at | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[ovs-dev] [PATCH ovn] tests: fixed userspace-system tests not properly cleaned up

2023-07-04 Thread Xavier Simonart
Usually, when cleaning up a system test we dexecute (for the ovn-vswitchd process): - OVS_TRAFFIC_VSWITCHD_STOP (i.e. ovs-appctl -t $1 exit --cleanup, wait up to 30 seconds and report failure if not properly cleaned up). - kill_ovs_vswitchd (i.e. if ovs-vsitwhd still running, ovs-appctl -t

Re: [ovs-dev] [PATCH ovn v3 2/2] ci: Run the new check-system-dpdk tests as part of the ci.

2023-07-04 Thread Ales Musil
On Mon, Jun 19, 2023 at 11:32 AM Eelco Chaudron wrote: > This patch includes changes made earlier by David in the > ovs branch to cache the dpdk builds. > > Co-authored-by: David Marchand > Signed-off-by: David Marchand > Signed-off-by: Eelco Chaudron > --- > > v2: Replaced 'sleep 1' with ''

Re: [ovs-dev] [PATCH ovn v3 1/2] tests: add make check-system-dpdk to test suite.

2023-07-04 Thread Ales Musil
On Tue, Jun 27, 2023 at 7:12 PM Dumitru Ceara wrote: > On 6/19/23 11:30, Eelco Chaudron wrote: > > Allow the ovn-system tests to run on the OVS-DPDK infrastructure, > > i.e., DPDK ports and mbuf memory. > > > > Co-authored-by: David Marchand > > Signed-off-by: David Marchand > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn 00/13] Fixes Multiple Unit Tests

2023-07-04 Thread Ales Musil
On Tue, Jun 27, 2023 at 11:31 AM Xavier Simonart wrote: > Xavier Simonart (13): > tests: fixed "policy-based routing" and "route tables IPv6 -- > overlapping subnets" > tests: fixed "dhcpv6 : 1 HV, 2 LS, 5 LSPs" and "external logical port" > tests: fixed "send gratuitous ARP for NAT

Re: [ovs-dev] [PATCH v1] bridge ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling fix unexpected values

2023-07-04 Thread Eelco Chaudron
On 4 Jul 2023, at 8:55, Sayali Naval (sanaval) via dev wrote: > As per the Open vSwitch Manual > (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge > IPFIX parameters can be passed as follows: > > ovs-vsctl -- set Bridge br0 ipfix=@i \ > -- --id=@i

[ovs-dev] [PATCH v1] bridge ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling fix unexpected values

2023-07-04 Thread Sayali Naval (sanaval) via dev
As per the Open vSwitch Manual (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge IPFIX parameters can be passed as follows: ovs-vsctl -- set Bridge br0 ipfix=@i \ -- --id=@i create IPFIX targets=\"192.168.0.34:4739\" obs_do‐ main_id=123

Re: [ovs-dev] [PATCH v2] bridge ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling fix unexpected values

2023-07-04 Thread Eelco Chaudron
On 4 Jul 2023, at 3:39, Sayali Naval (sanaval) via dev wrote: > As per the Open vSwitch Manual > (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge > IPFIX parameters can be passed as follows: > > ovs-vsctl -- set Bridge br0 ipfix=@i \ > -- --id=@i

Re: [ovs-dev] [PATCH v6 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-07-04 Thread Roi Dayan via dev
On 29/06/2023 11:50, Eelco Chaudron wrote: > > > On 27 Jun 2023, at 12:48, Roi Dayan wrote: > >> From: Gavin Li >> >> Add a vxlan gbp offload test case: >> >> vxlan offloads with gbp extention - ping between two ports - offloads >> enabled ok >> >> Signed-off-by: Gavin Li >> Reviewed-by:

Re: [ovs-dev] [PATCH v6 7/9] tc: Add vxlan encap action with gbp option offload

2023-07-04 Thread Roi Dayan via dev
On 29/06/2023 11:50, Eelco Chaudron wrote: > > > On 27 Jun 2023, at 12:48, Roi Dayan wrote: > >> From: Gavin Li >> >> Add TC offload support for vxlan encap with gbp option >> >> Signed-off-by: Gavin Li >> Reviewed-by: Gavi Teitz >> Reviewed-by: Roi Dayan >> Reviewed-by: Simon Horman >>