Re: [ovs-dev] [PATCH ovn] northd: Fix incorrect warning logs when handling port binding changes.

On Mon, Aug 14, 2023 at 2:07 AM wrote: > > From: Numan Siddique > > When changes to port bindings corresponding to router ports are > handled by northd engine node, incorrect warning logs (like below) > are logged. > > > northd|WARN|A port-binding for lrp0 is created but the LSP is not

Re: [ovs-dev] [PATCH net] net: openvswitch: reject negative ifindex

On Tue, 15 Aug 2023 08:41:50 -0400 Aaron Conole wrote: > > Validate the inputes. Now the second command correctly returns: > > s/inputes/inputs/ Thanks, fixed when applying > > $ ./cli.py --spec netlink/specs/ovs_vport.yaml \ > > --do new \ > > --json '{"upcall-pid": "0001",

Re: [ovs-dev] [PATCH net] net: openvswitch: reject negative ifindex

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 14 Aug 2023 13:38:40 -0700 you wrote: > Recent changes in net-next (commit 759ab1edb56c ("net: store netdevs > in an xarray")) refactored the handling of pre-assigned ifindexes > and let syzbot surface a latent

Re: [ovs-dev] [PATCH] dpif-netdev: Fix length calculation of netdet_flow_key.

Hi, Eelco, could you take a look at this patch? Zhiqi Chen via dev 于2023年8月13日周日 17:09写道： > The 'len' of a netdev_flow_key initialized by netdev_flow_key_init() > is always zero, which may cause errors when cloning a netdev_flow_key > by netdev_flow_key_clone(). > > Currently the 'len' member

[ovs-dev] [PATCH ovn] northd.c: Incremental processing for first/last switch port change.

Commit 1eb09838 fixed an incremental processing problem by falling back to recompute. The problem was handling VIF changes for a LS that has router ports when: - adding the first switch port to the LS, or - deleting the last switch port from the LS because there are router port related lflows that

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

Thanks Eelco Chaudron 于2023年8月16日 周三00:02写道： > > > On 15 Aug 2023, at 13:18, Eelco Chaudron wrote: > > > On 15 Aug 2023, at 11:06, Peng He wrote: > > > >> Do I need to send a new version to fix the indentation? > > > > Nope, I’ll fix it when committing the patch. Will be later this week, as > I

Re: [ovs-dev] [PATCH] connmgr: Count unsent async messages.

On 8/7/23 14:21, Simon Horman wrote: > On Sat, Aug 05, 2023 at 01:12:15PM +0200, Francois wrote: >> Add an additional coverage counter for the case where no controller is >> available to receive a OFPT_PACKET_IN/NXT_PACKET_IN2 message and so the >> message is not sent at all. >> >> This should

Re: [ovs-dev] [PATCH] AUTHORS: Update email for Simon Horman.

On Tue, Aug 15, 2023 at 06:20:54PM +0200, Ilya Maximets wrote: > On 8/15/23 17:33, Simon Horman wrote: > > Update my email contact address for Open vSwitch activities. > > I suppose, you may want to update the .mailmap as well, since > all your other addresses are currently mapped to a corigine

Re: [ovs-dev] [PATCH] AUTHORS: Update email for Simon Horman.

On 8/15/23 17:33, Simon Horman wrote: > Update my email contact address for Open vSwitch activities. I suppose, you may want to update the .mailmap as well, since all your other addresses are currently mapped to a corigine one. Just a suggestion. > > Signed-off-by: Simon Horman > --- >

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

On 15 Aug 2023, at 13:18, Eelco Chaudron wrote: > On 15 Aug 2023, at 11:06, Peng He wrote: > >> Do I need to send a new version to fix the indentation? > > Nope, I’ll fix it when committing the patch. Will be later this week, as I > need to catch up on some email etc. Thanks for the patch

[ovs-dev] [PATCH] AUTHORS: Update email for Simon Horman.

Update my email contact address for Open vSwitch activities. Signed-off-by: Simon Horman --- AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 8427f91672c9..efae850fd772 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -415,7 +415,7 @@

Re: [ovs-dev] [PATCH ovn v3] northd: Allow delay of northd engine runs

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH ovn v3] northd: Allow delay of northd engine runs

On 8/15/23 17:01, Ales Musil wrote: > Add config option called "northd-backoff-interval-ms" that allows > to delay northd engine runs capped by the config option. > When the config option is set to 0 or unspecified, the engine > will run without any restrictions. If the value >0 we will delay >

[ovs-dev] [PATCH ovn v3] northd: Allow delay of northd engine runs

Add config option called "northd-backoff-interval-ms" that allows to delay northd engine runs capped by the config option. When the config option is set to 0 or unspecified, the engine will run without any restrictions. If the value >0 we will delay northd engine run by the previous run time

Re: [ovs-dev] [PATCH net-next v3 03/10] genetlink: remove userhdr from struct genl_info

Jakub Kicinski writes: > Only three families use info->userhdr today and going forward > we discourage using fixed headers in new families. > So having the pointer to user header in struct genl_info > is an overkill. Compute the header pointer at runtime. > > Reviewed-by: Johannes Berg >

Re: [ovs-dev] [PATCH net] net: openvswitch: reject negative ifindex

Jakub Kicinski writes: > Recent changes in net-next (commit 759ab1edb56c ("net: store netdevs > in an xarray")) refactored the handling of pre-assigned ifindexes > and let syzbot surface a latent problem in ovs. ovs does not validate > ifindex, making it possible to create netdev ports with

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

Ok, thanks. Eelco Chaudron 于2023年8月15日周二 19:19写道： > > > On 15 Aug 2023, at 11:06, Peng He wrote: > > > Do I need to send a new version to fix the indentation? > > Nope, I’ll fix it when committing the patch. Will be later this week, as I > need to catch up on some email etc. > > //Eelco > > >

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

On 15 Aug 2023, at 11:06, Peng He wrote: > Do I need to send a new version to fix the indentation? Nope, I’ll fix it when committing the patch. Will be later this week, as I need to catch up on some email etc. //Eelco > Eelco Chaudron 于2023年8月15日周二 15:40写道： > >> >> >> On 27 Jul 2023, at

[ovs-dev] [PATCH ovn v2 4/5] tests: Add missing sync calls

Add various missing sync calls which caused the tests to be flaky due to sometimes missed on various checks or packets. Signed-off-by: Ales Musil --- v2: Address comments from Mark: - Add fix for the nb_cfg overflow test. --- tests/ovn-controller.at | 2 +- tests/ovn-ic.at | 7

[ovs-dev] [PATCH ovn v2 3/5] tests: Make sure the port group is not hardcoded

The port group name consists of DP key and NB PG name. Use first PG that is avaiable to avoid flakes when neither of the logical switches has DP key 2. Signed-off-by: Ales Musil Acked-by: Mark Michelson --- v2: Add ack from Mark. --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2

[ovs-dev] [PATCH ovn v2 2/5] system-tests: Make sure that the CT entries are sorted

Make sure the CT entries are sorted, otherwise the check sometimes fails depending on the order from OvS. Signed-off-by: Ales Musil Acked-by: Mark Michelson --- v2: Add ack from Mark. --- tests/system-ovn.at | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2 5/5] ovn-nbctl: Prevent sync exiting early on nb_cfg overflow

We are correctly wrapping nb_cfg over when the value is LLONG_MAX. However, the sync code is expecting the value to be always raising, so it would exit early as the current >= next is true for the wrap back to 0. To detect that use delta between those two values. The delta threshold is set to

[ovs-dev] [PATCH ovn v2 1/5] tests: Check proper DP and port key

The test was assuming that the DP key and Port keys are always fixed. Make sure that we use proper values for the flow check. Signed-off-by: Ales Musil Acked-by: Mark Michelson --- v2: Add ack from Mark. --- tests/ovn.at | 67 +++- 1 file

Re: [ovs-dev] [PATCH ovn v2] binding: handle ovs ofport update

On 8/14/23 22:17, Dumitru Ceara wrote: > On 8/9/23 20:01, Mark Michelson wrote: >> Thanks Mohammad and Ales. I have pushed the change to main and all >> branches back to 22.03. >> > > Hi Mark, Mohammad, > > It seems this change broke 22.03: > >

Re: [ovs-dev] [PATCH ovn] fix missing documentation of ovn-ic arguments

On 7/24/23 17:43, Felix Huettner via dev wrote: > the arguments for the interconnect database where missing. > > Signed-off-by: Felix Huettner > --- Thanks, Felix! Applied to main and backported to all branches down to 22.03. Regards, Dumitru ___

Re: [ovs-dev] [PATCH ovn] ovn-controller: Detect and use L4_SYM dp-hash if available.

On 8/14/23 15:57, Dumitru Ceara wrote: > On 8/12/23 07:19, Han Zhou wrote: >> On Fri, Aug 11, 2023 at 6:23 AM Dumitru Ceara wrote: >>> >>> On 8/1/23 12:51, Han Zhou wrote: On Tue, Jul 18, 2023 at 6:16 AM Dumitru Ceara wrote: > > On 7/18/23 12:14, Han Zhou wrote: >> On Mon, Jul

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Assume well-known tables are in the SB schema.

On 8/14/23 00:24, Han Zhou wrote: > On Fri, Aug 11, 2023 at 5:25 AM Dumitru Ceara wrote: >> >> It's safe to assume that tables that existed in the previous LTS branch >> first release (currently 22.03.0) can be monitored directly. Do so and >> only "optionally" monitor the ones that have been

Re: [ovs-dev] [PATCH ovn 1/2] tests: Change ct zone UUID->name migration test to use GW routers.

On 8/14/23 00:23, Han Zhou wrote: > On Fri, Aug 11, 2023 at 5:24 AM Dumitru Ceara wrote: >> >> The test added by 5a1d82cb28c5 ("controller: Migrate from ct zone UUID >> name to component name") was, in theory, correct. However, due to the >> way conditional monitoring works, the test cannot pass

Re: [ovs-dev] [PATCH ovn 2/2] ci: ovn-kubernetes: Remove container image after load.

On 8/15/23 12:00, Numan Siddique wrote: > On Tue, Aug 15, 2023 at 1:34 PM Dumitru Ceara wrote: >> >> The image is quite large and we're low on space. >> >> Signed-off-by: Dumitru Ceara > > Acked-by: Numan Siddique > Thanks, applied to main. Regards, Dumitru

Re: [ovs-dev] [PATCH ovn 1/2] ci: ovn-kubernetes: Free up more space in the github runner.

On 8/15/23 12:00, Numan Siddique wrote: > On Tue, Aug 15, 2023 at 1:34 PM Dumitru Ceara wrote: >> >> Recently, the GitHub ubuntu runner image changed to: >> Runner Image >> Image: ubuntu-22.04 >> Version: 20230728.3.0 >> >> The full diff between the old and new runner images is listed

Re: [ovs-dev] [PATCH ovn 2/2] ci: ovn-kubernetes: Remove container image after load.

On Tue, Aug 15, 2023 at 1:34 PM Dumitru Ceara wrote: > > The image is quite large and we're low on space. > > Signed-off-by: Dumitru Ceara Acked-by: Numan Siddique Numan > --- > .github/workflows/ovn-kubernetes.yml |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH ovn 1/2] ci: ovn-kubernetes: Free up more space in the github runner.

On Tue, Aug 15, 2023 at 1:34 PM Dumitru Ceara wrote: > > Recently, the GitHub ubuntu runner image changed to: > Runner Image > Image: ubuntu-22.04 > Version: 20230728.3.0 > > The full diff between the old and new runner images is listed at: >

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

Do I need to send a new version to fix the indentation? Eelco Chaudron 于2023年8月15日周二 15:40写道： > > > On 27 Jul 2023, at 12:53, Ilya Maximets wrote: > > > On 7/27/23 04:16, Peng He wrote: > >> > >> > >> Simon Horman simon.hor...@corigine.com>> 于2023年7月27日周四 01:04写道： > >> > >> On Thu, Jul 06,

Re: [ovs-dev] [PATCH ovn] northd: Fix incorrect warning logs when handling port binding changes.

On Tue, 15 Aug, 2023, 2:09 pm Dumitru Ceara, wrote: > On 8/14/23 11:07, num...@ovn.org wrote: > > From: Numan Siddique > > > > When changes to port bindings corresponding to router ports are > > handled by northd engine node, incorrect warning logs (like below) > > are logged. > > > > > >

Re: [ovs-dev] [PATCH ovn] binding.c: handle localnet port only if it is on local_datapaths.

On 8/14/23 00:31, Han Zhou wrote: > On Fri, Aug 11, 2023 at 11:30 PM Dumitru Ceara wrote: >> >> On Saturday, August 12, 2023, Han Zhou wrote: >>> >>> >>> >>> On Fri, Aug 11, 2023 at 5:36 AM Dumitru Ceara wrote: On 8/10/23 17:53, Han Zhou wrote: > Today the localnet ports are added

Re: [ovs-dev] [PATCH ovn] northd: Allow delay of northd engine runs

On 8/14/23 18:51, Han Zhou wrote: > On Mon, Aug 14, 2023 at 4:46 AM Dumitru Ceara wrote: >> >> On 8/12/23 07:08, Han Zhou wrote: >>> On Fri, Aug 11, 2023 at 6:07 AM Dumitru Ceara wrote: On 8/10/23 18:38, Ilya Maximets wrote: > On 8/10/23 17:34, Dumitru Ceara wrote: >> On

Re: [ovs-dev] [PATCH ovn] northd: Allow delay of northd engine runs

On 8/14/23 19:04, Han Zhou wrote: > On Mon, Aug 14, 2023 at 9:54 AM Ilya Maximets wrote: >> >> On 8/11/23 15:07, Dumitru Ceara wrote: >>> On 8/10/23 18:38, Ilya Maximets wrote: On 8/10/23 17:34, Dumitru Ceara wrote: > On 8/10/23 17:20, Han Zhou wrote: >> On Thu, Aug 10, 2023 at 6:36 

Re: [ovs-dev] [PATCH ovn] northd: Fix incorrect warning logs when handling port binding changes.

On 8/14/23 11:07, num...@ovn.org wrote: > From: Numan Siddique > > When changes to port bindings corresponding to router ports are > handled by northd engine node, incorrect warning logs (like below) > are logged. > > > northd|WARN|A port-binding for lrp0 is created but the LSP is not

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

On Tue, Aug 15, 2023 at 09:40:50AM +0200, Eelco Chaudron wrote: > > > On 27 Jul 2023, at 12:53, Ilya Maximets wrote: > > > On 7/27/23 04:16, Peng He wrote: > >> > >> > >> Simon Horman >> > 于2023年7月27日周四 01:04写道： > >> > >> On Thu, Jul 06, 2023 at 04:59:36PM

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-kubernetes CI jobs happy again.

On 8/15/23 10:03, Dumitru Ceara wrote: > We were running out of disk space in the GitHub runners. Free up some > disk space before running e2e tests. > > Dumitru Ceara (2): > ci: ovn-kubernetes: Free up more space in the github runner. > ci: ovn-kubernetes: Remove container image

[ovs-dev] [PATCH ovn 2/2] ci: ovn-kubernetes: Remove container image after load.

The image is quite large and we're low on space. Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-kubernetes.yml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml index 6569f8509d..69ab0566d2

[ovs-dev] [PATCH ovn 1/2] ci: ovn-kubernetes: Free up more space in the github runner.

Recently, the GitHub ubuntu runner image changed to: Runner Image Image: ubuntu-22.04 Version: 20230728.3.0 The full diff between the old and new runner images is listed at: https://github.com/actions/runner-images/compare/ubuntu22/20230724.1..ubuntu22/20230728.3 Since then

[ovs-dev] [PATCH ovn 0/2] Make ovn-kubernetes CI jobs happy again.

We were running out of disk space in the GitHub runners. Free up some disk space before running e2e tests. Dumitru Ceara (2): ci: ovn-kubernetes: Free up more space in the github runner. ci: ovn-kubernetes: Remove container image after load. .github/workflows/ovn-kubernetes.yml |

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

On 27 Jul 2023, at 12:53, Ilya Maximets wrote: > On 7/27/23 04:16, Peng He wrote: >> >> >> Simon Horman mailto:simon.hor...@corigine.com>> >> 于2023年7月27日周四 01:04写道： >> >> On Thu, Jul 06, 2023 at 04:59:36PM +0800, Peng He wrote: >> >> ... >> >> > +dnl Replace OpenFlow rules,

Re: [ovs-dev] [PATCH net] net: openvswitch: reject negative ifindex

On Mon, Aug 14, 2023 at 01:38:40PM -0700, Jakub Kicinski wrote: > Recent changes in net-next (commit 759ab1edb56c ("net: store netdevs > in an xarray")) refactored the handling of pre-assigned ifindexes > and let syzbot surface a latent problem in ovs. ovs does not validate > ifindex, making it

Re: [ovs-dev] [PATCH ovn 4/4] tests: Add missing sync calls

On Mon, Aug 14, 2023 at 10:02 PM Mark Michelson wrote: > Hi Ales, I have a couple of notes below. > > On 8/14/23 05:21, Ales Musil wrote: > > Add various missing sync calls which caused the > > tests to be flaky due to sometimes missed on various > > checks or packets. > > > > Signed-off-by: