On 10/26/23 14:10, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The unixctl implementation in Python has been split into three parts in
> the past. During this process the UnixctlClient was duplicated, in
> python/ovs/unixctl/client.py and python/ovs/unixctl/server.py. This
> patch removes the
On 10/27/23 23:51, Ilya Maximets wrote:
> On 10/26/23 13:44, Jakob Meng wrote:
>> On 25.10.23 11:37, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> For monitoring systems such as Prometheus it would be beneficial if
>>> OVS and OVS-DPDK would expose statistics in a machine-readable format.
Hi Jakob,
Just a comment about the use of 'whitespace' in the commit message.
There is an effort to try and use more inclusive language, so it might
be good to use empty-space or blank-space in the commit message. I know
that it is an editor config property, so not much to do about
On 10/26/23 13:44, Jakob Meng wrote:
> On 25.10.23 11:37, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For monitoring systems such as Prometheus it would be beneficial if
>> OVS and OVS-DPDK would expose statistics in a machine-readable format.
>>
>> This patch introduces support for
Hello,
I'm currently working on re-enabling our daily OVN tests in Incus (the
LXD fork).
Unfortunately I'm not having much luck getting our testsuite to go all
the way through as it's triggering kernel panics.
Here is the stack trace I'm getting:
```
[ 484.818312] BUG: TASK stack guard page
On Fri, Jul 14, 2023 at 2:12 AM Ales Musil wrote:
>
> On Thu, Jul 13, 2023 at 12:52 PM Dumitru Ceara wrote:
>
> > If we want to catch new failures faster we have a better chance if CI
> > doesn't auto-retry (once).
> >
> > There are some tests that are still "unstable" and fail every now and
> >
On Thu, Oct 26, 2023 at 7:37 AM Dumitru Ceara wrote:
>
> OVS actually supports way more. Detect the real number of groups and
> meters instead. To avoid preallocating huge bitmaps for the IDs,
> switch to id-pool instead (as suggested by Ilya).
>
> Reported-at:
On Fri, Oct 27, 2023 at 5:31 PM David Marchand
wrote:
>
> dpdk-testpmd does not need hugetlbfs backing as we don't require
> multiprocess support in OVS unit tests.
>
> Switch to --in-memory and remove the (then unneeded) check on
> hugetlbfs presence.
>
> Acked-by: Aaron Conole
> Acked-by:
Those tests are subject to a race when a testpmd hosting the vhost-user
server is stopped and OVS has enough time to detect the vhost-user socket
drop and tries to reconnect to this socket.
In such a situation, the tests can fail as the OVS process with the
vhost-user client port complains with a
Integrate system-traffic.at tests as part of check-dpdk.
Some tests that can't work with the userspace datapath are skipped by
overriding some OVS_CHECK_* macros.
ADD_VETH is implemented using the net/af_xdp DPDK driver.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since
When using net/af_xdp DPDK driver along OVS native AF_XDP support,
confusing logs are reported, like:
netdev_dpdk|INFO|Device 'net_af_xdpp0,iface=ovs-p0' attached to DPDK
dpif_netdev|INFO|PMD thread on numa_id: 0, core id: 11 created.
dpif_netdev|INFO|There are 1 pmd threads on numa node 0
The unit tests for changing MTU with vhost-user ports are not using
those tap interfaces.
Signed-off-by: David Marchand
---
Changes since v7:
- added this patch after getting regressions in Intel CI because of the
next patch,
---
tests/system-dpdk.at | 14 --
1 file changed, 4
Align system-dpdk existing helpers to other common OVS helpers so they
can accept some optional arguments.
Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
catch dpdk related logs in a centralised fashion.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes
Some unit tests expect that a OVS port has an associated netdevice on
which they can hook tc.
This will not be possible when testing the userspace datapath with DPDK.
Introduce a helper (which will be overriden in system-dpdk tests) and
use it in the existing tests.
Acked-by: Aaron Conole
Let's enhance our coverage in the CI and run DPDK system tests.
A few DPDK drivers are enabled in DPDK compilation.
Put DPDK build in $PATH for dpdk-testpmd to be available.
sudo drops PATH= updates and -E alone does not seem to preserve this
variable.
Pass PATH=$PATH when running the tests, as
dpdk-testpmd does not need hugetlbfs backing as we don't require
multiprocess support in OVS unit tests.
Switch to --in-memory and remove the (then unneeded) check on
hugetlbfs presence.
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v7:
-
Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
On 27/10/2023 14:38, Ilya Maximets wrote:
On 10/26/23 11:29, Jakob Meng wrote:
On 25.10.23 19:10, Ilya Maximets wrote:
On 10/24/23 11:21, Kevin Traynor wrote:
Using correct email for Simon this time
On 24/10/2023 10:19, Kevin Traynor wrote:
On 23/10/2023 10:11, Jakob Meng wrote:
On
On Thu, Oct 26, 2023 at 3:40 AM Dexia Li via dev
wrote:
>
> For userspace datapath, this patch provides vxlan and geneve tunnel tso.
> Only support userspace vxlan or geneve tunnel, meanwhile support
> tunnel outter and inner csum offload. If netdev do not support offload
> features, there is
On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Add global option to output JSON from ovs-appctl cmds.
>
> This patch is an update of [0] with the following major changes:
> * The JSON-RPC API change is now backward compatible. One can use an
> updated client
On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
> From: Jakob Meng
>
> This patch introduces support for different output formats to the
> Python code, as did the previous commit for ovs-xxx tools like
> 'ovs-appctl --format json dpif/show'.
> In particular, tests/appctl.py gains a global
On 10/26/23 11:29, Jakob Meng wrote:
> On 25.10.23 19:10, Ilya Maximets wrote:
>> On 10/24/23 11:21, Kevin Traynor wrote:
>>> Using correct email for Simon this time
>>>
>>> On 24/10/2023 10:19, Kevin Traynor wrote:
On 23/10/2023 10:11, Jakob Meng wrote:
> On 20.10.23 12:02, Kevin Traynor
On 27 Oct 2023, at 14:55, David Marchand wrote:
> On Fri, Oct 27, 2023 at 1:45 PM Eelco Chaudron wrote:
>> On 23 Oct 2023, at 10:18, David Marchand wrote:
>>
>>> Integrate system-traffic.at tests as part of check-dpdk.
>>>
>>> Some tests that can't work with the userspace datapath are skipped
On Fri, Oct 27, 2023 at 1:45 PM Eelco Chaudron wrote:
> On 23 Oct 2023, at 10:18, David Marchand wrote:
>
> > Integrate system-traffic.at tests as part of check-dpdk.
> >
> > Some tests that can't work with the userspace datapath are skipped by
> > overriding some OVS_CHECK_* macros.
> >
> >
, Oct 27, 2023 at 14:10:
From: Jakob Meng
Wildcard sections [*] and [**] are unsafe because properties cannot be
applied safely to any filetype in general. For example, IDEs like
Visual Studio Code and KDevelop store configuration files in subfolders
like .vscode or .kdev4. Properties from
On 27.10.23 12:29, Eelco Chaudron wrote:
>
> On 26 Oct 2023, at 14:34, Jakob Meng wrote:
>
>> On 26.10.23 14:21, Robin Jarry wrote:
>>> Jakob Meng, Oct 26, 2023 at 14:17:
On 26.10.23 13:52, Robin Jarry wrote:
> , Oct 26, 2023 at 13:07:
>> From: Jakob Meng
>>
>> Wildcard
On 27 Oct 2023, at 14:10, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Wildcard sections [*] and [**] are unsafe because properties cannot be
> applied safely to any filetype in general. For example, IDEs like
> Visual Studio Code and KDevelop store configuration files in subfolders
> like
From: Jakob Meng
Wildcard sections [*] and [**] are unsafe because properties cannot be
applied safely to any filetype in general. For example, IDEs like
Visual Studio Code and KDevelop store configuration files in subfolders
like .vscode or .kdev4. Properties from wildcard sections also apply
On 23 Oct 2023, at 10:18, David Marchand wrote:
> Integrate system-traffic.at tests as part of check-dpdk.
>
> Some tests that can't work with the userspace datapath are skipped by
> overriding some OVS_CHECK_* macros.
>
> ADD_VETH is implemented using the net/af_xdp DPDK driver.
>
>
On 23 Oct 2023, at 10:18, David Marchand wrote:
> Those tests are subject to a race when a testpmd hosting the vhost-user
> server is stopped and OVS has enough time to detect the vhost-user socket
> drop and tries to reconnect to this socket.
>
> In such a situation, the tests can fail as the
On 10/26/23 09:39, Dexia Li via dev wrote:
> For userspace datapath, this patch provides vxlan and geneve tunnel tso.
> Only support userspace vxlan or geneve tunnel, meanwhile support
> tunnel outter and inner csum offload. If netdev do not support offload
> features, there is a software
On 26 Oct 2023, at 14:34, Jakob Meng wrote:
> On 26.10.23 14:21, Robin Jarry wrote:
>> Jakob Meng, Oct 26, 2023 at 14:17:
>>> On 26.10.23 13:52, Robin Jarry wrote:
, Oct 26, 2023 at 13:07:
> From: Jakob Meng
>
> Wildcard sections [*] and [**] are unsafe because properties
On 26 Oct 2023, at 14:10, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The unixctl implementation in Python has been split into three parts in
> the past. During this process the UnixctlClient was duplicated, in
> python/ovs/unixctl/client.py and python/ovs/unixctl/server.py. This
> patch
On 23 Oct 2023, at 11:41, Kevin Traynor wrote:
> get_status for dpdkvhostuser(/client) netdev class may display
> userspace-tso status.
>
> Fixes: a5669fd51c9b ("netdev-dpdk: Drop TSO in case of conflicting virtio
> features.")
> Signed-off-by: Kevin Traynor
Thanks for updating this! The
On 23 Oct 2023, at 11:41, Kevin Traynor wrote:
> Add group for dpdkvhostuser(/client) netdev.
>
> Adding as a single group as they display the same status,
> one of which is 'mode' to indicate if it's client or server.
>
> Fixes: b2e8b12f8a82 ("netdev-dpdk: add vhost-user get_status.")
>
Hi Mark
Thanks for the review and the comments.
On Mon, Sep 25, 2023 at 9:48 PM Mark Michelson wrote:
>
> Hi Xavier,
>
> Functionality-wise, this looks good. I have a couple of small comments
> though.
>
> On 9/20/23 11:45, Xavier Simonart wrote:
> > Before this patch, if-status module handled
Hi all,
I'm using ovs-dpdk version 2.17.1.
Now I found ovs-ofctl replace xxx will cause flow_mod even if openflow is
same.
Detail:
```
[root@localhost ~]# cat flows
in_port="p0",dl_vlan=11,ip,nw_proto=17,actions=output:vf2
[root@localhost ~]# cat flows2
On 10/23/23 16:21, Eelco Chaudron wrote:
> This series fixes some of Clang's scan-build warnings reported.
>
> v2:
>- Split patch two into two, i.e. put the actual fix in a separate patch.
>- Updated commit messages.
>
> Eelco Chaudron (5):
> general: Fix Clang's static analyzer
On 10/27/23 11:04, David Marchand wrote:
> On Thu, Oct 26, 2023 at 7:54 PM Ilya Maximets wrote:
>>
>> We used this builder before, but from the project configuration
>> on the website. ReadTheDocs doesn't allow to change it there
>> anymore and it doesn't allow to see the full name of the
On Thu, Oct 26, 2023 at 7:54 PM Ilya Maximets wrote:
>
> We used this builder before, but from the project configuration
> on the website. ReadTheDocs doesn't allow to change it there
> anymore and it doesn't allow to see the full name of the previously
> used builder (!!), so I failed to
On 01/09/2023 13:19, Simon Horman wrote:
On Thu, Aug 31, 2023 at 09:32:23AM +0200, David Marchand wrote:
After DPDK started relying on compiler intrinsics in rte_cycles.h,
sparse raises the following warning:
libtool: compile: env REAL_CC=gcc "CHECK=sparse -Wsparse-error
-I
On 26 Oct 2023, at 19:55, Ilya Maximets wrote:
> We used this builder before, but from the project configuration
> on the website. ReadTheDocs doesn't allow to change it there
> anymore and it doesn't allow to see the full name of the previously
> used builder (!!), so I failed to migrate it
42 matches
Mail list logo
