Re: [ovs-dev] [PATCH ovn v3] controller: Track individual address set constants.

2024-05-01 Thread Han Zhou
On Tue, Apr 30, 2024 at 9:56 AM Ales Musil wrote: > > Instead of tracking address set per struct expr_constant_set track it > per individual struct expr_constant. This allows more fine grained > control for I-P processing of address sets in controller. It helps with > scenarios like matching on

[ovs-dev] [PATCH v9 1/2] ofproto-dpif-mirror: Reduce number of function parameters.

2024-05-01 Thread Mike Pattrick
Previously the mirror_set() and mirror_get() functions took a large number of parameters, which was inefficient and difficult to read and extend. This patch moves most of the parameters into a struct. Signed-off-by: Mike Pattrick Acked-by: Simon Horman Acked-by: Eelco Chaudron Signed-off-by:

[ovs-dev] [PATCH v9 2/2] ofproto-dpif-mirror: Add support for pre-selection filter.

2024-05-01 Thread Mike Pattrick
Currently a bridge mirror will collect all packets and tools like ovs-tcpdump can apply additional filters after they have already been duplicated by vswitchd. This can result in inefficient collection. This patch adds support to apply pre-selection to bridge mirrors, which can limit which

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Finn, Emma
> -Original Message- > From: Eelco Chaudron > Sent: Wednesday, May 1, 2024 1:52 PM > To: Simon Horman > Cc: Finn, Emma ; Stokes, Ian ; > sunil.pa...@intel.com; Van Haaren, Harry ; > d...@openvswitch.org; Flavio Leitner ; Ilya Maximets > > Subject: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Eelco Chaudron
On 1 May 2024, at 14:39, Simon Horman wrote: > On Tue, Apr 30, 2024 at 02:42:45PM +0200, Eelco Chaudron wrote: >> Greetings, Intel team! >> >> The self-test conducted as part of this patch has revealed an issue with the >> AVX512 checksumming code. Since it was agreed upon that your team would

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping specific table's contents if user supplies table's name > as a third positional argument. > > Signed-off-by: Martin Kalcok Acked-by: Simon Horman

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 11:59:02AM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 11:57:46AM +0100, Simon Horman wrote: > > On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > > > Add route-table that support ipv4 dst via ipv6. BGP unnumbered is > > > mechanism > > > that

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Simon Horman
On Mon, Apr 29, 2024 at 04:48:41PM +0200, Eelco Chaudron wrote: > While offloading header modifications to TC, OVS is using {TCA_PEDIT} + > {TCA_CSUM} combination as that it the only way to represent header > rewrite. However, {TCA_CSUM} is unable to calculate L4 checksums for > IP fragments. >

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Simon Horman
On Tue, Apr 30, 2024 at 02:42:45PM +0200, Eelco Chaudron wrote: > Greetings, Intel team! > > The self-test conducted as part of this patch has revealed an issue with the > AVX512 checksumming code. Since it was agreed upon that your team would > maintain this code upon its inclusion, could you

Re: [ovs-dev] [PATCH v2] ofproto-dpif-rid: Fix duplicate entries.

2024-05-01 Thread Simon Horman
On Tue, Apr 30, 2024 at 05:36:09PM +0800, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > In scenarios with multiple PMDs, there may be > simultaneous requests for recirc_id from multiple > PMD threads.In recirc_alloc_id_ctx, we first check > if there is a duplicate entry in the

Re: [ovs-dev] [PATCH] GitHub: Add Coverity scan as a daily GitHub action.

2024-05-01 Thread Eelco Chaudron
On 29 Apr 2024, at 14:59, Ilya Maximets wrote: > On 4/16/24 09:44, Eelco Chaudron wrote: >> This patch adds a daily Coverity run for the OVS main branch >> to the GitHub actions. The result of the runs can be found here: >> >> https://scan.coverity.com/projects/openvswitch >> >> Before

Re: [ovs-dev] [PATCH] GitHub: Add Coverity scan as a daily GitHub action.

2024-05-01 Thread Eelco Chaudron
On 26 Apr 2024, at 10:57, Simon Horman wrote: > On Tue, Apr 16, 2024 at 09:44:52AM +0200, Eelco Chaudron wrote: >> This patch adds a daily Coverity run for the OVS main branch >> to the GitHub actions. The result of the runs can be found here: >> >>

Re: [ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

2024-05-01 Thread Eelco Chaudron
On 1 May 2024, at 12:54, Simon Horman wrote: > Update link to pacemaker main page as the existing link is broken. > Also, use HTTPS. > > Broken link flagged by make check-docs > > Signed-off-by: Simon Horman > --- Thanks for fixing the link. Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH v5] ci: Add clang-analyze to GitHub actions.

2024-05-01 Thread Eelco Chaudron
On 5 Apr 2024, at 12:14, Ilya Maximets wrote: > On 1/11/24 00:08, Eelco Chaudron wrote: >> This patch identifies new static analysis issues during a GitHub action >> run and reports them. The process involves analyzing the changes introduced >> in the current commit and comparing them to those

[ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-01 Thread Martin Kalcok
Help text for 'ovsdb-client dump' does not mention that it's capable of dumping specific table's contents if user supplies table's name as a third positional argument. Signed-off-by: Martin Kalcok --- ovsdb/ovsdb-client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Key connections by zone.

2024-05-01 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:44:54PM +0200, Felix Huettner via dev wrote: > Currently conntrack uses a single large cmap for all connections stored. > This cmap contains all connections for all conntrack zones which are > completely separate from each other. By separating each zone to its own > cmap

Re: [ovs-dev] [PATCH v2 1/2] test-conntrack: Add per zone benchmark tool.

2024-05-01 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:44:47PM +0200, Felix Huettner via dev wrote: > The current test-conntrack benchmark command runs with multiple threads > against a single conntrack zone. We now add a new benchmark-zones > command that allows us to check the performance between multiple zones. > > We in

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 11:57:46AM +0100, Simon Horman wrote: > On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > > Add route-table that support ipv4 dst via ipv6. BGP unnumbered is mechanism > > that allows BGP to establish peering sessions without the need to explicitly > >

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > Add route-table that support ipv4 dst via ipv6. BGP unnumbered is mechanism > that allows BGP to establish peering sessions without the need to explicitly > configure IP addresses on the interfaces involved in the peering.

[ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

2024-05-01 Thread Simon Horman
Update link to pacemaker main page as the existing link is broken. Also, use HTTPS. Broken link flagged by make check-docs Signed-off-by: Simon Horman --- Documentation/topics/integration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH] socket: Don't fail when AF_UNIX connect() returns EAGAIN.

2024-05-01 Thread Simon Horman
On Fri, Apr 26, 2024 at 10:42:36PM +, Ihar Hrachyshka wrote: > POSIX defines EINPROGRESS as the return value for non-blocking connect() > [1]. But in Linux, AF_UNIX connect() returns EAGAIN instead of > EINPROGRESS. (but only for AF_UNIX sockets!) [2] > > Both cases should be handled the same

Re: [ovs-dev] [PATCH v3] docs: Document manual cluster recovery procedure.

2024-05-01 Thread Simon Horman
On Fri, Apr 26, 2024 at 04:54:48PM +, Ihar Hrachyshka wrote: > Remove the notion of cluster/leave --force since it was never > implemented. Instead of these instructions, document how a broken > cluster can be re-initialized with the old database contents. > > Signed-off-by: Ihar Hrachyshka