Acked-by: Alin-Gabriel Serdean
-Original Message-
From: dev On Behalf Of Ilya Maximets
Sent: Friday, November 4, 2022 4:26 PM
To: ovs-dev@openvswitch.org
Cc: Subrata Nath ; Dumitru Ceara
; Ilya Maximets
Subject: [ovs-dev] [PATCH] rculist: Fix iteration macros.
Some macros for rculist
Congrats, Dumitru !
Alin.
-Original Message-
From: dev On Behalf Of Numan Siddique
Sent: Wednesday, September 21, 2022 7:49 PM
To: Dumitru Ceara
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.
On Wed, Sep 21, 2022 at 11:33 AM Dumitru Ceara
Dejing,
Looking forward to it.
Alin.
From: Dejing Liu
Sent: Tuesday, August 16, 2022 1:00 PM
To: Alin-Gabriel Serdean ; d...@openvswitch.org
Cc: Frank Guo ; Wilson Peng ; Lina
Li
Subject: Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: support meter action
initial version
Hi Alin
Again patch looks good I only have one question. Please see bellow.
> This patch implemented meter action, currently, meter only support drop
> method and only support one band. The overall implementation is, when a
> packet comes in, it will first lookup meter according to the meter id,
> then
Applied on master! Thank you!
Alin.
-Original Message-
From: dev On Behalf Of Wilson Peng via dev
Sent: Thursday, June 2, 2022 9:44 AM
To: d...@openvswitch.org
Subject: [ovs-dev] [PATCH v1 1/1] datapath-windows: Update layers for
multiple tunnels processing
From: Wilson Peng
While
Applied on master! Thank you!
Alin
-Original Message-
From: William Tu
Sent: Monday, May 30, 2022 5:55 AM
To: d...@openvswitch.org
Cc: pweis...@vmware.com; Alin-Gabriel Serdean
Subject: [PATCH v2] datapath-windows: Fix GRE/VxLAN/STT Tunnel RX.
GRE/Vxlan/STT tunnel RX is broken due
Hi,
Do you mind sending a patch to the ML adding yourself to the AUTHORS.rst
I can apply it later on.
Thank you,
Alin.
-Original Message-
From: dev On Behalf Of jinjun gao
Sent: Thursday, June 2, 2022 5:38 PM
To: d...@openvswitch.org
Subject: [ovs-dev] Please help add me to AUTHORS
-Original Message-
From: William Tu
Sent: Wednesday, June 1, 2022 2:13 AM
To: Ilya Maximets
Cc: ; Alin Gabriel Serdean
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Detect CT timeout.
On Tue, May 31, 2022 at 12:09 PM Ilya Maximets wrote:
>
> On 5/31/22 20:29, William Tu
-Original Message-
From: Dumitru Ceara
Sent: Tuesday, May 24, 2022 10:42 AM
To: Alin Serdean
Cc: Alin-Gabriel Serdean ; d...@openvswitch.org; Diko
Parvanov
Subject: Re: [PATCH] [RFC] [ovn] northd: Fix IGMP external subscriber
subscribing to internal feed
On 5/24/22 01:13, Alin
Add localnet ports to their corresponding southbound multicast group.
Update unit tests.
Reported-at: https://github.com/ovn-org/ovn/issues/125
Reported-by: Diko Parvanov
Suggested-by: Dumitru Ceara
Signed-off-by: Alin-Gabriel Serdean
---
northd/northd.c | 17 ++---
tests/ovn.at
Signed-off-by: Alin-Gabriel Serdean
---
Documentation/howto/qos.rst | 8
.../internals/contributing/documentation-style.rst| 2 +-
Documentation/topics/testing.rst | 2 +-
Documentation/topics/windows.rst
This patch removes the newly added NEWS entry and adds it as a leaf
under post 2.17.
Add OVS version instead of specifying that the feature is supported
for IPv6 connection tracking and Genenve IPv6 tunnels.
Signed-off-by: Alin-Gabriel Serdean
---
Documentation/faq/releases.rst | 6
Applied on master. Thank you for working on the feature!
-Original Message-
From: dev On Behalf Of ldejing
Sent: Monday, April 11, 2022 10:18 AM
To: d...@openvswitch.org
Cc: ldejing
Subject: [ovs-dev] [PATCH v2 1/1] datapath-windows: Add IPv6 conntrack
support on Windows.
From: ldejing
Tested-by: Alin-Gabriel Serdean
Acked-by: Alin-Gabriel Serdean
-Original Message-
From: dev On Behalf Of Peng He
Sent: Saturday, February 19, 2022 5:26 AM
To: d...@openvswitch.org
Cc: i.maxim...@ovn.org; guohongzhi
Subject: [ovs-dev] [ovs-dev v7] ofproto: add refcount to ofproto
I enabled ASan on MSVC
(https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-wi
th-msvc/)
and this patch alleviates the issues found by the CI and my local testing.
Tested-by: Alin-Gabriel Serdean
Acked-by: Alin-Gabriel Serdean
-Original Message-
From: dev
Thank you Frank and Mike!
I applied the patch on master and backported all the way to branch-2.13
Alin.
-Original Message-
From: dev On Behalf Of Mike Pattrick
Sent: Wednesday, February 23, 2022 8:21 PM
To: Frank Guo
Cc: ; Frank Guo
Subject: Re: [ovs-dev] [PATCH v1 1/1]
Thank you for incorporating the comments!
Will apply it on master and backport it until branch-2.13.
Acked-by: Alin-Gabriel Serdean
Alin.
-Original Message-
From: dev On Behalf Of Wilson Peng
Sent: Thursday, January 20, 2022 2:32 AM
To: d...@openvswitch.org
Subject: [ovs-dev] [PATCH
Thanks a lot for debugging and fixing the issue.
Just one small nit from my side, maybe OvsPickupCtTupleAsLookupKey shouldn't
have a return value.
Alin.
-Original Message-
From: dev On Behalf Of Wilson Peng
Sent: Wednesday, January 12, 2022 6:33 PM
To: d...@openvswitch.org
Subject:
Thank you for the fix! Applied on master and backported until
branch-2.13.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> While testing OVS-windows flows for the DNAT/SNAT action, the checksum in
> TCP header is set incorrectly when TCP offload is enabled by default. As a
> result,the packet will be dropped on the Windows VM when processing the packet
> from Linux VM which has included correct checksum at first.
Acked-by: Alin-Gabriel Serdean
-Original Message-
From: dev On Behalf Of Ilya Maximets
Sent: Thursday, October 21, 2021 7:22 PM
To: ovs-dev@openvswitch.org
Cc: Flavio Leitner ; Ilya Maximets
Subject: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4.
This version includes
> Currently the layers info propogated to ProcessDeferredActions may be
> incorrect. Because of this, any subsequent usage of layers might result
> in undesired behavior. Accordingly in this patch it will add the related
> layers in the deferred action to make sure the layers consistent with
>
-Original Message-
From: Ilya Maximets
Sent: Tuesday, October 12, 2021 6:41 PM
To: Alin-Gabriel Serdean ; ovs-dev@openvswitch.org;
d...@openvswitch.org
Cc: i.maxim...@ovn.org; Aaron Conole
Subject: Re: [ovs-dev] [PATCH] ipf: release unhandled packets from the batch
> On 10/12/21 17
Applied on master.
Thank you!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Acked-by: Alin-Gabriel Serdean
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Signed-off-by: Alin-Gabriel Serdean
---
.mailmap| 4 ++--
AUTHORS.rst | 2 +-
MAINTAINERS.rst | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/.mailmap b/.mailmap
index 824af56b2..6cefe3cd4 100644
--- a/.mailmap
+++ b/.mailmap
@@ -14,8 +14,8 @@ Aaron Conole
This patch specifies the file digest algorithm for signtool on the package
and ovsext VS projects.
Fixes broken appveyor build.
Signed-off-by: Alin-Gabriel Serdean
---
datapath-windows/Package/package.VcxProj | 27
datapath-windows/ovsext/ovsext.vcxproj | 13
Thanks for everything Ben!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Acked-by: Alin-Gabriel Serdean
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Indeed. Thanks for pointing that out.
To be honest that looks like a bug.
We should return an error if the it is not a valid VLAN frame.
-Original Message-
From: Wilson Peng
Sent: Wednesday, September 29, 2021 5:52 PM
To: Alin-Gabriel Serdean ; ovs-dev@openvswitch.org
Subject: Re: [ovs
From: aserd...@ovn.org
Thank you for raising awareness about this issue. You are right the
offsets are not being updated when a pop vlan action is hit, they are
updated only on pop_mpls.
https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Actions.c#L1173-L1174
Can you please
On Wed, 2021-06-16 at 18:06 +0300, Alin-Gabriel Serdean wrote:
> On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote:
> > On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote:
> > > VStudio 16.10 adds usermode includes before including the driver
> > > kit one
On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote:
> On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote:
> > VStudio 16.10 adds usermode includes before including the driver
> > kit ones.
> >
> > Bug tracked at:
> > https://developercommunity.visualstudio.com/t/
-by: Frank Wagner
Reported-at:
https://github.com/openvswitch/ovs-issues/issues/209#issuecomment-861385852
Reported-at: https://github.com/openvswitch/ovs-issues/issues/211
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/ovsext.vcxproj | 17 +
1 file changed, 17
Acked-by: Alin-Gabriel Serdean
On Thu, 2021-06-10 at 11:24 +0200, Eelco Chaudron wrote:
> Currently, conntrack in the kernel has an undocumented feature
> referred
> to as all-zero IP address SNAT. Basically, when a source port
> collision is detected during the commit, the
Switch from OpenSSL 1.0.2 to 1.1.1.
`mkdir` does not support permission arguments on Windows. Create a wrapper
for it that uses only the last argument and uses `-p` option.
Signed-off-by: Alin Gabriel Serdean
---
v2: Add more details in the commit message.
---
appveyor.yml | 6
Switch from OpenSSL 1.0.2 to 1.1.1.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 6 +++---
m4/ax_check_openssl.m4 | 2 +-
utilities/ovs-pki.in | 8
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 25c3f69fb
Bump OpenSSL.
Add release and debug configuration.
Build and add Windows installer to generated artifacts.
Build and zip prebuilt version.
Co-authored-by: Yonggang Luo
Signed-off-by: Yonggang Luo
Co-authored-by: Jinjun Gao
Signed-off-by: Jinjun Gao
Signed-off-by: Alin Gabriel Serdean
This patch bundles the Windows 10 driver family in the installer and also
adds detection for the family.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 5 -
windows/ovs-windows-installer/Driver/.gitignore | 1 +
.../ovs-windows
pthreads-win32 has moved too PThreads4W.
This patch updates the build steps, CI (appveyor) and documentation.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 10 +-
appveyor.yml| 18 +++---
m4/openvswitch.m4
Until now we were bundling MSVC120 x86 runtime.
This patch changes it too the latest version and also add the 64 bit version
of it.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 3 ++-
windows/ovs-windows-installer/Product.wxs | 11 ---
2 files
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/intro/install/windows.rst
b/Documentation/intro/install/windows.rst
index 61582f791..e91c2dbf7 100644
--- a/Documentation
It is useful to build the latest supported version of the driver using the
`make` command.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/automake.mk | 4
1 file changed, 4 insertions(+)
diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk
index b8cf5dd95
VSTUDIO_CONFIG is used when generating the windows installer.
If the parameter passed to configure `--with-vstudiotarget` is not specified
to configure we default it to `Default`.
Fixes bug: vstudiotarget/vstudiotargetver should be available only on Windows.
Signed-off-by: Alin Gabriel Serdean
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/windows/automake.mk b/windows/automake.mk
index 80dca1467..49c8985fd 100644
--- a/windows/automake.mk
+++ b/windows/automake.mk
@@ -12,7 +12,6 @@
# License
The database is now called "_Server" so look for that instead of
"Open_vSwitch".
Signed-off-by: Alin Gabriel Serdean
---
v2: Address Ilya's comments
---
tests/daemon.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/daemon.at b/tests/daemo
When running OVSDB cluster tests on Windows not all the ovsdb processes are
terminated.
Queue up the pids of the started processes for termination when the test stops.
Signed-off-by: Alin Gabriel Serdean
---
v2: Address Ilya's comments
---
tests/ovsdb-idl.at | 2 +-
1 file changed, 1 insertion
When running OVSDB cluster tests on Windows not all the ovsdb
processes are terminated.
Strip carriage return and newline of the arguments passed to the kill
command because they will cause problems when passing them to tasklist
and taskkill.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovs
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Greg Rose
---
v2: Address comments
---
Documentation/intro/install/windows.rst | 8
Documentation/topics/windows.rst| 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/intro
This patch adds information on how to generate the Windows installer
which can be used to easily deploy the userspace binaries, kernel module
and create services on new environments.
Signed-off-by: Alin Gabriel Serdean
---
v3: Address comments
v2: Change line endings at 79 characters
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/intro/install/windows.rst
b/Documentation/intro/install/windows.rst
index 394572f00..4c7724b57 100644
--- a/Documentation
Until now we were bundling MSVC120 x86 runtime.
This patch changes it too the latest version and also add the 64 bit version
of it.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 3 ++-
windows/ovs-windows-installer/Product.wxs | 11 ---
2 files
VSTUDIO_CONFIG is used when generating the windows installer.
If the parameter passed to configure `--with-vstudiotarget` is not specified
to configure we default it to `Default`.
Fixes bug: vstudiotarget/vstudiotargetver should be available only on Windows.
Signed-off-by: Alin Gabriel Serdean
This patch bundles the Windows 10 driver family in the installer and also
adds detection for the family.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 5 -
windows/ovs-windows-installer/Driver/.gitignore | 1 +
.../ovs-windows
pthreads-win32 has moved too PThreads4W.
This patch updates the build steps, CI (appveyor) and documentation.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 10 +-
appveyor.yml| 18 +++---
m4/openvswitch.m4
It is useful to build the latest supported version of the driver using the
`make` command.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/automake.mk | 4
1 file changed, 4 insertions(+)
diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk
index b8cf5dd95
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/windows/automake.mk b/windows/automake.mk
index 80dca1467..49c8985fd 100644
--- a/windows/automake.mk
+++ b/windows/automake.mk
@@ -12,7 +12,6 @@
# License
Bump OpenSSL.
Add release and debug configuration.
Build and add Windows installer to generated artifacts.
Build and zip prebuilt version.
Co-authored-by: Yonggang Luo
Signed-off-by: Yonggang Luo
Co-authored-by: Jinjun Gao
Signed-off-by: Jinjun Gao
Signed-off-by: Alin Gabriel Serdean
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/intro/install/windows.rst
b/Documentation/intro/install/windows.rst
index 394572f00..4c7724b57 100644
--- a/Documentation
It is useful to build the latest supported version of the driver using the
`make` command.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/automake.mk | 4
1 file changed, 4 insertions(+)
diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk
index b8cf5dd95
pthreads-win32 has moved too PThreads4W.
This patch updates the build steps, CI (appveyor) and documentation.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 10 +-
appveyor.yml| 18 +++---
m4/openvswitch.m4
VSTUDIO_CONFIG is used when generating the windows installer.
If the parameter passed to configure `--with-vstudiotarget` is not specified
to configure we default it to `Default`
Signed-off-by: Alin Gabriel Serdean
---
m4/openvswitch.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Until now we were bundling MSVC120 x86 runtime.
This patch changes it too the latest version and also add the 64 bit version
of it.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 3 ++-
windows/ovs-windows-installer/Product.wxs | 11 ---
2 files
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/windows/automake.mk b/windows/automake.mk
index 80dca1467..49c8985fd 100644
--- a/windows/automake.mk
+++ b/windows/automake.mk
@@ -12,7 +12,6 @@
# License
This patch bundles the Windows 10 driver family in the installer and also
adds detection for the family.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 5 -
windows/ovs-windows-installer/Driver/.gitignore | 1 +
.../ovs-windows
The following patchset contains small updates in the build process and
corresponding documentation.
Alin Serdean (8):
windows: Remove unused variable
windows: Add default value for VSTUDIO_CONFIG
datapath_windows: Add datapath_windows target
windows, documentation: Recommend latest VS and
Bump OpenSSL.
Add release and debug configuration.
Build and add Windows installer to generated artifacts.
Build and zip prebuilt version.
Co-authored-by: Yonggang Luo
Signed-off-by: Yonggang Luo
Co-authored-by: Jinjun Gao
Signed-off-by: Jinjun Gao
Signed-off-by: Alin Gabriel Serdean
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/topics/windows.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/topics/windows.rst b/Documentation/topics/windows.rst
index 3a103b4e8..be6e2861e 100644
--- a/Documentation
This patch adds information on how to generate the Windows installer
which can be used to easily deploy the userspace binaries, kernel module
and create services on new environments.
Signed-off-by: Alin Gabriel Serdean
---
v2: Change line endings at 79 characters
---
Documentation/intro/install
This patch adds information on how to generate the Windows installer
which can be used to easily deploy the userspace binaries, kernel module
and create services on new environments.
Signed-off-by: Alin Gabriel Serdean
---
Documentation/intro/install/windows.rst | 23 ---
1
Bump OpenSSL and pthreads links.
Add release and debug configuration.
Build and add Windows installer to generated artifacts.
Co-authored-by: Yonggang Luo
Signed-off-by: Yonggang Luo
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 19 ++-
1 file changed, 14 insertions
> On 15 Oct 2019, at 19:14, Ben Pfaff wrote:
>
> On Tue, Oct 15, 2019 at 01:15:02PM +0300, Alin Gabriel Serdean wrote:
>> Signed-off-by: Alin Gabriel Serdean
>
> Acked-by: Ben Pfaff
Thanks! Applied on master.
_
Signed-off-by: Alin Gabriel Serdean
---
AUTHORS.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 443bb0ba2..480611a1f 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -34,6 +34,7 @@ Name Email
Aaron Conole
version from 1.0.2n to 1.0.2t.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index b30122744..ee72a948b 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -4,6 +4,8 @@ branches:
- master
The database is now called "_Server" so look for that instead of "Open_vSwitch".
Modify the test so it always stops and deletes the service.
Signed-off-by: Alin Gabriel Serdean
---
tests/daemon.at | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --g
When running OVSDB cluster tests on Windows not all the ovsdb processes are
terminated.
Queue up the pids of the started processes for termination when the test stops.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovsdb-idl.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Thanks for the patch!
Applied on master.
> On 18 May 2019, at 00:16, Anand Kumar via dev wrote:
>
> When a nbl is cloned, mru value stored in the original nbl
> context is lost, which skips refragemting the cloned nbls.
>
> This patch fixes it.
>
> Signed-off-by: Anand Kumar
> ---
>
> On 11 Apr 2019, at 19:14, Anand Kumar via dev wrote:
>
> As per MSDN documentation, "As soon as a filter driver calls the
> NdisFSendNetBufferLists function, it relinquishes ownership of
> the NET_BUFFER_LIST structures and all associated resources.
> A filter driver should never try to
he else block and by default try to send the packet out.
> —
>
Acked-by: Alin Gabriel Serdean mailto:aserd...@ovn.org>>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks both! I applied this patch as far back as branch-2.9.
> On 16 Apr 2019, at 02:16, Anand Kumar via dev wrote:
>
> Acked-by: Anand Kumar
>
> Thanks,
> Anand Kumar
>
>
___
dev mailing list
d...@openvswitch.org
> On 5 Apr 2019, at 21:22, Anand Kumar via dev wrote:
>
> Update flowkey to set vlan information in network byte order.
>
> Signed-off-by: Anand Kumar
> —
Thank you! Applied on master.
___
dev mailing list
d...@openvswitch.org
> On 8 Apr 2019, at 22:48, Ben Pfaff wrote:
>
> On Wed, Apr 03, 2019 at 03:03:34PM +0300, Alin Gabriel Serdean wrote:
>> Signed-off-by: Alin Gabriel Serdean
>
> Looks good to me.
>
> Acked-by: Ben Pfaff
Thank you. Applied on master!
inside our repository. This is the same ruleset used for
8,8.1 and 10.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/Package/package.VcxProj | 21 -
datapath-windows/Package/package.VcxProj.user | 5 +-
datapath-windows/automake.mk | 2 +
.../misc
Applied on master!
> On 19 Mar 2019, at 00:43, Alin Gabriel Serdean wrote:
>
> Using python `sys.exit(-1)` on Windows produces mixed results.
> Let's take the following results from different shells:
> CMD
>> python -c "import sys; sys.exit(-1)" & echo %e
is always a multiple of
> MEMORY_ALLOCATION_ALIGNMENT.
>
> Also change the DEFAULT_CONTEXT_SIZE to accomodate OVS_BUFFER_CONTEXT size.
>
> Signed-off-by: Anand Kumar
> ---
>
> Thanks a lot for implementing this!
>
> Acked-by: Alin Gabriel Serdean
>
&g
Signed-off-by: Alin Gabriel Serdean
---
tests/atlocal.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index 5eff0a0aa..50c2a48a4 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -100,7 +100,7 @@ esac
# Check for platform.
case
of `offsetof`.
Signed-off-by: Alin Gabriel Serdean
---
include/openvswitch/compiler.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/openvswitch/compiler.h b/include/openvswitch/compiler.h
index c7cb9308d..5289a70f6 100644
--- a/include/openvswitch/compiler.h
+++ b/include
-off-by: Alin Gabriel Serdean
---
lib/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/wmi.c b/lib/wmi.c
index e6dc63cde..44c1d75e9 100644
--- a/lib/wmi.c
+++ b/lib/wmi.c
@@ -686,7 +686,7 @@ create_wmi_port(char *name) {
/* Check if the element already exists
ructs - for FAILED (checkpatch.at:32)
13: checkpatch - comments FAILED (checkpatch.at:32)
because of:
./checkpatch.at:32: exit code was 0, expected 255
This patch introduces a positive constant for the default exit code (1)
similar to other OVS utilities.
Signed-off-
ructs - for FAILED (checkpatch.at:32)
13: checkpatch - comments FAILED (checkpatch.at:32)
because of:
./checkpatch.at:32: exit code was 0, expected 255
This patch introduces a positive constant for the default exit code.
Signed-off-by: Alin Gabriel Serdean
Add annotations to find vport functions to check if the dispatch lock is
held.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 7 ++-
datapath-windows/ovsext/Vport.h | 5 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext
When using a vport we need to guard its usage with the dispatch lock.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/User.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index
ructs - for FAILED (checkpatch.at:32)
13: checkpatch - comments FAILED (checkpatch.at:32)
because of:
./checkpatch.at:32: exit code was 0, expected 255
This patch introduces a positive constant for the default exit code.
Signed-off-by: Alin Gabriel Serdean
Acked-
ructs - for FAILED (checkpatch.at:32)
13: checkpatch - comments FAILED (checkpatch.at:32)
because of:
./checkpatch.at:32: exit code was 0, expected 255
This patch introduces a positive constant for the default exit code.
Signed-off-by: Alin Gabriel Serdean
---
utili
> On 23 Jan 2019, at 12:58, Numan Siddique wrote:
>
>
>
> On Wed, Jan 23, 2019 at 4:14 PM Alin Gabriel Serdean <mailto:aserd...@ovn.org>> wrote:
> The test fails on Windows because of:
> <--cut-->
> ovn-nbctl: sw0: invalid network address: 2001;1\64
&g
The test fails on Windows because of:
<--cut-->
ovn-nbctl: sw0: invalid network address: 2001;1\64
ovn-nbctl: sw1: invalid network address: 2002;1\64
<--cut-->
This is due to the fact msys converts '::1' into ';1'.
Use IPv6 long form instead of its short variant.
Signed-off-by:
> On 27 Dec 2018, at 20:29, Anand Kumar wrote:
>
> Acked-by: Anand Kumar mailto:kumaran...@vmware.com>>
>
Thanks both. Applied on master and branch-2.10.
Alin.
___
dev mailing list
d...@openvswitch.org
We need to hold the port lock until all the operations with a port are
completed.
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows
inal or restarted children.")
>
> Other minor improvements too.
>
> I only made small updates to the Windows-specific test, because it is hard
> for me to verify.
>
> Acked-by: Alin Gabriel Serdean
> Signed-off-by: Ben Pfaff
> ---
> v1->v2: Rebased, added
1 - 100 of 225 matches
Mail list logo
