Re: [ovs-dev] [PATCH v1 ovn] OVN: Multiple distributed gateway port support

2021-01-15 Thread Ankur Sharma
Hi Numan, Just submitted a V2. Please look. Appreciate your help. Regards, Ankur From: Numan Siddique Sent: Wednesday, January 13, 2021 2:48 AM To: svc.mail.git ; Ankur Sharma Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v1 ovn] OVN: Multiple distributed

[ovs-dev] [PATCH v2 ovn] OVN: Multiple distributed gateway port support

2021-01-15 Thread Ankur Sharma
From: Ankur Sharma By default, OVN support only one distributed gateway port (we will call it l3dgw port for further reference) per logical router. While a single l3dgw port suffices for most of the North South connectivity, however there are requirements where a logical router could

[ovs-dev] [PATCH v2 ovn] Multiple l3dgw port support

2021-01-15 Thread Ankur Sharma
From: Ankur Sharma This patch adds multiple l3dgw port support in OVN. Code changes are high, however since data structure was enhanced and it had to be consumed in same patch, hence we think that from review perspective probably a single patch would suffice, rather than a series. Some

[ovs-dev] [PATCH v1 ovn] OVN: Multiple distributed gateway port support

2021-01-12 Thread Ankur Sharma
From: Ankur Sharma By default, OVN support only one distributed gateway port (we will call it l3dgw port for further reference) per logical router. While a single l3dgw port suffices for most of the North South connectivity, however there are requirements where a logical router could

[ovs-dev] [PATCH v1 ovn] Multiple l3dgw port support

2021-01-12 Thread Ankur Sharma
From: Ankur Sharma This patch adds multiple l3dgw port support in OVN. Code changes are high, however since data structure was enhanced and it had to be consumed in same patch, hence we think that from review perspective probably a single patch would suffice, rather than a series. Some

Re: [ovs-dev] [PATCH ovn 11/14] ovn-nbctl: Fix leak of IPs while configuring NAT.

2020-11-20 Thread Ankur Sharma
Acked-by: Ankur Sharma Regards, Ankur From: Ilya Maximets Sent: Thursday, November 19, 2020 4:17 PM To: ovs-dev@openvswitch.org Cc: Mark Michelson ; Numan Siddique ; Dumitru Ceara ; Ilya Maximets ; Ankur Sharma Subject: [PATCH ovn 11/14] ovn-nbctl: Fix leak

Re: [ovs-dev] [PATCH v3 0/2] NAT port range support

2020-09-16 Thread Ankur Sharma
Hi Numan, Sure, just submitted the V4. Regards, Ankur From: Numan Siddique Sent: Wednesday, September 16, 2020 12:52 AM To: svc.mail.git ; Ankur Sharma Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v3 0/2] NAT port range support On Wed, Sep 16, 2020 at 5:35 AM

[ovs-dev] [PATCH v4 2/2 ovn] NAT: Northd and parser changes to support port

2020-09-16 Thread Ankur Sharma
From: Ankur Sharma This patch has following changes: a. Northd changes to put port range hash in the logical flow based on configuration. b. Changes to parse the logical flow, which specifies port_range_hash along with port_range for ct_nat action. Example logical flow: ct_snat

[ovs-dev] [PATCH v4 0/2 ovn] NAT port range support

2020-09-16 Thread Ankur Sharma
From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. In continuation to 509733c, this series adds support for specifying a hashing algorithm, to be used while picking a port number from given range Ankur Sharma (2): NAT: Provide port hash in input NAT

[ovs-dev] [PATCH v4 1/2 ovn] NAT: Provide port hash in input

2020-09-16 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional column in NAT table. external_port_hash: Specifies the hashing mechanism if port range is specified. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [PATCH v3 2/2] NAT: Northd and parser changes to support port

2020-09-15 Thread Ankur Sharma
From: Ankur Sharma This patch has following changes: a. Northd changes to put port range hash in the logical flow based on configuration. b. Changes to parse the logical flow, which specifies port_range_hash along with port_range for ct_nat action. Example logical flow: ct_snat

[ovs-dev] [PATCH v3 1/2] NAT: Provide port hash in input

2020-09-15 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional column in NAT table. external_port_hash: Specifies the hashing mechanism if port range is specified. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [PATCH v3 0/2] NAT port range support

2020-09-15 Thread Ankur Sharma
From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. In continuation to 509733c, this series adds support for specifying a hashing algorithm, to be used while picking a port number from given range Ankur Sharma (2): NAT: Provide port hash in input NAT

Re: [ovs-dev] [PATCH v1 0/2 ovn] NAT port range support

2020-09-15 Thread Ankur Sharma
Hi Numan, Just submitted V2 of this series. Thanks a lot for taking a look. Regards, Ankur From: Numan Siddique Sent: Friday, September 4, 2020 11:11 AM To: svc.mail.git ; Ankur Sharma Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v1 0/2 ovn] NAT port range

[ovs-dev] [PATCH v2 2/2] NAT: Northd and parser changes to support port

2020-09-15 Thread Ankur Sharma
From: Ankur Sharma This patch has following changes: a. Northd changes to put port range hash in the logical flow based on configuration. b. Changes to parse the logical flow, which specifies port_range_hash along with port_range for ct_nat action. Example logical flow: ct_snat

[ovs-dev] [PATCH v2 1/2] NAT: Provide port hash in input

2020-09-15 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional column in NAT table. external_port_hash: Specifies the hashing mechanism if port range is specified. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [PATCH v2 0/2] NAT port range support

2020-09-15 Thread Ankur Sharma
From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. In continuation to 509733c, this series adds support for specifying a hashing algorithm, to be used while picking a port number from given range Ankur Sharma (2): NAT: Provide port hash in input NAT

[ovs-dev] [PATCH v1] NEWS: Add external ip based NAT support

2020-09-08 Thread Ankur Sharma
Signed-off-by: Ankur Sharma --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index a1ce4e8..8e2869b 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,8 @@ Post-v20.06.0 called Chassis_Private now contains the nb_cfg column which is updated by incrementing the value

Re: [ovs-dev] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-09-07 Thread Ankur Sharma
] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI Hi Ankur, Sorry for the late review. This patch LGTM except for one comment. I have few comments in patch 2. Thanks Numan On Thu, Aug 20, 2020 at 8:05 AM Ankur Sharma wrote: > From: Ankur Sharma > > This patch adds

[ovs-dev] [PATCH v6 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-09-07 Thread Ankur Sharma
From: Ankur Sharma This patch adds following columns to NAT table. a. allowed_ext_ips: Represents Address Set of External IPs for which a NAT rule is applicable. b. exempted_ext_ips: Represents Address Set of External IPs for which a NAT rule is NOT applicable. Additionally, patch

[ovs-dev] [PATCH v6 2/2 ovn] External IP based NAT: NORTHD changes to use allowed/exempted external ip

2020-09-07 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes which consumes allowed/exempted external ip configuration per NAT rule in logical flow. Allowed external ip range adds an additional match criteria in snat/dnat logical flow rules. For example, if an allowed_external_ip address set ("

[ovs-dev] [PATCH v6 0/2 ovn] External IP based NAT

2020-09-07 Thread Ankur Sharma
From: Ankur Sharma Another term for this feature is destination based NAT, especially in the context of SNAT. Current NAT implementation is OVN endpoint ip based. For example, # ovn-nbctl lr-nat-list router TYPE EXTERNAL_IPLOGICAL_IP snat 10.15.24.135

[ovs-dev] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-08-19 Thread Ankur Sharma
From: Ankur Sharma This patch adds following columns to NAT table. a. allowed_ext_ips: Represents Address Set of External IPs for which a NAT rule is applicable. b. exempted_ext_ips: Represents Address Set of External IPs for which a NAT rule is NOT applicable. Additionally, patch

[ovs-dev] [PATCH v5 0/2 ovn] External IP based NAT

2020-08-19 Thread Ankur Sharma
From: Ankur Sharma Another term for this feature is destination based NAT, especially in the context of SNAT. Current NAT implementation is OVN endpoint ip based. For example, # ovn-nbctl lr-nat-list router TYPE EXTERNAL_IPLOGICAL_IP snat 10.15.24.135

[ovs-dev] [PATCH v5 2/2 ovn] External IP based NAT: NORTHD changes to use allowed/exempted external ip

2020-08-19 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes which consumes allowed/exempted external ip configuration per NAT rule in logical flow. Allowed external ip range adds an additional match criteria in snat/dnat logical flow rules. For example, if an allowed_external_ip address set ("

Re: [ovs-dev] [PATCH v1] ovn-controller: Fix the CT zone assignment logic for logical routers

2020-08-12 Thread Ankur Sharma
@openvswitch.org ; Ankur Sharma Subject: Re: [ovs-dev] [PATCH v1] ovn-controller: Fix the CT zone assignment logic for logical routers   On 8/4/20 5:55 AM, Ankur Sharma wrote: > From: Ankur Sharma > > BACKGROUND: > a. ovn-controller assigns CT ZONES for local ports and datapaths. > b.

[ovs-dev] [PATCH v4 0/2 ovn] External IP based NAT

2020-08-04 Thread Ankur Sharma
From: Ankur Sharma Another term for this feature is destination based NAT, especially in the context of SNAT. Current NAT implementation is OVN endpoint ip based. For example, # ovn-nbctl lr-nat-list router TYPE EXTERNAL_IPLOGICAL_IP snat 10.15.24.135

[ovs-dev] [PATCH v4 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-08-04 Thread Ankur Sharma
From: Ankur Sharma This patch adds following columns to NAT table. a. applied_ext_ips: Represents Address Set of External IPs for which a NAT rule is applicable. b. exempted_ext_ips: Represents Address Set of External IPs for which a NAT rule is NOT applicable. Additionally, patch

[ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD changes to use applied/exempted external ip

2020-08-04 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes which consumes applied/exempted external ip configuration per NAT rule in logical flow. Applied/Exempted external ip range adds an additional match criteria in snat/dnat/unsnat/undant logical flow rules. For example, if an allowed_external_ip

[ovs-dev] [PATCH v1] ovn-controller: Fix the CT zone assignment logic for logical routers

2020-08-03 Thread Ankur Sharma
From: Ankur Sharma BACKGROUND: a. ovn-controller assigns CT ZONES for local ports and datapaths. b. If a local port/datapath is cleaned up from a chassis, then corresponding CT ZONE is "unassigned"/"freed" up. ISSUE: Above logic and implementations leaves stale CT ent

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-29 Thread Ankur Sharma
Hi Han, Changes look fine. Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of Han Zhou Sent: Wednesday, July 29, 2020 6:44 PM To: d...@openvswitch.org Cc: Han Zhou Subject: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-29 Thread Ankur Sharma
Please let me know your thoughts. Please feel free to call out, if i missed something, i will be happy to discuss further. Appreciate the discussions and inputs. Regards, Ankur From: dev on behalf of Ankur Sharma Sent: Saturday, July 25, 2020 10:09 PM To: Numan Siddique ; Daniel Alvarez

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-25 Thread Ankur Sharma
From: Numan Siddique Sent: Wednesday, July 22, 2020 12:24 PM To: Ankur Sharma ; Daniel Alvarez Sanchez ; Lucas Alvares Gomes Martins Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-12 Thread Ankur Sharma
_ From: Numan Siddique Sent: Friday, July 10, 2020 6:18 AM To: Ankur Sharma Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches. On Fri, Jul 10, 2020 at 4:41 PM Numan Siddique mailto:num...@ov

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-09 Thread Ankur Sharma
to come up with an alternative. Regards, Ankur From: num...@ovn.org Sent: Thursday, July 9, 2020 2:11 AM To: d...@openvswitch.org Cc: Numan Siddique ; Daniel Alvarez ; Ankur Sharma Subject: [PATCH ovn v2] Fix the routing for external logical ports of bridged

[ovs-dev] [PATCH v3 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-07-08 Thread Ankur Sharma
From: Ankur Sharma This patch adds following columns to NAT table. a. applied_ext_ips: Represents Address Set of External IPs for which a NAT rule is applicable. b. exempted_ext_ips: Represents Address Set of External IPs for which a NAT rule is NOT applicable. Additionally, patch

[ovs-dev] [PATCH v3 2/2] External IP based NAT: NORTHD changes to use applied/exempted external ip

2020-07-08 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes which consumes applied/exempted external ip configuration per NAT rule in logical flow. Applied/Exempted external ip range adds an additional match criteria in snat/dnat/unsnat/undant logical flow rules. For example, if an allowed_external_ip

[ovs-dev] [PATCH v3 0/2 ovn] External IP based NAT

2020-07-08 Thread Ankur Sharma
is peered to (some) external subnets, and non overlapping ips between logical router and external subnet space are ensured. Ankur Sharma (2): External IP based NAT: Add Columns and CLI External IP based NAT: NORTHD changes to use applied/exempted external ip northd/ovn-northd.c | 61

[ovs-dev] [PATCH v3 ovn] Throttle the OVS-OVN Global config logs

2020-07-04 Thread Ankur Sharma
From: Ankur Sharma ISSUE: We observed that if ovn-controller is running, while ovn-encap-ip/ ovn-encap-type is not set, then following error gets logged continously: "chassis|INFO|Need to specify an encap type and ip" Above log increased the size of ovn-controller.log to hundreds of G

[ovs-dev] [PATCH v2 ovn] Throttle the OVS-OVN Global config logs

2020-07-02 Thread Ankur Sharma
From: Ankur Sharma ISSUE: We observed that if ovn-controller is running, while ovn-encap-ip/ ovn-encap-type is not set, then following error gets logged continously: "chassis|INFO|Need to specify an encap type and ip" Above log increased the size of ovn-controller.log to hundreds of G

[ovs-dev] [PATCH v1 ovn] Throttle the OVS-OVN Global config logs

2020-07-02 Thread Ankur Sharma
From: Ankur Sharma From: Ankur Sharma ISSUE: We observed that if ovn-controller is running, while ovn-encap-ip/ ovn-encap-type is not set, then following error gets logged continously: "chassis|INFO|Need to specify an encap type and ip" Above log increased the size of ovn-cont

Re: [ovs-dev] [PATCH v1 ovn] Fix seg fault while encoding DHCP domain search option.

2020-06-30 Thread Ankur Sharma
Hi Dhathri, Please Add "Fixes" header to commit message. Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of svc.eng.git-pa...@nutanix.com Sent: Tuesday, June 30, 2020 10:04 AM To: ovs-dev@openvswitch.org Cc: Dhathri Purohith Subject

[ovs-dev] [PATCH v2 0/2 ovn] External IP based NAT

2020-06-28 Thread Ankur Sharma
is peered to (some) external subnets, and non overlapping ips between logical router and external subnet space are ensured. Ankur Sharma (2): External IP based NAT: Add Columns and CLI External IP based NAT: NORTHD changes to use allowed/disallowed external ip northd/ovn-northd.c | 82

[ovs-dev] [PATCH v2 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-06-28 Thread Ankur Sharma
From: Ankur Sharma This patch adds following columns to NAT table. a. allowed_external_ip: Represents Address Set of External IPs for which a NAT rule is applicable. b. disallowed_external_ip Represents Address Set of External IPs for which a NAT rule is NOT applicable

[ovs-dev] [PATCH v2 2/2 ovn] External IP based NAT: NORTHD changes to use allowed/disallowed external ip

2020-06-28 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes which consumes allowed/disallowed external ip configuration per NAT rule in logical flow. Allowed/Disallowed external ip range adds an additional match criteria in snat/dnat/unsnat/undant logical flow rules. For example

[ovs-dev] [PATCH v1 0/2 ovn] External IP based NAT

2020-06-28 Thread Ankur Sharma
is peered to (some) external subnets, and non overlapping ips between logical router and external subnet space are ensured. Ankur Sharma (2): External IP based NAT: Add Columns and CLI External IP based NAT: NORTHD changes to use allowed/disallowed external ip northd/ovn-northd.c | 82

[ovs-dev] [PATCH v1 2/2 ovn] External IP based NAT: NORTHD changes to use allowed/disallowed external ip

2020-06-28 Thread Ankur Sharma
(lr_in_unsnat...)match=(ip && . && ip4.src == $efgh), action=(ct_snat;) Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 82 + tests/ovn-northd.at | 127 2 files changed, 209 insertions(+) dif

[ovs-dev] [PATCH v1 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-06-28 Thread Ankur Sharma
cli to set these column values. ovn-nbctl [--is-allowed] lr-nat-update-ext-ip Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 14 ++- ovn-nb.xml| 24 tests/ovn-nbctl.at| 37 +- utilities/ovn-nbctl.c | 102

[ovs-dev] [PATCH v10 ovn] Add support for DHCP domain search option (119)

2020-06-24 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- v9 -> v10 --- * Fixed Author Name --- --- v8 -> v9 --- * Add Signed-off-by: Ankur Sharma --- --- v7

[ovs-dev] [PATCH v9 ovn] Add support for DHCP domain search option (119)

2020-06-24 Thread Ankur Sharma
From: Dhathri Purohith From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- v8 -> v9 --- * Add Signed-off-by: Ankur Sharma --- --- v7 -> v8 ---

[ovs-dev] [PATCH v8 ovn] Add support for DHCP domain search option (119)

2020-06-24 Thread Ankur Sharma
From: Dhathri Purohith From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith --- v7 -> v8 --- * Use SHASH_INITIALIZER to initialize shash. * Use ovs_strlcpy() instead of strcpy(). * Use

[ovs-dev] [PATCH v7 ovn] Add support for DHCP domain search option (119)

2020-06-19 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- lib/actions.c | 90 - lib/ovn-l7.h| 3 ++ northd

[ovs-dev] [PATCH v6 ovn] Add support for DHCP domain search option (119)

2020-06-19 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- lib/actions.c | 90 - lib/ovn-l7.h| 3 ++ northd

[ovs-dev] [PATCH v2 2/2 ovn] NAT: Northd and parser changes to support port

2020-06-13 Thread Ankur Sharma
From: Ankur Sharma From: Ankur Sharma This patch has following changes: a. Northd changes to put port range hash in the logical flow based on configuration. b. Changes to parse the logical flow, which specifies port_range_hash along with port_range for ct_nat action. Example logical

[ovs-dev] [PATCH v2 1/2 ovn] NAT: Provide port hash in input

2020-06-13 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional column in NAT table. external_port_hash: Specifies the hashing mechanism if port range is specified. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [PATCH v5 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-11 Thread Ankur Sharma
From: Dhathri Purohith From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- lib/actions.c | 86 - lib/ovn-l7

[ovs-dev] [PATCH v5 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-11 Thread Ankur Sharma
Purohith Signed-off-by: Ankur Sharma --- lib/actions.c | 12 ++ lib/ovn-l7.h| 2 +- northd/ovn-northd.c | 7 +- ovn-nb.xml | 18 +- ovn-sb.ovsschema| 7 +++--- ovn-sb.xml | 13 ++ test

Re: [ovs-dev] [PATCH ovn] test: add more tests to IP-buffering unit-test

2020-06-03 Thread Ankur Sharma
Hi Lorenzo, Thanks for the explanation. Just need one more clarification, please find the same inline. Regards, Ankur From: Lorenzo Bianconi Sent: Wednesday, June 3, 2020 1:47 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn

Re: [ovs-dev] [PATCH ovn] test: add more tests to IP-buffering unit-test

2020-06-02 Thread Ankur Sharma
Hi Lorenzo, Please find my comments inline. Regards, Ankur From: dev on behalf of Ankur Sharma Sent: Monday, June 1, 2020 9:05 PM To: Lorenzo Bianconi ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn] test: add more tests to IP-buffering unit

Re: [ovs-dev] [PATCH ovn] test: add more tests to IP-buffering unit-test

2020-06-01 Thread Ankur Sharma
Hi Lorenzo, Thanks a lot for the patch. I will get back on this by EOD PST tomorrow. Regards, Ankur From: Lorenzo Bianconi Sent: Friday, May 29, 2020 7:01 AM To: ovs-dev@openvswitch.org Cc: Ankur Sharma ; num...@ovn.org ; dce...@redhat.com Subject: [PATCH ovn

[ovs-dev] [PATCH v4 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread Ankur Sharma
e for DHCP option 66 is changed to "host_id" instead of ipv4. OVN northd code that updates the OVN southbound database is enhanced to consider the change in the type and code for DHCP option, so that the change in datatype is reflected. Signed-off-by: Dhathri Purohith Signed-off-by: Ank

[ovs-dev] [PATCH v4 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- lib/actions.c | 100 +++- lib/ovn-l7.h| 3

[ovs-dev] [PATCH v3 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith --- lib/actions.c | 100 +++- lib/ovn-l7.h| 3 ++ northd/ovn-northd.c | 1 +

[ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Currently, DHCP option is of type ipv4. But, according to RFC 2132, option 66 can be a hostname i.e, we should also accept string type. In order to be backward compatible, a new type called "host_id" is introduced, which accepts both ipv4 address and string. Type for DHCP

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-28 Thread Ankur Sharma
ot be that of gateway ip. > > > > > That's a regular NS workflow. > > > > > > > > I think ovn does not add any "default" route by default. You need to > > add > > > > it doing > > > > something like: > > > > > > &

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-22 Thread Ankur Sharma
Hi Lorenzo, Please find my replies inline. Regards, Ankur From: Lorenzo Bianconi Sent: Friday, May 22, 2020 12:48 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes > Hi Lore

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-21 Thread Ankur Sharma
to static route right? By default there will be a gateway and destination ip will not be that of gateway ip. That's a regular NS workflow. Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of Lorenzo Bianconi Sent: Thursday, May 21, 2020 6:46 AM To: ovs

Re: [ovs-dev] [PATCH ovn] Don't leak values other than 1 or 0 as bool return values on C89 compiler

2020-05-19 Thread Ankur Sharma
Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of Ihar Hrachyshka Sent: Tuesday, May 19, 2020 3:12 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH ovn] Don't leak values other than 1 or 0 as bool return values on C89 compiler While the code

[ovs-dev] [PATCH v2 ovn] Add support for DHCP options - Domain Search List (119) and TFTP server (66).

2020-05-07 Thread Ankur Sharma
From: Dhathri Purohith 1. Add support for DHCP domain search option (119) Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. 2. Fix the data type for DHCP option tftp_server (66) Currently, DHCP option is of type ipv4. But, according to RFC 2132,

[ovs-dev] [PATCH v1] Add support for DHCP options - Domain Search List (119) and TFTP server (66).

2020-05-04 Thread Ankur Sharma
From: Dhathri Purohith 1. Add support for DHCP domain search option (119) Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. 2. Fix the data type for DHCP option tftp_server (66) Currently, DHCP option is of type ipv4. But, according to RFC 2132,

[ovs-dev] [PATCH v1 2/2 ovn] NAT: Northd and parser changes to support port

2020-05-04 Thread Ankur Sharma
From: Ankur Sharma This patch has following changes: a. Northd changes to put port range hash in the logical flow based on configuration. b. Changes to parse the logical flow, which specifies port_range_hash along with port_range for ct_nat action. Example logical flow: ct_snat

[ovs-dev] [PATCH v1 0/2 ovn] NAT port range support

2020-05-04 Thread Ankur Sharma
From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. In continuatuin to 509733c, this series adds support for specifying a hashing algorithm, to be used while picking a port number from given range Ankur Sharma (2): NAT: Provide port hash in input NAT

[ovs-dev] [PATCH v1 1/2 ovn] NAT: Provide port hash in input

2020-05-04 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional column in NAT table. external_port_hash: Specifies the hashing mechanism if port range is specified. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn

Re: [ovs-dev] [PATCH ovn v1] NAT: port range cannot be stateless

2020-04-22 Thread Ankur Sharma
Hi Flavio, Changes look fine to me. Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of Flavio Fernandes Sent: Wednesday, April 22, 2020 3:07 AM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH ovn v1] NAT: port range cannot be stateless Minor

Re: [ovs-dev] [PATCH ovn v1 1/1] NAT: Enhancements to external port range support

2020-04-21 Thread Ankur Sharma
Hi Flavio, Thanks for the patch, changes look good to me. Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of Flavio Fernandes Sent: Wednesday, April 15, 2020 3:10 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH ovn v1 1/1] NAT: Enhancements

[ovs-dev] [PATCH v5 1/2 ovn] NAT: Provide port range in input

2020-04-07 Thread Ankur Sharma
From: Ankur Sharma From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional comuln in NAT table. external_port_range: Specifies the range of port numbers to translate source port to. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur

[ovs-dev] [PATCH v5 2/2 ovn] NAT: Northd and parser changes to support port range

2020-04-07 Thread Ankur Sharma
From: Ankur Sharma From: Ankur Sharma This patch has northd changes to put port range in the logical flow based on configuration. Port range is NOT applicable for stateless dnat_and_snat rules. Changes to parse the logical flow, which specifies port_range for ct_nat action. Example logical

[ovs-dev] [PATCH v4 2/2 ovn] NAT: Northd and parser changes to support port range

2020-04-02 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes to put port range in the logical flow based on configuration. Port range is NOT applicable for stateless dnat_and_snat rules. Changes to parse the logical flow, which specifies port_range for ct_nat action. Example logical flow: ct_snat

[ovs-dev] [PATCH v4 1/2 ovn] NAT: Provide port range in input

2020-04-02 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional comuln in NAT table. external_port_range: Specifies the range of port numbers to translate source port to. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma Acked

[ovs-dev] [PATCH v3 2/2 ovn] NAT: Northd and parser changes to support port range

2020-04-01 Thread Ankur Sharma
) Signed-off-by: Ankur Sharma --- include/ovn/actions.h | 7 ++ include/ovn/lex.h | 1 + lib/actions.c | 48 ++ lib/lex.c | 5 +++- northd/ovn-northd.c | 31 + tests/ovn-northd.at | 64

[ovs-dev] [PATCH v3 1/2 ovn] NAT: Provide port range in input

2020-04-01 Thread Ankur Sharma
This patch enhances the NB OVSSCHEMA to add an additional comuln in NAT table. external_port_range: Specifies the range of port numbers to translate source port to. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 5

[ovs-dev] [PATCH v3 0/2 ovn] NAT port range support

2020-04-01 Thread Ankur Sharma
the range. In this series we cover a. above, i.e providing port range. Additional patches will be sent out in coming weeks for b., c. and d. above. Ankur Sharma (2): NAT: Provide port range in input NAT: Northd and parser changes to support port range include/ovn/actions.h | 7

Re: [ovs-dev] [PATCH v1 1/3 ovn] NAT: Provide port range in input

2020-04-01 Thread Ankur Sharma
in input On 3/27/20 7:18 PM, Ankur Sharma wrote: > From: Ankur Sharma > > This patch enhances the NB OVSSCHEMA to add an additional comuln in > NAT table. > > external_port_range: Specifies the range of port numbers > to translate source port to.

Re: [ovs-dev] [PATCH v1 3/3 ovn] NAT: Parsing port_range options in ct_*nat actions

2020-04-01 Thread Ankur Sharma
Sharma wrote: > From: Ankur Sharma > > Changes to parse the logical flow, which specifies port_range for > ct_nat action. > > Example logical flow: > ct_snat(10.15.24.135,1-3) > > Signed-off-by: Ankur Sharma > --- > include/ovn/actions.h | 7 +

[ovs-dev] [PATCH v2 1/2 ovn] NAT: Provide port range in input

2020-04-01 Thread Ankur Sharma
This patch enhances the NB OVSSCHEMA to add an additional comuln in NAT table. external_port_range: Specifies the range of port numbers to translate source port to. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 5

[ovs-dev] [PATCH v2 2/2 ovn] NAT: Northd and parser changes to support port range

2020-04-01 Thread Ankur Sharma
) Signed-off-by: Ankur Sharma --- include/ovn/actions.h | 7 ++ include/ovn/lex.h | 1 + lib/actions.c | 43 ++ lib/lex.c | 5 +++- northd/ovn-northd.c | 31 + tests/ovn-northd.at | 64

[ovs-dev] [PATCH v2 0/2 ovn] NAT port range support

2020-04-01 Thread Ankur Sharma
From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. Some of the key paramters: a. Specifying external source port range. b. Specifying the algorithm for mapping ports from the range. c. Specifying the external ip address range. d. Persisting the selection

[ovs-dev] [PATCH v1 1/3 ovn] NAT: Provide port range in input

2020-03-27 Thread Ankur Sharma
From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional comuln in NAT table. external_port_range: Specifies the range of port numbers to translate source port to. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [PATCH v1 3/3 ovn] NAT: Parsing port_range options in ct_*nat actions

2020-03-27 Thread Ankur Sharma
From: Ankur Sharma Changes to parse the logical flow, which specifies port_range for ct_nat action. Example logical flow: ct_snat(10.15.24.135,1-3) Signed-off-by: Ankur Sharma --- include/ovn/actions.h | 7 +++ include/ovn/lex.h | 1 + lib/actions.c | 39

[ovs-dev] [PATCH v1 0/3 ovn] NAT port range support

2020-03-27 Thread Ankur Sharma
From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. Some of the key paramters: a. Specifying external source port range. b. Specifying the algorithm for mapping ports from the range. c. Specifying the external ip address range. d. Persisting the selection

[ovs-dev] [PATCH v1 2/3 ovn] NAT: Northd changes to provide port range

2020-03-27 Thread Ankur Sharma
From: Ankur Sharma This patch has northd changes to put port range in the logical flow based on configuration. Port range is NOT applicable for stateless dnat_and_snat rules. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 31 +- tests/ovn-northd.at | 64

Re: [ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking entry

2019-11-22 Thread Ankur Sharma
Hi Numan, Sure, i will submit a v5 soon. Regards, Ankur From: Numan Siddique Sent: Thursday, November 21, 2019 3:07 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking

[ovs-dev] [PATCH v4 2/3 ovn] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-11-08 Thread Ankur Sharma
OVN allows only an integer (or masked integer) to be assigned to ct_mark and ct_label. This patch, enhances the parser code to allow ct_mark and ct_label to be assigned from registers as well. Signed-off-by: Ankur Sharma --- include/ovn/actions.h | 3 +++ lib/actions.c | 72

[ovs-dev] [PATCH v4 1/3 ovn] OVN ACL: Replace the usage of ct_label with ct_mark

2019-11-08 Thread Ankur Sharma
for storing other values like, identifier for corresponidng OVN ACL/Security group etc. Signed-off-by: Ankur Sharma --- Documentation/tutorials/ovn-openstack.rst | 14 - lib/logical-fields.c | 3 ++ northd/ovn-northd.8.xml | 14 - northd/ovn

[ovs-dev] [PATCH v4 3/3 ovn] OVN ACL: Allow a user to input ct.label value for an acl

2019-11-08 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. Signed-off-by: Ankur Sharma --- northd

[ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking entry

2019-11-08 Thread Ankur Sharma
ext;) . . . table=7 (ls_out_stateful), ... match=(reg0[1] == 1 && reg0[3] == 1), Ankur Sharma (3): OVN ACL: Replace the usage of ct_label with ct_mark OVN ACL: Allow ct_mark and ct_label values to be set from register as well OVN ACL: Allow a user to input ct.label value

Re: [ovs-dev] [PATCH v4 0/2] ALLOW Stateless NAT operations

2019-11-01 Thread Ankur Sharma
Hi Numan, Thanks for applying the patches. Sure, I have sent out the NEW entry changes. Just noticed that Acked-by is missing in the commits. Regards, Ankur From: Numan Siddique Sent: Friday, November 1, 2019 9:51 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH

[ovs-dev] [PATCH v1] NEWS: Add stateless NAT support

2019-11-01 Thread Ankur Sharma
Signed-off-by: Ankur Sharma --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index c6c2a3a..0ad9677 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,7 @@ Post-OVS-v2.12.0 - OVN was split out from the OVS repository and is now released independently. - Added IPv6 NAT

Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use ipv4.src and ipv4.dst actions for NAT rules

2019-10-31 Thread Ankur Sharma
Hi Numan, Just submitted V4, please take a look. Regards, Ankur -Original Message- From: Numan Siddique Sent: Thursday, October 31, 2019 10:39 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use ipv4.src and ipv4.dst actions for NAT

[ovs-dev] [PATCH v4 2/2 ovn] OVN: Use ip4.src and ip4.dst actions for NAT rules

2019-10-31 Thread Ankur Sharma
For dnat_and_snat rules which are meant to be stateless instead of using ct_snat/dnat OVN actions, we will use ip4.src/ip4.dst. This actions will do 1:1 mapping to inner ip to external ip, while recalculating the checksums. Signed-off-by: Ankur Sharma --- northd/ovn-northd.8.xml | 33

  1   2   3   >