_eth(pkt);
>
> > +l3 = dp_packet_inner_l3(pkt);
> > +l4 = dp_packet_inner_l4(pkt);
>
> You could move these outside the inner (pardon the pun) if else, but I
> could understand if you prefer to set l2/l3/l4 together for better
> readability ?
Well, as you noted, this code is not trivial.
I preferred to have all 3 pointers grouped, with a comment relating to
the group.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, May 15, 2024 at 2:09 PM Kevin Traynor wrote:
>
> On 19/04/2024 15:06, David Marchand wrote:
> > In a typical setup like:
> > guest A <-virtio-> OVS A <-vxlan-> OVS B <-virtio-> guest B
> >
> > TSO packets from guest A are segmented
Hello Kevin,
Thanks for reviewing.
On Fri, May 10, 2024 at 11:50 PM Kevin Traynor wrote:
>
> On 19/04/2024 15:06, David Marchand wrote:
> > Replace check on th == NULL with an assert() because dp_packet_l4(pkt)
> > is priorly used to compute (outer) L3 length.
> >
>
tions]` is ambiguous
and deprecated.
Link: https://git.dpdk.org/dpdk/commit/?id=bf66003b51ec
Signed-off-by: David Marchand
---
.ci/dpdk-build.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.ci/dpdk-build.sh b/.ci/dpdk-build.sh
index 23f3166a54..e1b8e3ccbb 1
are needed for tunneling (and below
features),
- l2_len and l3_len are needed for IP and L4 checksum (and below features),
- l4_len and tso_segsz are needed when doing TSO,
Signed-off-by: David Marchand
---
lib/dp-packet.h | 37 --
lib/netdev-dpdk.c | 35
slightly shorter than the
optimal size.
Reported-at: https://github.com/openvswitch/ovs-issues/issues/321
Signed-off-by: David Marchand
---
Note:
As we trust the guest with this change, should we put a lower limit on
mbuf->tso_segsz?
---
lib/netdev-dpdk.c | 11 ---
1 file changed, 8 in
Replace check on th == NULL with an assert() because dp_packet_l4(pkt)
is priorly used to compute (outer) L3 length.
Besides, filling l4_len and tso_segsz only matters to TSO, so there is
no need to check for other L4 checksum offloading requests.
Signed-off-by: David Marchand
---
lib/netdev
ENEVE TSO.")
Signed-off-by: David Marchand
---
lib/netdev-dpdk.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index f732716141..8b6a3ed189 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2629,1
tdev-native-tnl: Mark all vxlan/geneve packets as
tunneled.")
Signed-off-by: David Marchand
---
Changes since v2:
- kept offloads disabled for net/i40e and net/ice as this patch does not
fix outer udp checksum (a DPDK fix is required),
- updated commitlog with details to reproduce the issu
Same as the commit 6f93d8e62f13 ("netdev-dpdk: Disable outer UDP checksum
offload for ice/i40e driver."), disable outer UDP checksum and related
offloads for net/iavf.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: David Marchand
---
Note:
re is
native support of bonding in OVS?
I am not familiar with OVN setups so maybe I am missing something on this side.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_TX_OUTER_IPV4 RTE_MBUF_F_TX_TUNNEL_VXLAN , outer_l2_len=18,
> >>> outer_l3_len=20, l2_len=0, l3_len=0, l4_len=0, tso_segsz=0
>
> The fact that l2_len and l3_len are not set here looks like an OVS
> bug though, as AFAIU, these should always be set if any Tx offload
ver worked with ice in OVS and it is experimental,
> I tend to think that we should just disable it for ice as well until
> DPDK is fixed.
>
> A little too many fixes for that thing we have already and this one will
> involve some extra driver-specific logic that we don't have any automated
> tests for.
I don't mind waiting for the DPDK fix before re-enabling outer udp and
other offloads.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Mar 28, 2024 at 10:16 AM David Marchand
wrote:
>
> The outer checksum offloading API in DPDK is ambiguous and was
> added by Intel folks with the assumption that any outer offloading
> always goes with an inner offloading request.
>
> With net/i40e and net/ice drivers, r
gt;
> Could you please provide the exact file path or location for the
> 'ovs-vswitchd.conf.db' MAN page?
You are probably looking for vswitchd/vswitch.xml.
ovsdb man page gets generated from vswitchd/vswitch.xml (and
vswitchd/vswitch.ovsschema) content.
offloading request.
And outer offloading can be re-enabled for net/i40e and netice.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: David Marchand
---
Changes since v1:
- reset inner marks before converting outer requests,
- fixed some coding style,
---
li
gt; 4e:a9:1d:ce:85:4a, ethertype IPv4 (0x0800),
length 98: (tos 0x0, ttl 64, id 9408, offset 0, flags [DF], proto ICMP
(1), length 84)
172.31.22.2 > 172.31.22.1: ICMP echo request, id 1442, seq 9, length 64
Please have a try with the v2 (I'll post soon).
If it still fails, can you
On Wed, Mar 27, 2024 at 5:51 PM David Marchand
wrote:
> /* If packet is vxlan or geneve tunnel packet, calculate outer
> * l2 len and outer l3 len. Inner l2/l3/l4 len are calculated
> * before. */
> -const uint64_t tunnel_type = mbuf->ol_flags & RTE_MB
offloading request.
And outer offloading can be re-enabled for net/i40e and netice.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: David Marchand
---
lib/netdev-dpdk.c | 84 +++
1 file changed, 42 inserti
r of tunnel from my unit test, it would be
enough to reproduce without hitting af_xdp headroom limit.
Or do you think we can extend an existing test?
At least, fixes should be isolated from the new features like one
introduced in patch 1 of this series.
--
David Marchand
_
> UDP tunnel layer instead of the intermediary tunnel layer.
>
> This resulted in the middle UDP tunnel not checksum offloading properly.
>
> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
> Reported-by: David Marchand
> Signed-off-by: M
On Mon, Feb 12, 2024 at 7:54 AM Mike Pattrick wrote:
>
> Include inner offsets in functions where l3 and l4 offsets are either
> modified or checked.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Mike Pattrick
Reviewed-by:
e other
> metadata like packet_type are set appropriately.
>
> Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding Detection.")
> Signed-off-by: Mike Pattrick
Reviewed-by: David Marchand
--
David Marchand
___
dev
On Tue, Feb 6, 2024 at 3:47 PM Eelco Chaudron wrote:
> On 6 Feb 2024, at 15:17, David Marchand wrote:
>
> > On Tue, Feb 6, 2024 at 2:31 PM Eelco Chaudron wrote:
> >>
> >> Avoid unnecessary thread creation as no upcalls are generated,
> >> resulting in idle
ere is no handler to start at all.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
igned-off-by: Mike Pattrick
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
512_dp_packet_resize_l2(struct dp_packet *b, int
> resize_by_bytes)
> /* Each lane represents 16 bits in a 12-bit register. In this case the
> * first three 16-bit values, which will map to the l2_5_ofs, l3_ofs and
> * l4_ofs fields. */
> -const uint8_t k_lanes = 0b1110;
> +const uint8_t k_lanes = 0b10;
>
> /* Set all 16-bit words in the 128-bits v_offset register to the value we
> * need to add/substract from the l2_5_ofs, l3_ofs, and l4_ofs fields. */
Touching this part scares me.
I think some comments are wrong, and otherwise I hope Intel CI will be
enough to check nothing gets broken here :-).
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
m
offloading, this patch also fixes the packet_type used by other
dp_packet helpers.
I see nothing fixed on that later topic though.
>
> Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding Detection.")
> Signed-off-by: Mike Pattrick
Reviewed-by: David
packet is already flagged
> for tunneling, so an incorrect determination isn't possible as long as
> the flags of the packet are correct.
>
> Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
> Signed-off-by: Mike Pattrick
Review
On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote:
>
> On 1/18/24 14:00, David Marchand wrote:
> > Seen in GHA recently.
> > Unit tests are checking conntracks relating to a destination ip address
> > but the FORMAT_CT macro is not strict enough and would match unre
On Fri, Jan 19, 2024 at 1:20 PM Simon Horman wrote:
>
> On Thu, Jan 18, 2024 at 02:00:18PM +0100, David Marchand wrote:
> > Seen in GHA recently.
> > Unit tests are checking conntracks relating to a destination ip address
> > but the FORMAT_CT macro is not strict enough a
later handles the port reset request.
More details in the DPDK upstream bz as this issue appeared following a
change in DPDK.
Link: https://bugs.dpdk.org/show_bug.cgi?id=1337
Signed-off-by: David Marchand
---
Changes since v2:
- fixed build with clang,
- fixed indentation,
- updated NEWS
On Thu, Jan 18, 2024 at 4:43 PM Ilya Maximets wrote:
>
> On 1/18/24 15:41, David Marchand wrote:
> > When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> > mutex lock.
> > As part of this configure operation, the net/iavf driver (used with i40e
On Thu, Jan 18, 2024 at 3:41 PM David Marchand
wrote:
> Changes since v1:
> - converted to atomic accesses on netdev_dpdk_pending_reset[],
I did not wait for the clang results during my tests... cooking v3.
--
David Marchand
___
dev mailing
later handles the port reset request.
More details in the DPDK upstream bz as this issue appeared following a
change in DPDK.
Link: https://bugs.dpdk.org/show_bug.cgi?id=1337
Signed-off-by: David Marchand
---
Changes since v1:
- converted to atomic accesses on netdev_dpdk_pending_reset
On Thu, Jan 18, 2024 at 2:23 PM Ilya Maximets wrote:
>
> On 1/18/24 14:16, David Marchand wrote:
> > When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> > mutex lock.
> > As part of this configure operation, the net/iavf driver (used with i40e
later handles the port reset request.
Link: https://bugs.dpdk.org/show_bug.cgi?id=1337
Signed-off-by: David Marchand
---
lib/netdev-dpdk.c | 73 +--
1 file changed, 58 insertions(+), 15 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
c3c1 ("Add support for connection tracking.")
Signed-off-by: David Marchand
---
tests/system-common-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 01ebe364ee..07be29f673 100644
--- a
r.
>
> David, could you, please, add a note in the NEWS file and send a new version
> of the patch?
I just sent a v2.
I'll continue investigating the iavf issue.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
issue with i40e VF devices where OVS main thread may
block when adding such devices as dpif-netdev dpdk ports.
Signed-off-by: David Marchand
---
.ci/dpdk-build.sh| 28 +++-
.ci/linux-build.sh | 9
.github/workflows/build
-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v5:
- rebased,
- moved the script to the python scripts list in automake.mk,
- bumped copyright date,
Changes since v4:
- separated from the original series,
- rebased,
- dropped mlx5 devices from the discovery script,
- documented
The MFEX code and tests do not depend on DPDK anymore.
We can move the unit tests to dpif-netdev.
Reviewed-by: Maxime Coquelin
Acked-by: Eelco Chaudron
Acked-by: Kumar Amber
Signed-off-by: David Marchand
---
Changes since v4:
- rebased,
- added dummy numa configuration,
Changes since v3
spent calling ovs-appctl).
Suggested-by: Ilya Maximets
Reviewed-by: Maxime Coquelin
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v4:
- rebased,
- updated genpkts.py so it outputs 8 packets per line and have
netdev-dummy/receive called for 8 packets at a time
t; Signed-off-by: Eelco Chaudron
Thanks for the fix.
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
-by: David Marchand
---
.ci/dpdk-build.sh| 28 +++-
.ci/linux-build.sh | 9
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 2 +-
Documentation/intro/install/dpdk.rst | 16
log, some manual tests show that
untagged/tagged/"double" tagged packets (with 0x8100 ethertype)
are still received/transmitted fine.
Ignore this log waiting for a fix on the DPDK side.
Link: https://bugs.dpdk.org/show_bug.cgi?id=1331
Signed-off-by: David Marchand
---
tests/system-dpdk
On Tue, Nov 28, 2023 at 9:40 AM David Marchand
wrote:
>
> On Wed, Nov 22, 2023 at 5:34 PM David Marchand
> wrote:
> >
> > The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded:
> > on systems with only mlx5, this test is always skipped.
> >
&g
that a netdev (re)configuration did happen.
With those synchronisation points in place, error messages may be checked
in logs afterward.
Fixes: bf47829116a8 ("tests: Add OVS-DPDK MTU unit tests.")
Signed-off-by: David Marchand
---
Changes since v1:
- dropped test output,
---
tests/syst
rd.
Fixes: bf47829116a8 ("tests: Add OVS-DPDK MTU unit tests.")
Signed-off-by: David Marchand
---
tests/system-dpdk.at | 42 --
1 file changed, 12 insertions(+), 30 deletions(-)
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
index 17742d20a
black box.
The net/ice driver spews this warning but does not fail to initialise the port.
OVS does not rely on vlan offloading (and it is a good thing as I
think Intel broke it a number of times with the E810 driver...).
I tested 23.11 on dpdk-latest, with untagged packets, single
encapsulated vlan p
On Wed, Nov 22, 2023 at 5:34 PM David Marchand
wrote:
>
> The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded:
> on systems with only mlx5, this test is always skipped.
>
> Besides, the test tries to grab the first device listed by dpdk-devbind.py,
> reg
On Mon, Nov 27, 2023 at 3:26 PM Eelco Chaudron wrote:
> On 27 Nov 2023, at 13:53, David Marchand wrote:
> > On Mon, Nov 27, 2023 at 1:39 PM Eelco Chaudron wrote:
> >>
> >> When new drivers are introduced, the cache key is not accurately computed.
> >>
ure
> grep -rwE 'DPDK_GIT|DPDK_VER' .github/ >> dpdk-ci-signature
> if [ "${DPDK_VER##refs/*/}" != "${DPDK_VER}" ]; then
> git ls-remote --heads $DPDK_GIT $DPDK_VER >> dpdk-ci-signature
>
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Nov 23, 2023 at 12:51 PM Kevin Traynor wrote:
>
> Update the CI and docs to use DPDK 22.11.3.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswit
On Thu, Nov 23, 2023 at 12:51 PM Kevin Traynor wrote:
>
> Update the CI and docs to use DPDK 22.11.3.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswit
On Thu, Nov 23, 2023 at 12:51 PM Kevin Traynor wrote:
>
> Update the CI and docs to use DPDK 21.11.5.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswit
> + - Bug fixes
I see in the history that the "Bug fixes" characterization is usually
added when releasing a version.
So I am not sure it should be added in this patch.
> + - DPDK:
> + * OVS validated with DPDK 21.11.5
>
> v2.17.8 - 17 Oct 2023
Otherwise, it lgtm.
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v4:
- separated from the original series,
- rebased,
- dropped mlx5 devices from the discovery script,
- documented DPDK_PCI_ADDR env variable,
Changes since v3:
- fixed nit from Maxime,
Changes since v2:
- sorted logs alphabetically
-off-by: David Marchand
---
.ci/dpdk-build.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.ci/dpdk-build.sh b/.ci/dpdk-build.sh
index 8380c48637..698b9e1b14 100755
--- a/.ci/dpdk-build.sh
+++ b/.ci/dpdk-build.sh
@@ -42,6 +42,9 @@ function build_dpdk()
DPDK_OPTS="$DPDK
size go from ~120MB to ~7MB.
Signed-off-by: David Marchand
---
.ci/dpdk-build.sh | 25 +++--
.ci/linux-build.sh | 9 +
2 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/.ci/dpdk-build.sh b/.ci/dpdk-build.sh
index aa83e44643..8380c48637 100755
On Mon, Nov 20, 2023 at 4:58 PM David Marchand
wrote:
>
> Integrate system-traffic.at tests as part of check-dpdk.
>
> Some tests that can't work with the userspace datapath are skipped by
> overriding some OVS_CHECK_* macros.
>
> ADD_VETH is implemented using the n
Integrate system-traffic.at tests as part of check-dpdk.
Some tests that can't work with the userspace datapath are skipped by
overriding some OVS_CHECK_* macros.
ADD_VETH is implemented using the net/af_xdp DPDK driver.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since
Introduce macros responsible for adding a vhost-user / vhost-user client
port to a userspace datapath bridge and check associated logs.
Signed-off-by: David Marchand
---
Changes since v8:
- added this patch to avoid issues like what is fixed by the previous
patch in this series,
---
tests
Adding those grep gives enough time to OVS to be ready to connect with
the testpmd virtio-user port instantiated afterward.
Fixes: bf47829116a8 ("tests: Add OVS-DPDK MTU unit tests.")
Signed-off-by: David Marchand
---
Changes since v8:
- added this patch for random failures observed on
) reconnecting...
Invert the order of the cleanup steps.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since v6:
- added this fix for spurious failures hit by Eelco,
---
tests/system-dpdk.at | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git
The unit tests for changing MTU with vhost-user ports are not using
those tap interfaces.
Signed-off-by: David Marchand
---
Changes since v7:
- added this patch after getting regressions in Intel CI because of the
next patch,
---
tests/system-dpdk.at | 14 --
1 file changed, 4
Align system-dpdk existing helpers to other common OVS helpers so they
can accept some optional arguments.
Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
catch dpdk related logs in a centralised fashion.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes
a
helper for logging libbpf messages.
Making both net/af_xdp and netdev-afxdp work at the same time seems
difficult, so at least, ensure that netdev-afxdp won't register this
helper unless a netdev is actually allocated.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
lib/netdev-afxdp.c
-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since v4:
- as the traffic tests now use net/af_xdp, it is not required to skip
tests relying on tcpdump anymore,
---
tests/system-common-macros.at| 6 ++
tests/system-offloads-traffic.at | 6 +++---
tests/system-traffic.at
dpdk-testpmd does not need hugetlbfs backing as we don't require
multiprocess support in OVS unit tests.
Switch to --in-memory and remove the (then unneeded) check on
hugetlbfs presence.
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v7
for OVS main and PMD
threads).
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
---
Changes since v1:
- rebased after DPDK build has been moved out of linux-build.sh,
- restored running "normal" checks in the DPDK jobs,
---
.ci/dpdk-build.sh
Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
; Not a full review, but in case you're sending a new version for Eelco's
> comments, please, add more indentation to the 3 lines above, so they
> are not on the same level with ovs-vsctl.
I did not see this comment.
Well, I'll wait for a full review before s
Capitalize comments and end them with a . when needed.
Signed-off-by: David Marchand
---
tests/mcast-snooping.at | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at
index faeb7890d9..890e6aca00 100644
--- a/tests
to
flood multicast traffic too with the mcast-snooping-flood option.
IGMP reports may have to be flooded to some ports explicitly with the
mcast-snooping-flood-reports option.
Test those parameters.
Acked-by: Simon Horman
Acked-by: Paolo Valerio
Signed-off-by: David Marchand
---
Changes since v2
624868 ("mcast-snooping: Flush ports mdb when VLAN configuration
changed.")
Acked-by: Simon Horman
Acked-by: Paolo Valerio
Signed-off-by: David Marchand
---
Changes since v2:
- christmas tree,
- added some comments in tests,
Changes since v1:
- updated the test on report flooding,
---
understand what we test here.
Wdyt of:
+# Change p2 ofport to force a ofbundle change and check that the mdb contains
+# no stale port.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Nov 16, 2023 at 11:57 AM Eelco Chaudron wrote:
> On 10 Nov 2023, at 18:52, David Marchand wrote:
> > +Final flow: unchanged
> > +Megaflow:
> > recirc_id=0,eth,udp,in_port=3,dl_src=aa:55:aa:55:00:ff,dl_dst=01:00:5e:01:01:01,nw_dst=224.1.1.1,nw_frag=no
> > +]
output_normal(ctx, out->xbundles[i], xvlan);
}
}
...
In this case, there is no flooding (contrary to previous tests) over
all the ports from this bridge.
There is only one "group" port and one "flood" port and the order is fixed.
--
David Marchand
624868 ("mcast-snooping: Flush ports mdb when VLAN configuration
changed.")
Signed-off-by: David Marchand
---
Changes since v1:
- updated the test on report flooding,
---
lib/mcast-snooping.c| 15 +++
tests/mcast-snooping.at | 38 ++
2 files ch
to
flood multicast traffic too with the mcast-snooping-flood option.
IGMP reports may have to be flooded to some ports explicitly with the
mcast-snooping-flood-reports option.
Test those parameters.
Signed-off-by: David Marchand
---
Changes since v1:
- fixed dest mac address,
- added tests for mcast
On Thu, Nov 9, 2023 at 4:33 PM Paolo Valerio wrote:
>
> David Marchand writes:
>
> > When multicast snooping is enabled and a reporter is known, it is still
> > possible to flood associated packets to some other port via the
> > mcast-snooping-flood option.
&g
When multicast snooping is enabled and a reporter is known, it is still
possible to flood associated packets to some other port via the
mcast-snooping-flood option.
Test this combination.
Signed-off-by: David Marchand
---
tests/mcast-snooping.at | 88
>> mcast flood port is unknown, dropping
-> mcast flood port is input port, dropping
-> forwarding to mcast flood port
Add relevant cleanup and update a unit test.
Fixes: 4fbbf8624868 ("mcast-snooping: Flush ports mdb when VLAN configuration
changed.")
Sign
On Fri, Oct 27, 2023 at 5:31 PM David Marchand
wrote:
>
> dpdk-testpmd does not need hugetlbfs backing as we don't require
> multiprocess support in OVS unit tests.
>
> Switch to --in-memory and remove the (then unneeded) check on
> hugetlbfs presence.
>
> Acked-b
) reconnecting...
Invert the order of the cleanup steps.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since v6:
- added this fix for spurious failures hit by Eelco,
---
tests/system-dpdk.at | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git
Integrate system-traffic.at tests as part of check-dpdk.
Some tests that can't work with the userspace datapath are skipped by
overriding some OVS_CHECK_* macros.
ADD_VETH is implemented using the net/af_xdp DPDK driver.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since
a
helper for logging libbpf messages.
Making both net/af_xdp and netdev-afxdp work at the same time seems
difficult, so at least, ensure that netdev-afxdp won't register this
helper unless a netdev is actually allocated.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
lib/netdev-afxdp.c
The unit tests for changing MTU with vhost-user ports are not using
those tap interfaces.
Signed-off-by: David Marchand
---
Changes since v7:
- added this patch after getting regressions in Intel CI because of the
next patch,
---
tests/system-dpdk.at | 14 --
1 file changed, 4
Align system-dpdk existing helpers to other common OVS helpers so they
can accept some optional arguments.
Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
catch dpdk related logs in a centralised fashion.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes
-off-by: David Marchand
Acked-by: Eelco Chaudron
---
Changes since v4:
- as the traffic tests now use net/af_xdp, it is not required to skip
tests relying on tcpdump anymore,
---
tests/system-common-macros.at| 6 ++
tests/system-offloads-traffic.at | 6 +++---
tests/system-traffic.at
for OVS main and PMD
threads).
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
---
Changes since v1:
- rebased after DPDK build has been moved out of linux-build.sh,
- restored running "normal" checks in the DPDK jobs,
---
.ci/dpdk-build.sh
dpdk-testpmd does not need hugetlbfs backing as we don't require
multiprocess support in OVS unit tests.
Switch to --in-memory and remove the (then unneeded) check on
hugetlbfs presence.
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v7
Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
On Fri, Oct 27, 2023 at 1:45 PM Eelco Chaudron wrote:
> On 23 Oct 2023, at 10:18, David Marchand wrote:
>
> > Integrate system-traffic.at tests as part of check-dpdk.
> >
> > Some tests that can't work with the userspace datapath are skipped by
> > over
gt; Fixes: e388bd73b70d ("readthedocs: Add the configuration file.")
> Reported-by: Antonin Bas
> Reported-by: David Marchand
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/310
> Signed-off-by: Ilya Maximets
> ---
>
> The version of the docs wit
On Thu, Oct 26, 2023 at 10:10 AM Frode Nordahl
wrote:
>
> On Mon, Oct 23, 2023 at 10:19 AM David Marchand
> wrote:
> >
> > Rather than copy/paste everywhere, introduce helpers to control
> > testpmd runs.
> > Rely on --stats-period (which outputs port stats eve
On Wed, Oct 25, 2023 at 2:50 PM Aaron Conole wrote:
>
> David Marchand writes:
>
> > On Mon, Oct 23, 2023 at 10:20 AM David Marchand
> > wrote:
> >> +# OVS_DPDK_CHECK_TESTPMD()
> >> +#
> >> +# Check dpdk-testpmd availability.
> >> +#
>
On Wed, Oct 25, 2023 at 1:18 PM Ilya Maximets wrote:
> On 10/25/23 12:09, David Marchand wrote:
> >>> 2023-10-23T15:02:13.756Z|00082|bridge|INFO|bridge br10: deleted interface
> >>> dpdkvhostuserclient0 on port 1
> >>> 2023-10-23T15:02:13.756Z|00083|dp
all) received by a pmd on a port that is not
referenced in the ofproto bridge anymore.
Why did it show up again? This is probably due to my patch 7 in the v7
series which lets testpmd sends packets while deleting the vhu port.
The easiest (laziest?) for me is probably to drop this patch 7 and
instead waive warnings about a vhu socket reconnection...
But I find it strange that there is a window in which OVS pmd threads
still poll packets (and complain) while the ports are being removed.
Opinions?
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
1 - 100 of 967 matches
Mail list logo
