Re: [ovs-dev] [branch-2.8 1/2] Set release date for 2.8.2.

2018-02-19 Thread Flavio Leitner
> -- > 2.7.4 > > _______ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-by: Flavio Leitner <f...@sysclose.org> -- Flavio ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Set release dates for 2.9.0.

2018-02-19 Thread Flavio Leitner
angelog > > @@ -2,7 +2,7 @@ openvswitch (2.9.0-1) unstable; urgency=low > > > > * New upstream version > > > > - -- Open vSwitch team <d...@openvswitch.org> Wed, 17 Jan 2018 09:49:31 > > -0700 > > + -- Open vSwitch team <d...@openvswitch.org&g

Re: [ovs-dev] [PATCH v7 0/6] OVS-DPDK flow offload with rte_flow

2018-01-31 Thread Flavio Leitner
On Mon, Jan 29, 2018 at 02:59:42PM +0800, Yuanhan Liu wrote: > Hi, > > Here is a joint work from Mellanox and Napatech, to enable the flow hw > offload with the DPDK generic flow interface (rte_flow). > > The basic idea is to associate the flow with a mark id (a unit32_t number). > Later, we

Re: [ovs-dev] OVS-DPDK public meeting

2018-01-31 Thread Flavio Leitner
31th January 2018 Attendees: Flavio, Johann, Olga, Aaron, Ben, Michael, Jan, Ian, Frikkie, Sugesh, Yipeng === GENERAL === OVS 2.9 Release - New features deadline for 2.9: 31/Jan. - Patches on DPDK_MERGE_2_9 -- VHost Zero Copy (Experimental) Potential patches for DPDK_MERGE_2_9

Re: [ovs-dev] [PATCH] rhel: Change depmod configuration

2018-01-26 Thread Flavio Leitner
On Fri, Jan 26, 2018 at 10:03:53AM -0800, Gregory Rose wrote: > On 1/26/2018 5:30 AM, Flavio Leitner wrote: > > Regarding to change --add-modules to --add-kernel, well, I don't see > > how that is helping. Maybe I am missing something, but every time a > > kernel is instal

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-26 Thread Flavio Leitner
Hi Ben, On Wed, Jan 10, 2018 at 04:07:38PM -0800, Ben Pfaff wrote: > Thanks for the series. I actually think that it's pretty close. For > me, this series falls into the category of "obviously the right > direction but impossible to fully validate before applying it". It > builds fine and I

Re: [ovs-dev] [PATCH] rhel: Change depmod configuration

2018-01-26 Thread Flavio Leitner
l run weak-modules --add-kernel which should create the weak-updates links accordingly, unless the kernel is not compatible. You can verify what the kernel's post install scripts does with this command: # rpm -q kernel --scripts You should find this snippet: if [ -x /sbin/weak-modules ] then /sbin/weak-modul

Re: [ovs-dev] OVS-DPDK public meeting

2018-01-24 Thread Flavio Leitner
24th January 2018 Attendees: Flavio, Thomas, Jan, satananda, Michael, Ian, Zoltan, John, Aaron, Ben, Johann, Pradeep, Simon, Olga, Frikkie, === GENERAL === OVS 2.9 Release - New features deadline for 2.9: 31/Jan. - Pull requests on a weekly basis, on Friday. - Patches on DPDK_MERGE_2_9

Re: [ovs-dev] [PATCH v4] netdev-linux: do not send packets to down tap ifaces.

2018-01-24 Thread Flavio Leitner
On Tue, Jan 23, 2018 at 12:31:53PM -0800, Ben Pfaff wrote: > On Wed, Jan 17, 2018 at 10:09:58PM -0200, Flavio Leitner wrote: > > Today OVS pushes packets to the TAP interface ignoring its > > current state. That works because the kernel will return -EIO > > when it's not

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-19 Thread Flavio Leitner
> || mtu < ETHER_MIN_MTU) { > VLOG_WARN("%s: unsupported MTU %d\n", dev->up.name, mtu); > return EINVAL; We got a bug report for another related MTU issue because in older OVS/DPDK, the i40e driver didn't include the 2 VLAN headers overhead, so

Re: [ovs-dev] [PATCH v5 00/10] Add OVS DPDK keep-alive functionality.

2018-01-19 Thread Flavio Leitner
On Fri, Jan 19, 2018 at 10:51:59AM +, Stokes, Ian wrote: > > Keepalive feature is aimed at achieving Fastpath Service Assurance in OVS- > > DPDK deployments. It adds support for monitoring the packet processing > > threads by dispatching heartbeats at regular intervals. > > > > Hi All, > >

Re: [ovs-dev] [PATCH] Documentation: Document optional RHEL7 repositories

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 10:15:31PM -0200, Flavio Leitner wrote: > On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote: > > On minimal install RHEL 7 servers (and perhaps other types of installs) > > you need to enable a couple of optional repositories for the yum-builddep >

Re: [ovs-dev] [PATCH] Documentation: Document optional RHEL7 repositories

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote: > On minimal install RHEL 7 servers (and perhaps other types of installs) > you need to enable a couple of optional repositories for the yum-builddep > utility to work correctly. This patch documents those two optional > repositories. >

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 10:10:17AM -0800, Ben Pfaff wrote: > On Wed, Jan 17, 2018 at 04:51:20PM +, Vishal Deep Ajmera wrote: > > > You mean add more details to NEWS file explaining that change? > > > > I am not much familiar with documentation part of ovs. It will help if > > others can

[ovs-dev] [PATCH v4] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
stop the traffic breaking the use-case. This patch relies on netlink notifications to find out if the device is local or not. When it's local, the device state is checked otherwise it will behave as before. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- NEWS | 2 +

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 09:42:34AM -0800, Guru Shetty wrote: > On 17 January 2018 at 07:57, Flavio Leitner <f...@sysclose.org> wrote: > > > > > Hi, > > > > One of the reasons is to clean up a bit because today it is not > > obvious that openvswitch.spec

Re: [ovs-dev] [PATCH] rhel: Ensure proper OVS kernel modules load - rhel6

2018-01-17 Thread Flavio Leitner
r OVS kernel modules...") > CC: Ansis Atteka <ansisatt...@gmail.com> > CC: Flavio Leitner <f...@sysclose.org> > Signed-off-by: Greg Rose <gvrose8...@gmail.com> > --- LGTM Acked-by: Flavio Leitner <f...@sysclose.org>

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

2018-01-17 Thread Flavio Leitner
Hi, One of the reasons is to clean up a bit because today it is not obvious that openvswitch.spec uses initscripts and shouldn't be used for Fedora or RHEL-7. Then we have openvswitch-fedora.spec which is not obvious if it works or not in RHEL-7 too. We could document that somehow, but it

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 12:43:08PM +, Vishal Deep Ajmera wrote: > Hi Flavio, Hi Vishal, > I was testing your patch and comparing the stats of tap port for both > ovs-master > and your patch. The drop stats are now matching with master. Thanks for doing that work, I appreciate it! >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 11:44:08AM +, Stokes, Ian wrote: > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of Flavio Leitner > > Sent: Tuesday, January 16, 2018 4:22 AM > > To: d...@ope

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

2018-01-16 Thread Flavio Leitner
On Tue, Jan 16, 2018 at 10:31:29AM -0800, Gregory Rose wrote: > On 1/16/2018 10:15 AM, Flavio Leitner wrote: > > On Tue, Jan 16, 2018 at 08:44:15AM -0800, Greg Rose wrote: > > > Add post install and post un-install scripts to make sure that the > > > openvswitch k

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

2018-01-16 Thread Flavio Leitner
witch kernel modules from a previous installation will > be found by the depmod search path. > > Suggested-by: Flavio Leitner <f...@sysclose.org> > Signed-off-by: Greg Rose <gvrose8...@gmail.com> > > --- LGTM, though I have not tested. A

[ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-15 Thread Flavio Leitner
stop the traffic breaking the use-case. This patch relies on netlink notifications to find out if the device is local or not. When it's local, the device state is checked otherwise it will behave as before. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- NEWS | 2 ++ lib/

[ovs-dev] [PATCH v2] netdev-linux: do not send packets to down tap ifaces.

2018-01-15 Thread Flavio Leitner
stop the traffic breaking the use-case. This patch relies on netlink notifications to find out if the device is local or not. When it's local, the device state is checked otherwise it will behave as before. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- lib/netdev-linux.

[ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status.

2018-01-15 Thread Flavio Leitner
Expose relevant vhost-user information in status. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- NEWS | 1 + lib/netdev-dpdk.c | 62 +-- 2 files changed, 61 insertions(+), 2 deletions(-) Changelog: V2 - Dropped the

Re: [ovs-dev] [PATCH] netdev-linux: do not send packets to down tap ifaces.

2018-01-15 Thread Flavio Leitner
urich > Sent: Monday, January 15, 2018 5:56 PM > To: Vishal Deep Ajmera <vishal.deep.ajm...@ericsson.com>; Flavio Leitner > <f...@sysclose.org>; d...@openvswitch.org > Cc: Rohith Basavaraja <rohith.basavar...@ericsson.com> > Subject: RE: [ovs-dev] [PATCH] netdev-lin

Re: [ovs-dev] [PATCH v6 0/8] Add OVS DPDK keep-alive functionality.

2018-01-15 Thread Flavio Leitner
Hi, Sorry to jump on this at v6 only, but I skimmed over the code and I am struggling to understand what problem you're trying to solve. Yes, I realize you want some sort of feedback about the PMD processing, but it's not clear to me what exactly you want from it. This last patchset uses a

Re: [ovs-dev] [PATCH V2 1/2] rhel: Add depmod file for openvswitch module search

2018-01-13 Thread Flavio Leitner
On Sat, Jan 13, 2018 at 10:59:25AM -0800, Gregory Rose wrote: > On 1/12/2018 7:05 PM, Flavio Leitner wrote: > > On Fri, Jan 12, 2018 at 03:46:16PM -0800, Gregory Rose wrote: > > > On 1/12/2018 12:30 PM, Gregory Rose wrote: > > > > On 1/12/2018 11:53 AM, Flavio Leitne

Re: [ovs-dev] [PATCH V2 1/2] rhel: Add depmod file for openvswitch module search

2018-01-12 Thread Flavio Leitner
On Fri, Jan 12, 2018 at 11:38:05AM -0800, Gregory Rose wrote: > On 1/12/2018 11:32 AM, Flavio Leitner wrote: > > On Fri, Jan 12, 2018 at 08:37:43AM -0800, Greg Rose wrote: > > > From: Gurucharan Shetty <shet...@vmware.com> > > > > > > There are occas

Re: [ovs-dev] [PATCH V2 2/2] rhel: Add post installation check for kernel modules

2018-01-12 Thread Flavio Leitner
On Fri, Jan 12, 2018 at 08:37:44AM -0800, Greg Rose wrote: > A bug in RHEL 7.2 has been found in which a customer who installed > a RHEL 7.2 openvswitch kernel module rpm with a slightly different > minor build number than the running kernel found that the kernel > modules were installed to the

Re: [ovs-dev] [PATCH V2 1/2] rhel: Add depmod file for openvswitch module search

2018-01-12 Thread Flavio Leitner
On Fri, Jan 12, 2018 at 08:37:43AM -0800, Greg Rose wrote: > From: Gurucharan Shetty > > There are occasions when an openvswitch kernel module rpm which does > not match the exact build number of the running kernel. In that > case the openvswitch kernel modules will be

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-11 Thread Flavio Leitner
ew feature. Sounds good. Thanks, fbl > > Thanks, > > Ben. > > On Fri, Jan 05, 2018 at 11:05:05AM -0200, Flavio Leitner wrote: > > > > Hi, > > > > I know this change is not easy to review, but at the same time > > we are getting close to the rele

Re: [ovs-dev] [PATCH] netdev-linux: do not send packets to down tap ifaces.

2018-01-11 Thread Flavio Leitner
On Wed, Jan 10, 2018 at 03:09:30PM -0800, Ben Pfaff wrote: > On Wed, Jan 10, 2018 at 02:06:43PM -0200, Flavio Leitner wrote: > > Today OVS pushes packets to the TAP interface ignoring its > > current state. That works because the kernel will return -EIO > > when it's not

[ovs-dev] [PATCH] netdev-linux: do not send packets to down tap ifaces.

2018-01-10 Thread Flavio Leitner
stop the traffic breaking the use-case. This patch relies on netlink notifications to find out if the device is local or not. When it's local, the device state is checked otherwise it will behave as before. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- lib/netdev-linux.

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-05 Thread Flavio Leitner
On Thu, Dec 07, 2017 at 12:22:18AM -0200, Flavio Leitner wrote: > Today Open vSwitch doesn't know about network namespaces (netns), but > users are moving internal ports to other namespaces. Although packets > are still flowing, the daemon fails to find out basic port information, > like

Re: [ovs-dev] [patch v2] conntrack: Some style improvements.

2017-12-28 Thread Flavio Leitner
I missed this one when I reviewed V1, but looks like some comments still applies. fbl On Mon, Dec 11, 2017 at 08:00:08AM -0800, Darrell Ball wrote: > Fix up some instances where variable declarations were not close > enough to their use, as these were missed before. This is the > preferred

Re: [ovs-dev] [patch v1 1/4] conntrack: Some formatting improvements.

2017-12-28 Thread Flavio Leitner
Hi Darrell, I am coming back from vacations, sorry the delay. The patch doesn't apply anymore, but I reviewed anyways. On Sun, Nov 19, 2017 at 01:02:19PM -0800, Darrell Ball wrote: > Fix up some instances where variable declarations were not close > enough to their use, as these were missed

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add debug appctl to get mempool information.

2017-12-12 Thread Flavio Leitner
debugging mbuf leaks and other mempool related > issues. Most useful in pair with `grep -v "cache_count.*=0"`. > > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Acked-by: Flavio Leitner <f...@redhat.com> __

Re: [ovs-dev] [PATCH v4 1/2] vswitchd: Document netdev-dpdk commands.

2017-12-12 Thread Flavio Leitner
On Mon, Dec 11, 2017 at 04:18:42PM +0300, Ilya Maximets wrote: > netdev-dpdk appctl commands added to man pages. > > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Acked-by: Flavio Leitner <f...@redhat.com> Thanks! __

Re: [ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add debug appctl to get mempool information.

2017-12-08 Thread Flavio Leitner
gt; + > /* > * Set virtqueue flags so that we do not receive interrupts. > */ > @@ -2816,6 +2866,10 @@ netdev_dpdk_class_init(void) > "pci address of device", 1, 1, > netdev_dpdk_detach, NULL); > > +u

Re: [ovs-dev] [PATCH v3 1/2] vswitchd: Document netdev-dpdk commands.

2017-12-08 Thread Flavio Leitner
d-rxq-rebalance\fR [\fIdp\fR]" > Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current usage. > . > +.so lib/netdev-dpdk-unixctl.man > .so ofproto/ofproto-dpif-unixctl.man > .so ofproto/ofproto-unixctl.man > .so lib/vlog-unixctl.man > -- > 2.7.4 &g

[ovs-dev] [PATCH v3 6/6] netdev-linux: fail ops not supporting remote netns.

2017-12-06 Thread Flavio Leitner
When the netdev is in another namespace and the operation doesn't support network namespaces, return the correct error. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-linux.c | 134 +++-- 1 file changed, 120 insertions(

[ovs-dev] [PATCH v3 5/6] nlmon: added netns support.

2017-12-06 Thread Flavio Leitner
Signed-off-by: Flavio Leitner <f...@redhat.com> --- utilities/nlmon.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/utilities/nlmon.c b/utilities/nlmon.c index d38a70b6f..448b5eb5d 100644 --- a/utilities/nlmon.c +++ b/utilities/nlmon.c @@ -25,6 +25,7 @@ #i

[ovs-dev] [PATCH v3 4/6] netlink linux: enable listening to all nsids

2017-12-06 Thread Flavio Leitner
kernel 4.2 or newer. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/daemon-unix.c| 3 ++- lib/daemon.man | 6 +++--- lib/daemon.xml | 8 lib/netdev-linux.c | 1 + lib/netlink-protocol.h | 6 ++ lib/netlink-so

[ovs-dev] [PATCH v3 3/6] netdev-linux: use netlink to update netdev.

2017-12-06 Thread Flavio Leitner
The ioctl interface doesn't support network namespaces, so try updating the netdev using netlink message instead. To provide backwards compatibility, fall back to the previous method if netlink isn't supported or fails. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-l

[ovs-dev] [PATCH v3 2/6] netnsid: update device only if netnsid matches.

2017-12-06 Thread Flavio Leitner
-off-by: Flavio Leitner <f...@redhat.com> --- datapath/linux/compat/include/linux/openvswitch.h | 2 + lib/dpif-netlink.c| 8 +++ lib/dpif-netlink.h| 1 + lib/netdev-linux.c

[ovs-dev] [PATCH v3 1/6] netlink: provide network namespace id from a msg.

2017-12-06 Thread Flavio Leitner
The netlink notification's ancillary data contains the network namespace id (netnsid) needed to identify the device correctly. Signed-off-by: Flavio Leitner <f...@redhat.com> --- configure.ac | 3 +- lib/automake.mk| 1 + lib/dpif-netlink.c | 6 +-- lib/netdev-l

[ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2017-12-06 Thread Flavio Leitner
(Greg) - Rewrote assuming that the kernel will not send negative numbers as valid network namespace id. (Ben, Flavio, Jiri) * V2: - report and close unexpected file descriptors (Ben) Flavio Leitner (6): netlink: provide network namespace id from a msg. netnsid: update device only

Re: [ovs-dev] [PATCH v2 2/8] netdev-linux: initialize netns as invalid.

2017-12-04 Thread Flavio Leitner
On Fri, 1 Dec 2017 13:15:06 -0800 Ben Pfaff <b...@ovn.org> wrote: > On Thu, Nov 09, 2017 at 03:31:01PM -0200, Flavio Leitner wrote: > > A port might be already in another netns, so initialize it > > as invalid to force a state update. > > > > Signed-off-by

Re: [ovs-dev] [PATCH v2 3/8] vport: retrieve the netnsid if available.

2017-12-04 Thread Flavio Leitner
On Tue, 14 Nov 2017 10:55:44 -0800 Gregory Rose <gvrose8...@gmail.com> wrote: > On 11/9/2017 9:31 AM, Flavio Leitner wrote: > > Recent kernels provide the network namespace ID of a port, > > so use that to discover where the port currently is. > > > >

Re: [ovs-dev] [PATCH v2 1/8] netlink: provide network namespace id from a msg.

2017-12-04 Thread Flavio Leitner
On Fri, 1 Dec 2017 13:14:07 -0800 Ben Pfaff <b...@ovn.org> wrote: > On Thu, Nov 09, 2017 at 03:31:00PM -0200, Flavio Leitner wrote: > > The netlink notification's ancillary data contains the network > > namespace id (netnsid) needed to identify the device correctly. >

Re: [ovs-dev] [PATCH v2] coding-style: Explain when to break lines before or after binary operators.

2017-12-04 Thread Flavio Leitner
On Fri, 1 Dec 2017 11:22:59 -0800 Ben Pfaff <b...@ovn.org> wrote: > The coding style has never been explicit about this. This commit adds some > explanation of why one position or the other might be favored in a given > situation. > > Suggested-by: Flavio Leitner <f...@s

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-20 Thread Flavio Leitner
On Mon, 20 Nov 2017 08:48:10 -0800 Ben Pfaff <b...@ovn.org> wrote: > On Mon, Nov 20, 2017 at 11:42:43AM -0200, Flavio Leitner wrote: > > On Sun, 19 Nov 2017 10:58:11 -0800 Ben Pfaff <b...@ovn.org> wrote: > > > The other technical issue here is

Re: [ovs-dev] [PATCH v3 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

2017-11-20 Thread Flavio Leitner
/ofproto-dpif.h > +++ b/ofproto/ofproto-dpif.h > @@ -178,7 +178,10 @@ struct group_dpif *group_dpif_lookup(struct ofproto_dpif > *, > DPIF_SUPPORT_FIELD(size_t, sample_nesting, "Sample nesting")\ >

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-20 Thread Flavio Leitner
Hi Ben, On Sun, 19 Nov 2017 10:58:11 -0800 Ben Pfaff <b...@ovn.org> wrote: > On Fri, Nov 17, 2017 at 03:51:34PM -0200, Flavio Leitner wrote: > > No functional change, just fixing coding style. > > > > Signed-off-by: Flavio Leitner <f...@sysclose.org> >

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-20 Thread Flavio Leitner
On Sun, 19 Nov 2017 11:18:25 -0800 Ben Pfaff wrote: [...] > I tend to take this patch as a kind of bug report against the coding > style document. The right response to that might be to explain why the > coding style document is wrong and the history behind it, and to thank > the

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-19 Thread Flavio Leitner
On Sat, 18 Nov 2017 00:41:27 + Darrell Ball <db...@vmware.com> wrote: > On 11/17/17, 3:01 PM, "Flavio Leitner" <f...@sysclose.org> wrote: > > On Fri, 17 Nov 2017 19:34:49 + > Darrell Ball <db...@vmware.com> wrote: > > >

Re: [ovs-dev] [PATCH v2 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

2017-11-17 Thread Flavio Leitner
On Thu, 26 Oct 2017 15:30:42 -0400 Eric Garver wrote: > This supports using the ct_clear action in the kernel datapath. To > preserve compatibility with current ct_clear behavior on old kernels, we > only pass this action down to the datapath if a probe reveals the > datapath

Re: [ovs-dev] [PATCH v2 3/3] system-traffic: Add conntrack floating IP test

2017-11-17 Thread Flavio Leitner
in SYN_RECV > +dnl (OVS maps to ESTABLISHED) means the initial frame was committed, but not > a > +dnl second time after the FIP translation (because ct_clear didn't occur). > +NS_CHECK_EXEC([at_ns1], [echo "foobar" |nc $NC_EOF_OPT 10.254.254.1 123

Re: [ovs-dev] [PATCH v2 2/3] system-common-macros: Check for ct_clear action in datapath

2017-11-17 Thread Flavio Leitner
[AT_SKIP_IF([! grep -q "Datapath supports ct_clear action" > ovs-vswitchd.log])]) Acked-by: Flavio Leitner <f...@sysclose.org> Thanks! -- Flavio ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-17 Thread Flavio Leitner
ch looked ok, > but I did not check carefully. > There is some missed extra newlines after declarations, which generally looks > ok; I’ll check more however. > I also see some extra newlines removed which looked ok, but I’ll check more. > > I’ll submit my own patch since I don’

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: update stats properly on flow deletion

2017-11-17 Thread Flavio Leitner
gt; +} > + > error = tc_del_filter(ifindex, prio, handle); > del_ufid_tc_mapping(ufid); > > netdev_close(dev); > > -if (stats) { > -memset(stats, 0, sizeof *stats); > -} > return error; > } > Thanks for the V2 :-) Acked-by: Flavio Leitner <f...@sysclose.org> -- Flavio ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-17 Thread Flavio Leitner
No functional change, just fixing coding style. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- lib/conntrack.c | 335 +++- 1 file changed, 188 insertions(+), 147 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c

Re: [ovs-dev] [PATCH v2 0/8] Add minimum network namespace support.

2017-11-16 Thread Flavio Leitner
On Tue, 14 Nov 2017 14:54:20 -0800 Gregory Rose <gvrose8...@gmail.com> wrote: > On 11/9/2017 9:30 AM, Flavio Leitner wrote: > > Today Open vSwitch doesn't know about network namespaces (netns), but > > users are moving internal ports to other namespaces. Although packets

Re: [ovs-dev] [PATCH] RPM: Improve doc to use builddep tool.

2017-11-15 Thread Flavio Leitner
On Wed, 15 Nov 2017 11:17:42 -0500 Aaron Conole <acon...@redhat.com> wrote: > Flavio Leitner <f...@sysclose.org> writes: > > > On Wed, 15 Nov 2017 02:20:16 -0500 > > Aaron Conole <acon...@redhat.com> wrote: > > > >> Flavio Leitner <f...@s

Re: [ovs-dev] [PATCH] RPM: Improve doc to use builddep tool.

2017-11-15 Thread Flavio Leitner
On Wed, 15 Nov 2017 02:20:16 -0500 Aaron Conole <acon...@redhat.com> wrote: > Flavio Leitner <f...@sysclose.org> writes: > > > Instead of listing all the dependencies, use the RPM group > > 'Development Tools' and the builddep tool to find specific > > ones. &

Re: [ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

2017-11-14 Thread Flavio Leitner
On Wed, 8 Nov 2017 12:18:36 -0800 Ben Pfaff <b...@ovn.org> wrote: > On Wed, Nov 08, 2017 at 03:31:48PM -0200, Flavio Leitner wrote: > > On Wed, 01 Nov 2017 13:21:22 -0400 > > Aaron Conole <acon...@redhat.com> wrote: > > > > > Guru Shetty <g...@ovn.o

[ovs-dev] [PATCH] RPM: Improve doc to use builddep tool.

2017-11-14 Thread Flavio Leitner
Instead of listing all the dependencies, use the RPM group 'Development Tools' and the builddep tool to find specific ones. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- Documentation/intro/install/fedora.rst | 54 +++--- Documentation/intro/install/rh

[ovs-dev] [PATCH v2 8/8] netdev-linux: fail ops not supporting remote netns.

2017-11-09 Thread Flavio Leitner
When the netdev is in another namespace and the operation doesn't support network namespaces, return the correct error. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-linux.c | 134 +++-- 1 file changed, 120 insertions(

[ovs-dev] [PATCH v2 7/8] nlmon: added netns support.

2017-11-09 Thread Flavio Leitner
Signed-off-by: Flavio Leitner <f...@redhat.com> --- utilities/nlmon.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/utilities/nlmon.c b/utilities/nlmon.c index d38a70b6f..8d9d20f97 100644 --- a/utilities/nlmon.c +++ b/utilities/nlmon.c @@ -41,6 +41,7 @@ main(in

[ovs-dev] [PATCH v2 6/8] netlink linux: enable listening to all nsids

2017-11-09 Thread Flavio Leitner
kernel 4.2 or newer. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/daemon-unix.c| 3 ++- lib/daemon.man | 6 +++--- lib/daemon.xml | 8 lib/netdev-linux.c | 1 + lib/netlink-protocol.h | 6 ++ lib/netlink-so

[ovs-dev] [PATCH v2 5/8] netdev-linux: use netlink to update netdev.

2017-11-09 Thread Flavio Leitner
The ioctl interface doesn't support network namespaces, so try updating the netdev using netlink message instead. To provide backwards compatibility, fall back to the previous method if netlink isn't supported or fails. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-l

[ovs-dev] [PATCH v2 3/8] vport: retrieve the netnsid if available.

2017-11-09 Thread Flavio Leitner
Recent kernels provide the network namespace ID of a port, so use that to discover where the port currently is. Signed-off-by: Flavio Leitner <f...@redhat.com> --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ lib/dpif-netlink.c| 6 ++ li

[ovs-dev] [PATCH v2 2/8] netdev-linux: initialize netns as invalid.

2017-11-09 Thread Flavio Leitner
A port might be already in another netns, so initialize it as invalid to force a state update. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-linux.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 184822816..c31334ce1

[ovs-dev] [PATCH v2 0/8] Add minimum network namespace support.

2017-11-09 Thread Flavio Leitner
messages from all netns which has an ID assigned into it. This and the previous change allows the userspace to track ports in other network namespaces. If any of the APIs aren't available, it falls back to the older APIs to not break backwards compatibility. Flavio Leitner (8): netlink: provide

Re: [ovs-dev] [PATCH 3/2] vswitchd: Document netdev-dpdk commands.

2017-11-09 Thread Flavio Leitner
Hi Ilya, This patch is doing two things. If we need to revert the mempool stuff, it will impact on everything on top of the documentation refactoring. I think the refactoring looks easier for Ian to get in. I could ack just the refactoring because I haven't reviewed the mempool change. fbl

Re: [ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

2017-11-08 Thread Flavio Leitner
On Wed, 01 Nov 2017 13:21:22 -0400 Aaron Conole wrote: > Guru Shetty writes: > > > On 31 October 2017 at 13:06, Aaron Conole wrote: > > > > Ben Pfaff writes: > > > > > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron

Re: [ovs-dev] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Flavio Leitner
" for > any dpdk interface. > > Implementation comments inline. > > Best regards, Ilya Maximets. > > On 06.11.2017 17:20, Flavio Leitner wrote: > > Add a command to dump vhost-user's information. > > > > Signed-off-by: Flavio L

Re: [ovs-dev] [PATCH] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Flavio Leitner
On Tue, 7 Nov 2017 07:34:24 -0400 "Raymond Burkholder" wrote: > > > > > > Add a command to dump vhost-user's information. > > > > > > > > > > Thanks for the patch Flavio, I'll take a look in greater depth and test > later > > this week. On a first pass through though,

Re: [ovs-dev] [PATCH 1/8] netlink: provide network namespace id from a msg.

2017-11-07 Thread Flavio Leitner
On Fri, 3 Nov 2017 11:26:47 -0700 Ben Pfaff <b...@ovn.org> wrote: > On Thu, Nov 02, 2017 at 05:05:02PM -0200, Flavio Leitner wrote: > > The netlink notification's ancillary data contains the network > > namespace id (netnsid) needed to identify the device correctly. >

Re: [ovs-dev] [PATCH] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Flavio Leitner
s and it exposes internal information which is subjected to change from version to version, so I wouldn't add to those regular user facing guides. fbl > > Ian > > > > Signed-off-by: Flavio Leitner <f...@redhat.com> > > --- > > lib/netdev-dpdk.c | 124

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-11-03 Thread Flavio Leitner
On Tue, 31 Oct 2017 12:11:32 +0100 Timothy Redaelli wrote: > The reload procedure will trigger a script that saves the flows and tlv > maps (using ovs-save) then it restarts ovsdb-server, it stops ovs-vswitchd, > it sets other_config:flow-restore-wait=true (to wait till

[ovs-dev] [PATCH 7/8] nlmon: added netns support.

2017-11-02 Thread Flavio Leitner
Signed-off-by: Flavio Leitner <f...@redhat.com> --- utilities/nlmon.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/utilities/nlmon.c b/utilities/nlmon.c index 08a117b58..609b152f9 100644 --- a/utilities/nlmon.c +++ b/utilities/nlmon.c @@ -41,6 +41,7 @@ main(in

[ovs-dev] [PATCH 8/8] netdev-linux: fail ops not supporting remote netns.

2017-11-02 Thread Flavio Leitner
When the netdev is in another namespace and the operation doesn't support network namespaces, return the correct error. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-linux.c | 134 +++-- 1 file changed, 120 insertions(

[ovs-dev] [PATCH 6/8] netlink linux: enable listening to all nsids

2017-11-02 Thread Flavio Leitner
kernel 4.2 or newer. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/daemon-unix.c| 3 ++- lib/daemon.man | 6 +++--- lib/daemon.xml | 8 lib/netdev-linux.c | 1 + lib/netlink-protocol.h | 6 ++ lib/netlink-so

[ovs-dev] [PATCH 5/8] netdev-linux: use netlink to update netdev.

2017-11-02 Thread Flavio Leitner
The ioctl interface doesn't support network namespaces, so try updating the netdev using netlink message instead. To provide backwards compatibility, fall back to the previous method if netlink isn't supported or fails. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-l

[ovs-dev] [PATCH 4/8] netdev: update device info only if netns matches.

2017-11-02 Thread Flavio Leitner
A network device in another network namespace could have the same name, so once the socket starts listening to other network namespaces, it is necessary to confirm the netns id. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-linux.

[ovs-dev] [PATCH 3/8] vport: retrieve the netnsid if available.

2017-11-02 Thread Flavio Leitner
Recent kernels provide the network namespace ID of a port, so use that to discover where the port currently is. Signed-off-by: Flavio Leitner <f...@redhat.com> --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ lib/dpif-netlink.c| 6 ++ li

[ovs-dev] [PATCH 2/8] netdev-linux: initialize netns as invalid.

2017-11-02 Thread Flavio Leitner
A port might be already in another netns, so initialize it as invalid to force a state update. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/netdev-linux.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 0d03ca876..3c80690f4

[ovs-dev] [PATCH 1/8] netlink: provide network namespace id from a msg.

2017-11-02 Thread Flavio Leitner
The netlink notification's ancillary data contains the network namespace id (netnsid) needed to identify the device correctly. (ifindex and netnsid). Signed-off-by: Flavio Leitner <f...@redhat.com> --- configure.ac | 3 +- lib/automake.mk| 1 + lib/dpif-netlink.c

[ovs-dev] [PATCH 0/8] Add minimum network namespace support.

2017-11-02 Thread Flavio Leitner
netlink messages from all netns which has an ID assigned into it. This and the previous change allows the userspace to track ports in other network namespaces. If any of the APIs aren't available, it falls back to the older APIs to not break backwards compatibility. Flavio Leitner (8): netlink

[ovs-dev] [PATCH net-next 3/3] rtnetlink: use netnsid to query interface

2017-11-02 Thread Flavio Leitner
From: Jiri Benc Currently, when an application gets netnsid from the kernel (for example as the result of RTM_GETLINK call on one end of the veth pair), it's not much useful. There's no reliable way to get to the netns fd from the netnsid, nor does any kernel API accept

[ovs-dev] [PATCH net-next 2/3] openvswitch: reliable interface indentification in port dumps

2017-11-02 Thread Flavio Leitner
From: Jiri Benc This patch allows reliable identification of netdevice interfaces connected to openvswitch bridges. In particular, user space queries the netdev interfaces belonging to the ports for statistics, up/down state, etc. Datapath dump needs to provide enough

[ovs-dev] [PATCH net-next 1/3] net: export peernet2id_alloc

2017-11-02 Thread Flavio Leitner
From: Jiri Benc It will be used by openvswitch. Signed-off-by: Jiri Benc --- net/core/net_namespace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 6cfdc7c84c48..b797832565d3 100644 ---

[ovs-dev] [PATCH net-next 0/3] Allow openvswitch to query ports in another netns.

2017-11-02 Thread Flavio Leitner
Today Open vSwitch users are moving internal ports to other namespaces and although packets are flowing OK, the userspace daemon can't find out basic information like if the port is UP or DOWN, for instance. This patchset extends openvswitch API to retrieve the current netnsid of a port. It will

Re: [ovs-dev] [PATCH] treewide: Get rid of "echo -n", and add a test to prevent regression.

2017-10-30 Thread Flavio Leitner
On Fri, 27 Oct 2017 09:59:33 -0700 Ben Pfaff <b...@ovn.org> wrote: > "echo -n" is not POSIX and has spotty support in shells. > > CC: Timothy Redaelli <tredae...@redhat.com> > CC: Flavio Leitner <f...@sysclose.org> > Signed-off-by: Ben Pfaff <b..

Re: [ovs-dev] [PATCH v4 0/2] Add system service to delete transient ports on boot.

2017-10-27 Thread Flavio Leitner
utilities/ovs-ctl.8| 6 ++ > utilities/ovs-ctl.in | 24 > +- > 6 files changed, 34 insertions(+), 11 deletions(-) > create mode 100644 > rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service Acked-b

Re: [ovs-dev] [PATCH v2 2/3] ovs-save: Use a file to restore flows instead of heredoc

2017-10-17 Thread Flavio Leitner
the rules directly. > > Signed-off-by: Timothy Redaelli <tredae...@redhat.com> > --- > utilities/ovs-save | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > Acked-by: Flavio Leitner <f...@sysclose.org> Thanks! fbl __

Re: [ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

2017-10-17 Thread Flavio Leitner
u have the default OpenFlow version > disabled then ovs-save fails. This patch also fixes that problem. > > Signed-off-by: Timothy Redaelli <tredae...@redhat.com> > --- > utilities/ovs-save | 22 +++--- > 1 file changed, 19 insertions(+), 3 deletions(-) >

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-29 Thread Flavio Leitner
On Mon, 25 Sep 2017 15:00:34 -0400 Russell Bryant <rbry...@redhat.com> wrote: > On Mon, Sep 25, 2017 at 2:42 PM, Aaron Conole <acon...@redhat.com> wrote: > > > Flavio Leitner <f...@sysclose.org> writes: > > > > > On Fri, 22 Sep 2017 09:44:18 -0400

<    4   5   6   7   8   9   10   11   >