Great!
Thank you for the fast review!
Could you also look at https://github.com/ovn-org/ovn-website/pull/81 ?
> On Wed, May 8, 2024 at 1:38 PM Igor Zhukov wrote:
>
>> I came across a new patch recently:
>> https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.
I came across a new patch recently:
https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.24429-1-martin.kal...@canonical.com/
After that, I searched the OVN source code for instances of "to to" and
discovered two more occurrences of the same typo.
Signed-off-by: I
It's a mega nitpick, but I observed that the example URL in the "Submitted-at"
points to the OVS repository instead of OVN.
Signed-off-by: Igor Zhukov
---
Documentation/internals/contributing/submitting-patches.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
You're welcome.
> On Fri, Apr 12, 2024 at 7:49 AM Dumitru Ceara wrote:
>
>> On 4/11/24 17:28, Igor Zhukov wrote:
>>> I tried to build OVN in a fresh Ubuntu 24.04 Docker container.
>>>
>>> I only installed the Build-Depends.
>>>
>>> I ran:
-buildpackage: error: debian/rules clean subprocess returned exit status 2
debuild: fatal error at line 1184:
dpkg-buildpackage -us -uc -ui -b failed
After researching a solution, I discovered that we need to add dh-python to the
Build-Depends in debian/control.
Signed-off-by: Igor Zhukov
---
debian
Great! You're welcome!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I found the broken link at
https://docs.ovn.org/en/latest/internals/release-process.html.
I believe the correct link is https://www.ovn.org/en/releases/#long-term-support
Signed-off-by: Igor Zhukov
---
Documentation/internals/release-process.rst | 2 +-
1 file changed, 1 insertion(+), 1
I noticed the copyright year at the bottom of
https://docs.ovn.org/en/latest/contents.html
Signed-off-by: Igor Zhukov
---
Documentation/conf.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/conf.py b/Documentation/conf.py
index f8fc0125f..828e9443b 100644
I noticed the copyright year at the bottom of
https://docs.ovn.org/en/latest/contents.html
Signed-off-by: Igor Zhukov
---
Documentation/conf.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/conf.py b/Documentation/conf.py
index f8fc0125f..828e9443b 100644
Sure, you are welcome.
> Thank you Igor,
>
> Acked-by: Mark Michelson
>
> On 10/19/23 00:31, Igor Zhukov wrote:
>
>> Although this typo does not cause a real error.
>>
>> Look at my test: https://gcc.godbolt.org/z/hdKc389vd
>>
>> Signed-off-by
Although this typo does not cause a real error.
Look at my test: https://gcc.godbolt.org/z/hdKc389vd
Signed-off-by: Igor Zhukov
---
controller/ofctrl.c | 2 +-
northd/northd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
Although this typo does not cause a real error.
Look at my test: https://gcc.godbolt.org/z/hdKc389vd
Signed-off-by: Igor Zhukov
---
northd/northd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/northd/northd.c b/northd/northd.c
index 916068d44..f8b046d83 100644
The server returns 404 for the previous link.
Signed-off-by: Igor Zhukov
---
ovn-architecture.7.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index a2a87ec28..96294fe2b 100644
--- a/ovn-architecture.7.xml
+++ b/ovn
Sure.
Acked-by: Igor Zhukov
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I agree.
Yes, we needed to check the build on version 22.03.
Sorry.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I agree.
Yes, we needed to check the build on version 22.03.
Sorry.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Great!
You are welcome!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
From: Igor Zhukov
You can check logs by running: make check-valgrind TESTSUITEFLAGS="246"
(Actually almost every test affected but for example we need one test)
Valgrind message looks like
==65437== 304 bytes in 1 blocks are possibly lost in loss record 265 of 289
==65437==at
to update the maintainers.rst changes in two places...
> On Thu, Dec 29, 2022 at 7:20 AM Igor Zhukov wrote:
>>
>> From: Igor Zhukov
>>
>> Found at https://docs.ovn.org/en/latest/internals/maintainers.html
>>
>> Signed-off-by: Igor Zhukov
>>
>>
Oh, sorry. You're right. The links don't work on github.
For some reason I thought it works.
Yes, I don't know what should we do. Broken links are bad. For both github and
https://docs.ovn.org/
___
dev mailing list
d...@openvswitch.org
From: Igor Zhukov
Found at https://docs.ovn.org/en/latest/internals/maintainers.html
Signed-off-by: Igor Zhukov
---
MAINTAINERS.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index a4012a5cf..adb4ffca2 100644
Great! You're welcome!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
From: Igor Zhukov
Also add python 3.11
Just a some cleanup of the commit:
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
From: Igor Zhukov
Also add python 3.11
Just a some cleanup of the commit:
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
From: Igor Zhukov
Also add python 3.11
Just a some cleanup of the commit:
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
From: Igor Zhukov
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
index bc2ac1aef..6667e5e4d 100644
--- a/m4/ovn.m4
+++ b/m4/ovn.m4
@@ -303,13 +303,13 @@ AC_DEFUN([OVN_CHECK_VALGRIND],
dnl Checks for Python
Great!
I see it works: https://github.com/ovn-org/ovn/commits/main
> On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov wrote:
>
>> From: Igor Zhukov
>>
>> Docs:
>> https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
>>
Yesterday I created a patch:
https://patchwork.ozlabs.org/project/ovn/patch/20220804145543.8294-1-fsb4...@yandex.ru/
I hope it solves all the problems.
Maybe I should have written to this thread right away, because you might not see
> On 8/4/22 15:19, Igor Zhukov wrote:
>
>>
From: Igor Zhukov
Docs:
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO
Signed-off-by: Igor Zhukov
---
.github/workflows/ovn-kubernetes.yml | 2 +-
.github/workflows
Yes, some tests needed. I will try to test later today.
> On 8/4/22 15:19, Igor Zhukov wrote:
>
>> Hi. Yes, I confirm.
>> I'm sorry :(
>
> No problem. :)
>
>> Probably removing
>> `|| github.ref`
>> will help.
>
> Makes sense to me to limit
have any other thoughts on this matter?
>
> Thanks,
> Dumitru
>
> On 7/14/22 22:02, Numan Siddique wrote:
>
>> On Wed, Jul 13, 2022 at 6:53 AM Ales Musil wrote:
>>
>>> Ok, thanks.
>>>
>>> Acked-by: Ales Musil
>>
>> Thanks. I ap
Great!
You are welcome!
Igor Zhukov
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
just to be sure.
>
> Thanks,
>
> Ales
>
> On Wed, Jul 13, 2022 at 1:25 PM Igor Zhukov wrote:
>
>> From: Igor Zhukov
>>
>> While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes pushed
>>
>> several commits quickly and after that I noti
From: Igor Zhukov
While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes pushed
several commits quickly and after that I noticed that previous run was still in
progress and the most recent run was waiting in line.
I googled some solutions and
I found the answer: https
From: Igor Zhukov
Also fix typo in comments
Also fix memory leak in utilities/ovn-dbctl.c
Also add "-g" to CFLAGS to forbid autotools from adding "-g -O2" (temporary
solution)
Signed-off-by: Igor Zhukov
Acked-by: Dumitru Ceara
Submitted-at: https://github.com/ovn-org/o
You're welcome!
I sent this patch via `git send-email`
:)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
From: Igor Zhukov
Signed-off-by: Igor Zhukov
Acked-by: Dumitru Ceara
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
Signed-off-by: Igor Zhukov
Acked-by: Dumitru Ceara
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -4505,7 +4505,7
Signed-off-by: Igor Zhukov
Acked-by: Dumitru Ceara
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -4505,7 +4505,7
39 matches
Mail list logo
