Re: [ovs-dev] [PATCH ovn 4/4] multicast: Properly flood IGMP queries and reports.

On Thu, Jul 7, 2022 at 12:24 PM Lucas Alvares Gomes wrote: > > Hi, > > I tested this series of patches with OpenStack upstream [0] since we > have some automated tests for IGMP and it seems good: > > test_multicast_between_vms_on_same_network[id-113486fc-24c9-4be4-8361-03b1c

Re: [ovs-dev] [PATCH ovn 4/4] multicast: Properly flood IGMP queries and reports.

Hi, I tested this series of patches with OpenStack upstream [0] since we have some automated tests for IGMP and it seems good: test_multicast_between_vms_on_same_network[id-113486fc-24c9-4be4-8361-03b1c9892867] pass (link:

Re: [ovs-dev] [PATCH ovn] Allow for setting the Next server IP in the DHCP header

On Thu, May 19, 2022 at 10:05 PM Numan Siddique wrote: > > On Thu, May 19, 2022 at 4:11 AM Lucas Alvares Gomes > wrote: > > > > Hi, > > > > Thanks Numan for the review. See the replies below. > > > > On Thu, May 19, 2022 at 12:36 AM Numan Siddique

Re: [ovs-dev] [PATCH ovn] Allow for setting the Next server IP in the DHCP header

Hi, Thanks Numan for the review. See the replies below. On Thu, May 19, 2022 at 12:36 AM Numan Siddique wrote: > > On Wed, May 11, 2022 at 11:34 AM wrote: > > > > From: Lucas Alvares Gomes > > > > In order to PXE boot a baremetal server using the OVN DHCP ser

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't add arp responder flows for lports with 'unknown' address.

Hi Numan, Can we backport this change to 20.03 please ? I did locally, and should be a clean merge. The OVN packages from Ubuntu LTS 20.04 (focal) which is used upstream to test OpenStack is based on 20.03 and this patch fixes an issue we have with one tempest test [0] [0]

Re: [ovs-dev] [PATCH ovn v3] Avoid nb_cfg update notification flooding

wards compatibility note that the nb_cfg from the > Chassis table is no longer updated. If any system is relying on this > mechanism they should start using the nb_cfg from the Chassis_Private > table from now on. > > Co-authored-by: Lucas Alvares Gomes > Signed-off-by: Lucas

Re: [ovs-dev] [PATCH ovn v2] Avoid nb_cfg update notification flooding

On Wed, Jul 29, 2020 at 8:03 PM Han Zhou wrote: > > > > On Wed, Jul 29, 2020 at 2:46 AM Lucas Alvares Gomes > wrote: > > > > Hi Han, > > > > > > > > Just to follow up. I didn't find any new versions for this patch and it > > > doesn'

Re: [ovs-dev] [PATCH ovn v2] Avoid nb_cfg update notification flooding

Hi Han, > > Just to follow up. I didn't find any new versions for this patch and it > doesn't seem to be merged. Did you send any new versions or do you still > plan to work on this? > Thanks for this follow up. So I am not currently working on it but the work is still in our backlog. Many of

Re: [ovs-dev] [ovs-discuss] OVN: configuration in Neutron DB?

Hi, On Wed, Jul 29, 2020 at 7:42 AM Numan Siddique wrote: > > Adding Daniel and Lucas. Maybe you can also include opendev ML to get > appropriate responses from the OpenStack side. > > Please see below for few comments. > > > On Wed, Jul 29, 2020 at 12:02 PM Tony Liu wrote: > > > Quick update.

Re: [ovs-dev] [PATCH ovn] ovn-controller to no longer monitor Chassis' external_ids

Thank you all for looking into this. On Tue, May 12, 2020 at 1:37 PM Dumitru Ceara wrote: > > On 5/7/20 12:12 PM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > Prior to this patch, the external_ids column from the Chassis table were > > being us

Re: [ovs-dev] [PATCH ovn] ovn-controller to no longer monitor Chassis' external_ids

ovn-controller process is the one writing to that table and the CMSs are suppose to handle such events (and get rid of the entry when they are done). So I'm afraid we can not leverage this for the health checks :-( Cheers, Lucas > On Thu, May 7, 2020 at 12:12 PM wrote: > > > From: Lucas

Re: [ovs-dev] [PATCH ovn] Add support for DHCP options 35 and 38

Hi, On Thu, Apr 23, 2020 at 4:08 PM Flavio Fernandes wrote: > > Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > > > > On Apr 23, 2020, at 10:32 AM, lmart...@redhat.com wrote: > > > > From: Lucas Alvares Gomes > > > > This

Re: [ovs-dev] [PATCH ovn] [OVN] Avoid nb_cfg update notification flooding

Hi, On Fri, Mar 20, 2020 at 10:07 AM Dumitru Ceara wrote: > > On 3/13/20 2:18 PM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > nb_cfg as a mechanism to "ping" OVN control plane is very useful > > in many ways. However, the curren

Re: [ovs-dev] [PATCH ovn] [RFC] Add chassis liveness monitoring mechanism

Hi Han, Thank you very much for the feedback, much appreciated! On Wed, Mar 11, 2020 at 7:06 AM Han Zhou wrote: > > Thanks Lucas for working on this! Please see my comments below. > > On Thu, Feb 20, 2020 at 1:56 AM Lucas Alvares Gomes > wrote: > > > > Th

Re: [ovs-dev] [PATCH ovn] [RFC] Add chassis liveness monitoring mechanism

Thanks for the review Dumitry! On Thu, Feb 20, 2020 at 9:19 AM Dumitru Ceara wrote: > > On 2/19/20 4:37 PM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > NOTE: SENDING THIS PATCH AS A RFC TO SEE WHAT OTHERS MIGHT THINK ABOUT > > TH

Re: [ovs-dev] [PATCH ovn] Build OVN using external OVS directory

/ovsdb-idlc > +noinst_SCRIPTS += ${OVSDIR}/ovsdb/ovsdb-idlc > +EXTRA_DIST += ${OVSDIR}/ovsdb/ovsdb-idlc.in > +MAN_ROOTS += ${OVSDIR}/ovsdb/ovsdb-idlc.1 > +CLEANFILES += ${OVSDIR}/ovsdb/ovsdb-idlc > SUFFIXES += .ovsidl .ovsschema > -OVSDB_IDLC = $(run_python)

Re: [ovs-dev] [[ovn]] OVN split: Fix modules_install

Hi, On Mon, Jul 29, 2019 at 10:25 AM Numan Siddique wrote: > > On Mon, Jul 29, 2019 at 2:30 PM wrote: > > > From: Lucas Alvares Gomes > > > > The Makefile for modules_install should point to the ovs subrepository > > to be able to compile the ovs kernel m

Re: [ovs-dev] [PATCH] [ovn-northd] Don't emit ICMP need to frag on LRP with no IPv4 address

continue; > } > ds_clear(); > -- > 2.21.0 (Apple Git-120) > > ___________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-By: Lucas Alvares Gom

Re: [ovs-dev] [PATCH] ovsdb-server: drop all connections on read/write status change

b-server/sync-status | grep -c > backup], [0], [1 > +]) > +AT_CHECK([ovn-nbctl ls-add sw1], [1], [ignore], > +[ovn-nbctl: transaction error: {"details":"insert operation not allowed when > database server is in read only mode","error"

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

lves so that the agent has a better chance of doing > # the right thing at startup > ${CRM_ATTR_REPL_INFO} -v "$host_name" > -- > 2.21.0 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-By: Lucas Alvares Gomes ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

On Fri, 28 Jun 2019, 19:17 Numan Siddique, wrote: > On Fri, Jun 28, 2019 at 11:46 PM Numan Siddique > wrote: > > > > > > > On Wed, Jun 26, 2019 at 2:42 PM wrote: > > > >> From: Lucas Alvares Gomes > >> > >> This patc

Re: [ovs-dev] Request to release a new version of the ovs python library

Hi, On Sat, Jun 22, 2019 at 5:39 AM Ben Pfaff wrote: > > On Fri, Jun 21, 2019 at 09:36:36AM +0100, Lucas Alvares Gomes wrote: > > Hi, > > > > Not sure if this is the right place to ask for it but, can we get a > > new release of the ovs python library p

[ovs-dev] Request to release a new version of the ovs python library

Hi, Not sure if this is the right place to ask for it but, can we get a new release of the ovs python library please [0] ? The latest release was in Oct, 9, 2018. I keep seeing the following error [1] in the upstream OpenStack gate: Jun 20 20:22:00.178737 ubuntu-bionic-vexxhost-sjc1-0008154837

Re: [ovs-dev] [PATCH v6] OVN: Add support for Transport Zones

On Mon, Apr 22, 2019 at 9:38 PM Ben Pfaff wrote: > > On Thu, Apr 18, 2019 at 02:39:09PM +0100, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > This patch is adding support for Transport Zones. Transport zones (a.k.a > > TZs) is way to enable us

Re: [ovs-dev] [PATCH v5] OVN: Add support for Transport Zones

On Thu, Apr 18, 2019 at 11:34 AM Lucas Alvares Gomes wrote: > > Hi, > > On Wed, Apr 17, 2019 at 6:04 PM Ben Pfaff wrote: > > > > On Wed, Apr 17, 2019 at 04:55:24PM +0100, lmart...@redhat.com wrote: > > > From: Lucas Alvares Gomes > > > > > &g

Re: [ovs-dev] [PATCH v5] OVN: Add support for Transport Zones

Hi, On Wed, Apr 17, 2019 at 6:04 PM Ben Pfaff wrote: > > On Wed, Apr 17, 2019 at 04:55:24PM +0100, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > This patch is adding support for Transport Zones. Transport zones (a.k.a > > TZs) is way to enable us

Re: [ovs-dev] [PATCH v4] OVN: Add support for Transport Zones

On Wed, Apr 17, 2019 at 4:46 PM Numan Siddique wrote: > > On Wed, Apr 17, 2019 at 8:21 PM wrote: > > > From: Lucas Alvares Gomes > > > > This patch is adding support for Transport Zones. Transport zones (a.k.a > > TZs) is way to enable users of OVN to separate C

Re: [ovs-dev] [PATCH v3] OVN: Add support for Transport Zones

On Sat, Apr 13, 2019 at 12:08 AM Ben Pfaff wrote: > > On Thu, Mar 28, 2019 at 10:37:00AM +, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > This patch is adding support for Transport Zones. Transport zones (a.k.a > > TZs) is way to enable us

Re: [ovs-dev] [PATCH v2] OVN: Add support for Transport Zones

d to me. >> >> Acked-by: Mark Michelson >> >> On 3/25/19 2:24 PM, lmart...@redhat.com wrote: >> > From: Lucas Alvares Gomes >> > >> > This patch is adding support for Transport Zones. Transport zones (a.k.a >> > TZs) is way to enable user

Re: [ovs-dev] [PATCH] OVN: Add support for Transport Zones

Hi, Thanks a lot Mark for the quick review. On Mon, Mar 25, 2019 at 3:40 PM Mark Michelson wrote: > > Hi Lucas, > > Thanks for the patch. It's mostly good but I have a few issues with it. > See below. > > On 3/25/19 10:36 AM, lmart...@redhat.com wrote: > >

Re: [ovs-dev] [PATCH] ovn-nbctl: Don't segfault when ovn-northd doesn't configure dynamic addresses.

t; -if (is_dynamic_lsp_address(addr)) { > +if (is_dynamic_lsp_address(addr) && lsp_test->dynamic_addresses) > { > addr = lsp_test->dynamic_addresses; > } > if (extract_lsp_addresses(addr, _

Re: [ovs-dev] [PATCH] ovn: change load balancer references to weak in NB schema

-nbctl.at > @@ -752,7 +752,15 @@ AT_CHECK([ovn-nbctl lr-lb-add lr0 lb0]) > AT_CHECK([ovn-nbctl lr-lb-add lr0 lb1]) > AT_CHECK([ovn-nbctl lr-lb-add lr0 lb3]) > AT_CHECK([ovn-nbctl lr-lb-del lr0]) > -AT_CHECK([ovn-nbctl lr-lb-list lr0 | uuidfilt], [0], [])]) > +AT_CHECK([ovn-nbctl lr-lb-list lr0 | uuidfilt], [0], []) > + > +

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

> +self.input = self.input[self.parser.feed(self.input):] > if self.parser.is_done(): > msg = self.__process_msg() > if msg: > -- > 1.8.3.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-By: Lucas Alvares Gomes ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2 v2] Work around Python/C JSON unicode differences

self.input = self.input[self.parser.feed(self.input):] > if self.parser.is_done(): > msg = self.__process_msg() > if msg: > -- > 1.8.3.1 > > ________

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

of the ML >> >> On Mon, Aug 13, 2018 at 11:17 AM Lucas Alvares Gomes >> wrote: >> >> > Hi, >> > >> > > Before starting in-depth technical discussions on this list or the >> > > ovs-dev list, I'm curious if people would be interest

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

Hi, > Before starting in-depth technical discussions on this list or the > ovs-dev list, I'm curious if people would be interested in splitting off > a separate OVN list for this and future OVN-related discussions? I can > see merits of keeping discussions on this list and of starting a new >

Re: [ovs-dev] [branch-2.9] Revert "flow: Fix buffer overread for crafted IPv6 packets."

-dsvm-ovs-release/4b5bb1d/logs/testr_results.html.gz (the link will eventually expire) Acked-By: Lucas Alvares Gomes On Sat, Jul 14, 2018 at 9:33 PM Justin Pettit wrote: > > This reverts commit 0760bd61a666e9fa866fcb5ed67f48f34895d2f6. > > This patch was a cherry-pick from a bug fix i

Re: [ovs-dev] [PATCH v2 3/3] OVN: add protocol unreachable support to OVN router ports

Hi, > this should be the same issue reported by Darrell ('ovn: Fix gateway > load balancing') > Regards, > Yeah that's right, I have applied Darrell's patch [0] and re-run the same test that myself and Daniel were debugging [1] and I can confirm that it works now. Thanks for the pointers! [0]

Re: [ovs-dev] [PATCH v2] ovn-northd: Apply pre ACLs when using Port Groups

ateful(od, lflows); > build_acls(od, lflows, port_groups); > diff --git a/tests/ovn.at b/tests/ovn.at > index 6553d17c6..93644b023 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -9981,7 +9981,7 @@ ovn-nbctl create Port_Group name=pg2 ports="$pg2_ports" >

Re: [ovs-dev] [PATCH 1/3] datapath: Fix max MTU size on RHEL 7.5 kernel

dev->extended->max_mtu = ETH_MAX_MTU; > #endif > netdev->netdev_ops = _dev_netdev_ops; > > -- > 2.7.4 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-b

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Hi Yi-Hung, > I format the patch and post in here: > https://patchwork.ozlabs.org/patch/927995/ Could you help to take a > look? Oh great! Sorry for the delay on this, I will take a look! Cheers, Lucas ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Hi Yi-Hung Wei, > But as mentioned in ovs commit 6c0bf091 ("datapath: use core MTU range > checking in core net infra"), it might be the case that my commit [0] > does not set max_mtu correctly. How about the fix in the following? > From what I tested, without the fix, min_mtu: 64, max_mtu:

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

On Thu, May 17, 2018 at 12:27 PM, <lucasago...@gmail.com> wrote: > From: Lucas Alvares Gomes <lucasago...@gmail.com> > > The commit [0] partially fixed the problem but in RHEL 7.5 neither > .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for > vport-int

Re: [ovs-dev] [PATCH v2] datapath: compat: Fix build on RHEL 7.5

patch defines a new symbol HAVE_RHEL7_MAX_MTU that determines > the previous 2 conditions, and fixes the backport issue. > > Signed-off-by: Yi-Hung Wei <yihung@gmail.com> Acked-by: Lucas Alvares Gomes <lucasago...@gmail.com> ___ dev mai

Re: [ovs-dev] [PATCH] datapath: compat: Fix build on RHEL 7.5

> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c > index f48684b2e70f..90e76bac2165 100644 > --- a/datapath/vport-internal_dev.c > +++ b/datapath/vport-internal_dev.c > @@ -153,7 +153,7 @@ static const struct net_device_ops > internal_dev_netdev_ops = { >

[ovs-dev] [PATCH v1] ovn-ctl: Trivial, remove duplicated stop_controller case option

Signed-off-by: Lucas Alvares Gomes <lucasago...@gmail.com> --- ovn/utilities/ovn-ctl | 3 --- 1 file changed, 3 deletions(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 0e56bf8c5..dc0c26159 100755 --- a/ovn/utilities/ovn-ctl +++ b/ovn/utilities/ovn-ctl @@ -581,9

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

Hi, Excellent investigative work here Daniel, thanks for that! On Wed, Feb 28, 2018 at 9:37 AM, Miguel Angel Ajo Pelayo wrote: > And if we can get backports down the lane, that'd be great :) > +1 for backporting it. The changes seems straight forward to do so. > On Wed,

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

-by: Daniel Alvarez <dalva...@redhat.com> >> >> >> >> From [0] one can expect this column to be present in all tables. >> >> [0] https://github.com/openvswitch/ovs/blob/v2.8.1/ovn/ovn-nb.xml#L19 >> >> >> >> On Mon, Dec 4, 2017 at 2

[ovs-dev] [PATCH] Add NAT information to the logical routers in nbctl show output

This patch is changing the print_lr() function in ovn-nbctl.c to include logical router NAT information as part of the output (external ip, logical ip and type). Signed-off-by: Lucas Alvares Gomes <lucasago...@gmail.com> --- ovn/utilities/ovn-nbctl.c | 12 1 file chang

[ovs-dev] [PATCH v3] python: Allow tuning the session probe_interval from IDL

en disable it. Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1680146 Signed-off-by: Lucas Alvares Gomes <lucasago...@gmail.com> --- python/ovs/db/idl.py | 12 +--- python/ovs/jsonrpc.py | 11 +-- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH v2] python: Allow tuning the session probe_interval from IDL

en disable it. Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1680146 Signed-off-by: Lucas Alvares Gomes <lucasago...@gmail.com> --- v2: Change the probe interval before the connection is opened python/ovs/db/idl.py | 12 +--- python/ovs/jsonrpc.py | 11 +-- 2 f

Re: [ovs-dev] [PATCH] python: Allow tuning the session probe_interval from IDL

Hi, > Nothing else in the Idl class is touching the reconnect object > directly, which makes me wonder if this should also be a method on the > session, or perhaps an option to Session.open(). > > I also wonder if it'd be better as an optional argument to the > constructor so that we can pass in

[ovs-dev] [PATCH] python: Allow tuning the session probe_interval from IDL

/1680146 Signed-off-by: Lucas Alvares Gomes <lucasago...@gmail.com> --- python/ovs/db/idl.py | 9 + 1 file changed, 9 insertions(+) diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index 079a03ba1..d3c0086c6 100644 --- a/python/ovs/db/idl.py +++ b/python/ovs/db/idl.py @@ -147,6 +