Re: [ovs-dev] [PATCH net-next] net: openvswitch: select vport upcall portid drectly

On Wed, Nov 6, 2019 at 3:04 PM wrote: > From: Tonghao Zhang > drectly --> directly in the commit title ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] netdev-tc-offloads: Properly get the block id on flow del/get

. While here, add the block id to existing debug print. Fixes: 88dcf2aa8234 ('netdev-provider: add class op to get block_id') Signed-off-by: Or Gerlitz Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 8 1 file changed, 4 insertions(+), 4 deletions

[ovs-dev] [PATCH 1/2] lib/tc: Put the tunnel match fields as part of the tc/flower key struct

Move the tunnel match fields to be part of the tc/flower key structure. This is pre-step for being able to apply masked match where needed. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 50 lib/tc.c

[ovs-dev] [PATCH 0/2] Fixes for TC DP matching on IP tunnels ttl/tos

The tc library wrongly programs the kernel tc stack to match on tunnel ttl/tos also when not needed. Fix that by taking into account the mask. Or. Or Gerlitz (2): lib/tc: Put the tunnel match fields as part of the tc/flower key struct lib/tc: Avoid matching on tunnel ttl or tos if not needed

[ovs-dev] [PATCH 2/2] lib/tc: Avoid matching on tunnel ttl or tos if not needed

') Signed-off-by: Or Gerlitz Reported-by: Eli Britstein Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 9 +++-- lib/tc.c | 16 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

On Wed, Aug 1, 2018 at 2:29 PM, Simon Horman wrote: > Hi Or, > > On 1 August 2018 at 13:21, Or Gerlitz wrote: >> >> On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman >> wrote: >> > On 1 August 2018 at 11:31, Simon Horman >> > wrote: >> >>

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman wrote: > On 1 August 2018 at 11:31, Simon Horman wrote: >> >> Thanks Or, Thanks Ben, >> >> On 1 August 2018 at 08:43, Or Gerlitz wrote: >>> >>> On Tue, Jul 31, 2018 at 1:40 PM, Or Gerlitz >>> wro

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

On Tue, Jul 31, 2018 at 1:40 PM, Or Gerlitz wrote: > This series comes to address the case to set (encap) and match (decap) > also the tos and ttl fields of TC based IP tunnels. This happens e.g > due to inherit setup of tunnel port for tos or due to specific OF rule. > > The se

[ovs-dev] [PATCH V2 3/4] lib/tc: Support setting tos and ttl for TC IP tunnels

Allow to set the tos and ttl for TC tunnels. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- acinclude.m4 | 6 +++--- include/linux/tc_act/tc_tunnel_key.h | 10 -- lib/netdev-tc-offloads.c | 16 lib/tc.c

[ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

: - rebased to include Jianbo's changes from the master and not locally - addressed comment from Simon on duplicated code Or Gerlitz (4): lib/tc: Handle ttl for ipv6 too lib/tc: Support matching on ip tos lib/tc: Support setting tos and ttl for TC IP tunnels lib/tc: Support matching on ip tunnel tos

[ovs-dev] [PATCH V2 4/4] lib/tc: Support matching on ip tunnel tos and ttl

Support matching on tos and ttl of ip tunnels for the TC data-path. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- acinclude.m4 | 10 +- include/linux/pkt_cls.h | 7 ++- lib/netdev-tc-offloads.c | 8 lib/tc.c | 26

[ovs-dev] [PATCH V2 2/4] lib/tc: Support matching on ip tos

Add the missing code to match on ip tos when dealing with the TC data-path. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 1 + lib/match.c | 7 +++ lib/netdev-tc-offloads.c| 6 -- lib/tc.c| 10

[ovs-dev] [PATCH V2 1/4] lib/tc: Handle ttl for ipv6 too

TTL can and should be used to match on IPv6's hop-limit, fix that. Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower') Fixes: 0b4b5203d12e ('tc: Add ip layer ttl matching') Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 4 ++-- lib/tc.c

Re: [ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

On Thu, Jul 26, 2018 at 11:19 PM, Simon Horman wrote: > On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote: >> +++ b/lib/tc.c >> @@ -298,6 +298,10 @@ static const struct nl_policy tca_flower_policy[] = { >>

Re: [ovs-dev] [PATCH 1/4] lib/tc: Handle ttl for ipv6 too

On Thu, Jul 26, 2018 at 5:41 PM, Simon Horman wrote: > On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote: >> TTL can and should be used to match on IPv6's hop-limit, fix that. >> Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower') >> Fix

Re: [ovs-dev] [PATCH 2/4] lib/tc: Support matching on ip tos

On Thu, Jul 26, 2018 at 5:44 PM, Simon Horman wrote: > On Wed, Jul 25, 2018 at 09:20:07PM +0300, Or Gerlitz wrote: >> Add the missing code to match on ip tos when dealing >> with the TC data-path. >> --- a/lib/netdev-tc-offloads.c >> +++ b/lib/netdev-tc-off

[ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

Support matching on tos and ttl of ip tunnels for the TC data-path. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- acinclude.m4 | 10 +- include/linux/pkt_cls.h | 7 ++- lib/netdev-tc-offloads.c | 8 lib/tc.c | 30

[ovs-dev] [PATCH 3/4] lib/tc: Support setting tos and ttl for TC IP tunnels

Allow to set the tos and ttl for TC tunnels. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- acinclude.m4 | 6 +++--- include/linux/tc_act/tc_tunnel_key.h | 10 -- lib/netdev-tc-offloads.c | 16 lib/tc.c

[ovs-dev] [PATCH 2/4] lib/tc: Support matching on ip tos

Add the missing code to match on ip tos when dealing with the TC data-path. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 1 + lib/match.c | 7 +++ lib/netdev-tc-offloads.c| 6 -- lib/tc.c| 10

[ovs-dev] [PATCH 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

://mail.openvswitch.org/pipermail/ovs-dev/2018-July/349752.html Or Gerlitz (4): lib/tc: Handle ttl for ipv6 too lib/tc: Support matching on ip tos lib/tc: Support setting tos and ttl for TC IP tunnels lib/tc: Support matching on ip tunnel tos and ttl acinclude.m4 | 16

[ovs-dev] [PATCH 1/4] lib/tc: Handle ttl for ipv6 too

TTL can and should be used to match on IPv6's hop-limit, fix that. Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower') Fixes: 0b4b5203d12e ('tc: Add ip layer ttl matching') Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 4 ++-- lib/tc.c

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 7/27/2017 1:14 PM, Roi Dayan wrote: the system call is done only once. good to know, would be worth to mention that on the change-log, so it's clear we're good w.r.t performance. Or. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 7/27/2017 11:32 AM, Simon Horman wrote: On Thu, Jul 27, 2017 at 11:29:10AM +0300, Or Gerlitz wrote: On 7/27/2017 11:00 AM, Simon Horman wrote: Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks to msecs. This is how ip

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 7/27/2017 11:00 AM, Simon Horman wrote: Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks to msecs. This is how iproute does the conversion when parsing tc filters. Signed-off-by: Paul Blakey Reviewed-by: Roi

Re: [ovs-dev] [PATCH] tc: Add SCTP support

On 7/25/2017 8:29 AM, Roi Dayan wrote: Imlement SCTP source and destination ports support for flower s/Imlement/Implement also would be good to add a period @ the end of the sentence. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovs V4 00/24] Introducing HW offload support for openvswitch

On 3/17/2017 4:14 PM, Simon Horman wrote: Hi again, I think that once the TODO items above are resolved - both of which I have provided some feedback on separately - some consideration should be given to merging this patchset. Any thoughts/comments on that? Roi just commented that he will