Re: [ovs-dev] [PATCH] net: openvswitch: Check vport name

2024-04-16 Thread Paolo Abeni
On Sat, 2024-04-13 at 16:48 +0800, jun.gu wrote: > Check vport name from dev_get_by_name, this can avoid to add and remove > NIC repeatedly when NIC rename failed at system startup. > > Signed-off-by: Jun Gu > --- > net/openvswitch/vport-netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread Paolo Abeni
On Fri, 2024-02-16 at 10:28 -0500, Aaron Conole wrote: > Many openvswitch test cases reused netns and interface names. This works > fine as long as the test case cleans up gracefully. However, if there is > some kind of ungraceful termination (such as an external signal) the netns > or

Re: [ovs-dev] [PATCH net 4/4] selftests: openvswitch: Fix the ct_tuple for v4

2023-10-10 Thread Paolo Abeni
On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote: > Caught during code review. Since there are a few other small things, please additionally expand this changelog briefly describing the addressed problem and it's consequences. Thanks, Paolo ___

Re: [ovs-dev] [PATCH net 3/4] selftests: openvswitch: Skip drop testing on older kernels

2023-10-10 Thread Paolo Abeni
On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote: > Kernels that don't have support for openvswitch drop reasons also > won't have the drop counter reasons, so we should skip the test > completely. It previously wasn't possible to build a test case > for this without polluting the datapath,

Re: [ovs-dev] [PATCH net 1/4] selftests: openvswitch: Add version check for pyroute2

2023-10-10 Thread Paolo Abeni
On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote: > Paolo Abeni reports that on some systems the pyroute2 version isn't > new enough to run the test suite. Ensure that we support a minimum > version of 0.6 for all cases (which does include the existing ones). > The 0.6.1 version

Re: [ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases

2023-08-03 Thread Paolo Abeni
On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control

Re: [ovs-dev] [PATCH net] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread Paolo Abeni
On Mon, 2023-06-05 at 16:38 +0200, Simon Horman wrote: > On Mon, Jun 05, 2023 at 03:53:59PM +0200, Eelco Chaudron wrote: > > > Yeah, I see that. And I might have done the same thing. > > > But, OTOH, this change is making the error path more complex > > > (or at least more prone to error). > > >

Re: [ovs-dev] [PATCH net-next v2 1/1] net: openvswitch: Use on stack sw_flow_key in ovs_packet_cmd_execute

2023-02-23 Thread Paolo Abeni
On Thu, 2023-02-23 at 20:24 +0800, Eddy Tao wrote: > Sorry, there is a typo in the mail, i will resend shortly, please, don't do that. # Form letter - net-next is closed The merge window for v6.3 has begun and therefore net-next is closed for new drivers, features, code refactoring and

Re: [ovs-dev] [syzbot] KASAN: use-after-free Read in ovs_vport_locate

2022-12-20 Thread Paolo Abeni
On Tue, 2022-12-20 at 00:22 -0800, syzbot wrote: > HEAD commit:041fae9c105a Merge tag 'f2fs-for-6.2-rc1' of git://git.ker.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15c5d02048 > kernel config:

Re: [ovs-dev] [PATCH] [openvswitch v3 1/2] openvswitch: Add support to count upcall packets

2022-11-22 Thread Paolo Abeni
Hello, On Fri, 2022-11-18 at 06:19 -0500, wangchuanlei wrote: > Add support to count upall packets > > Signed-off-by: wangchuanlei The fact that you are posting this series simultaneusly to netdev and the ovs ML with only patch 1/2 landing here is confusing. On next iteration please sent this

Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features

2022-10-17 Thread Paolo Abeni
On Mon, 2022-10-17 at 09:26 -0400, Aaron Conole wrote: > Paolo Abeni writes: > > On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:e8bc52cb8d

Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features

2022-10-13 Thread Paolo Abeni
On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git... > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de04288 > kernel

Re: [ovs-dev] [syzbot] WARNING in ovs_dp_cmd_new (2)

2022-10-13 Thread Paolo Abeni
On Wed, 2022-10-12 at 10:33 -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git... > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=1112f08a88 > kernel

Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-11 Thread Paolo Abeni
Hello, On Thu, 2022-10-06 at 15:45 -0400, Xin Long wrote: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 > RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack]

Re: [ovs-dev] [PATCH net-next 3/3] net: sched: add helper support in act_ct

2022-10-06 Thread Paolo Abeni
On Tue, 2022-10-04 at 21:19 -0400, Xin Long wrote: > This patch is to add helper support in act_ct for OVS actions=ct(alg=xxx) > offloading, which is corresponding to Commit cae3a2627520 ("openvswitch: > Allow attaching helpers to ct action") in OVS kernel part. > > The difference is when adding

Re: [ovs-dev] [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

2022-09-25 Thread Paolo Abeni
; be removed. However, just in case there is something still depending > on this behavior, issue a WARN and fall back to as before to ksize() > which means we'll also potentially get KASAN warnings. > > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc

Re: [ovs-dev] [PATCH 1/2] net: openvswitch: allow metering in non-initial user namespace

2022-09-20 Thread Paolo Abeni
On Sun, 2022-09-11 at 19:38 +0200, Michael Weiß wrote: > The Netlink interface for metering was restricted to global CAP_NET_ADMIN > by using GENL_ADMIN_PERM. To allow metring in a non-inital user namespace, > e.g., a container, this is changed to GENL_UNS_ADMIN_PERM. > > Signed-off-by: Michael

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Paolo Abeni
On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote: > On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > > IMO to encourage use of the track-capable API we could keep their names > > > short and call the legacy functions __netdev_hold() as I

Re: [ovs-dev] [PATCH] openvswitch: meter: Remove unnecessary int

2022-04-21 Thread Paolo Abeni
On Mon, 2022-04-18 at 00:50 +, Solomon Tan wrote: > This patch addresses the checkpatch.pl warning that long long is > preferred over long long int. Please don't do that. This kind of changes cause e.g. backporting issue for any later relevant bugfix touching the same area, for no real

Re: [ovs-dev] [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread Paolo Abeni
.@syzkaller.appspotmail.com > Reported-by: syzbot+f612c02823acb02ff...@syzkaller.appspotmail.com > Signed-off-by: Tonghao Zhang Acked-by: Paolo Abeni ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next] net: openvswitch: reorder masks array based on usage

2020-07-15 Thread Paolo Abeni
> > Kernel without this patch : 7.71 Gbps > Kernel with this patch applied: 14.52 Gbps > > We also run some tests to verify the rebalance activity does not > lower the flow insertion rate, which does not. > > Signed-off-by: Eelco Chaudron >

[ovs-dev] [PATCH v2] netdev-tc-offloads: update stats properly on flow deletion

2017-11-17 Thread Paolo Abeni
) CC: Paul Blakey <pa...@mellanox.com> Reported-by: Kumar Sanghvi <kuma...@chelsio.com> Signed-off-by: Paolo Abeni <pab...@redhat.com> --- v1 -> v2: - ensure to always clear stats if tc_get_flower() fails for some reasons --- lib/netdev-tc-offloads.c | 13 ++--- 1 fi

[ovs-dev] [PATCH] netdev-tc-offloads: update stats properly on flow deletion

2017-11-07 Thread Paolo Abeni
filter, as currently done by others DP providers. Fixes: 30b6b047260b ("netdev-tc-offloads: Implement netdev flow del using tc interface") CC: Paul Blakey <pa...@mellanox.com> Reported-by: Kumar Sanghvi <kuma...@chelsio.com> Signed-off-by: Paolo Abeni <pab...@redha