Re: [ovs-dev] Restore flows is slow using "ovs-save", is there someone who use RPC to speed up flow restore?

2017-11-24 Thread Timothy M. Redaelli
On 11/24/2017 04:07 AM, Sam wrote: > Hi all, > > I'm working on speed up ovs restart, I found that restore flows is slow > when there are lots of flows, so I want to use RPC to store flows in > another process, and then restore from it. > > Is there someone who have worked on this? could you

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-11-03 Thread Timothy M. Redaelli
On 11/03/2017 07:20 PM, Ben Pfaff wrote: [...] >> >> This looks good to me, my only comment is that the script is in rhel/ >> and uses systemd so maybe we should reflect that in the script's name? >> Because OVS itself might provide an ovs-reload too and then we will >> have issues. >> >> What do

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-26 Thread Timothy M. Redaelli
On 09/22/2017 03:44 PM, Aaron Conole wrote: > When the logrotate script runs, and Open vSwitch is running as a non-root > user, the /var/log/openvswitch directory doesn't have other rx bits set. > This means the reopen attempt will fail with "permission denied", even though > the default logrotate

Re: [ovs-dev] [PATCH] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

2017-09-25 Thread Timothy M. Redaelli
On 09/23/2017 01:09 AM, Flavio Leitner wrote: [...] > > Where is $workdir set? Looks like it's empty and will use root fs. > > Although this is a small patch, it actually does two things. One is > fixing to use highest enabled OF and another is replacing echo with > printf. > > I suggest to

Re: [ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

2017-08-28 Thread Timothy M. Redaelli
On 08/11/2017 07:12 PM, Aaron Conole wrote: > Timothy Redaelli writes: > >> Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. >> >> This feature can be disabled by appending --no-delete-transient-ports-on-boot >> to OPTIONS in /etc/sysconfig/openvswitch >>

Re: [ovs-dev] [PATCH] netdev-dpdk: include dpdk PCI header directly

2017-08-10 Thread Timothy M. Redaelli
On 08/09/2017 10:00 PM, Aaron Conole wrote: > As part of a devargs rework in DPDK, the PCI header file was removed, and > needs to be directly included. This isn't required to build with 17.05 or > earlier, but will be required should a future update happen. > > Signed-off-by: Aaron Conole

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-08 Thread Timothy M. Redaelli
On 08/08/2017 08:24 PM, Guru Shetty wrote: > > > On 8 August 2017 at 11:05, Russell Bryant > wrote: > > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty > wrote: > > On 8 August 2017 at 07:42, Timothy

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-08-01 Thread Timothy M. Redaelli
On 07/25/2017 02:34 PM, Michal Weglicki wrote: Upgrading to DPDK 17.05.1 stable release adds new significant features relevant to OVS, including, but not limited to: - tun/tap PMD, - VFIO hotplug support, - Generic flow API. Following changes are applied: - netdev-dpdk: Changes required by DPDK

Re: [ovs-dev] [PATCH v2] netdev: check for NULL fields in netdev_get_addrs

2017-07-19 Thread Timothy M. Redaelli
On 07/18/2017 05:25 PM, Daniel Alvarez Sanchez wrote: > When the interfaces list is retrieved through getiffaddrs(), there > might be elements with iface_name set to NULL. > > This patch checks ifa_name to be not NULL before comparing it to the > actual device name in the loop that calculates how

Re: [ovs-dev] [PATCH] tests: Disable no-format-truncation warnings

2017-07-14 Thread Timothy M. Redaelli
On 07/13/2017 07:21 PM, Ben Pfaff wrote: > On Thu, Jul 13, 2017 at 04:29:33PM +0200, Timothy Redaelli wrote: >> test_snprintf function (tests/test-util.c) tests snprintf with shorter >> length, >> but this emit a warning on GCC 7.0 or later. >> >> This commit disables that warning on tests only.

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-11 Thread Timothy M. Redaelli
On 07/05/2017 11:19 AM, Christian Ehrhardt wrote: > If available use dpdk pkg-config info of libdpdk to set the right > include paths. > That for example, allows packagers to provide non default include > paths in a common way (pkg-config). I like the idea, but I think it's better to wait for

Re: [ovs-dev] [PATCH v2 4/4] redhat: allow dpdk to also run as non-root user

2017-07-06 Thread Timothy M. Redaelli
Hi Aaron, On 07/05/2017 07:56 PM, Aaron Conole wrote: > After this commit, users may start a dpdk-enabled ovs setup as a > non-root user. This is accomplished by exporting the $HOME directory, > which dpdk uses to fill in it's semi-persistent RTE configuration. > > This change may be a bit

Re: [ovs-dev] [PATCH 2/2] rhel: delete transient ports on boot when starting ovsdb-server

2017-05-08 Thread Timothy M. Redaelli
On 05/05/2017 08:41 PM, Aaron Conole wrote: [...] >> @@ -534,7 +538,7 @@ fi >> %doc COPYING NOTICE README.rst NEWS rhel/README.RHEL.rst >> /var/lib/openvswitch >> /var/log/openvswitch >> -%ghost %attr(755,root,root) %{_rundir}/openvswitch >> +%dir %{_rundir}/openvswitch > > Doesn't this still

Re: [ovs-dev] [PATCH] tests/ofproto.at: Workaround some races

2017-05-04 Thread Timothy M. Redaelli
On 05/03/2017 10:28 PM, Ben Pfaff wrote: > On Thu, Apr 27, 2017 at 05:24:22PM +0200, Timothy Redaelli wrote: >> Port commit a6d1a2997db4: >> ofproto.at: Workaround a race >> >> While a barrier serializes requests from the same connection, >> it doesn't wait for requests from other

Re: [ovs-dev] [PATCH 4/8] ovsdb-idl: Fix memory leak

2017-04-26 Thread Timothy M. Redaelli
On 04/24/2017 06:30 PM, Ben Pfaff wrote: > On Fri, Apr 07, 2017 at 02:43:42PM -0700, Yi-Hung Wei wrote: >> In testcase "simple idl, conditional, multiple clauses in condition - C", >> valgrind reports a memory leak with the following call stack. >> xmalloc (util.c:112) >> resize

Re: [ovs-dev] [PATCH] ofproto: Report only un-deleted groups in group stats replies.

2017-04-20 Thread Timothy M. Redaelli
On 04/19/2017 08:29 PM, Ben Pfaff wrote: > Deleted groups hang around in the group table until the next grace period, > so it's important for the group stats code to pretend that they're gone > until they really get deleted. [...] Thank you for the patch, I tested it in all the scenarios and it

Re: [ovs-dev] [PATCH] m4: Add hard requirements for python in "configure"

2017-04-06 Thread Timothy M. Redaelli
On 04/06/2017 12:16 AM, Ben Pfaff wrote: > On Wed, Mar 29, 2017 at 01:49:42PM +0200, Timothy Redaelli wrote: >> Since Python 2.7 and python-six are needed to build Open vSwitch, >> ./configure should return an error if they are missing or if they are too old >> >> Signed-off-by: Timothy Redaelli