Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

> On Jan 25, 2018, at 12:36 PM, Aaron Conole wrote: > > Because more voices of support are better - I am in favor of this > change. > > I agree with the sentiment that checkpatch is meant to help bring things > to light that humans sometimes glaze over (we all develop our

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

Justin Pettit writes: >> On Jan 25, 2018, at 10:26 AM, Stokes, Ian wrote: >> >>> Yes, this was my thinking too. I don't think we should have a prohibition >>> against using "xxx", but I do usually see it in patches as something that >>> was left behind

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

> On Jan 25, 2018, at 10:26 AM, Stokes, Ian wrote: > >> Yes, this was my thinking too. I don't think we should have a prohibition >> against using "xxx", but I do usually see it in patches as something that >> was left behind unintentionally. That said, my personal

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

un...@openvswitch.org] On Behalf Of Justin Pettit > >>> Sent: Wednesday, January 24, 2018 2:31 AM > >>> To: d...@openvswitch.org > >>> Subject: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in > comments. > >>> > >>&g

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

ehalf Of Justin Pettit >>> Sent: Wednesday, January 24, 2018 2:31 AM >>> To: d...@openvswitch.org >>> Subject: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments. >>> >>> "xxx" is often used to indicate items that t

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

..@openvswitch.org > > Subject: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments. > > > > "xxx" is often used to indicate items that the developer wanted to look at > > again before committing. Flag those as a warning. > > Does this me

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Justin Pettit > Sent: Wednesday, January 24, 2018 2:31 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx&

[ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

"xxx" is often used to indicate items that the developer wanted to look at again before committing. Flag those as a warning. Signed-off-by: Justin Pettit --- utilities/checkpatch.py | 16 1 file changed, 16 insertions(+) diff --git a/utilities/checkpatch.py