Re: [ovs-dev] [PATCH] dpif-netdev: Simplify atomic function pointer stores

2022-03-11 Thread Ilya Maximets
On 2/21/22 17:01, Cian Ferriter wrote: > The same pattern for atomic stores and initialization was used for the > DPIF and MFEX function pointers declared in struct dp_netdev_pmd_thread. > Simplify this pattern for all stores to 'miniflow_extract_opt' and > 'netdev_input_func'. > > Also replace

Re: [ovs-dev] [PATCH] dpif-netdev: Simplify atomic function pointer stores

2022-02-22 Thread Ferriter, Cian
Hi Amber, Thanks for reviewing and Acking! > -Original Message- > From: Amber, Kumar > Sent: Tuesday 22 February 2022 06:15 > To: ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian > Subject: RE: [PATCH] dpif-netdev: Simplify atomic function pointer stores > > Hi Cian,

Re: [ovs-dev] [PATCH] dpif-netdev: Simplify atomic function pointer stores

2022-02-21 Thread Amber, Kumar
Hi Cian, Thanks for the Patch. I have tested the patch and reviewed as well. One small minor comment . > +atomic_store_relaxed(>miniflow_extract_opt, > +miniflow_funcs[MFEX_IMPL_SCALAR].extract_func); > VLOG_INFO("Not enough packets matched (%u/%u),

[ovs-dev] [PATCH] dpif-netdev: Simplify atomic function pointer stores

2022-02-21 Thread Cian Ferriter
The same pattern for atomic stores and initialization was used for the DPIF and MFEX function pointers declared in struct dp_netdev_pmd_thread. Simplify this pattern for all stores to 'miniflow_extract_opt' and 'netdev_input_func'. Also replace the first store to 'miniflow_extract_opt' which was