Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-06 Thread Eric Garver
_BE16_MAX); > } > goto unencap; > } > > nl_msg_put_be16(buf, OVS_KEY_ATTR_ETHERTYPE, data->dl_type); > > -Original Message- > From: Zoltán Balogh [mailto:zoltan.bal...@ericsson.com] > Sent: Wednesday, July 5, 2017 5:25 AM > To: Yang, Yi Y

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-06 Thread Yang, Yi Y
zoltan.bal...@ericsson.com] Sent: Wednesday, July 5, 2017 5:25 AM To: Yang, Yi Y <yi.y.y...@intel.com>; Eric Garver <e...@erig.me> Cc: 'd...@openvswitch.org' <d...@openvswitch.org>; Jan Scheurich <jan.scheur...@ericsson.com> Subject: RE: [ovs-dev] [PATCH] dpif-netilnk: con

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-04 Thread Zoltán Balogh
2017 2:10 AM > To: Eric Garver <e...@erig.me>; Zoltán Balogh <zoltan.bal...@ericsson.com> > Cc: 'd...@openvswitch.org' <d...@openvswitch.org> > Subject: RE: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink > attribute > > Zoltan, I tested this

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-04 Thread Zoltán Balogh
.org' <d...@openvswitch.org> > Subject: RE: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink > attribute > > Zoltan, I tested this patch for net-next, it will result in failure by > ovs_assert, in addition, we need to handle > OVS_FLOW_ATTR_MASK and OVS_FLO

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-04 Thread Zoltán Balogh
Subject: Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink > attribute > > On Mon, Jul 03, 2017 at 02:27:18PM +, Zoltán Balogh wrote: > > By introducing packet type-aware pipeline, match on ethertype was > > removed when packet type is not Ethernet. As poi

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-03 Thread Yang, Yi Y
> Subject: Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute On Mon, Jul 03, 2017 at 02:27:18PM +, Zoltán Balogh wrote: > By introducing packet type-aware pipeline, match on ethertype was > removed when packet type is not Ethernet. As pointed out by Eric > Ga

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-03 Thread Eric Garver
On Mon, Jul 03, 2017 at 02:27:18PM +, Zoltán Balogh wrote: > By introducing packet type-aware pipeline, match on ethertype was > removed when packet type is not Ethernet. As pointed out by Eric Garver, > this could have a side effect on the kernel datapath: >

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-03 Thread Eric Garver
On Mon, Jul 03, 2017 at 02:27:18PM +, Zoltán Balogh wrote: > By introducing packet type-aware pipeline, match on ethertype was > removed when packet type is not Ethernet. As pointed out by Eric Garver, > this could have a side effect on the kernel datapath: >

[ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

2017-07-03 Thread Zoltán Balogh
By introducing packet type-aware pipeline, match on ethertype was removed when packet type is not Ethernet. As pointed out by Eric Garver, this could have a side effect on the kernel datapath: https://patchwork.ozlabs.org/patch/782991/ This patch does approach the problem from a different