Re: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

2017-08-08 Thread Joe Stringer
On 8 August 2017 at 16:10, Ben Pfaff wrote: > On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote: >> If a libopenvswitch user includes ofp-print.h before ofp-util.h (which >> is standard alphabetical order), and turns on -Werror, then they would >> hit this compilation error in the inclu

Re: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

2017-08-08 Thread Ben Pfaff
On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote: > If a libopenvswitch user includes ofp-print.h before ofp-util.h (which > is standard alphabetical order), and turns on -Werror, then they would > hit this compilation error in the include: > > error: 'struct ofputil_port_map' declared

[ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

2017-08-08 Thread Joe Stringer
If a libopenvswitch user includes ofp-print.h before ofp-util.h (which is standard alphabetical order), and turns on -Werror, then they would hit this compilation error in the include: error: 'struct ofputil_port_map' declared inside parameter list will not be visible outside of this definition or