Re: [ovs-dev] [PATCH] ofp-parse: Support "igmp" keyword in flows.

2020-12-16 Thread Flavio Leitner
On Wed, Nov 04, 2020 at 05:33:27PM +0100, Ilya Maximets wrote: > On 11/3/20 5:46 PM, Ben Pfaff wrote: > > On Tue, Nov 03, 2020 at 03:53:51AM +0100, Ilya Maximets wrote: > >> On 11/3/20 12:28 AM, Ben Pfaff wrote: > >>> match_format() prints out "igmp" for IGMP flows, but > >>> ofp_parse_protocol()

Re: [ovs-dev] [PATCH] ofp-parse: Support "igmp" keyword in flows.

2020-11-04 Thread Ilya Maximets
On 11/3/20 5:46 PM, Ben Pfaff wrote: > On Tue, Nov 03, 2020 at 03:53:51AM +0100, Ilya Maximets wrote: >> On 11/3/20 12:28 AM, Ben Pfaff wrote: >>> match_format() prints out "igmp" for IGMP flows, but >>> ofp_parse_protocol() didn't accept it, which meant that OVS would print >>> out a flow that it

Re: [ovs-dev] [PATCH] ofp-parse: Support "igmp" keyword in flows.

2020-11-03 Thread Ben Pfaff
On Tue, Nov 03, 2020 at 03:53:51AM +0100, Ilya Maximets wrote: > On 11/3/20 12:28 AM, Ben Pfaff wrote: > > match_format() prints out "igmp" for IGMP flows, but > > ofp_parse_protocol() didn't accept it, which meant that OVS would print > > out a flow that it wouldn't re-parse. This fixes the

Re: [ovs-dev] [PATCH] ofp-parse: Support "igmp" keyword in flows.

2020-11-02 Thread Ilya Maximets
On 11/3/20 12:28 AM, Ben Pfaff wrote: > match_format() prints out "igmp" for IGMP flows, but > ofp_parse_protocol() didn't accept it, which meant that OVS would print > out a flow that it wouldn't re-parse. This fixes the problem and adds > a test. I'm a bit confused. IIUC, matching on igmp is

[ovs-dev] [PATCH] ofp-parse: Support "igmp" keyword in flows.

2020-11-02 Thread Ben Pfaff
match_format() prints out "igmp" for IGMP flows, but ofp_parse_protocol() didn't accept it, which meant that OVS would print out a flow that it wouldn't re-parse. This fixes the problem and adds a test. Signed-off-by: Ben Pfaff --- lib/ofp-parse.c| 1 + tests/ovs-ofctl.at | 2 ++ 2 files