Re: [ovs-dev] [PATCH] ovs-atomic: __GNUC__ == 4 is enough

2020-09-21 Thread Linhaifeng
> > On 9/19/20 8:08 AM, Linhaifeng wrote: > > 1. include config.h to avoid include different atomic head file > > All .c files should include config.h as their first include, so config.h > should always > be already included at the time we including ovs-atomic.h. Do you know the .c > file

Re: [ovs-dev] [PATCH] ovs-atomic: __GNUC__ == 4 is enough

2020-09-21 Thread Ilya Maximets
On 9/19/20 8:08 AM, Linhaifeng wrote: > 1. include config.h to avoid include different atomic head file All .c files should include config.h as their first include, so config.h should always be already included at the time we including ovs-atomic.h. Do you know the .c file that doesn't include

[ovs-dev] [PATCH] ovs-atomic: __GNUC__ == 4 is enough

2020-09-19 Thread Linhaifeng
1. include config.h to avoid include different atomic head file 2. __GNUC__ == 4 is enough Fixes: 31a3fc6e3e9c ("ovs-atomic: New library for atomic operations.") Cc: b...@nicira.com Signed-off-by: Linhaifeng --- lib/ovs-atomic.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff