Re: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-06-02 Thread Yanqin Wei
org > Cc: nd > Subject: RE: [PATCH] ovs rcu: update rcu pointer first > > Hi Haifeng, > > It looks indeed a risk for using ovs-rcu. A few comments inline. > > Best Regards, > Wei Yanqin > > > -Original Message- > > From: dev On Behalf Of L

Re: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-06-02 Thread Linhaifeng
, It looks indeed a risk for using ovs-rcu. A few comments inline. Best Regards, Wei Yanqin > -Original Message- > From: dev On Behalf Of Linhaifeng > Sent: Monday, June 1, 2020 11:13 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

Re: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-06-01 Thread Yanqin Wei
Hi Haifeng, It looks indeed a risk for using ovs-rcu. A few comments inline. Best Regards, Wei Yanqin > -Original Message- > From: dev On Behalf Of Linhaifeng > Sent: Monday, June 1, 2020 11:13 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] ovs rcu: update rc

[ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-05-31 Thread Linhaifeng
We should update rcu pointer first then use ovsrcu_postpone to free otherwise maybe cause use-after-free. e.g, thead are two threads A and B: 1. thread A call ovsrcu_postpone and flush cbset, this time have not call ovsrcu_quiesce 2. thread rcu wait all threads call ovsrcu_quiesce 3. thread B

Re: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-05-31 Thread 0-day Robot
Bleep bloop. Greetings Linhaifeng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Linhaifeng needs to sign off. WARNING: Unexpected sign-offs from developers who

[ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-05-31 Thread Linhaifeng
We should update rcu pointer first then use ovsrcu_postpone to free otherwise maybe cause use-after-free. e.g, thead are two threads, A and B: 1. thread A call ovsrcu_postpone and flush cbset, have not call ovsrcu_quiesce 2. thread rcu wait all threads call ovsrcu_quiesce 3. thread B call