Re: [ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU unit tests.

2022-07-26 Thread Aaron Conole
Ilya Maximets writes: > On 7/20/22 18:26, Michael Phelan wrote: >> The MTU vport unit tests do not clean up testpmd after use which causes them >> to fail randomly. >> This commit amends the MTU vport unit tests to clean up testpmd after >> running. >> >> Fixes:

Re: [ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU unit tests.

2022-07-22 Thread Ilya Maximets
On 7/20/22 18:26, Michael Phelan wrote: > The MTU vport unit tests do not clean up testpmd after use which causes them > to fail randomly. > This commit amends the MTU vport unit tests to clean up testpmd after running. > > Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS-DPDK

Re: [ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU unit tests.

2022-07-22 Thread Pai G, Sunil
Hi Mike, Amber, Thanks for working on this. Couple of comments below, rest looks good. > -Original Message- > From: dev On Behalf Of Amber, Kumar > Sent: Friday, July 22, 2022 2:36 PM > To: d...@openvswitch.org > Cc: Ilya Maximets > Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU unit tests.

2022-07-22 Thread Amber, Kumar
Hi Michael, The Regression looks good, and the patch looks good too. Regression CI runs are added as Screenshots. Acked-by: Kumar Amber > -Original Message- > From: Phelan, Michael > > Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS- > DPDK > > MTU unit tests.") >

[ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU unit tests.

2022-07-20 Thread Michael Phelan
The MTU vport unit tests do not clean up testpmd after use which causes them to fail randomly. This commit amends the MTU vport unit tests to clean up testpmd after running. Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS-DPDK MTU unit tests.") Signed-off-by: Michael Phelan