Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

2017-08-02 Thread Andy Zhou
On Wed, Aug 2, 2017 at 8:56 AM, Ben Pfaff wrote: > This inner 'xcfg' shadowed the outer one and could have read a different > value if 'xcfgp' was changing, so this is possibly a bug fix. > > Found by -Wshadow=local in GCC 7. > > Signed-off-by: Ben Pfaff Acked-by:

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

2017-08-02 Thread Ben Pfaff
This inner 'xcfg' shadowed the outer one and could have read a different value if 'xcfgp' was changing, so this is possibly a bug fix. Found by -Wshadow=local in GCC 7. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 1 - 1 file changed, 1 deletion(-) diff --git