Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 7 Jun 2022 21:39:55 -0700 you wrote: > Netdev reference helpers have a dev_ prefix for historic > reasons. Renaming the old helpers would be too much churn > but we can rename the tracking ones which are

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Eric Dumazet via dev
On Thu, Jun 9, 2022 at 4:50 AM Paolo Abeni wrote: > > On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote: > > On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > > > > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > > > IMO to encourage use of the track-capable API we could keep their names

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread David Ahern
On 6/8/22 8:58 AM, Jakub Kicinski wrote: > IMO to encourage use of the track-capable API we could keep their names > short and call the legacy functions __netdev_hold() as I mentioned or > maybe netdev_hold_notrack(). I like that option. Similar to the old nla_parse functions that were renamed

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Eric Dumazet via dev
On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > IMO to encourage use of the track-capable API we could keep their names > > short and call the legacy functions __netdev_hold() as I mentioned or > > maybe netdev_hold_notrack(). > > I like that

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread Paolo Abeni
On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote: > On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > > IMO to encourage use of the track-capable API we could keep their names > > > short and call the legacy functions __netdev_hold() as I

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-08 Thread Jiri Pirko
Wed, Jun 08, 2022 at 04:58:27PM CEST, k...@kernel.org wrote: >On Wed, 8 Jun 2022 10:27:15 +0200 Jiri Pirko wrote: >> Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote: >> >Netdev reference helpers have a dev_ prefix for historic >> >reasons. Renaming the old helpers would be too much

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-08 Thread Jakub Kicinski
On Wed, 8 Jun 2022 16:58:08 -0600 David Ahern wrote: > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > IMO to encourage use of the track-capable API we could keep their names > > short and call the legacy functions __netdev_hold() as I mentioned or > > maybe netdev_hold_notrack(). > > I like that

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-08 Thread Jiri Pirko
Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote: >Netdev reference helpers have a dev_ prefix for historic >reasons. Renaming the old helpers would be too much churn Hmm, I think it would be great to eventually rename the rest too in order to maintain unique prefix for netdev things.

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-08 Thread Jakub Kicinski
On Wed, 8 Jun 2022 10:27:15 +0200 Jiri Pirko wrote: > Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote: > >Netdev reference helpers have a dev_ prefix for historic > >reasons. Renaming the old helpers would be too much churn > > Hmm, I think it would be great to eventually rename the

[ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-07 Thread Jakub Kicinski
Netdev reference helpers have a dev_ prefix for historic reasons. Renaming the old helpers would be too much churn but we can rename the tracking ones which are relatively recent and should be the default for new code. Rename: dev_hold_track()-> netdev_hold() dev_put_track() ->