On Wed, 9 Mar 2022 14:43:07 +0100 Ilya Maximets wrote:
> >> It's a bit of an uncharted territory, hard to say what's right.
> >> It may be a little easier to code up the rejection if we have
> >> the types defined (which I think we need to do in
> >> __parse_flow_nlattrs()? seems OvS does its own
On 3/9/22 08:49, Roi Dayan wrote:
>
>
> On 2022-03-08 10:16 PM, Jakub Kicinski wrote:
>> On Tue, 8 Mar 2022 20:33:12 +0100 Ilya Maximets wrote:
>>> On 3/8/22 17:17, Jakub Kicinski wrote:
On Tue, 8 Mar 2022 15:12:45 +0100 Ilya Maximets wrote:
> Yes, that is something that I had in mind
On 2022-03-08 10:16 PM, Jakub Kicinski wrote:
On Tue, 8 Mar 2022 20:33:12 +0100 Ilya Maximets wrote:
On 3/8/22 17:17, Jakub Kicinski wrote:
On Tue, 8 Mar 2022 15:12:45 +0100 Ilya Maximets wrote:
Yes, that is something that I had in mind too. The only thing that makes
me uncomfortable is
On Tue, 8 Mar 2022 19:25:31 +0100 Ilya Maximets wrote:
> > since its rc7 we end up with kernel and ovs broken with each other.
> > can we revert the kernel patches anyway and introduce them again later
> > when ovs userspace is also updated?
>
> I don't think this patch is part of 5-17-rc7.
On Tue, 8 Mar 2022 20:33:12 +0100 Ilya Maximets wrote:
> On 3/8/22 17:17, Jakub Kicinski wrote:
> > On Tue, 8 Mar 2022 15:12:45 +0100 Ilya Maximets wrote:
> >> Yes, that is something that I had in mind too. The only thing that makes
> >> me uncomfortable is OVS_KEY_ATTR_TUNNEL_INFO = 30 here.
On 3/8/22 17:17, Jakub Kicinski wrote:
> On Tue, 8 Mar 2022 15:12:45 +0100 Ilya Maximets wrote:
diff --git a/include/uapi/linux/openvswitch.h
b/include/uapi/linux/openvswitch.h
index 9d1710f20505..ab6755621e02 100644
--- a/include/uapi/linux/openvswitch.h
+++
On 3/8/22 15:39, Roi Dayan wrote:
>
>
> On 2022-03-08 4:12 PM, Ilya Maximets wrote:
>> On 3/8/22 09:21, Johannes Berg wrote:
>>> On Mon, 2022-03-07 at 21:45 -0800, Jakub Kicinski wrote:
Let me add some people I associate with genetlink work in my head
(fairly or not) to keep me
On Tue, 8 Mar 2022 15:12:45 +0100 Ilya Maximets wrote:
> >> diff --git a/include/uapi/linux/openvswitch.h
> >> b/include/uapi/linux/openvswitch.h
> >> index 9d1710f20505..ab6755621e02 100644
> >> --- a/include/uapi/linux/openvswitch.h
> >> +++ b/include/uapi/linux/openvswitch.h
> >> @@ -351,11
On 2022-03-08 4:12 PM, Ilya Maximets wrote:
On 3/8/22 09:21, Johannes Berg wrote:
On Mon, 2022-03-07 at 21:45 -0800, Jakub Kicinski wrote:
Let me add some people I associate with genetlink work in my head
(fairly or not) to keep me fair here.
:)
It's highly unacceptable for user space
On 3/8/22 09:21, Johannes Berg wrote:
> On Mon, 2022-03-07 at 21:45 -0800, Jakub Kicinski wrote:
>>
>> Let me add some people I associate with genetlink work in my head
>> (fairly or not) to keep me fair here.
>
> :)
>
>> It's highly unacceptable for user space to straight up rewrite kernel
>>
On Mon, 2022-03-07 at 21:45 -0800, Jakub Kicinski wrote:
>
> Let me add some people I associate with genetlink work in my head
> (fairly or not) to keep me fair here.
:)
> It's highly unacceptable for user space to straight up rewrite kernel
> uAPI types
>
Agree.
> but if it already happened
On Tue, 8 Mar 2022 01:04:00 +0100 Ilya Maximets wrote:
> > Thanks for the explanation, we can apply a revert if that'd help your
> > CI / ongoing development but sounds like the fix really is in user
> > space. Expecting netlink attribute lists not to grow is not fair.
>
> I don't think it was
On 3/7/22 23:46, Jakub Kicinski wrote:
> On Mon, 7 Mar 2022 23:14:13 +0100 Ilya Maximets wrote:
>> The main problem is that userspace uses the modified copy of the uapi header
>> which looks like this:
>>
>>
On Mon, 7 Mar 2022 23:14:13 +0100 Ilya Maximets wrote:
> The main problem is that userspace uses the modified copy of the uapi header
> which looks like this:
>
>
On 3/7/22 21:26, Jakub Kicinski wrote:
> On Mon, 7 Mar 2022 10:49:31 +0200 Roi Dayan wrote:
I think there is a missing userspace fix. didnt verify yet.
but in ovs userspace odp-netlink.h created from
datapath/linux/compat/include/linux/openvswitch.h
and that file is not synced
On Mon, 7 Mar 2022 10:49:31 +0200 Roi Dayan wrote:
> >> I think there is a missing userspace fix. didnt verify yet.
> >> but in ovs userspace odp-netlink.h created from
> >> datapath/linux/compat/include/linux/openvswitch.h
> >> and that file is not synced the change here.
> >> So the new enum
On 2022-03-02 3:59 PM, Eelco Chaudron wrote:
On 2 Mar 2022, at 11:50, Roi Dayan wrote:
On 2022-03-02 12:03 PM, Roi Dayan wrote:
On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed,
On 2 Mar 2022, at 11:50, Roi Dayan wrote:
> On 2022-03-02 12:03 PM, Roi Dayan wrote:
>>
>>
>> On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
>>> Hello:
>>>
>>> This patch was applied to netdev/net-next.git (master)
>>> by David S. Miller :
>>>
>>> On Wed, 23 Feb 2022 16:54:09
On 2022-03-02 12:03 PM, Roi Dayan wrote:
On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 23 Feb 2022 16:54:09 -0800 you wrote:
This change adds a new OpenFlow field
On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 23 Feb 2022 16:54:09 -0800 you wrote:
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 23 Feb 2022 16:54:09 -0800 you wrote:
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> packets can be filtered using ipv6_ext flag.
>
> Signed-off-by: Toms Atteka
> Acked-by: Pravin B
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using ipv6_ext flag.
Signed-off-by: Toms Atteka
Acked-by: Pravin B Shelar
---
include/uapi/linux/openvswitch.h | 6 ++
net/openvswitch/flow.c | 140 +++
On Wed, 9 Feb 2022 12:46:01 -0800 Cpp Code wrote:
> > ok, I see advantage of using skb_header_pointer() in this case, but
> > replacing all check_header() with skb_header_pointer() would add lot
> > of copy operation in flow extract. Anyways for this use case
> > skb_header_pointer() is fine.
> >
On Thu, Dec 9, 2021 at 11:36 PM Pravin Shelar wrote:
>
> ()
>
> On Mon, Dec 6, 2021 at 3:00 PM Cpp Code wrote:
> >
> > On Thu, Dec 2, 2021 at 9:28 PM Pravin Shelar wrote:
> > >
> > > On Thu, Dec 2, 2021 at 12:20 PM Cpp Code wrote:
> > > >
> > > > On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar
()
On Mon, Dec 6, 2021 at 3:00 PM Cpp Code wrote:
>
> On Thu, Dec 2, 2021 at 9:28 PM Pravin Shelar wrote:
> >
> > On Thu, Dec 2, 2021 at 12:20 PM Cpp Code wrote:
> > >
> > > On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar
> > > wrote:
> > > >
> > > > On Wed, Nov 24, 2021 at 11:33 AM Toms
On Thu, Dec 2, 2021 at 9:28 PM Pravin Shelar wrote:
>
> On Thu, Dec 2, 2021 at 12:20 PM Cpp Code wrote:
> >
> > On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar wrote:
> > >
> > > On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka
> > > wrote:
> > > >
> > > > This change adds a new OpenFlow field
On Thu, Dec 2, 2021 at 12:20 PM Cpp Code wrote:
>
> On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar wrote:
> >
> > On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka wrote:
> > >
> > > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> > > packets can be filtered using ipv6_ext flag.
>
On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar wrote:
>
> On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka wrote:
> >
> > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> > packets can be filtered using ipv6_ext flag.
> >
> > Signed-off-by: Toms Atteka
> > ---
> >
On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka wrote:
>
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> packets can be filtered using ipv6_ext flag.
>
> Signed-off-by: Toms Atteka
> ---
> include/uapi/linux/openvswitch.h | 6 ++
> net/openvswitch/flow.c | 140
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using ipv6_ext flag.
Signed-off-by: Toms Atteka
---
include/uapi/linux/openvswitch.h | 6 ++
net/openvswitch/flow.c | 140 +++
net/openvswitch/flow.h | 14
On Fri, 29 Oct 2021 11:20:08 -0700 Toms Atteka wrote:
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> packets can be filtered using ipv6_ext flag.
>
> Signed-off-by: Toms Atteka
Hi! This patch didn't get reviewed in time for the v5.16 merge window,
please continue the work
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using ipv6_ext flag.
Signed-off-by: Toms Atteka
---
include/uapi/linux/openvswitch.h | 6 ++
net/openvswitch/flow.c | 140 +++
net/openvswitch/flow.h | 14
32 matches
Mail list logo
