Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-12 Thread Aaron Conole
Simon Horman writes: > On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote: > > ... > >> >> We moved the per cpu upcall counter allocation to the existing vport >> >> alloc and free functions to solve this. >> >> >> >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-08 Thread Simon Horman
On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote: ... > >> We moved the per cpu upcall counter allocation to the existing vport > >> alloc and free functions to solve this. > >> > >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on > >> failure") > >> Fixes:

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Tue, 6 Jun 2023 13:56:35 +0200 you wrote: > Currently, the per cpu upcall counters are allocated after the vport is > created and inserted into the system. This could lead to the datapath > accessing the counters

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-07 Thread Eelco Chaudron
On 7 Jun 2023, at 3:05, wangchuanlei wrote: > Thanks for fix this, in common enviroment, it's a > small probability event. Well, on ARM, they could replicate it a couple of times, but I guess the system was under memory pressure and has a lot of cores. >> Eelco Chaudron writes: > >>

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread wangchuanlei
Thanks for fix this, in common enviroment, it's a small probability event. > Eelco Chaudron writes: > Currently, the per cpu upcall counters are allocated after the vport > is created and inserted into the system. This could lead to the > datapath accessing the counters before they are

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread Aaron Conole
Eelco Chaudron writes: > Currently, the per cpu upcall counters are allocated after the vport is > created and inserted into the system. This could lead to the datapath > accessing the counters before they are allocated resulting in a kernel > Oops. > > Here is an example: > > PID: 59693

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread Simon Horman
On Tue, Jun 06, 2023 at 01:56:35PM +0200, Eelco Chaudron wrote: > Currently, the per cpu upcall counters are allocated after the vport is > created and inserted into the system. This could lead to the datapath > accessing the counters before they are allocated resulting in a kernel > Oops. > >

[ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread Eelco Chaudron
Currently, the per cpu upcall counters are allocated after the vport is created and inserted into the system. This could lead to the datapath accessing the counters before they are allocated resulting in a kernel Oops. Here is an example: PID: 59693TASK: 0005f4f51500 CPU: 0