Re: [ovs-dev] [PATCH v24 4/8] netdev-offload-tc: Add sFlow offload API for TC

2023-03-22 Thread Eelco Chaudron
On 22 Mar 2023, at 7:21, Chris Mi wrote: > On 3/16/2023 5:13 PM, Eelco Chaudron wrote: >> On 1 Mar 2023, at 8:22, Chris Mi wrote: >> >>> Initialize psample socket. Add sFlow recv API to receive sampled >>> packets from psample socket. Add sFow recv wait API to add psample >>> socket fd to poll

Re: [ovs-dev] [PATCH v24 4/8] netdev-offload-tc: Add sFlow offload API for TC

2023-03-22 Thread Chris Mi via dev
On 3/16/2023 5:13 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: Initialize psample socket. Add sFlow recv API to receive sampled packets from psample socket. Add sFow recv wait API to add psample socket fd to poll list. See some comments inline below. and one question for

Re: [ovs-dev] [PATCH v24 4/8] netdev-offload-tc: Add sFlow offload API for TC

2023-03-16 Thread Ilya Maximets
On 3/16/23 10:13, Eelco Chaudron wrote: > On 1 Mar 2023, at 8:22, Chris Mi wrote: > >> Initialize psample socket. Add sFlow recv API to receive sampled >> packets from psample socket. Add sFow recv wait API to add psample >> socket fd to poll list. > > See some comments inline below. and one

Re: [ovs-dev] [PATCH v24 4/8] netdev-offload-tc: Add sFlow offload API for TC

2023-03-16 Thread Eelco Chaudron
On 1 Mar 2023, at 8:22, Chris Mi wrote: > Initialize psample socket. Add sFlow recv API to receive sampled > packets from psample socket. Add sFow recv wait API to add psample > socket fd to poll list. See some comments inline below. and one question for Ilya ;) //Eelco > Signed-off-by: Chris

[ovs-dev] [PATCH v24 4/8] netdev-offload-tc: Add sFlow offload API for TC

2023-02-28 Thread Chris Mi via dev
Initialize psample socket. Add sFlow recv API to receive sampled packets from psample socket. Add sFow recv wait API to add psample socket fd to poll list. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/dpif.h| 2 + lib/netdev-offload-provider.h | 14 +++