Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-07-26 Thread Eelco Chaudron
On 20 Jul 2021, at 9:55, bindiya Kurle wrote: > Comments inline BK >> > > On Wed, Jun 23, 2021 at 3:50 PM Eelco Chaudron wrote: > >> On 26 May 2021, at 14:34, Eelco Chaudron wrote: >> >> On 18 May 2021, at 20:15, Ilya Maximets wrote: >> >> On 5/18/21 4:44 PM, Eelco Chaudron wrote: >> >> Add

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-07-20 Thread bindiya Kurle
Comments inline BK >> On Wed, Jun 23, 2021 at 3:50 PM Eelco Chaudron wrote: > On 26 May 2021, at 14:34, Eelco Chaudron wrote: > > On 18 May 2021, at 20:15, Ilya Maximets wrote: > > On 5/18/21 4:44 PM, Eelco Chaudron wrote: > > Add support for the dec_ttl action. Instead of programming the

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-06-23 Thread Eelco Chaudron
On 26 May 2021, at 14:34, Eelco Chaudron wrote: On 18 May 2021, at 20:15, Ilya Maximets wrote: On 5/18/21 4:44 PM, Eelco Chaudron wrote: Add support for the dec_ttl action. Instead of programming the datapath with a flow that matches the packet TTL and an IP set, use a single dec_ttl

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-26 Thread Matteo Croce
On Wed, May 26, 2021 at 2:50 PM Eelco Chaudron wrote: > > > > On 26 May 2021, at 14:46, Matteo Croce wrote: > > > On Wed, May 26, 2021 at 2:34 PM Eelco Chaudron wrote: > >> On 18 May 2021, at 20:15, Ilya Maximets wrote: > +/* Tests whether 'dpif' datapath supports decrement of the IP TTL

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-26 Thread Eelco Chaudron
On 26 May 2021, at 14:46, Matteo Croce wrote: > On Wed, May 26, 2021 at 2:34 PM Eelco Chaudron wrote: >> On 18 May 2021, at 20:15, Ilya Maximets wrote: +/* Tests whether 'dpif' datapath supports decrement of the IP TTL via + * OVS_ACTION_DEC_TTL. */ +static bool

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-26 Thread Ilya Maximets
On 5/26/21 2:46 PM, Matteo Croce wrote: > On Wed, May 26, 2021 at 2:34 PM Eelco Chaudron wrote: >> On 18 May 2021, at 20:15, Ilya Maximets wrote: +/* Tests whether 'dpif' datapath supports decrement of the IP TTL via + * OVS_ACTION_DEC_TTL. */ +static bool

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-26 Thread Matteo Croce
On Wed, May 26, 2021 at 2:34 PM Eelco Chaudron wrote: > On 18 May 2021, at 20:15, Ilya Maximets wrote: > >> +/* Tests whether 'dpif' datapath supports decrement of the IP TTL via > >> + * OVS_ACTION_DEC_TTL. */ > >> +static bool > >> +check_dec_ttl_action(struct dpif *dpif) > >> +{ > >> +

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-26 Thread Eelco Chaudron
On 18 May 2021, at 20:15, Ilya Maximets wrote: > On 5/18/21 4:44 PM, Eelco Chaudron wrote: >> Add support for the dec_ttl action. Instead of programming the datapath with >> a flow that matches the packet TTL and an IP set, use a single dec_ttl >> action. >> >> The old behavior is kept if the

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-18 Thread Ilya Maximets
On 5/18/21 4:44 PM, Eelco Chaudron wrote: > Add support for the dec_ttl action. Instead of programming the datapath with > a flow that matches the packet TTL and an IP set, use a single dec_ttl action. > > The old behavior is kept if the new action is not supported by the datapath. > > #

Re: [ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-18 Thread 0-day Robot
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include

[ovs-dev] [PATCH v4] datapath: Add a new action dec_ttl

2021-05-18 Thread Eelco Chaudron
Add support for the dec_ttl action. Instead of programming the datapath with a flow that matches the packet TTL and an IP set, use a single dec_ttl action. The old behavior is kept if the new action is not supported by the datapath. # ovs-ofctl dump-flows br0 cookie=0x0, duration=12.538s,