Re: [ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

2019-03-20 Thread Numan Siddique
Hi Ben, Few comments inline. Thanks Numan On Wed, Feb 13, 2019 at 10:53 PM Numan Siddique wrote: > > Thanks Ben for providing the review comments. > > I will address all the comments. > > A couple of comments inline. > > Thanks > Numan > > > On Tue, Feb 12, 2019 at 8:33 AM Ben Pfaff wrote: >

Re: [ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

2019-02-13 Thread Ben Pfaff
On Wed, Feb 13, 2019 at 10:53:53PM +0530, Numan Siddique wrote: > On Tue, Feb 12, 2019 at 8:33 AM Ben Pfaff wrote: > > > The OpenFlow syntax looks really weird. I don't understand it at all. > > > > By OpenFlow syntax you mean the way this action is being used ? > > i.e

Re: [ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

2019-02-13 Thread Numan Siddique
Thanks Ben for providing the review comments. I will address all the comments. A couple of comments inline. Thanks Numan On Tue, Feb 12, 2019 at 8:33 AM Ben Pfaff wrote: > On Thu, Jan 10, 2019 at 11:30:33PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds

Re: [ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

2019-02-11 Thread Ben Pfaff
On Thu, Jan 10, 2019 at 11:30:33PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new action 'check_pkt_larger' which checks if the > packet is larger than the given size and stores the result in the > destination register. Thanks. This patch renumbers

[ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

2019-01-10 Thread nusiddiq
From: Numan Siddique This patch adds a new action 'check_pkt_larger' which checks if the packet is larger than the given size and stores the result in the destination register. Usage: check_pkt_larger:len->REGISTER Eg. match=...,actions=check_pkt_larger:1442->NXM_NX_REG0[0],next; This patch