Re: [ovs-dev] [ovs-dev, patch_v1] db-ctl-base: Use boolean variable values.

2018-07-06 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by

Re: [ovs-dev] [patch_v1] db-ctl-base: Use boolean variable values.

2018-07-05 Thread Darrell Ball
On Thu, Jul 5, 2018 at 1:49 PM, Ian Stokes wrote: > On 7/5/2018 9:38 PM, Darrell Ball wrote: > >> Traditionally, for boolean variables we use boolean values. >> Lets keep to that tradition. >> Hopefully, using false with a bool works with gcc 6.3.1; >> I use both recent versions of gcc (7.3) and

Re: [ovs-dev] [ovs-dev, patch_v1] db-ctl-base: Use boolean variable values.

2018-07-05 Thread 0-day Robot
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 37, Warnings:

Re: [ovs-dev] [patch_v1] db-ctl-base: Use boolean variable values.

2018-07-05 Thread Ben Pfaff
On Thu, Jul 05, 2018 at 01:38:47PM -0700, Darrell Ball wrote: > Traditionally, for boolean variables we use boolean values. > Lets keep to that tradition. > Hopefully, using false with a bool works with gcc 6.3.1; > I use both recent versions of gcc (7.3) and older > versions (4.x), but did not

Re: [ovs-dev] [patch_v1] db-ctl-base: Use boolean variable values.

2018-07-05 Thread Ian Stokes
On 7/5/2018 9:38 PM, Darrell Ball wrote: Traditionally, for boolean variables we use boolean values. Lets keep to that tradition. Hopefully, using false with a bool works with gcc 6.3.1; I use both recent versions of gcc (7.3) and older versions (4.x), but did not see the issue found in

[ovs-dev] [patch_v1] db-ctl-base: Use boolean variable values.

2018-07-05 Thread Darrell Ball
Traditionally, for boolean variables we use boolean values. Lets keep to that tradition. Hopefully, using false with a bool works with gcc 6.3.1; I use both recent versions of gcc (7.3) and older versions (4.x), but did not see the issue found in 165c1f0649af commit. Cc: Ian Stokes Fixes: