Hi Eelco ,
Replies inline.
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, June 30, 2021 3:17 PM
> To: Amber, Kumar ; Van Haaren, Harry
>
> Cc: d...@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner
>
> Subject: Re: [ovs-dev] [v4 01/12] dpif-
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
> This patch introduces the mfex function pointers which allows
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on optimized ISA CPU.
>
> The user can query for the available minflow
>> Subject: Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function
>> pointer for miniflow extract
>>
>>
>>
>> On 29 Jun 2021, at 13:59, Amber, Kumar wrote:
>>
>>> Hi Eelco,
>>>
>>> Thanks a lot for the comments and my
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, June 29, 2021 2:56 PM
> To: Amber, Kumar
> Cc: Van Haaren, Harry ; d...@openvswitch.org;
> i.maxim...@ovn.org; Flavio Leitner
> Subject: Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line a
On 29 Jun 2021, at 13:59, Amber, Kumar wrote:
> Hi Eelco,
>
> Thanks a lot for the comments and my replies are inline.
>
>>> +return;
>>> +}
>>> +
>>> +/* Add all mfex functions to reply string. */
>>> +struct ds reply = DS_EMPTY_INITIALIZER;
>>> +ds_put_cstr(,
bject: Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and
> function pointer for miniflow extract
>
> Hi Kumar/Harry,
>
> Find my comments inline.
>
> //Eelco
>
>
> On 17 Jun 2021, at 18:27, Kumar Amber wrote:
>
> > This patch introduces the mfe
Hi Kumar/Harry,
Find my comments inline.
//Eelco
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
> This patch introduces the mfex function pointers which allows
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on optimized ISA CPU.
>
>
Hi Flavio,
Thanks a lot for the review my replies are inline.
> > +uint32_t mfex_hit = (mf_mask & (1 << i));
>
> This is actually a bool.
>
Fixed in upcoming v5.
> >
> > /* Check for partial hardware offload mark. */
> > uint32_t mark;
>
> I find 'ovs-appctl
Hi,
I am reviewing this patch ignoring the things that were
already pointed out in other reviews in the ML.
On Thu, Jun 17, 2021 at 09:57:43PM +0530, Kumar Amber wrote:
> This patch introduces the mfex function pointers which allows
> the user to switch between different miniflow extract
Hi Ian ,
Thanks for the review , replies are inline.
> > This allow for more performance and flexibility to the user to choose
>
> Minor typo above, allow -> allows.
>
Included in v5
> > the miniflow implementation according to the needs.
> >
> > Signed-off-by: Kumar Amber
> >
> This patch introduces the mfex function pointers which allows
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on optimized ISA CPU.
Thanks for the patch Amber/harry. Comments inline below.
>
> The user can query for the available
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed
This patch introduces the mfex function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by following commands:
13 matches
Mail list logo
