Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-20 Thread Simon Horman
Hi David, On Wed, Oct 18, 2023 at 01:49:08PM +0200, David Marchand wrote: > Hello Simon, > > On Fri, Oct 13, 2023 at 2:53 PM David Marchand > wrote: > > On Tue, Oct 10, 2023 at 5:10 PM Simon Horman wrote: > > > > > > On Mon, Oct 09, 2023 at 05:06:51PM +0200, David Marchand wrote: > > > > A

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-18 Thread David Marchand
On Wed, Oct 18, 2023 at 2:15 PM Ilya Maximets wrote: > On 10/16/23 16:06, Eelco Chaudron wrote: > > The check-offloads target can run fine if removing the exception on > > "failed to flow_get" and "failed to acquire ukey" warning logs. > > Would it be good to add another patch

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-18 Thread Ilya Maximets
On 10/16/23 16:06, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 14:24, Eelco Chaudron wrote: > >> On 16 Oct 2023, at 14:22, David Marchand wrote: >> >>> On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron wrote: > The check-offloads target can run fine if removing the exception on >

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-18 Thread David Marchand
Hello Simon, On Fri, Oct 13, 2023 at 2:53 PM David Marchand wrote: > On Tue, Oct 10, 2023 at 5:10 PM Simon Horman wrote: > > > > On Mon, Oct 09, 2023 at 05:06:51PM +0200, David Marchand wrote: > > > A main thread executing the 'revalidator/purge' command could race with > > > revalidator

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-16 Thread Eelco Chaudron
On 16 Oct 2023, at 14:24, Eelco Chaudron wrote: > On 16 Oct 2023, at 14:22, David Marchand wrote: > >> On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron wrote: The check-offloads target can run fine if removing the exception on "failed to flow_get" and "failed to acquire ukey" warning

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-16 Thread Eelco Chaudron
On 16 Oct 2023, at 14:22, David Marchand wrote: > On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron wrote: >>> The check-offloads target can run fine if removing the exception on >>> "failed to flow_get" and "failed to acquire ukey" warning logs. >> >> Would it be good to add another patch in

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-16 Thread David Marchand
On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron wrote: > > The check-offloads target can run fine if removing the exception on > > "failed to flow_get" and "failed to acquire ukey" warning logs. > > Would it be good to add another patch in the series, to remove these? > Yes, I intend to send a

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-13 Thread David Marchand
Hello Simon, On Tue, Oct 10, 2023 at 5:10 PM Simon Horman wrote: > > On Mon, Oct 09, 2023 at 05:06:51PM +0200, David Marchand wrote: > > A main thread executing the 'revalidator/purge' command could race with > > revalidator threads that can be dumping/sweeping the purged flows at the > > same

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-13 Thread Eelco Chaudron
On 9 Oct 2023, at 17:06, David Marchand wrote: > A main thread executing the 'revalidator/purge' command could race with > revalidator threads that can be dumping/sweeping the purged flows at the > same time. > > This race can be reproduced (with dpif debug logs) by running the > conntrack -

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

2023-10-10 Thread Simon Horman
On Mon, Oct 09, 2023 at 05:06:51PM +0200, David Marchand wrote: > A main thread executing the 'revalidator/purge' command could race with > revalidator threads that can be dumping/sweeping the purged flows at the > same time. > > This race can be reproduced (with dpif debug logs) by running the >