Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2024-03-06 Thread Aaron Conole
Simon Horman writes: > + Xavier > > On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote: >> Ilya Maximets writes: >> >> > On 8/31/23 09:15, Frode Nordahl wrote: >> >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote: >> >>> >> >>> From: hepeng >> >>> >> >>> The patch avoids the

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2024-03-06 Thread Simon Horman
+ Xavier On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote: > Ilya Maximets writes: > > > On 8/31/23 09:15, Frode Nordahl wrote: > >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote: > >>> > >>> From: hepeng > >>> > >>> The patch avoids the extra allocation for nat_conn. > >>>

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2023-08-31 Thread Aaron Conole
Ilya Maximets writes: > On 8/31/23 09:15, Frode Nordahl wrote: >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote: >>> >>> From: hepeng >>> >>> The patch avoids the extra allocation for nat_conn. >>> Currently, when doing NAT, the userspace conntrack will use an extra >>> conn for the two

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2023-08-31 Thread Ilya Maximets
On 8/31/23 09:15, Frode Nordahl wrote: > On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote: >> >> From: hepeng >> >> The patch avoids the extra allocation for nat_conn. >> Currently, when doing NAT, the userspace conntrack will use an extra >> conn for the two directions in a flow. However,

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2023-08-31 Thread Frode Nordahl
On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote: > > From: hepeng > > The patch avoids the extra allocation for nat_conn. > Currently, when doing NAT, the userspace conntrack will use an extra > conn for the two directions in a flow. However, each conn has actually > the two keys for both

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2023-08-30 Thread 0-day Robot
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author hepeng needs to sign off. WARNING: Unexpected sign-offs from developers who