Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-09 Thread Justin Pettit
> On Jan 3, 2018, at 3:57 PM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:11PM -0800, Justin Pettit wrote: >>- This reduces the number of times upcall cookies are processed. >>- It separate true miss calls from slow-path actions. >> >> The reorganization will also

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-09 Thread Gregory Rose
On 1/9/2018 1:33 PM, Justin Pettit wrote: On Jan 5, 2018, at 11:20 AM, Gregory Rose wrote: That didn't seem to help. The cookie->header.type is still equal to type USER_ACTION_COOKIE_UNSPEC in the classify_upcall() function and that causes this message:

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-09 Thread Justin Pettit
> On Jan 5, 2018, at 11:20 AM, Gregory Rose wrote: > > That didn't seem to help. The cookie->header.type is still equal to type > USER_ACTION_COOKIE_UNSPEC > in the classify_upcall() function and that causes this message: > >

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-05 Thread Gregory Rose
On 1/5/2018 10:46 AM, Justin Pettit wrote: On Jan 5, 2018, at 8:05 AM, Gregory Rose wrote: For now that's about as far as I can take my investigation since I have a few other things I need to work on. If you can think of another test I should run or something for me to

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-05 Thread Justin Pettit
> On Jan 5, 2018, at 8:05 AM, Gregory Rose wrote: > > For now that's about as far as I can take my investigation since I have a few > other things I need to work > on. If you can think of another test I should run or something for me to > check into let me know. Ben

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-05 Thread Gregory Rose
On 1/3/2018 9:37 AM, Gregory Rose wrote: On 1/2/2018 11:42 AM, Justin Pettit wrote: On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote: SFAICT it emulates exactly what the system-traffic.at test 001 does.  And it works fine... /shrug. What distribution, kernel, etc are

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-03 Thread Ben Pfaff
On Thu, Dec 21, 2017 at 02:25:11PM -0800, Justin Pettit wrote: > - This reduces the number of times upcall cookies are processed. > - It separate true miss calls from slow-path actions. > > The reorganization will also be useful for a future commit. > > Signed-off-by: Justin Pettit

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-03 Thread Gregory Rose
On 1/2/2018 11:42 AM, Justin Pettit wrote: On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote: SFAICT it emulates exactly what the system-traffic.at test 001 does. And it works fine... /shrug. What distribution, kernel, etc are you using for your check-kmod testing? I'll

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-02 Thread Justin Pettit
> On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote: > > SFAICT it emulates exactly what the system-traffic.at test 001 does. And it > works fine... /shrug. > > What distribution, kernel, etc are you using for your check-kmod testing? > I'll try to emulate that >

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-02 Thread Gregory Rose
On 12/28/2017 3:22 PM, Gregory Rose wrote: On 12/21/2017 2:25 PM, Justin Pettit wrote: - This reduces the number of times upcall cookies are processed. - It separate true miss calls from slow-path actions. The reorganization will also be useful for a future commit. Signed-off-by:

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2018-01-02 Thread Ben Pfaff
On Thu, Dec 21, 2017 at 02:25:11PM -0800, Justin Pettit wrote: > - This reduces the number of times upcall cookies are processed. > - It separate true miss calls from slow-path actions. > > The reorganization will also be useful for a future commit. > > Signed-off-by: Justin Pettit

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2017-12-28 Thread Gregory Rose
On 12/21/2017 2:25 PM, Justin Pettit wrote: - This reduces the number of times upcall cookies are processed. - It separate true miss calls from slow-path actions. The reorganization will also be useful for a future commit. Signed-off-by: Justin Pettit Justin, The