[ovs-dev] [PATCH] lib: Add initalize when xmalloc ofproto: Add initalize when recv from sdn controller

From: findtheonlway When recv packet from onos, the ovs may report an error or crash due to the buffer is uninitalized. Signed-off-by: findtheonlway Signed-off-by: sunwenjie --- lib/util.c| 1 + ofproto/ofproto.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/util.c

Re: [ovs-dev] Issue with OVS 2.9.0, DPDK 18.02 and vhost-user

On Wed, Jun 13, 2018 at 9:50 AM Ian Stokes wrote: > On 6/12/2018 9:50 PM, Ravi Kerur wrote: > > > > > > On Tue, Jun 12, 2018 at 3:31 AM, Stokes, Ian > > wrote: > > > > > Hi, > > > > > > I have used first link to install, compile and run OVS 2.9.0 and >

[ovs-dev] 答复: [PATCH net-next 0/6] Add dpdk-bond support

I think this dpdkbond option is worthy of being supported. In my view, ovs bonding works based on openflow upcall processing. When some slave gets link down, the datapath flows related it will be flushed an revalidated. As a result, that may cause a great deal of upcall requests to be handled

Re: [ovs-dev] [PATCH 1/3] datapath: Fix max MTU size on RHEL 7.5 kernel

On Tue, Jun 12, 2018 at 1:50 AM, Yi-Hung Wei wrote: > Without the patch, in RHEL 7.5, the maximum configurable MTU of vport > internal device is 1500, which shall be 65535. This patch fixes this > issue. > > Fixes: 39ca338374ab ("datapath: compat: Fix build on RHEL 7.5") > Reported-by: Lucas

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Hi Yi-Hung, > I format the patch and post in here: > https://patchwork.ozlabs.org/patch/927995/ Could you help to take a > look? Oh great! Sorry for the delay on this, I will take a look! Cheers, Lucas ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] [RFC] ovn-controller: Experiment with restricting access to columns.

On Thu, Jun 14, 2018 at 10:09 AM, Ben Pfaff wrote: > > On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han Zhou wrote: > > On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote: > > > > > > To make ovn-controller recompute incrementally, we need accurate > > > dependencies for each function that reads or

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

Looks good to me, thanks. Reviewed-by: Yifeng Sun On Wed, Jun 13, 2018 at 12:43 PM, Aaron Conole wrote: > lib/netdev-dpdk.c: In function : > lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the > last format character [-Wformat-truncation=] > snprintf(vhost_vring,

Re: [ovs-dev] [PATCH 1/2] lldp: fix string warnings

Thanks for the improvement. Reviewed-by: Yifeng Sun On Wed, Jun 13, 2018 at 12:43 PM, Aaron Conole wrote: > lib/lldp/lldpd.c: In function : > lib/lldp/lldpd.c:520:17: warning: output truncated before terminating nul > copying as many bytes from a string as its length [-Wstringop-truncation]

Re: [ovs-dev] [PATCH] lib: Add initalize when xmalloc ofproto: Add initalize when recv from sdn controller

On Thu, Jun 14, 2018 at 04:18:27PM +0800, findtheonly...@gmail.com wrote: > From: findtheonlway > > When recv packet from onos, the ovs may report an error or > crash due to the buffer is uninitalized. > > Signed-off-by: findtheonlway > Signed-off-by: sunwenjie Can you provide an example?

Re: [ovs-dev] [PATCH] [RFC] ovn-controller: Experiment with restricting access to columns.

On Thu, Jun 14, 2018 at 10:17:58AM -0700, Han Zhou wrote: > On Thu, Jun 14, 2018 at 10:09 AM, Ben Pfaff wrote: > > > > On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han Zhou wrote: > > > On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote: > > > > > > > > To make ovn-controller recompute incrementally,

Re: [ovs-dev] [PATCH] [RFC] ovn-controller: Experiment with restricting access to columns.

On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han Zhou wrote: > On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote: > > > > To make ovn-controller recompute incrementally, we need accurate > > dependencies for each function that reads or writes a table. It's > > currently difficult to be sure about

[ovs-dev] [PATCH v2] OVN: add ICMP time exceeded support to OVN logical router

Using icmp4 action, send an ICMP time exceeded frame whenever an OVN logical router receives an IPv4 packets whose TTL has expired (ip.ttl == {0, 1}) Signed-off-by: Lorenzo Bianconi --- Changes since v1: - use ovn-nbctl --wait=hv sync instead of sleep in automatic test ---

[ovs-dev] La energía del futuro

--- Este correo electrónico ha sido comprobado en busca de virus por AVG. http://www.avg.com ___

Re: [ovs-dev] [PATCH 1/2] lldp: fix string warnings

On Wed, Jun 13, 2018 at 03:43:03PM -0400, Aaron Conole wrote: > lib/lldp/lldpd.c: In function : > lib/lldp/lldpd.c:520:17: warning: output truncated before terminating nul > copying as many bytes from a string as its length [-Wstringop-truncation] > strncat(buffer,

Re: [ovs-dev] [PATCH] rhel: remove ovs-sim man page from temporary directory (also for RHEL)

On Thu, Jun 07, 2018 at 10:17:53AM +0300, Roi Dayan wrote: > > > On 06/06/2018 08:49, Ansis Atteka wrote: > > On Tue, 5 Jun 2018 at 20:32, Ben Pfaff wrote: > >> > >> On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote: > >>> Fix following compilation error when building rpm packages >

Re: [ovs-dev] [PATCH 1/2] lldp: fix string warnings

On Thu, Jun 14, 2018 at 05:10:10PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Wed, Jun 13, 2018 at 03:43:03PM -0400, Aaron Conole wrote: > >> lib/lldp/lldpd.c: In function : > >> lib/lldp/lldpd.c:520:17: warning: output truncated before > >> terminating nul copying as many bytes

Re: [ovs-dev] [PATCH 1/3] tests/sendpkt.py: Fix to work with Python3

Thanks Timothy (and Ashish). I applied this to master. On Mon, Jun 04, 2018 at 03:21:46PM -0700, Ashish Varma wrote: > Acked-by: Ashish Varma > > > On Thu, May 31, 2018 at 7:52 AM, Timothy Redaelli > wrote: > > > CC: Ashish Varma > > Fixes: 296251ca0c82 ("tests: Added NSH related unit test

Re: [ovs-dev] [PATCH 2/3] Partially revert "m4: Add hard requirements for python in "configure""

On Thu, May 31, 2018 at 04:52:41PM +0200, Timothy Redaelli wrote: > This partially reverts commit d53d2f4b84cc77868f2a55d66417fe6058d0. > > Python2 check for "six.moves.range" is not reverted. > > Signed-off-by: Timothy Redaelli Thanks for the patch. The commit message doesn't make it

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

Hi MalleshX, The error you get is because the specific flow you try to offload is not yet supported by this patchset. This patchset only provide the first stage of partial offload in OVS-DPDK and supporting only few protocols as stated on the release notes[1] You can check out all the

Re: [ovs-dev] [PATCH 1/5] dpctl.man: Correct argument to "dump-flows".

On Thu, Jun 14, 2018 at 12:00:43PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit For the series: Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: > lib/netdev-dpdk.c: In function : > lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last > format character [-Wformat-truncation=] > snprintf(vhost_vring, 16, "vring_%d_size", i); >

Re: [ovs-dev] [PATCH v3 1/6] ovs-kmod-ctl: introduce a kernel module load script

On Wed, Jun 06, 2018 at 10:07:14AM -0700, Ansis Atteka wrote: > On Wed, Jun 6, 2018, 7:31 AM Aaron Conole wrote: > > > Aaron Conole writes: > > > > > Currently, Open vSwitch on linux embeds the logic of loading and > > unloading > > > kernel modules into the ovs-ctl and ovs-lib script files.

Re: [ovs-dev] [PATCH 2/5] dpctl: Use common code to open dpif with optional name.

On Thu, Jun 14, 2018 at 12:00 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > lib/dpctl.c | 158 +++--- > -- > 1 file changed, 38 insertions(+), 120 deletions(-) > > diff --git a/lib/dpctl.c b/lib/dpctl.c > index

Re: [ovs-dev] [PATCH v1 1/2] Fix packet drops on LACP bond after link up

Thanks for the patch. The patch cannot be applied. It appears to be white space damaged. Please resubmit using "git send-email". ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] [RFC] ovn-controller: Experiment with restricting access to columns.

On Thu, Jun 14, 2018 at 10:40 AM, Ben Pfaff wrote: > > On Thu, Jun 14, 2018 at 10:17:58AM -0700, Han Zhou wrote: > > On Thu, Jun 14, 2018 at 10:09 AM, Ben Pfaff wrote: > > > > > > On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han Zhou wrote: > > > > On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote:

Re: [ovs-dev] [PATCH v2] OVN: add ICMP time exceeded support to OVN logical router

On Thu, Jun 14, 2018 at 05:27:18PM +0200, Lorenzo Bianconi wrote: > Using icmp4 action, send an ICMP time exceeded frame whenever > an OVN logical router receives an IPv4 packets whose TTL has > expired (ip.ttl == {0, 1}) > > Signed-off-by: Lorenzo Bianconi > --- > Changes since v1: > - use

Re: [ovs-dev] [PATCH] rhel: Add python-netifaces as a dependency for openvswitch-test

On Tue, Jun 12, 2018 at 03:37:09PM -0400, Aaron Conole wrote: > Timothy Redaelli writes: > > > Currently python-netifaces is needed for ovs-tcpdump that is installed > > by openvswitch-test package. > > > > This commit adds {python,python2}-netifaces as a dependency for the > > openvswitch-test

Re: [ovs-dev] [PATCH 1/2] lldp: fix string warnings

Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:03PM -0400, Aaron Conole wrote: >> lib/lldp/lldpd.c: In function : >> lib/lldp/lldpd.c:520:17: warning: output truncated before >> terminating nul copying as many bytes from a string as its length >> [-Wstringop-truncation] >>

[ovs-dev] [PATCH 3/5] dpctl: Prefer "--more" to indicate verbosity for "ct-stats-show".

The "ct-stats-show" used the keyword "verbose" to indicate verbosity, but the more standard way in OVS is to use "-m" or "--more". This commit continues to support the keyword method, but adds support for "-m" and "--more" and documents their use. Signed-off-by: Justin Pettit --- lib/dpctl.c

[ovs-dev] [PATCH 4/5] dpctl.man: Some minor cleanups to the dpctl man page.

Signed-off-by: Justin Pettit --- lib/dpctl.man | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/lib/dpctl.man b/lib/dpctl.man index 51c401c31ae9..a6917bd0b29b 100644 --- a/lib/dpctl.man +++ b/lib/dpctl.man @@ -217,7 +217,7 @@ do not apply

[ovs-dev] [PATCH 5/5] ovs-dpctl: Remove redundant documentation from man page.

Remove descriptions of options that are already described with the command. These options were not staying current with the commands that supported them. Signed-off-by: Justin Pettit --- utilities/ovs-dpctl.8.in | 16 1 file changed, 16 deletions(-) diff --git

[ovs-dev] [PATCH 2/5] dpctl: Use common code to open dpif with optional name.

Signed-off-by: Justin Pettit --- lib/dpctl.c | 158 +++- 1 file changed, 38 insertions(+), 120 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index ec8c51e4b0a7..f522785a5f97 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -187,6

Re: [ovs-dev] [patch v1] tests: Enable Valgrind for userspace system tests.

On Mon, Jun 11, 2018 at 05:51:42PM -0700, Darrell Ball wrote: > Signed-off-by: Darrell Ball Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/5] dpctl.man: Correct argument to "dump-flows".

Signed-off-by: Justin Pettit --- lib/dpctl.man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpctl.man b/lib/dpctl.man index 50623c4a91b0..3a1716fedb6c 100644 --- a/lib/dpctl.man +++ b/lib/dpctl.man @@ -119,7 +119,7 @@ flow. As an example, \fBfilter='tcp,tp_src=100'\fR

[ovs-dev] [PATCH] ovn-controller: Only add comment in binding_cleanup() in case of changes.

This makes the comment more meaningful. Signed-off-by: Ben Pfaff --- ovn/controller/binding.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index 2b27f3cbd9ad..021ecddcff77 100644 ---

Re: [ovs-dev] [PATCH 1/3] datapath: Fix max MTU size on RHEL 7.5 kernel

Thanks Yi-Hung (and Greg). I applied these to master. If they need backports, let me know. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tests: Fix test that tests if the system doesn't support IPv6

On Mon, Jun 11, 2018 at 01:15:35PM +0200, Timothy Redaelli wrote: > Currently if IPv6 is globally disabled (net.ipv6.conf.all.disable_ipv6=1) or > if IPv6 is disabled on loopback interface (net.ipv6.conf.lo.disable_ipv6=1) > the check doesn't work since no interface have ::1 and EADDRNOTAVAIL is >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> lib/netdev-dpdk.c: In function : >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last >> format character [-Wformat-truncation=] >> snprintf(vhost_vring, 16, "vring_%d_size",

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> lib/netdev-dpdk.c: In function : >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last >> format character [-Wformat-truncation=] >> snprintf(vhost_vring, 16, "vring_%d_size",

Re: [ovs-dev] [PATCH] linux: Assume it is local if no API is available.

On Thu, Jun 07, 2018 at 04:33:50PM +0200, Eelco Chaudron wrote: > On 07/06/18 16:10, Flavio Leitner wrote: > >If the 'openvswitch' kernel module is not loaded, the API is not > >available and the userspace will keep retrying. This approach is > >not ideal for the netdev datapath type. > > > >This

Re: [ovs-dev] [PATCH] linux: Assume it is local if no API is available.

On Thu, Jun 14, 2018 at 04:09:24PM -0700, Ben Pfaff wrote: > On Thu, Jun 07, 2018 at 04:33:50PM +0200, Eelco Chaudron wrote: > > On 07/06/18 16:10, Flavio Leitner wrote: > > >If the 'openvswitch' kernel module is not loaded, the API is not > > >available and the userspace will keep retrying. This

Re: [ovs-dev] eBPF and OVS

On Mon, Jun 11, 2018 at 10:32:52AM +, Stokes, Ian wrote: > Hi all, > > The recent DPDK 18.05 release provides BPF functionality for DPDK devices. > > The BPF Library provides the ability to load and execute Enhanced Berkeley > Packet Filters (eBPF) within user-space DPDK applications. It

Re: [ovs-dev] eBPF and OVS

On Thu, Jun 14, 2018 at 3:25 PM, Ben Pfaff wrote: > On Mon, Jun 11, 2018 at 10:32:52AM +, Stokes, Ian wrote: >> Hi all, >> >> The recent DPDK 18.05 release provides BPF functionality for DPDK devices. >> >> The BPF Library provides the ability to load and execute Enhanced Berkeley >> Packet

Re: [ovs-dev] [PATCH] linux: disable netns support for tap.

On Thu, Jun 07, 2018 at 04:33:39PM +0200, Eelco Chaudron wrote: > On 07/06/18 16:11, Flavio Leitner wrote: > >Tap device is not added to the kernel datapath, so there is > >no way to get netns information. > > > >Reported-by: Eelco Chaudron > >Signed-off-by: Flavio Leitner > >--- > >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

Ben Pfaff writes: > On Thu, Jun 14, 2018 at 05:11:39PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> >> lib/netdev-dpdk.c: In function : >> >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the >>

Re: [ovs-dev] [PATCH] tests/stp: Make validation of flows before changing of topology.

On Tue, Jun 05, 2018 at 05:37:42PM +0300, Ilya Maximets wrote: > From: Ivan Dyukov > > The change fixes random stp test failure. Accuracy is about 20%. > Failed test is following: > 2337: STP - flush the fdb and mdb when topology changed > > In some cases, a validation is executed after

[ovs-dev] Webinar Interactivo

InnovaGroup Webinar Interactivo 26 de Junio "Indicadores de competividad: Benchmaking " ¿Qué veré en este webinar? Este curso está diseñado para aprender a observar y analizar el mercado y el ambiente empresarial, reconocer a los competidores y a las empresas líderes para adaptar e

[ovs-dev] 64Byte packet performance regression on 2.9 from 2.7

Hi, I just upgraded from OvS 2.7 + DPDK 16.11 to OvS2.9 + DPDK 17.11 and running into performance issue with 64 Byte packet rate. One interesting thing that I notice that even at very light load from IXIA the processing cycles on all the PMD threads run close to 100% of the cpu cycle on 2.9 OvS,

Re: [ovs-dev] [PATCH] vxlan: Fix for the packet loop issue in vxlan

Thanks for your feedback. This means that recent kernel changes might have fixed the issue. I will see if there is any generic solution for the issue. On Thu, Jun 14, 2018 at 8:09 AM, Pravin Shelar wrote: > On Wed, Jun 13, 2018 at 5:16 AM, Neelakantam Gaddam > wrote: > > It should be Qdisc's

[ovs-dev] Advanced Shipping Notification for Consignment Number 877777725.

PIECES: 1 WEIGHT: 218.000 KG SHIPMENT REFERENCE: TNT-87725 DESCRIPTION: MERCANCIA If you would like to find out about the many ways TNT helps you to track your shipment, or if you would like to know more about the services provided by TNT, simply connect to www.tnt.com and select

Re: [ovs-dev] [PATCH] tap: flag as present after opening it.

On Thu, Jun 07, 2018 at 04:34:02PM +0200, Eelco Chaudron wrote: > On 07/06/18 16:10, Flavio Leitner wrote: > >Assume the device is present if it can be opened. > > > >Reported-by: Eelco Chaudron > >Signed-off-by: Flavio Leitner > >--- > > lib/netdev-linux.c | 1 + > > 1 file changed, 1