On Wed, Jul 11, 2018 at 4:35 PM, Flavio Leitner wrote:
> On Wed, Jul 11, 2018 at 03:30:08PM -0700, Martin Xu wrote:
> > This patch only affects rhel6 spec file.
> >
> > RHEL 7.4 introduced backward incompatible changes in the kernel. As
> > a result, prebuilt PRM packages against kernels newer
On Wed, Jul 11, 2018 at 03:30:08PM -0700, Martin Xu wrote:
> This patch only affects rhel6 spec file.
>
> RHEL 7.4 introduced backward incompatible changes in the kernel. As
> a result, prebuilt PRM packages against kernels newer than 693.17.1
> will cannot be used on systems with older kernels,
Hi William,
Thanks for the test. I will do.
Best,
Yifeng
On Wed, Jul 11, 2018 at 4:19 PM, William Tu wrote:
> Thanks for the patch.
>
> On Tue, Jul 10, 2018 at 12:24 PM, Yifeng Sun
> wrote:
> > Currently check-kmod's gre test is broken on certain kernel
> > versions where ovs's gre module
Thanks for the patch.
On Tue, Jul 10, 2018 at 12:24 PM, Yifeng Sun wrote:
> Currently check-kmod's gre test is broken on certain kernel
> versions where ovs's gre module conflits with kernel's gre
> module. But at the same time, present gre test depends on
> Linux gre module to setup gre port.
>
Bleep bloop. Greetings Martin Xu, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
WARNING: Line is 116 characters
On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote:
Do not assign an initial value to ` status`, it will be assigned
later on.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote:
Do not assign an initial value for the variable `entry`, it will
be reassigned later on.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote:
Assign variables directly instead of reassigning them after.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/BufferMgmt.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git
On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote:
Assign variables directly instead of reassigning them after.
Also purge unused variable `PNL_ATTR queueAttr`.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Actions.c | 24 ++--
1 file changed, 10
This patch only affects rhel6 spec file.
RHEL 7.4 introduced backward incompatible changes in the kernel. As
a result, prebuilt PRM packages against kernels newer than 693.17.1
will cannot be used on systems with older kernels, vice versa.
This patch allows multiple kernel version numbers
Hi Darrell,
Thanks for the test. It shouldn't be that slow. For the same
'nsh -forward' test, it is pretty fast on my test machine.
## -- ##
## openvswitch 2.9.90 test suite. ##
## -- ##
111: nsh - forward
Thanks.
Reviewed-by: Yifeng Sun
On Mon, Jul 9, 2018 at 2:37 PM, Ben Pfaff wrote:
> OVS trips over this warning all over the place, so it's not worth leaving
> on.
>
> Signed-off-by: Ben Pfaff
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac
Thanks.
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Mon, Jul 9, 2018 at 1:04 PM, Ben Pfaff wrote:
> This was useful for testing the previous patch.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.c | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git
On Wed, Jul 11, 2018 at 10:26 PM Ben Pfaff wrote:
> On Wed, Jul 11, 2018 at 12:37:28PM +0530, Numan Siddique wrote:
> > On Wed, Jul 11, 2018 at 2:08 AM Ben Pfaff wrote:
> >
> > > On Wed, Jul 11, 2018 at 12:56:39AM +0530, nusid...@redhat.com wrote:
> > > > From: Numan Siddique
> > > >
> > > >
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#80 FILE:
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo utilities/ovs-dpctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Ben Pfaff writes:
> The bot couldn't apply this patch presumably because it tried to apply
> it against master. Maybe the bot should notice version numbers in [] in
> subject lines and try against that branch.
Good call. I'm at a conference at the moment, but will try to get that
integrated
Adding Ben.
On Tue, Jul 10, 2018 at 3:54 PM Gregory Rose wrote:
> On 7/10/2018 3:42 PM, Martin Xu wrote:
> > This patch only affects rhel6 spec file.
> >
> > RHEL 7.4 introduced backward incompatible changes in the kernel. As
> > a result, prebuilt PRM packages against kernels newer than
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 89daf631a..60b4d0c9c 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1403,3 +1403,24 @@ AT_CHECK([ovn-nbctl
Signed-off-by: Jakub Sitnicki
---
tests/ovn.at | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index d1a8967dd..adb99db77 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -10541,3 +10541,22 @@ OVN_CHECK_PACKETS([hv2/vif2-tx.pcap],
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 73a61a4be..89daf631a 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1382,3 +1382,24 @@ inactivity_probe:
Make ovn-nbctl act as a unixctl server if we were asked to detach. This
turns ovn-nbctl into a long-lived process that acts a proxy for
interacting with NB DB. The main difference to regular mode of ovn-nbctl
is that in the daemon mode, a local copy of database contents has to be
obtained only
This will allow us to direct oneline-formatted output to other sinks
than stdout if needed. Preparatory work for daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 53 ++-
1 file changed, 34 insertions(+), 19 deletions(-)
diff
Extend the main loop and the command runner so that the caller can
specify a timeout for poll_block(). This will allow us to break out of
the main loop when waiting on IDL, like in the blocked '--wait=sb/hv
sync' case.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 27
Let the caller handle the errors instead of reporting it and
terminating. Prepare for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the prerequisites runner in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff
Introduce an output parameter for the flag that signals need to retry
running the command. This leaves the return value for error reporting.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20 +---
1 file
Destroy IDL resources in the routine where we allocated them.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Split out a routine for the main ovn-nbctl loop.
Preparatory work for introducing daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Destroy commands in the same routine where they were allocated.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
If IDL was created with monitoring and alerts turned on by default for
all columns, then there is no harm in allowing the API users to ask
again for monitoring and alerts to be enabled for any given column.
This allows us to run prerequisites handlers for db-ctl and ovn-nbctl
commands once the
This series extends ovn-nbctl tool with support for the daemon mode, where
ovn-nbctl acts a long-lived process that accepts commands over a UNIX socket.
The daemon can be started the same way as any other OVS/OVN server:
ovn-nbctl --detach --pidfile --log-file
While commands can be issued to
> Acked-by: Billy O'Mahony
>
Thanks to all for the work on this.
I've applied this to dpdk_merge branch, it will be part of this week's pull
request.
I rolled patch 2 of the series into the same commit as I don't think it makes
sense to have a broken unit test for the 1st commit.
Thanks
Ian
>Hi Ben/All,
>If possible, Kindly hold reviewing this patch for now. Expecting an
approval from my Org. Sorry for the inconvenience >caused and thanks for
the support.
>Will get back and intimate for the review as soon as possible after the
approval (expecting it to take not more than a week).
On Wed, Jul 11, 2018 at 11:32 AM Ian Stokes wrote:
> On 7/11/2018 7:23 PM, Ian Stokes wrote:
> > On 7/11/2018 7:02 PM, Ravi Kerur wrote:
> >> Hello OVS-DPDK team,
> >>
> >> I am using OVS 2.9.90 for my vhost-virtio testing and had some
> >> questions on
> >> vhost multiqueue support, it doesn't
On 7/11/2018 7:23 PM, Ian Stokes wrote:
On 7/11/2018 7:02 PM, Ravi Kerur wrote:
Hello OVS-DPDK team,
I am using OVS 2.9.90 for my vhost-virtio testing and had some
questions on
vhost multiqueue support, it doesn't seem to be working correctly. Kindly
let me know if multiqueue is supported? I
On 7/11/2018 7:02 PM, Ravi Kerur wrote:
Hello OVS-DPDK team,
I am using OVS 2.9.90 for my vhost-virtio testing and had some questions on
vhost multiqueue support, it doesn't seem to be working correctly. Kindly
let me know if multiqueue is supported? I am using following link as a
reference.
The following tests are added to the DPDK testsuite to add some
coverage for the multi-segment mbufs:
- Check that multi-segment mbufs are disabled by default;
- Check that providing `other_config:dpdk-multi-seg-mbufs=true` indeed
enables mbufs;
- Using a DPDK port, send a random packet out and
In order to create a minimal environment that allows the tests to get
mbufs from an existing mempool, the following approach is taken:
- EAL is initialised (by using the main dpdk_init()) and a (very) small
mempool is instantiated (mimicking the logic in dpdk_mp_create()).
This mempool
As it stands, OVS_DPDK_START() won't allow other configs to be set
before starting the ovs-vswitchd daemon. This is a problem since some
configs, such as the "dpdk-multi-seg-mbufs=true" for enabling the
multi-segment mbufs, need to be set prior to start OvS.
To support other options,
From: Mark Kavanagh
Currently, jumbo frame support for OvS-DPDK is implemented by
increasing the size of mbufs within a mempool, such that each mbuf
within the pool is large enough to contain an entire jumbo frame of
a user-defined size. Typically, for each user-defined MTU,
'requested_mtu', a
From: Mark Kavanagh
Currently, packets are only copied to a single segment in the function
dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames,
particularly when multi-segment mbufs are involved.
This patch calculates the number of segments needed by a packet and
copies the
From: Michael Qiu
When doing packet clone, if packet source is from DPDK driver,
multi-segment must be considered, and copy the segment's data one by
one.
Also, lots of DPDK mbuf's info is missed during a copy, like packet
type, ol_flags, etc. That information is very important for DPDK to do
When enabled with DPDK OvS relies on mbufs allocated by mempools to
receive and output data on DPDK ports. Until now, each OvS dp_packet has
had only one mbuf associated, which is allocated with the maximum
possible size, taking the MTU into account. This approach, however,
doesn't allow us to
In its current implementation dp_packet_shift() is also unaware of
multi-seg mbufs (that holds data in memory non-contiguously) and assumes
that data exists contiguously in memory, memmove'ing data to perform the
shift.
To add support for multi-seg mbuds a new set of functions was
introduced,
Most helper functions in dp-packet assume that the data held by a
dp_packet is contiguous, and perform operations such as pointer
arithmetic under that assumption. However, with the introduction of
multi-segment mbufs, where data is non-contiguous, such assumptions are
no longer possible. Some
When a dp_packet is from a DPDK source, and it contains multi-segment
mbufs, the data_len is not equal to the packet size, pkt_len. Instead,
the data_len of each mbuf in the chain should be considered while
distributing the new (provided) size.
To account for the above dp_packet_set_size() has
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise
allocation and free operations by non-pmd threads on a given mempool.
free_dpdk_buf() has been modified to make use of the introduced mutex.
Signed-off-by: Tiago Lam
Acked-by: Eelco Chaudron
---
lib/netdev-dpdk.c | 35
From: Mark Kavanagh
dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's
possible the the resultant mbuf portion of the dp_packet contains
random data. For some mbuf fields, specifically those related to
multi-segment mbufs and/or offload features, random values may cause
When enabled with DPDK OvS deals with two types of packets, the ones
coming from the mempool and the ones locally created by OvS - which are
copied to mempool mbufs before output. In the latter, the space is
allocated from the system, while in the former the mbufs are allocated
from a mempool,
From: Mark Kavanagh
There are numerous factors that must be considered when calculating
the size of an mbuf:
- the data portion of the mbuf must be sized in accordance With Rx
buffer alignment (typically 1024B). So, for example, in order to
successfully receive and capture a 1500B packet,
Overview
This patchset introduces support for multi-segment mbufs to OvS-DPDK.
Multi-segment mbufs are typically used when the size of an mbuf is
insufficient to contain the entirety of a packet's data. Instead, the
data is split across numerous mbufs, each carrying a portion, or
Signed-off-by: Han Zhou
---
ovn/controller/ovn-controller.c | 6 -
ovn/controller/pinctrl.c| 54 -
ovn/controller/pinctrl.h| 3 +--
3 files changed, 43 insertions(+), 20 deletions(-)
diff --git a/ovn/controller/ovn-controller.c
On Tue, Jul 10, 2018 at 2:07 PM Ben Pfaff wrote:
> On Thu, Jul 05, 2018 at 01:44:33PM -0700, Ravi Kerur wrote:
> > During scale flow add/delete (>10K), I am seeing ovs-vswitchd cpu usage
> > spike to 100% and stay there without any sign of returning to normal cpu
> > usage. It's normal OVS 2.4.1
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
Lines checked: 149, Warnings: 0,
On Wed, Jul 11, 2018 at 09:45:08AM -0700, William Tu wrote:
> Commit 9f57c67c379d ("gre: Remove support for sharing GRE protocol hook")
> allows only single GRE packet receiver. When upstream kernel's gre module
> is loaded, the gre.ko exclusively becomes the only gre packet receiver,
>
The bot couldn't apply this patch presumably because it tried to apply
it against master. Maybe the bot should notice version numbers in [] in
subject lines and try against that branch.
Thanks,
Ben.
On Wed, Jul 11, 2018 at 11:59:24AM -0400, 0-day Robot wrote:
> Bleep bloop. Greetings Darrell
On Wed, Jul 11, 2018 at 12:37:28PM +0530, Numan Siddique wrote:
> On Wed, Jul 11, 2018 at 2:08 AM Ben Pfaff wrote:
>
> > On Wed, Jul 11, 2018 at 12:56:39AM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > The python function ovs.socket_util.check_connection_completion()
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 conntrack: Fix use after free for FTP control
Commit 9f57c67c379d ("gre: Remove support for sharing GRE protocol hook")
allows only single GRE packet receiver. When upstream kernel's gre module
is loaded, the gre.ko exclusively becomes the only gre packet receiver,
preventing OVS kernel module from registering another gre receiver.
We can
On 7/11/2018 9:24 AM, William Tu wrote:
Commit 9f57c67c379d ("gre: Remove support for sharing GRE protocol hook")
allows only single GRE packet receiver. When upstream kernel's gre module
is loaded, the gre.ko exclusively becomes the only gre packet receiver,
preventing OVS kernel module from
Commit 9f57c67c379d ("gre: Remove support for sharing GRE protocol hook")
allows only single GRE packet receiver. When upstream kernel's gre module
is loaded, the gre.ko exclusively becomes the only gre packet receiver,
preventing OVS kernel module from registering another gre receiver.
We can
When conn_update_state() returns true, conn has been freed, so skip calling
handle_ftp_ctl() with this conn and instead follow code path for new
connections.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 7 +--
1 file
Acked-by: Billy O'Mahony
> -Original Message-
> From: Wang, Yipeng1
> Sent: Tuesday, July 10, 2018 11:14 AM
> To: d...@openvswitch.org; jan.scheur...@ericsson.com; O Mahony, Billy
>
> Cc: Wang, Yipeng1 ; Stokes, Ian
> ; b...@ovn.org
> Subject: [PATCH v5 2/2] tests: Fix unit test case
Acked-by: Billy O'Mahony
> -Original Message-
> From: Wang, Yipeng1
> Sent: Tuesday, July 10, 2018 11:14 AM
> To: d...@openvswitch.org; jan.scheur...@ericsson.com; O Mahony, Billy
>
> Cc: Wang, Yipeng1 ; Stokes, Ian
> ; b...@ovn.org
> Subject: [PATCH v5 1/2] dpif-netdev: Add SMC cache
On Wed, Jul 11, 2018 at 8:56 AM, Darrell Ball wrote:
>
>
> On Wed, Jul 11, 2018 at 8:36 AM, Ben Pfaff wrote:
>
>> On Wed, Jul 11, 2018 at 08:34:49AM -0700, Ben Pfaff wrote:
>> > On Tue, Jul 10, 2018 at 04:41:58PM -0700, Darrell Ball wrote:
>> > > When conn_update_state() returns true, conn has
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 conntrack: Fix conn_update_state_alg use
On Wed, Jul 11, 2018 at 8:36 AM, Ben Pfaff wrote:
> On Wed, Jul 11, 2018 at 08:34:49AM -0700, Ben Pfaff wrote:
> > On Tue, Jul 10, 2018 at 04:41:58PM -0700, Darrell Ball wrote:
> > > When conn_update_state() returns true, conn has been freed, so skip
> calling
> > > handle_ftp_ctl() with this
When conn_update_state() returns true, conn has been freed, so skip calling
handle_ftp_ctl() with this conn and instead follow code path for new
connections.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 7 +--
1 file
Thanks for your review!
On Tue, Jul 10, 2018 at 6:16 PM, Ansis Atteka wrote:
> On Wed, 27 Jun 2018 at 10:59, Qiuyu Xiao wrote:
>>
>> This patch adds CA-cert based authentication to the ovs-monitor-ipsec
>> daemon. With CA-cert based authentication enabled, OVS approves IPsec
>> tunnel if the
On Wed, Jul 11, 2018 at 08:34:49AM -0700, Ben Pfaff wrote:
> On Tue, Jul 10, 2018 at 04:41:58PM -0700, Darrell Ball wrote:
> > When conn_update_state() returns true, conn has been freed, so skip calling
> > handle_ftp_ctl() with this conn and instead follow code path for new
> > connections.
> >
On Tue, Jul 10, 2018 at 04:41:58PM -0700, Darrell Ball wrote:
> When conn_update_state() returns true, conn has been freed, so skip calling
> handle_ftp_ctl() with this conn and instead follow code path for new
> connections.
>
> Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
On Tue, Jul 10, 2018 at 08:23:17PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > Fixes test 815 "tunnel_push_pop_ipv6 - action".
> >
> > CC: Aaron Conole
> > Fixes: 6f231f7c3a9e ("xlate: use const struct in6_addr in linklocal check")
> > Signed-off-by: Ben Pfaff
> > ---
>
> D'oh! The
On Tue, Jul 10, 2018 at 10:19:22PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On GNU systems these macros work with arbitrary pointers, but the relevant
> > standards only require IN6_IS_ADDR_MC_LINKLOCAL to work with in6_addr (and
> > don't specify IN6_ARE_ADDR_EQUAL at all). Make
On Wed, Jul 11, 2018 at 09:13:15AM +, Stokes, Ian wrote:
> > On Tue, Jul 10, 2018 at 07:46:55PM +0100, Ian Stokes wrote:
> > > This commit fixes 'maybe-uninitialized' warnings for pointers in
> > > various functions in ovn-nbctl when compiling with gcc 6.3.1 and -
> > Werror.
> > > Pointers to
On Wed, Jul 11, 2018 at 09:17:55AM +, Stokes, Ian wrote:
> > This makes it easier to reason about the outputs, and fixes warnings for
> > GCC 6.3.x.
> >
> > Cc: Venkata Anil
> > Fixes: 31114af758c7 ("ovn-nbctl: Update logical router port commands.")
> > Fixes: 80f408f4cffb ("ovn: Use
On Wed, Jul 11, 2018 at 05:30:13PM +0530, Sriharsha Basavapatna wrote:
> On Wed, Jul 11, 2018 at 3:33 AM, Ben Pfaff wrote:
> > On Tue, Jul 10, 2018 at 11:59:35AM +0530, Sriharsha Basavapatna via dev
> > wrote:
> >> This is the first patch in the patch-set to support dynamic rebalancing
> >> of
Thanks, applied to branch-2.9.
On Wed, Jul 11, 2018 at 08:36:18AM -0400, Mark Michelson wrote:
> Thanks, Ben!
>
> Acked-by: Mark Michelson
>
> On 07/10/2018 06:24 PM, Ben Pfaff wrote:
> >This is a partial backport of commit 396d492cfa8d ("Don't shadow
> >variables.") to fix a build break due
> On 11/07/2018 12:40, Ian Stokes wrote:
> > On 7/10/2018 12:06 PM, Tiago Lam wrote:
> >> When configuring a mempool, in netdev_dpdk_mempool_configure(), the
> >> result of a call to dpdk_buf_size() is being used as the MTU. This,
> >> however, is not the MTU but a ROUND_UP aligned number based on
On 11/07/2018 12:40, Ian Stokes wrote:
> On 7/10/2018 12:06 PM, Tiago Lam wrote:
>> When configuring a mempool, in netdev_dpdk_mempool_configure(), the
>> result of a call to dpdk_buf_size() is being used as the MTU. This,
>> however, is not the MTU but a ROUND_UP aligned number based on the MTU,
On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote:
> Added new types to the flow dump filter, and allowed multiple filter
> types to be passed at once, as a comma separated list. The new types
> added are:
> * tc - specifies flows handled by the tc dp
> * non-offloaded - specifies flows
Thanks, Ben!
Acked-by: Mark Michelson
On 07/10/2018 06:24 PM, Ben Pfaff wrote:
This is a partial backport of commit 396d492cfa8d ("Don't shadow
variables.") to fix a build break due to backporting a different commit
that depended on it.
CC: Mark Michelson
Fixes: 15fbc3baee5a ("ovn: Add
On Wed, Jul 11, 2018 at 3:33 AM, Ben Pfaff wrote:
> On Tue, Jul 10, 2018 at 11:59:35AM +0530, Sriharsha Basavapatna via dev wrote:
>> This is the first patch in the patch-set to support dynamic rebalancing
>> of offloaded flows.
>>
>> The patch detects OOR condition on a netdev port when ENOSPC
On 7/10/2018 12:06 PM, Tiago Lam wrote:
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise
allocation and free operations by non-pmd threads on a given mempool.
free_dpdk_buf() has been modified to make use of the introduced mutex.
1 comment Below Tiago.
Signed-off-by: Tiago
On 7/10/2018 12:06 PM, Tiago Lam wrote:
From: Mark Kavanagh
Currently, packets are only copied to a single segment in the function
dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames,
particularly when multi-segment mbufs are involved.
This patch calculates the number of
On 7/10/2018 12:06 PM, Tiago Lam wrote:
When configuring a mempool, in netdev_dpdk_mempool_configure(), the
result of a call to dpdk_buf_size() is being used as the MTU. This,
however, is not the MTU but a ROUND_UP aligned number based on the MTU,
which could lead to the reuse of mempools even
1 - 100 of 105 matches
Mail list logo
