replace_substring() wants the total size of the string in order to move
the end of the string after the part being replaced.
When replacing the ipv4 address in repl_ftp_v4_addr(), the remain_size
variable must be updated after replace_substring() has been called, not
before.
Besides, the
Greetings
Compliment of the day to you. I am Mr. Ahmed Zama, I am sending this
brief letter to solicit your partnership to transfer €15 million Euros
into your account for investment in your country. I shall send you
more information and procedures when I receive positive response from
you.
Hi Simon,
thank you for the comments
Is the tnl->flags check necessary? What is the meaning of a match on the flags
if the tunnel type doesn't support that field. Is it possible to configure such
a flow?
it is possible to configure such flow, for example GRE tunnel without key is a
possible
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 94 characters long (recommended limit is 79)
#131 FILE:
On 21.01.2019 19:01, Aaron Conole wrote:
> Harry van Haaren writes:
>
>> Hi Folks,
>>
>> This patchset is a v4, changes from v3 are a fix to the issue reported
>> by Ilya (see v3 patchset for details). Note that this patchset enables
>> the work as presented at OVS Conf last December,
This allows plugging-in of different subtable hash-lookup-verify
routines, and allows special casing of those functions based on
known context (eg: # of bits set) of the specific subtable.
Signed-off-by: Harry van Haaren
---
lib/dpif-netdev.c | 127 +++---
This commit moves some data-structures to be available
in the dpif-netdev.h header. This allows specific implementations
of the subtable lookup function to include just that header
file, and not require that the code exists in dpif-netdev.c
Signed-off-by: Harry van Haaren
---
lib/dpif-netdev.c
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: C99 style comment
#110 FILE: lib/dpif-netdev.c:7805:
Hi Han,
I have addressed your comments. But before posting the patch I wanted to
get an opinion
on the HA support for these external ports.
The proposed patch doesn't support HA. If the requested chassis goes down
for some reason
it is expected that CMS would detect it and change the
Harry van Haaren writes:
> Hi Folks,
>
> This patchset is a v4, changes from v3 are a fix to the issue reported
> by Ilya (see v3 patchset for details). Note that this patchset enables
> the work as presented at OVS Conf last December, particularly this is
> the function pointer part:
This commit splits the generic hash-lookup-verify
function to its own file. In doing so, we must move
some MACRO definitions to dpif-netdev.h
Signed-off-by: Harry van Haaren
---
lib/automake.mk | 1 +
lib/dpif-netdev-lookup-generic.c | 95
This commit optimizes the dpcls_rule_matches_key() function
by refactoring the code to be shorter and less branchy. The
main code-change (and optimization) is to use popcount and
mask to calculate the packet block index.
This code is split out to the header file, which is marked as
static inline.
Currently the TC tunnel_key action is always
initialized with the given tunnel id value. However,
some tunneling protocols define the tunnel id as an optional field.
This patch initializes the id field of tunnel_key:set and tunnel_key:unset
only if a value is provided.
In the case that a tunnel
Hi Folks,
This patchset is a v4, changes from v3 are a fix to the issue reported
by Ilya (see v3 patchset for details). Note that this patchset enables
the work as presented at OVS Conf last December, particularly this is
the function pointer part: https://www.youtube.com/watch?v=5-MDlpUIOBE
The
On Mon, Jan 21, 2019 at 4:02 PM Numan Siddique wrote:
>
> Hi Han,
>
> I have addressed your comments. But before posting the patch I wanted to
> get an opinion
> on the HA support for these external ports.
>
> The proposed patch doesn't support HA. If the requested chassis goes down
> for some
ping
-Original Message-
From: Eli Britstein
Sent: Monday, January 21, 2019 2:14 PM
To: Roi Dayan
Cc: Simon Horman ; Jarno Rajahalme ;
Ben Pfaff ; William Tu ; Andy Zhou
Subject: Re: [PATCH V2 0/2] Do not rewrite fields with the same values as
ping
On 1/13/2019 9:27 AM, Eli
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#77 FILE:
On Mon, Jan 21, 2019 at 11:53:20AM +, Adi Nissim wrote:
> Hi Simon,
>
> thank you for the comments
>
> Is the tnl->flags check necessary? What is the meaning of a match on the
> flags if the tunnel type doesn't support that field. Is it possible to
> configure such a flow?
>
>
> it is
Cursos escenciales - Webinar Interactivo – Jueves 07 de Febrero
Reeclutamiento y selección eficiente de puestos operativos
La dificultad de reclutar puestos operativos puede encontrar excelentes aliados
en las redes sociales, las plataformas profesionales, los blogs y el internet.
Nuestro
Hello
I want to seek for your assistance and partnership to invest in your country. I
have € 7.5M (Seven million five hundred thousand Euros) that I want to invest
in your country and I am willing to offer you 20% of the money for your
assistance in this project.
If you are interested,
From: David Marchand
When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size
was incorrectly calculated which could lead to the wrong replacement
adjustment.
This goes unnoticed most of the time, unless you choose carefully your
initial and replacement addresses.
Example fail
Thanks for the fix David
I sent an alternative fix here:
https://patchwork.ozlabs.org/patch/1028908/
Darrell
On Mon, Jan 21, 2019 at 2:15 AM David Marchand
wrote:
> replace_substring() wants the total size of the string in order to move
> the end of the string after the part being replaced.
>
Cursos escenciales - Webinar Interactivo – Viernes 08 de Febrero
Capacitación a tu Medida Todo sobre CFDI en 100 casos prácticos
El asistente conocerá los recientes cambios en materia de comprobantes fiscales
digitales y su complemento de pago a fin de cerciorarse
de la emisión correcta para
The CLANG version of the builds have not honored the TESTSUITE variable.
This dates to at least 2015, and the reason for the restriction isn't
clear.
Signed-off-by: Aaron Conole
---
.travis/linux-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis/linux-build.sh
Ilya Maximets writes:
> On 21.01.2019 19:01, Aaron Conole wrote:
>> Harry van Haaren writes:
>>
>>> Hi Folks,
>>>
>>> This patchset is a v4, changes from v3 are a fix to the issue reported
>>> by Ilya (see v3 patchset for details). Note that this patchset enables
>>> the work as presented at
The testsuite flag isn't currently being passed for DPDK. Let's pass it
and when a future DPDK supports running the check-dpdk suite, we can
turn that on then, too.
Signed-off-by: Aaron Conole
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index
Following are some quick changes to improve the travis testing.
Aaron Conole (2):
travis: enable testsuite with dpdk
travis/linux-build: enable testing with clang builds
.travis.yml| 1 +
.travis/linux-build.sh | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.19.1
On 1/16/2019 8:03 AM, Aaron Conole wrote:
Following code looks like it might be wrong. I don't know much about
the way the stt infrastructure is being used, so feel free to ignore if
it is expected to return NETDEV_TX_OK even in error cases (just seems
strange).
Caught by compiler warning:
It was deceptive for the example to imply that a seq can be declared
directly, because the API only allows for creating a new one on the heap.
Signed-off-by: Ben Pfaff
---
lib/seq.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/seq.h b/lib/seq.h
index
On 1/14/2019 4:20 PM, Gregory Rose wrote:
On 1/14/2019 3:22 PM, Yi-Hung Wei wrote:
On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote:
Upstream commit 648700f76b03 ("inet: frags: use rhashtables...")
changed
how ipv6 fragmentation is implemented. This patch was backported to
the upstream
On 1/21/2019 2:06 PM, Gregory Rose wrote:
It turns out after I had more of a chance to look at this that
HAVE_INET_FRAGS_WITH_FRAGS_WORK and
HAVE_INET_FRAGS_RND are both keying off the same upstream patch I
mentioned in the commit message
(648700f76b03). There's no need for the redundancy.
When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size
was incorrectly calculated which could lead to the wrong replacement
adjustment.
This goes unnoticed most of the time, unless you choose carefully your
initial and replacement addresses.
Example fail address combination
Hi,
Hope you're having a great day!
I just wanted to know if you're looking to acquire Google Cloud Users Contact
List for your marketing efforts?
Information Field: Names, Title, Email, Phone, Company Name, Company URL,
Company physical address, SIC Code, Industry and Company Size
Ignore V2; I sent V3 with more improvements.
On Mon, Jan 21, 2019 at 12:12 PM Darrell Ball wrote:
> From: David Marchand
>
> When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size
> was incorrectly calculated which could lead to the wrong replacement
> adjustment.
>
> This
Fixed a bug introduced in V3 and added a second patch and sent V4.
i.e. V3 is superceded
On Mon, Jan 21, 2019 at 4:22 PM Darrell Ball wrote:
> Ignore V2; I sent V3 with more improvements.
>
> On Mon, Jan 21, 2019 at 12:12 PM Darrell Ball wrote:
>
>> From: David Marchand
>>
>> When replacing
From: David Marchand
When configuring the nat part of an expectation, care must be taken to
look at the master nat action and direction to properly reproduce it.
DNAT tests have been added to both active and passive modes, all
ftp/tftp tests titles have been updated to reflect they are dealing
From: David Marchand
The ftp alg deals with packets in two ways for the command connection:
either they are inspected and can be mangled when nat is enabled
(CT_FTP_CTL_INTEREST) or they just go through without being modified
(CT_FTP_CTL_OTHER).
For CT_FTP_CTL_INTEREST packets, we must both
At the same time, splice out a function and also rely on the compiler
for overflow/underflow handling.
Found by inspection.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 38 ++
1 file
I am going to guess it is due to space vs '-'
i.e. s/branch 2.9/branch-2.9/
and resend
On Mon, Jan 21, 2019 at 6:59 PM 0-day Robot wrote:
> Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I
Good day,
Please arrange to provide the best offer for below attached Purchase Order
The requirement for our green field contract in Oman
Kindly get back to us
1) Proforma invoice with bank details
2) Delivery date
3) FOB/CIF Port
Regards,
kahn Gotze Sales & Services Assistant
When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size
was incorrectly calculated which could lead to the wrong replacement
adjustment.
This goes unnoticed most of the time, unless you choose carefully your
initial and replacement addresses.
Example fail address combination
The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
the maximum possible V6 address size for v4 mapping case.
Found by inspection.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack.c
From: David Marchand
When configuring the nat part of an expectation, care must be taken to
look at the master nat action and direction to properly reproduce it.
DNAT tests have been added to both active and passive modes, all
ftp/tftp tests titles have been updated to reflect they are dealing
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 conntrack: fix tcp seq adjustments when
At the same time, splice out a function and also rely on the compiler
for overflow/underflow handling.
Found by inspection.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 38 ++
1 file
From: David Marchand
The ftp alg deals with packets in two ways for the command connection:
either they are inspected and can be mangled when nat is enabled
(CT_FTP_CTL_INTEREST) or they just go through without being modified
(CT_FTP_CTL_OTHER).
For CT_FTP_CTL_INTEREST packets, we must both
46 matches
Mail list logo
