Enable TC datapath on ip6gretap interface.
It will work once https://patchwork.ozlabs.org/patch/1120457/ is merged.
Eli Britstein (1):
netdev-vport: Make ip6gretap netdev type to use TC rules
lib/netdev-vport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.17.2
The offload api functions already assigned to every tunnel class.
For ip6gretap tunnel class only need to also assign the get_ifindex
function, similarly as done in commit 5e63eaa969a3 ("netdev-vport: Make
gre netdev type to use TC rules").
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
From: Lucas Alvares Gomes
This patch is enhacing the ovndb-servers.ocf script to handle updates to
the inactive_probe_interval via pacemaker. For example, one could run:
$ sudo crm_resource --resource ovndb_servers --set-parameter
inactive_probe_interval --parameter-value
To set a new
We have been testing the rebalance code in different situations while
having traffic going through OVS.
Those tests have shown that part of the observed packets losses is due to
some time wasted in signaling/waiting for the pmd threads to reload their
polling configurations.
This series is an
pmd reloads are currently serialised in each steps calling
reload_affected_pmds.
Any pmd processing packets, waiting on a mutex etc... will make other
pmd threads wait for a delay that can be undeterministic when syscalls
adds up.
Switch to a little busy loop on the control thread using the
When swapping queues from a pmd thread to another (q0 polled by pmd0/q1
polled by pmd1 -> q1 polled by pmd0/q0 polled by pmd1), the current
"Step 5" puts both pmds to sleep waiting for the control thread to wake
them up later.
Prefer to make them spin in such a case to avoid sleeping an
Bleep bloop. Greetings Lucas Alvares Gomes, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#30 FILE:
No need for a latch here since we don't have to wait.
A simple boolean flag is enough.
The memory order on the reload flag is changed to rel-acq ordering to
serve as a synchronisation point between the pmd threads and the control
thread that asks for termination.
Fixes: e4cfed38b159
From: Lucas Alvares Gomes
This patch is enhacing the ovndb-servers.ocf script to handle updates to
the inactive_probe_interval via pacemaker. For example, one could run:
$ sudo crm_resource --resource ovndb_servers --set-parameter
inactive_probe_interval --parameter-value
To set a new
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Committer Justin Pettit needs to sign off.
Lines checked: 52, Warnings: 0, Errors: 1
Looking at the reload flag only every 1024 loops can be a long time
under load, since we might be handling 32 packets per rxq, per iteration,
which means up to poll_cnt * 32 * 1024 packets.
Look at the flag every loop, no major performance impact seen.
Signed-off-by: David Marchand
Acked-by:
pmd->static_tx_qid is allocated under a mutex by the different pmd
threads.
Unconditionally reallocating it will make those pmd threads sleep
when contention occurs.
During "normal" reloads like for rebalancing queues between pmd threads,
this can make pmd threads waste time on this.
Reallocating
On 26.06.2019 12:08, David Marchand wrote:
> pmd reloads are currently serialised in each steps calling
> reload_affected_pmds.
> Any pmd processing packets, waiting on a mutex etc... will make other
> pmd threads wait for a delay that can be undeterministic when syscalls
> adds up.
>
> Switch to
On Tue, Jun 25, 2019 at 03:57:21PM +0100, Kevin Traynor wrote:
> Fix minor issue of one possible additional retry.
>
> Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.")
> Signed-off-by: Kevin Traynor
> Acked-by: Eelco Chaudron
> ---
Acked-by: Flavio Leitner
On Wed, Jun 26, 2019 at 10:37:49AM -0300, Flavio Leitner via dev wrote:
>
> Hi William,
>
> On Thu, Jun 20, 2019 at 11:00:56AM -0700, William Tu wrote:
> > The patch adds the basic spin lock functions:
> > ovs_spin_{lock, try_lock, unlock, init, destroy}.
> > I have some use cases using af_xdp,
On Wed, Jun 26, 2019 at 2:43 PM Ilya Maximets
wrote:
> On 26.06.2019 12:08, David Marchand wrote:
> > pmd reloads are currently serialised in each steps calling
> > reload_affected_pmds.
> > Any pmd processing packets, waiting on a mutex etc... will make other
> > pmd threads wait for a delay
On Wed, Jun 26, 2019 at 11:05:42AM -0300, Flavio Leitner via dev wrote:
> On Tue, Jun 25, 2019 at 03:57:22PM +0100, Kevin Traynor wrote:
> > Add documentation about vhost tx retries and external
> > configuration that can help reduce/avoid them.
> >
> > Signed-off-by: Kevin Traynor
> > Acked-by:
On 26/06/2019 15:27, Flavio Leitner wrote:
> On Wed, Jun 26, 2019 at 11:05:42AM -0300, Flavio Leitner via dev wrote:
>> On Tue, Jun 25, 2019 at 03:57:22PM +0100, Kevin Traynor wrote:
>>> Add documentation about vhost tx retries and external
>>> configuration that can help reduce/avoid them.
>>>
Me da mucho gusto saludarte.
Es, para mí, un placer poder invitarte a nuestro webinar "Administración
efectiva de inventarios", que se estará llevando a cabo el
día Jueves 25 de julio con un horario de 10:00 a 14:00 hrs. (hora del centro de
México)
Ejes Temáticos:
• La importancia e impacto
On Tue, Jun 25, 2019 at 03:57:23PM +0100, Kevin Traynor wrote:
> vhost tx retries may occur, and it can be a sign that
> the guest is not optimally configured.
>
> Add some stats so a user will know if vhost tx retries are
> occurring and hence give a hint that guest config should be
> examined.
On Wed, Jun 26, 2019 at 7:08 AM Ben Pfaff wrote:
>
> On Wed, Jun 26, 2019 at 10:37:49AM -0300, Flavio Leitner via dev wrote:
> >
> > Hi William,
> >
> > On Thu, Jun 20, 2019 at 11:00:56AM -0700, William Tu wrote:
> > > The patch adds the basic spin lock functions:
> > > ovs_spin_{lock, try_lock,
On Wed, Jun 26, 2019 at 2:07 AM Eli Britstein wrote:
>
> Enable TC datapath on ip6gretap interface.
> It will work once https://patchwork.ozlabs.org/patch/1120457/ is merged.
>
I've sent v4 patch
https://patchwork.ozlabs.org/patch/1122890/
William
___
Hi William,
On Thu, Jun 20, 2019 at 11:00:56AM -0700, William Tu wrote:
> The patch adds the basic spin lock functions:
> ovs_spin_{lock, try_lock, unlock, init, destroy}.
> I have some use cases using af_xdp, patches will
> come later.
Usually the new API is merged along with an user
On Tue, Jun 25, 2019 at 03:57:24PM +0100, Kevin Traynor wrote:
> vhost tx retries can provide some mitigation against
> dropped packets due to a temporarily slow guest/limited queue
> size for an interface, but on the other hand when a system
> is fully loaded those extra cycles retrying could
On Tue, Jun 25, 2019 at 11:09:07AM -0700, Yi-Hung Wei wrote:
> This fix the compilation issue on CentOS 7.6 kernel
> (3.10.0-957.21.3.el7.x86_64).
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-June/360013.html
> Reported-by: Fred Neubauer
> Fixes: 6660a9597a49
On 26/06/2019 15:51, Flavio Leitner wrote:
> On Tue, Jun 25, 2019 at 03:57:24PM +0100, Kevin Traynor wrote:
>> vhost tx retries can provide some mitigation against
>> dropped packets due to a temporarily slow guest/limited queue
>> size for an interface, but on the other hand when a system
>> is
The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE
tunnel over IPv6, carrying inner ethernet packets and encap with GRE header
with outer IPv6 header. Encapsulation of layer 3 packet over IPv6 GRE, ip6gre,
is not supported yet. I tested it by running:
# make
On Tue, Jun 25, 2019 at 03:59:57PM +0300, Ilya Maximets wrote:
> On 25.06.2019 15:41, Flavio Leitner wrote:
> > On Tue, Jun 25, 2019 at 03:37:09PM +0300, Ilya Maximets wrote:
> >> On 25.06.2019 15:20, Flavio Leitner wrote:
> >>> On Tue, Jun 25, 2019 at 01:07:53PM +0300, Ilya Maximets wrote:
>
On Tue, Jun 25, 2019 at 03:57:22PM +0100, Kevin Traynor wrote:
> Add documentation about vhost tx retries and external
> configuration that can help reduce/avoid them.
>
> Signed-off-by: Kevin Traynor
> Acked-by: Eelco Chaudron
> ---
This also has a magic number without a define, but since the
From: Numan Siddique
Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar"
results in the incremetal processing engine to recompute the flows on the
chassis where the logical port 'foo' is claimed.
This patch avoids this unnecessary recomputation by omitting the alert
The patch adds ip6gretap support. Tunnel type ip6gretap is a layer 2 GRE
tunnel over IPv6, carrying inner ethernet packets and encap with GRE header
with outer IPv6 header. I tested it by running:
# make check-kernel
under kernel 5.2 and for userspace:
# make check TESTSUITEFLAGS='-k
On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote:
> The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE
> tunnel over IPv6, carrying inner ethernet packets and encap with GRE header
> with outer IPv6 header. Encapsulation of layer 3 packet over IPv6 GRE,
>
On Thu, Jun 27, 2019 at 12:19 AM Ben Pfaff wrote:
> On Wed, Jun 26, 2019 at 07:46:25PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > Running the command "ovn-nbctl set logical_switch_port foo
> external_ids:foo=bar"
> > results in the incremetal processing engine to
On Tue, Jun 25, 2019 at 02:52:38PM -0700, William Tu wrote:
> Previously, '--disable-system' disables both system dp and the system
> routing table. The patch makes '--disable-system' only disable system
> dp and adds '--disable-system-route' for disabling the route table.
> This fixes failures
On Thu, Jun 27, 2019 at 12:43:18AM +0530, Numan Siddique wrote:
> On Thu, Jun 27, 2019 at 12:19 AM Ben Pfaff wrote:
>
> > On Wed, Jun 26, 2019 at 07:46:25PM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > Running the command "ovn-nbctl set logical_switch_port foo
> >
On Wed, Jun 26, 2019 at 07:46:25PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> Running the command "ovn-nbctl set logical_switch_port foo
> external_ids:foo=bar"
> results in the incremetal processing engine to recompute the flows on the
> chassis where the logical port 'foo'
On Thu, Jun 27, 2019 at 12:41 AM Ben Pfaff wrote:
> On Wed, Jun 26, 2019 at 11:59:30AM +0100, lmart...@redhat.com wrote:
> > From: Lucas Alvares Gomes
> >
> > This patch is enhacing the ovndb-servers.ocf script to handle updates to
> > the inactive_probe_interval via pacemaker. For example, one
Modify travis linux build script to use the latest DPDK stable release
18.11.2. Update docs for latest DPDK stable releases.
Signed-off-by: Ian Stokes
---
V1 -> V2
* Remove DPDK minimum requirement 18.11.2 notice in NEWS.
* Remove DPDK minimum requirement 18.11.2 from commit message.
---
Modify travis linux build script to use the latest DPDK stable release
18.11.2. Update docs for latest DPDK stable releases.
Signed-off-by: Ian Stokes
---
V1 -> V2
* Remove DPDK 18.11.2 minimum requirement notice from NEWS and commit
message.
---
.travis/linux-build.sh | 2
On 4/18/2019 3:44 PM, Ilya Maximets wrote:
On 18.04.2019 17:05, David Marchand wrote:
On Thu, Apr 18, 2019 at 1:51 PM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote:
On 18.04.2019 14:26, David Marchand wrote:
> On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor
On Thu, 13 Jun 2019 at 09:54, Ben Pfaff wrote:
> On Wed, Jun 12, 2019 at 09:48:59PM -0700, Gurucharan Shetty wrote:
> > Commit e981a45a6cae4 (ovs-atomic: Add 64 bit apis.)
> > added a few 64 bit apis (e.g: atomic_count_inc64). For C++,
> > this invokes std::atomic_fetch_*_explicit() functions
Suggested-by: Numan Siddique
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.h | 76 -
1 file changed, 63 insertions(+), 13 deletions(-)
diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h
index 0f5a6d0a27d8..9f12ce3206f3 100644
--- a/lib/ovsdb-idl.h
+++
Bleep bloop. Greetings Kevin Traynor, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#48 FILE:
On Wed, Jun 26, 2019 at 11:59:30AM +0100, lmart...@redhat.com wrote:
> From: Lucas Alvares Gomes
>
> This patch is enhacing the ovndb-servers.ocf script to handle updates to
> the inactive_probe_interval via pacemaker. For example, one could run:
>
> $ sudo crm_resource --resource ovndb_servers
Bug 2128511 is a result of a conflict that arises when upgrading
on RHEL 7.x systems when the built-in geneve and vxlan kernel modules
were in use before the upgrade but then the newer compat geneve
and vxlan interfaces embedded in the openvswitch kernel module
are used after the upgrade.
This
On 4/25/2019 4:22 PM, David Marchand wrote:
We currently poll all available queues based on the max queue count
exchanged with the vhost peer and rely on the vhost library in DPDK to
check the vring status beneath.
This can lead to some overhead when we have a lot of unused queues.
To enhance
On Tue, Jun 25, 2019 at 01:12:11PM +0300, Ilya Maximets wrote:
> 'netdev' datapath is implemented within ovs-vswitchd process and can
> not exist without it, so it should be gracefully terminated with a
> full cleanup of resources upon ovs-vswitchd exit.
>
> This change forces dpif cleanup for
On Tue, Jun 25, 2019 at 06:48:15PM +0300, Ilya Maximets wrote:
> Running ovsdb-server with empty private-key and non-empty certificate
> (or otherwise) causes crash:
>
> # ovsdb-tool create ./etc/openvswitch/conf.db ./vswitch.ovsschema
> # ovsdb-server --remote=punix:./db.sock \
>
On 4/25/2019 4:22 PM, David Marchand wrote:
At the moment, a malicious guest might negotiate VIRTIO_NET_F_MQ and
!VIRTIO_NET_F_MQ in a loop which would be seen as qp_num going from 1 to
n and n to 1 continuously, triggering datapath reconfigurations at each
transition.
Limit this by only
Dear d...@openvswitch.org
Kindly check and confirm the PI in attachment. Send back the signed PI
after confirmation.
Regards,
Kevin Zhang / Sales Director
WSD LED INC
C: 214.940.9581
T: 469.857.5683
W: https://www.wsdled.con/
A: 2965 Congressman Lane Dallas TX 75220
On Fri, Jun 21, 2019 at 7:56 AM Ilya Maximets wrote:
>
> On 19.06.2019 22:51, William Tu wrote:
> > The patch introduces experimental AF_XDP support for OVS netdev.
> > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket
> > type built upon the eBPF and XDP technology. It
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#18 FILE: lib/ovsdb-idl.h:1:
/*
Please ignore - mistakes were made...
Thanks,
- Greg
On 6/26/2019 2:25 PM, Greg Rose wrote:
Bug 2128511 is a result of a conflict that arises when upgrading
on RHEL 7.x systems when the built-in geneve and vxlan kernel modules
were in use before the upgrade but then the newer compat geneve
On 6/26/2019 11:59 AM, Ben Pfaff wrote:
On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote:
The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE
tunnel over IPv6, carrying inner ethernet packets and encap with GRE header
with outer IPv6 header. Encapsulation of
54 matches
Mail list logo
