[ovs-dev] [PATCH] show "rx_missed_errors" counter in interface statisics

2019-09-03 Thread txfh2007 via dev
Hi all: Currently OVS maintains several Statistics counters per interface. "rx_missed_errors" counter is amount them and collects pkts not received due to local resource constaints. Many ovs netdevs support collecting this counter, such as netdev-linux, netdev-dpdk, netdev-bsd and so on.

Re: [ovs-dev] [PATCH ovn] Fix configure help string for ovs source/build path

2019-09-03 Thread Numan Siddique
On Fri, Aug 30, 2019 at 6:53 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Signed-off-by: Lorenzo Bianconi > Thanks. I pushed this to master. Numan > --- > acinclude.m4 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/acinclude.m4 b/acinclude.m4 >

Re: [ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-09-03 Thread Numan Siddique
On Fri, Aug 2, 2019 at 3:12 AM Ankur Sharma wrote: > ISSUE: > For a VIF port (on a bridged logical switch), OVN sends out > GARPs, advertising port's mac and IP. > > However, if a VIF port (on a bridged logical switch) has not > been assigned an IP, then OVN does not advertise anything. > As a

Re: [ovs-dev] [PATCH] show "rx_missed_errors" counter in interface statisics

2019-09-03 Thread 0-day Robot
Bleep bloop. Greetings txfh2007 via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author txfh2007 needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] Ваш заказ сформирован

2019-09-03 Thread Зайнаб via dev
Добрый день! Мы обеспечим ваш офис всем необходимым!    Компания «Море рюкзаков» занимается оптовыми продажами канцелярских товаров, нам уже более 15 лет. Мы работаем только с самыми надежными поставщиками как из Российской Федерации так и иностранными партнерами.    Мы обеспечиваем ваш офис

[ovs-dev] SIGILL ovs branch-2.12/arm64/DPDK

2019-09-03 Thread James Page
Hi I've been testing non-x86 architecture builds for the upcoming 2.12 release of OVS and I'm hitting an issue with DPDK enabled builds on the arm64 architecture. branch-2.12 includes improvements for native hashing under arm64; these appear to work fine when DPDK is not in the mix, but with

Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Numan Siddique
On Tue, Aug 27, 2019 at 7:31 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-09-03 Thread Anil Kumar Koli via dev
Hi Ilya, Sorry for late reply and thanks for the review comments. Yes, the issue happens only in the userspace datapath and not in kernel datapath. I have tested it on kernel datapath and could not see this issue for the same build. Regarding the suggested solution, I still feel like going

[ovs-dev] [PATCH v5 ovn 2/3] add meter support to trigger_event action

2019-09-03 Thread Lorenzo Bianconi
Introduce meter support to trigger_event action in order to not overload pinctrl thread under heavy load Signed-off-by: Lorenzo Bianconi --- include/ovn/actions.h | 1 + lib/actions.c | 43 +-- ovn-sb.xml| 5 - tests/ovn.at

[ovs-dev] [PATCH v5 ovn 3/3] northd: add rate limiting support for SB controller events

2019-09-03 Thread Lorenzo Bianconi
Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. Each event type relies on a meter with a defined name: - empty_lb_backends: event-elb Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi ---

[ovs-dev] [PATCH v5 ovn 1/3] northd: introduce build_empty_lb_event_flow routine

2019-09-03 Thread Lorenzo Bianconi
Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 63 ++--- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 9a282..679d36d88 100644 --- a/northd/ovn-northd.c +++

[ovs-dev] [PATCH v5 ovn 0/3] Add rate limiting support for controller_events

2019-09-03 Thread Lorenzo Bianconi
Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. For each event type we need to define a naming convention for the related meter: - empty_lb_backends: event-elb Changes since v4: - rebase ontop of current ovn

Re: [ovs-dev] [PATCH v12] Improved Packet Drop Statistics in OVS

2019-09-03 Thread Eelco Chaudron
On 20 Aug 2019, at 11:57, Anju Thomas wrote: Thanks for the comments Eelco. I will address them in the next patch. On a similar note, are these the final set of comments for this patch ? Did you get any update, and are you planning on sending out an update? Thanks, Eelco Regards Anju

[ovs-dev] [PATCH] tests: Add track-origins flag to valgrind.

2019-09-03 Thread Ilya Maximets
Useful for tracking where the uninitialized memory came from. Report example: Thread 13 revalidator11: Conditional jump or move depends on uninitialised value(s) at 0x4C35D96: __memcmp_sse4_1 (in vgpreload_memcheck.so) by 0x9D4404: ofpbuf_equal (ofpbuf.h:273) by 0x9D4404:

[ovs-dev] [PATCH] rhel: Revert RHEL 7.4 comp_ver change

2019-09-03 Thread Greg Rose
I looked at the wrong list of kernels when I changed the value for the RHEL 7.4 comp_ver variable. Revert that part of commit e64c2c1 ("rhel: Fix ovs-kmod-manage.sh to work with RHEL 7.3"). Fixes: e64c2c1 ("rhel: Fix ovs-kmod-manage.sh to work with RHEL 7.3") Signed-off-by: Greg Rose ---

Re: [ovs-dev] [PATCH] rhel: Revert RHEL 7.4 comp_ver change

2019-09-03 Thread Guru Shetty
On Tue, 3 Sep 2019 at 08:50, Greg Rose wrote: > I looked at the wrong list of kernels when I changed the value for the > RHEL 7.4 comp_ver variable. Revert that part of commit e64c2c1 > ("rhel: Fix ovs-kmod-manage.sh to work with RHEL 7.3"). > > Fixes: e64c2c1 ("rhel: Fix ovs-kmod-manage.sh to

Re: [ovs-dev] [PATCH v2] treewide: Use packet batch APIs

2019-09-03 Thread William Tu
On Sun, Sep 01, 2019 at 03:10:05PM +0200, Paul Chaignon wrote: > This patch replaces direct accesses to dp_packet_batch and dp_packet > internal components by the appropriate API calls. It extends commit > 1270b6e52 (treewide: Wider use of packet batch APIs). > > This patch was generated using

Re: [ovs-dev] SIGILL ovs branch-2.12/arm64/DPDK

2019-09-03 Thread Ilya Maximets
> Hi > > I've been testing non-x86 architecture builds for the upcoming 2.12 release > of OVS and I'm hitting an issue with DPDK enabled builds on the arm64 > architecture. > > branch-2.12 includes improvements for native hashing under arm64; these > appear to work fine when DPDK is not in the

Re: [ovs-dev] [PATCH v3] flow: fix incorrect padding length checking in ipv6_sanity_check

2019-09-03 Thread William Tu
On Mon, Sep 02, 2019 at 04:36:47PM +0800, Yanqin Wei wrote: > The padding length is (packet size - ipv6 header length - ipv6 plen). This > patch fixes incorrect padding size checking in ipv6_sanity_check. > > Reviewed-by: Gavin Hu > Signed-off-by: Yanqin Wei Looks good to me. Acked-by:

[ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Ankur Sharma
During E-W routing for vlan backed networks, we replace router port mac with chassis mac, when packet leaves the source hypervisor. As a result, the destination VM (on remote hypervisor) will see chassis mac as source mac in received packet. Although, functionality wise this does not cause any

Re: [ovs-dev] [PATCH v2] treewide: Use packet batch APIs

2019-09-03 Thread Paul Chaignon
On Tue, Sep 03, 2019 at 06:37PM +, William Tu wrote: > On Sun, Sep 01, 2019 at 03:10:05PM +0200, Paul Chaignon wrote: > > This patch replaces direct accesses to dp_packet_batch and dp_packet > > internal components by the appropriate API calls. It extends commit > > 1270b6e52 (treewide:

Re: [ovs-dev] [PATCH] rhel: Revert RHEL 7.4 comp_ver change

2019-09-03 Thread Gregory Rose
On 9/3/2019 10:02 AM, Guru Shetty wrote: On Tue, 3 Sep 2019 at 08:50, Greg Rose > wrote: I looked at the wrong list of kernels when I changed the value for the RHEL 7.4 comp_ver variable.  Revert that part of commit e64c2c1 ("rhel: Fix

Re: [ovs-dev] [PATCH v2] treewide: Use packet batch APIs

2019-09-03 Thread William Tu
On Tue, Sep 3, 2019 at 10:39 AM Paul Chaignon wrote: > > On Tue, Sep 03, 2019 at 06:37PM +, William Tu wrote: > > On Sun, Sep 01, 2019 at 03:10:05PM +0200, Paul Chaignon wrote: > > > This patch replaces direct accesses to dp_packet_batch and dp_packet > > > internal components by the

[ovs-dev] [PATCH] Add a __str__ method to idl.Row

2019-09-03 Thread Terry Wilson
It's sometimes handy to log an entire Row object, so this just adds a string representation of the object as: Tablename(col1=val1, col2=val2, ..., coln=valn) Signed-off-by: Terry Wilson --- python/ovs/db/idl.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/python/ovs/db/idl.py

Re: [ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-09-03 Thread Ankur Sharma
Hi Numan, Thanks a lot for trying the patch. Yes, as of now i kept RARP and GARP separate entities and that lead to code duplication. Sure, I will try to unify them. I will rebase, make the unification changes and will submit a v2 soon. Regards, Ankur From: Numan Siddique Sent: Tuesday,

Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Ankur Sharma
Hi Numan, Thanks a lot for trying the patch. Just submitted the v3. Regards, Ankur From: Numan Siddique Sent: Tuesday, September 3, 2019 3:42 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

Re: [ovs-dev] [PATCH] tests: Add track-origins flag to valgrind.

2019-09-03 Thread William Tu
On Tue, Sep 03, 2019 at 06:07:26PM +0300, Ilya Maximets wrote: > Useful for tracking where the uninitialized memory came from. > Report example: > > Thread 13 revalidator11: > Conditional jump or move depends on uninitialised value(s) > at 0x4C35D96: __memcmp_sse4_1 (in

[ovs-dev] [branch-2.12 1/2] Set release date for 2.12.0.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index be3ea42b4c91..9f4845d8788e 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,5 @@ -v2.12.0 - xx xxx -- +v2.12.0 -

[ovs-dev] [branch-2.10 2/2] Prepare for 2.10.4.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6233984fa1e0..109d809d6a61 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.10.4 - xx xxx

[ovs-dev] [branch-2.10 1/2] Set release date for 2.10.3.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 064550b038f9..6233984fa1e0 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.10.3 - xx xxx +v2.10.3 - 03 Sep 2019

[ovs-dev] [branch-2.12 2/2] Prepare for 2.12.1.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 9f4845d8788e..877d965e8691 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.12.1 - xx xxx

[ovs-dev] [branch-2.9 2/2] Prepare for 2.9.7.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8f6469fd4dbc..0e708efd64c4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.9.7 - xx xxx

[ovs-dev] [branch-2.9 1/2] Set release date for 2.9.6.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index c1bb90fe03af..8f6469fd4dbc 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.9.6 - xx xxx +v2.9.6 - 03 Sep 2019

[ovs-dev] [branch-2.11 2/2] Prepare for 2.11.3.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f2d44e4630bb..a21d475628d0 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.11.3 - xx xxx

[ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

2019-09-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ff2647739375..f2d44e4630bb 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.11.2 - xx xxx +v2.11.2 - 03 Sep 2019