Re: [ovs-dev] [PATCH v6 ovn 1/4] ovn-controller: Refactor I-P engine_run() tracking.

2019-11-27 Thread Dumitru Ceara
On Wed, Nov 27, 2019 at 12:26 AM Han Zhou wrote: > > > Thanks. I applied this patch to master. I will review the rest in the series. Great, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2 06/10] netdev-offload-tc: Add conntrack support

2019-11-27 Thread Roi Dayan
From: Paul Blakey Zone and ct_state first. Signed-off-by: Paul Blakey --- lib/dpif-netlink.c | 2 + lib/netdev-offload-tc.c | 136 lib/tc.c| 122 +++ lib/tc.h| 11

Re: [ovs-dev] [PATCH v2 06/10] netdev-offload-tc: Add conntrack support

2019-11-27 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I

Re: [ovs-dev] [PATCH v1 1/1] dpdk: Use DPDK 18.11.5 release.

2019-11-27 Thread Stokes, Ian
On 11/26/2019 1:36 PM, Kevin Traynor wrote: On 26/11/2019 12:03, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 18.11.5. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +-

Re: [ovs-dev] OVS Switch Queue

2019-11-27 Thread Ben Pfaff
On Wed, Nov 27, 2019 at 11:50:06AM -0300, Luzzz Dazzz wrote: > I'm trying to investigate the behavior of switches queue. So, what is the > data structure that implements it? We don't have one. When a packet comes in, we don't queue it, we just process it.

[ovs-dev] [PATCH v2 10/10] netdev-offloads-tc: Probe recirc tc sharing feature on first recirc_id rule

2019-11-27 Thread Roi Dayan
From: Paul Blakey Since recirculations splits the datapath processing into multiple rules, and we offload them to tc, when we are done processing in tc, we need to continue in the correct recirc_id in OvS. For that, tc needs to pass the recirculation id back to OvS. We check for kernel support

[ovs-dev] [PATCH v2 05/10] netdev-offload-tc: Add recirculation support via tc chains

2019-11-27 Thread Roi Dayan
From: Paul Blakey Each recirculation id will create a tc chain, and we translate the recirculation action to a tc goto chain action. --- Changelog: V1->V2: moved make_tc_id_chain helper to tc.h as static inline updated is_tc_id_eq with chain compare instead of find_ufid Signed-off-by:

[ovs-dev] [PATCH v2 04/10] netdev-offload-tc: Implement netdev tc flush via tc filter del

2019-11-27 Thread Roi Dayan
From: Paul Blakey To be consistent with our tc-ufid mapping after flush, and to support tc chains flushing in the next commit, implement flush operation via deleting all the filters we actually added and delete their mappings. This will also not delete the configured qos policing via matchall

[ovs-dev] [PATCH v2 02/10] compat: Add tc ct action and flower matches defines for older kernels

2019-11-27 Thread Roi Dayan
From: Paul Blakey Update kernel UAPI to support conntrack matches, and the tc actions ct and goto chain. Signed-off-by: Paul Blakey --- include/linux/automake.mk| 3 ++- include/linux/pkt_cls.h | 46 +--- include/linux/tc_act/tc_ct.h | 41

[ovs-dev] [PATCH v2 03/10] tc: Introduce tc_id to specify a tc filter

2019-11-27 Thread Roi Dayan
From: Paul Blakey Move all that is needed to identify a tc filter to a new structure, tc_id. This removes a lot of duplication in accessing/creating tc filters. --- Changelog: V1->V2: In tc_del_matchall_policer - reverse xmas param order Added and used helper is_tc_id_eq(id1, id2) in

[ovs-dev] [PATCH v2 07/10] netdev-offload-tc: Add conntrack label and mark support

2019-11-27 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey --- lib/dpif-netlink.c | 2 ++ lib/netdev-offload-tc.c | 66 + lib/tc.c| 52 ++ lib/tc.h| 6 + 4 files changed, 116

[ovs-dev] [PATCH v7 ovn 0/3] Refactor I-P engine and fix use after free.

2019-11-27 Thread Dumitru Ceara
The incremental processing engine might stop a run before the en_runtime_data node is processed. In such cases the ed_runtime_data fields might contain pointers to already deleted SB records. For example, if a port binding corresponding to a patch port is removed from the SB database and the

Re: [ovs-dev] [PATCH v2 03/10] tc: Introduce tc_id to specify a tc filter

2019-11-27 Thread Marcelo Ricardo Leitner
On Wed, Nov 27, 2019 at 02:55:09PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Move all that is needed to identify a tc filter to a > new structure, tc_id. This removes a lot of duplication > in accessing/creating tc filters. Ok, gotta say, 'tc_id' is a bit confusing here. Every time I read

Re: [ovs-dev] [PATCH v2 03/10] tc: Introduce tc_id to specify a tc filter

2019-11-27 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Paul Blakey needs to sign off. Lines checked: 745, Warnings: 0, Errors: 1 Please

Re: [ovs-dev] [PATCH v2 08/10] netdev-offload-tc: Add conntrack nat support

2019-11-27 Thread Marcelo Ricardo Leitner
On Wed, Nov 27, 2019 at 02:55:14PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Changelog: > V1->V2: > Missing ntohs/htons on nat port range. > > Signed-off-by: Paul Blakey > --- > lib/netdev-offload-tc.c | 104 > > lib/tc.c

Re: [ovs-dev] [PATCH v2 09/10] tc: Move tunnel_key unset action before output ports

2019-11-27 Thread Marcelo Ricardo Leitner
On Wed, Nov 27, 2019 at 02:55:15PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Since OvS datapath gets packets already decapsulated from tunnel devices, > it doesn't explicitly decapsulate them. So in a recirculation setup, > the tunnel matching continues in the recirculation as the tunnel >

Re: [ovs-dev] [PATCH v1 1/1] dpdk: Use DPDK 18.11.5 release.

2019-11-27 Thread Stokes, Ian
On 11/26/2019 12:18 PM, Ilya Maximets wrote: On 26.11.2019 13:03, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 18.11.5. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +-

Re: [ovs-dev] [PATCH v2 10/10] netdev-offloads-tc: Probe recirc tc sharing feature on first recirc_id rule

2019-11-27 Thread Marcelo Ricardo Leitner
On Wed, Nov 27, 2019 at 02:55:16PM +0200, Roi Dayan wrote: > @@ -1367,7 +1387,7 @@ netdev_tc_flow_put(struct netdev *netdev, struct match > *match, > uint32_t block_id = 0; > struct nlattr *nla; > struct tc_id id; > -uint32_t chain; > +uint32_t chain = 0; > size_t

Re: [ovs-dev] [PATCH v2 05/10] netdev-offload-tc: Add recirculation support via tc chains

2019-11-27 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Paul Blakey needs to sign off. Lines checked: 316, Warnings: 0, Errors: 1 Please

[ovs-dev] [PATCH v2 01/10] match: Add match_set_ct_zone_masked helper

2019-11-27 Thread Roi Dayan
From: Paul Blakey Sets zone in match. Signed-off-by: Paul Blakey --- include/openvswitch/match.h | 2 ++ lib/match.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h index

[ovs-dev] [PATCH v2 09/10] tc: Move tunnel_key unset action before output ports

2019-11-27 Thread Roi Dayan
From: Paul Blakey Since OvS datapath gets packets already decapsulated from tunnel devices, it doesn't explicitly decapsulate them. So in a recirculation setup, the tunnel matching continues in the recirculation as the tunnel metadata still exists on the SKB. Tunnel key unset action unsets this

[ovs-dev] [PATCH v2 08/10] netdev-offload-tc: Add conntrack nat support

2019-11-27 Thread Roi Dayan
From: Paul Blakey Changelog: V1->V2: Missing ntohs/htons on nat port range. Signed-off-by: Paul Blakey --- lib/netdev-offload-tc.c | 104 lib/tc.c| 91 ++ lib/tc.h|

[ovs-dev] [PATCH v2 00/10] Add support for offloading CT datapath rules to TC

2019-11-27 Thread Roi Dayan
The following patchset introduces hardware offload of OVS connection tracking datapath rules. OVS uses ct() and recirc() (recirculation) actions and recirc_id()/ct_state() matches to support connection tracking. The datapath rules are in the form of:

[ovs-dev] [PATCH v7 ovn 3/3] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-27 Thread Dumitru Ceara
The incremental processing engine might stop a run before the en_runtime_data node is processed. In such cases the ed_runtime_data fields might contain pointers to already deleted SB records. For example, if a port binding corresponding to a patch port is removed from the SB database and the

[ovs-dev] [PATCH v7 ovn 1/3] ovn-controller: Add per node states to I-P engine.

2019-11-27 Thread Dumitru Ceara
This commit transforms the 'changed' field in struct engine_node in a 'state' field. Possible node states are: - "Stale": data in the node is not up to date with the DB. - "Updated": data in the node is valid but was updated during the last run of the engine. - "Valid": data in the node is valid

[ovs-dev] [PATCH v7 ovn 2/3] ovn-controller: Add separate I-P engine node for processing ct-zones.

2019-11-27 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- controller/ovn-controller.c | 117 +-- 1 file changed, 78 insertions(+), 39 deletions(-) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index 255531d..f5a83f9 100644 ---

[ovs-dev] OVS Switch Queue

2019-11-27 Thread Luzzz Dazzz
Hello I'm trying to investigate the behavior of switches queue. So, what is the data structure that implements it? Is there a way to query the number of packets that are currently waiting to be processed by a queue of a switch? If no, how could we provide it?

Re: [ovs-dev] [PATCH v2 07/10] netdev-offload-tc: Add conntrack label and mark support

2019-11-27 Thread Marcelo Ricardo Leitner
On Wed, Nov 27, 2019 at 02:55:13PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Signed-off-by: Paul Blakey > --- > lib/dpif-netlink.c | 2 ++ > lib/netdev-offload-tc.c | 66 > + > lib/tc.c| 52

Re: [ovs-dev] [PATCH] debian: Update list of copyright holders.

2019-11-27 Thread Yi-Hung Wei
On Wed, Oct 9, 2019 at 10:35 AM Ben Pfaff wrote: > > The list of copyright holders was incomplete and out of date. This > updates it based on a "grep" for copyright notices, which I reviewed by > hand. > > CC: 942...@bugs.debian.org > Reported-by: Chris Lamb > Reported-at:

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Restore table ID on error in xlate_table_action().

2019-11-27 Thread Yi-Hung Wei
On Mon, Oct 14, 2019 at 4:33 PM Ben Pfaff wrote: > > Found by inspection. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index f92cb62c80ce..0fa5d8a7c61b

[ovs-dev] Indicadores económicos y de precios

2019-11-27 Thread Cierre de Inscripciones
Me da mucho gusto saludarte. Es, para mí, un placer poder invitarte a nuestro Curso en Línea "Indicadores de compras para una administración óptima", que se estará llevando a cabo el día Martes 17 de Diciembre con un horario de 10:00 a 17:00 hrs. (hora del centro de México) Diseñar

Re: [ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

2019-11-27 Thread David Marchand
On Thu, Nov 21, 2019 at 3:35 PM Ilya Maximets wrote: > > On 21.11.2019 14:58, Ilya Maximets wrote: > > 'ol_flags' of DPDK mbuf could contain bits responsible for external > > or indirect buffers which are not actually offload flags in a common > > sense. Clearing/copying of these flags could

Re: [ovs-dev] [OVN][RAFT] Follower refusing new entries from leader

2019-11-27 Thread taoyunupt
Hi,Han Thanks for your reply. I think maybe we can disconnect the failed follower from the Haproxy then synchronize the date, after all completed, reconnect it to Haproxy again. But I do not know how to synchronize actually. It is just my naive idea. Do you have some

Re: [ovs-dev] [PATCH] Documentation: Convert multiple manpages to ReST.

2019-11-27 Thread Numan Siddique
On Thu, Nov 28, 2019 at 12:49 PM Numan Siddique wrote: > > On Wed, Nov 27, 2019 at 4:10 AM Ben Pfaff wrote: > > > > On Thu, Oct 10, 2019 at 02:29:42PM -0700, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > > > Still needs review. > > Hi Ben, > > Can you please rebase this patch. It doesn't

Re: [ovs-dev] [PATCH] Documentation: Convert multiple manpages to ReST.

2019-11-27 Thread Numan Siddique
On Wed, Nov 27, 2019 at 4:10 AM Ben Pfaff wrote: > > On Thu, Oct 10, 2019 at 02:29:42PM -0700, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Still needs review. Hi Ben, Can you please rebase this patch. It doesn't apply. Thanks Numan > ___ >

[ovs-dev] Comment financer sa formation : découvrez le Guide 2020 des dispositifs de financement

2019-11-27 Thread Guide du Financement
Logo Office Academy FORMATION PROFESSIONNELLE Guide 2020 des dispositifs de financement Salaris, demandeurs d’emploi, chefs d’entreprise, agents de l’Etat… Quel que soit votre statut, il existe en France de nombreuses solutions pour financer vos projets de formation. TÉLÉCHARGER LE GUIDE Une

Re: [ovs-dev] [OVN][RAFT] Follower refusing new entries from leader

2019-11-27 Thread Han Zhou
On Wed, Nov 27, 2019 at 7:22 PM taoyunupt wrote: > > Hi, > My OVN cluster has 3 OVN-northd nodes, They are proxied by Haproxy with a VIP. Recently, I restart OVN cluster frequently. One of the members report the logs below. > After read the code and paper of RAFT, it seems normal process

[ovs-dev] Técnicas 2020 para un reclutamiento efectivo

2019-11-27 Thread Head Hunting y Employeer Branding
10 de Enero | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - Técnicas 2020 para un reclutamiento efectivo - Reclutamiento 4.0, Head Hunting y Employeer Branding. ¿De qué hablaremos? Nuestro webinar te presentará una guía del panorama actual del reclutamiento y las

[ovs-dev] [OVN][RAFT] Follower refusing new entries from leader

2019-11-27 Thread taoyunupt
Hi, My OVN cluster has 3 OVN-northd nodes, They are proxied by Haproxy with a VIP. Recently, I restart OVN cluster frequently. One of the members report the logs below. After read the code and paper of RAFT, it seems normal process ,If the follower does not find an entry in its log

Re: [ovs-dev] [PATCH v6 ovn 2/4] ovn-controller: Add per node states to I-P engine.

2019-11-27 Thread Dumitru Ceara
On Wed, Nov 27, 2019 at 2:24 AM Han Zhou wrote: > > Thanks Dumitru, please see my comments inlined. Thanks Han for the review. > > On Fri, Nov 22, 2019 at 8:13 AM Dumitru Ceara wrote: > > > > This commit transforms the 'changed' field in struct engine_node in a > > 'state' field. Possible node