From: Flavio Leitner
This provides a software implementation in the case
the egress netdev doesn't support segmentation in hardware.
The challenge here is to guarantee packet ordering in the
original batch that may be full of TSO packets. Each TSO
packet can go up to ~64kB, so with segment size
From: Flavio Leitner
Currently OVS will calculate the segment size based on the
MTU of the egress port. That usually happens to be correct
when the ports share the same MTU, but that is not always true.
Therefore, if the segment size is provided, then use that and
make sure the over sized
On Tue, Jul 4, 2023 at 9:00 PM Ilya Maximets wrote:
>
> On 6/21/23 22:36, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > This provides a software implementation in the case
> > the egress netdev doesn't support segmentation in hardware.
> >
> > The challenge here is to guarantee packet
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for asynchronous DNS resolving
The above version uses the unbound C library, and this
implimentation uses the SWIG-wrapped Python version of that.
In the event that the Python unbound library is not
On 7 Jul 2023, at 22:07, Chandan Somani wrote:
> This will be useful for correcting possible spelling
> mistakes with ease. Suggestions limited to 3 at first,
> but configurable in the future.
>
> Signed-off-by: Chandan Somani
> Acked-by: Aaron Conole
> ---
This looks good, thank Chandan.
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds non-null pointer assertions in some code that performs
> some decisions based on old and new input ovsdb_rows.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by: Simon Horman
What about error messages/argument
On 7/10/23 22:20, Vladislav Odintsov wrote:
> Hi Dumitru,
>
> thanks for digging into this! I highly appreciate your help!
>
No worries, my pleasure! :)
> Please, see my answers inline.
>
>> On 10 Jul 2023, at 15:28, Dumitru Ceara wrote:
>>
>> On 7/10/23 12:57, Dumitru Ceara wrote:
>>> On
On 7 Jul 2023, at 22:07, Chandan Somani wrote:
> Single out flagged words and allow for more useful
> details, like spelling suggestions. Fixed syntax
> error from v1
>
> Signed-off-by: Chandan Somani
Hi Chandan,
Thanks for the patch! I think it looks good, however some small comments on the
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds assertions in the functions `shash_count`,
> `simap_count`, and `smap_count` to ensure that the corresponding input
> struct pointer is not NULL.
>
> This ensures that if the return values of `shash_sort`, `simap_sort`,
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds a few null pointer assertions and checks to some return
> values of `ovsdb_table_schema_get_column`. If a null pointer is
> encountered in these blocks, either the assertion will fail or the
> control flow will now be
On 10 Jul 2023, at 17:34, Mike Pattrick wrote:
> Currently OVS keeps track of which mirrors that each packet has been
> sent to for the purpose of deduplication. However, this doesn't consider
> that openflow rules can make significant changes to packets after
> ingress.
>
> For example, OVN
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`,
> initializing a `pollfd` struct variable with zeroes, and changing some
> calls to `xmalloc` to
On 7/5/23 01:29, Flavio Leitner wrote:
> Today the exit code refers to the execution of the change
> in the database. However, when not using parameter --no-wait
> (default), the ovs-vsctl also checks if OVSDB transactions
> are successfully recorded and reload by ovs-vswitchd. In this
> case, an
On 7/10/23 16:33, Eelco Chaudron wrote:
On 10 Jul 2023, at 16:26, Adrian Moreno wrote:
On 7/10/23 16:19, Adrian Moreno wrote:
On 7/6/23 14:50, Eelco Chaudron wrote:
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
Instead of relying on feature bits, use the speed value directly as
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds some `ovs_assert()` checks to some return values of
> `dp_packet_data()` to ensure that they are not NULL and to prevent
> null-pointer dereferences, which might lead to unwanted crashes. We use
> assertions since it
On 5 Jul 2023, at 1:29, Flavio Leitner wrote:
> Today the exit code refers to the execution of the change
> in the database. However, when not using parameter --no-wait
> (default), the ovs-vsctl also checks if OVSDB transactions
> are successfully recorded and reload by ovs-vswitchd. In this
On Tue, Jul 11, 2023 at 7:14 AM Ales Musil wrote:
>
>
> On Mon, Jul 10, 2023 at 5:26 PM Dumitru Ceara wrote:
>
>> If we want to catch new failures faster we have a better chance if CI
>> doesn't auto-retry (once).
>>
>> There are some tests that are still "unstable" and fail every now and
>>
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This patch adds an assortment of `ovs_assert` statements to check for
> null pointers. We use assertions since it should be impossible for any
> of these pointers to be NULL.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by:
On 10 Jul 2023, at 17:20, Mike Pattrick wrote:
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
> xlate_resubmit_resource_check() is able to
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> In the case where routing is enabled, the bridge member of the
> `vsctl_port` structs is not populated. This can cause a crash if we
> attempt to access it. This patch fixes the crash by checking if the
> bridge member is valid before
On 7 Jul 2023, at 22:07, Chandan Somani wrote:
> This narrows down spelling errors that are in the commit
> subject. In v2, it also provides a subject if the subject
> line is missing. The provisional subject is the name of the
> patch file, which should provide some context about the patch.
>
On 7/11/23 10:30, Ales Musil wrote:
> On Tue, Jul 11, 2023 at 7:14 AM Ales Musil wrote:
>
>>
>>
>> On Mon, Jul 10, 2023 at 5:26 PM Dumitru Ceara wrote:
>>
>>> If we want to catch new failures faster we have a better chance if CI
>>> doesn't auto-retry (once).
>>>
>>> There are some tests that
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds various null pointer checks to some files in the `lib`
> and the `ovsdb` directories to fix several Coverity defects. These
> changes are grouped together as they perform similar checks, returning
> early or skipping
On 7/11/23 18:33, Vladislav Odintsov wrote:
> Hi Dumitru,
>
> The system on which I reproduced this issue is running 22.09.x version. I’ve
> tried to upgrade ovn-controller to main branch + your patch. Please, note
> that it has test error: [1].
> After two minutes after upgrade it still
On Sat, Jul 8, 2023 at 1:27 AM Mark Michelson wrote:
>
> Hi Numan,
>
> I gave the series a look. I've looked at the code but haven't yet run
> any tests with it. The main reason for this is that the series does not
> apply cleanly to OVN main.
>
> Overall, I only have small notes. I've replied to
Just a small update,
We have moved the conference dates to December 6-7, 2023 so as to not overlap
with another networking conference happening around the same time.
Stay tuned for further updates!
Thank you!
Conference Team
On Fri, Jul 7, 2023 at 1:23 PM Michael Santana wrote:
>
> Hello
Hi Dumitru,
The system on which I reproduced this issue is running 22.09.x version. I’ve
tried to upgrade ovn-controller to main branch + your patch. Please, note that
it has test error: [1].
After two minutes after upgrade it still consumed 3.3G.
I tried to backport your patch to 22.09, it
On 11 Jul 2023, at 16:33, Ilya Maximets wrote:
> On 7/11/23 12:13, Eelco Chaudron wrote:
>>
>>
>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>
>>> This commit adds a few null pointer assertions and checks to some return
>>> values of `ovsdb_table_schema_get_column`. If a null
On 7/11/23 12:13, Eelco Chaudron wrote:
>
>
> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>
>> This commit adds a few null pointer assertions and checks to some return
>> values of `ovsdb_table_schema_get_column`. If a null pointer is
>> encountered in these blocks, either the
On 7/11/23 12:17, Eelco Chaudron wrote:
>
>
> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>
>> This commit adds non-null pointer assertions in some code that performs
>> some decisions based on old and new input ovsdb_rows.
>>
>> Signed-off-by: James Raphael Tiovalen
>>
On 11 Jul 2023, at 16:38, Ilya Maximets wrote:
> On 7/11/23 12:17, Eelco Chaudron wrote:
>>
>>
>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>
>>> This commit adds non-null pointer assertions in some code that performs
>>> some decisions based on old and new input ovsdb_rows.
>>>
On Tue, Jul 11, 2023 at 12:38 AM Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 22:07, Chandan Somani wrote:
>
> > This narrows down spelling errors that are in the commit
> > subject. In v2, it also provides a subject if the subject
> > line is missing. The provisional subject is the name of the
Chandan Somani writes:
> Single out flagged words and allow for more useful
> details, like spelling suggestions. Fixed syntax
> error from v1
>
> Signed-off-by: Chandan Somani
> ---
Thanks!
Acked-by: Aaron Conole
> utilities/checkpatch.py | 12 +---
> 1 file changed, 9
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for asynchronous DNS resolving
The above version uses the unbound C library, and this
implimentation uses the SWIG-wrapped Python version of that.
In the event that the Python unbound library is not
On 7/6/23 09:25, Adrian Moreno wrote:
>
>
> On 7/5/23 22:02, Sayali Naval (sanaval) via dev wrote:
>> As per the Open vSwitch Manual
>> (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge
>> IPFIX parameters can be passed as follows:
>>
>> ovs-vsctl -- set Bridge br0
Eric Garver writes:
> On Mon, Jul 10, 2023 at 06:51:19PM +0200, Ilya Maximets wrote:
>> On 7/8/23 00:06, Jakub Kicinski wrote:
>> > On Fri, 7 Jul 2023 18:04:36 +0200 Ilya Maximets wrote:
>> That already exists, right? Johannes added it in the last release for
>> WiFi.
>> >>>
>> >>>
On 7/11/23 12:05, Eelco Chaudron wrote:
>
>
> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>
>> This commit adds assertions in the functions `shash_count`,
>> `simap_count`, and `smap_count` to ensure that the corresponding input
>> struct pointer is not NULL.
>>
>> This ensures that
On 7/11/23 13:40, Eelco Chaudron wrote:
>> diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c
>> index 5361b3c76..a3ca48a7b 100644
>> --- a/ovsdb/jsonrpc-server.c
>> +++ b/ovsdb/jsonrpc-server.c
>> @@ -1131,6 +1131,8 @@ static void
>> ovsdb_jsonrpc_trigger_create(struct
On 7/11/23 19:01, Dumitru Ceara wrote:
> On 7/11/23 18:33, Vladislav Odintsov wrote:
>> Hi Dumitru,
>>
>> The system on which I reproduced this issue is running 22.09.x version. I’ve
>> tried to upgrade ovn-controller to main branch + your patch. Please, note
>> that it has test error: [1].
>>
On 7/11/23 16:41, Eelco Chaudron wrote:
>
>
> On 11 Jul 2023, at 16:33, Ilya Maximets wrote:
>
>> On 7/11/23 12:13, Eelco Chaudron wrote:
>>>
>>>
>>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>>
This commit adds a few null pointer assertions and checks to some return
On 7/11/23 12:22, Eelco Chaudron wrote:
>
>
> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>
>> In the case where routing is enabled, the bridge member of the
>> `vsctl_port` structs is not populated. This can cause a crash if we
>> attempt to access it. This patch fixes the crash by
On 7/11/23 17:08, Eelco Chaudron wrote:
>
>
> On 11 Jul 2023, at 16:38, Ilya Maximets wrote:
>
>> On 7/11/23 12:17, Eelco Chaudron wrote:
>>>
>>>
>>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>>
This commit adds non-null pointer assertions in some code that performs
Eelco Chaudron writes:
> On 7 Jul 2023, at 22:07, Chandan Somani wrote:
>
>> This narrows down spelling errors that are in the commit
>> subject. In v2, it also provides a subject if the subject
>> line is missing. The provisional subject is the name of the
>> patch file, which should provide
43 matches
Mail list logo
