Re: [ovs-dev] [PATCH] dpdk: Fix abort on double free.

On 28.11.2016 21:55, Aaron Conole wrote: > Ilya Maximets writes: > >> According to DPDK API (lib/librte_eal/common/include/rte_eal.h): >> >> "After the call to rte_eal_init(), all arguments argv[x] >> with x < ret may be modified and should not be accessed >>

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

On Mon, Nov 28, 2016 at 05:37:48PM -0800, Joe Stringer wrote: > On 28 November 2016 at 17:00, Ben Pfaff wrote: > > On Fri, Oct 21, 2016 at 11:47:54AM -0700, Pravin Shelar wrote: > >> On Fri, Oct 21, 2016 at 11:39 AM, Joe Stringer wrote: > >> > On 21 October 2016 at

Re: [ovs-dev] [PATCH v4] ovn-northd: Force SNAT for multiple gateway routers.

Acked-by: Mickey Spiegel A few comments and nits below. On Thu, Nov 17, 2016 at 10:17 PM, Gurucharan Shetty wrote: > When multiple gateway routers exist, a packet can > enter any gateway router. Once the packet reaches its > destination, its reverse

[ovs-dev] Administración de Sueldos - En Línea

En línea y en Vivo / Para todo su Equipo con una sola Conexión Administración de Sueldos y Programas de Compensación 14 de diciembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs Mantenga salarios competitivos sin dañar la economía de su empresa. Las presiones económicas

Re: [ovs-dev] [PATCH 2/2] ovn-trace: Fix implementation of get_arp and get_nd logical actions.

On Mon, Nov 28, 2016 at 02:27:11PM -0500, Aaron Conole wrote: > Ben Pfaff writes: > > > These actions looked up the MAC binding but failed to update eth.dst with > > the result. > > > > Signed-off-by: Ben Pfaff > > --- > > This looks safe to me. > > Reviewed-by:

Re: [ovs-dev] [PATCH v2 7/7] checkpatch: Add file-parsing mode

On Fri, Oct 21, 2016 at 02:49:09PM -0400, Aaron Conole wrote: > This adds a new argument and feature, 'check-file', which will allow > checkpatch to run against files instead of only against patches. > > Signed-off-by: Aaron Conole Thanks for the patches. I applied all of

Re: [ovs-dev] [PATCH v2 1/7] checkpatch: Announce the file where errors occur

On Fri, Oct 21, 2016 at 02:49:03PM -0400, Aaron Conole wrote: > This makes finding the warning and error marks much easier. > > Signed-off-by: Aaron Conole Thanks, I applied this to master, it's certainly going to be a help sometimes. However, I'm used to error message in a

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

On Fri, Oct 21, 2016 at 11:47:54AM -0700, Pravin Shelar wrote: > On Fri, Oct 21, 2016 at 11:39 AM, Joe Stringer wrote: > > On 21 October 2016 at 11:37, Joe Stringer wrote: > >> On 21 October 2016 at 10:55, Pravin B Shelar wrote: > >>> On upstream

Re: [ovs-dev] [PATCH v12 rebased 1/3] userspace: add support for pop_eth and push_eth actions

On Wed, Oct 19, 2016 at 07:21:17PM +0200, Jiri Benc wrote: > From: Lorand Jakab > > These actions will allow L2->L3 and L3->L2 switching, and are supposed > to be added to flows installed in the datapath transparently by > ovs-vswitchd. > > Signed-off-by: Lorand Jakab

[ovs-dev] [PATCH] tests: Test reset_counts in flow_mod message

commit 23c753793204df86aa6eedd00ec62911a1ef9559 Author: Tony van der Peet Date: Tue Nov 29 13:16:17 2016 +1300 tests: Test reset_counts in flow_mod message Setting the reset_counts flag in a flow_mod message should cause the flow counters to be

Re: [ovs-dev] [PATCH] tests: Test reset_counts in flow_mod message

Actually, I have a split personality wrt Open vSwitch. I should probably post this from my work email account. See if that works any better. Tony On Tue, Nov 29, 2016 at 1:36 PM, Ben Pfaff wrote: > Hi, thanks for the patch. It came across word-wrapped, e.g. the > following should

Re: [ovs-dev] [PATCH] tests: Test reset_counts in flow_mod message

Hi, thanks for the patch. It came across word-wrapped, e.g. the following should be only a single line: On Tue, Nov 29, 2016 at 01:22:41PM +1300, Tony van der Peet wrote: > +ovs-appctl netdev-dummy/receive p1 >

[ovs-dev] [PATCH] tests: Test reset_counts in flow_mod message

commit 23c753793204df86aa6eedd00ec62911a1ef9559 Author: Tony van der Peet Date: Tue Nov 29 13:16:17 2016 +1300 tests: Test reset_counts in flow_mod message Setting the reset_counts flag in a flow_mod message should cause the flow counters to be

Re: [ovs-dev] [RFC] [PATCH] ovn: Support sample action in logical datapath

On Fri, Oct 14, 2016 at 04:35:46PM +0500, Valentine Sinitsyn wrote: > This is a quick attempt to implement sample action at logical port level.The > goal is to export IPFIX flows for logical ports, yet it is easy to extend > this approach to logical switches as well. > > Nothing is done to

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

Ben, The current proposal that Yin has put out calls for a new daemon that monitors VIFs that show up on the native HyperV swtitch, gives them a name and adds it to OVSDB. It does it change the existing workflow. You can think of it as how libvirt integrates with OVS in terms of adding ports

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

Does this actually call for vswitchd to add ports? Reading it, it looks like the new daemon does that. But I didn't read it carefully enough to understand it in full. On Mon, Nov 28, 2016 at 11:13:21PM +, Nithin Raju wrote: > hi Alin, > Thanks for the comments. > > There has not been a

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

hi Alin, Thanks for the comments. There has not been a case so far (AFAIK) where vswitchd added ports to OVSDB. This would be a diversion from that. We’ll have to take this up with Ben or Justin to see how they feel. Thanks, -- Nithin On Nov 28, 2016, at 11:18 AM, Alin Serdean

Re: [ovs-dev] [PATCH] netdev-dpdk: Assign value '0' to unsupported netdev features

On Thu, Oct 13, 2016 at 11:18:20PM +0800, Binbin Xu wrote: > When OVS is used, DPDK doesn't support features 'advertised', > 'supported' and 'peer'. If a physical port added to bridge, features > descirbed above can't be assigned, and the values are random. > > Signed-off-by: Binbin Xu

Re: [ovs-dev] [patch_v8] ovn: Add datapaths of interest filtering.

I hope that this version is ready to go in. Liran, are you happy with this version? On Sun, Nov 27, 2016 at 01:08:59PM -0800, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea

Re: [ovs-dev] [patch_v6 2/3] ovn: Add additional comments regarding arp responders.

On Fri, Nov 04, 2016 at 10:06:17AM -0700, Darrell Ball wrote: > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding why they exist and > document the special cases. > >

Re: [ovs-dev] [PATCH] dist-docs: typo in IntegrationGuide.rst

On Mon, Nov 28, 2016 at 3:50 PM, Lance Richardson wrote: > Unbalanced angle bracket was causing 'Unknown target name: "ocf > when building dist-docs. > > Signed-off-by: Lance Richardson

Re: [ovs-dev] [PATCH v2 2/2] rhel: Add EnvironmentFile for ovn services.

On Fri, Nov 25, 2016 at 9:16 AM, Simon Horman wrote: > On Wed, Nov 23, 2016 at 03:01:24PM -0500, Russell Bryant wrote: > > A previous commit documented how you do this using systemd > > native interfaces for customizing services. However, it seems > > that some

Re: [ovs-dev] [PATCH v2 1/2] rhel: Fix Environment for ovn-controller-vtep.

On Fri, Nov 25, 2016 at 9:14 AM, Simon Horman wrote: > Hi Russell, > > On Wed, Nov 23, 2016 at 03:01:23PM -0500, Russell Bryant wrote: > > The systemd unit for ovn-controller-vtep incorrectly specified > > Environment multiple times. Multiple environment variables

[ovs-dev] Guía para Elaborar un Mapeo de Procesos

En línea y en Vivo / Para todo su Equipo con una sola Conexión Guía para Elaborar un Mapeo de Procesos 13 de diciembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs Este seminario está diseñado, en teoría y práctica, para aprender a mapear los procesos con un enfoque

Re: [ovs-dev] [PATCH] dpdk: Fix abort on double free.

Ilya Maximets writes: > According to DPDK API (lib/librte_eal/common/include/rte_eal.h): > > "After the call to rte_eal_init(), all arguments argv[x] >with x < ret may be modified and should not be accessed >by the application." > > This means, that

Re: [ovs-dev] [PATCH] Numa: Allow leading 0x on pmd-cpu-mask.

On Mon, Nov 28, 2016 at 05:06:53PM +, billy.o.mah...@intel.com wrote: > From: billyom > > pmd-cpu-mask is interpreted as a hex bit mask. So it should be written > with a leading 0x to indicate this. But if this is done, while the value > is interpreted correctly and

[ovs-dev] [PATCH] Numa: Allow leading 0x on pmd-cpu-mask.

From: billyom pmd-cpu-mask is interpreted as a hex bit mask. So it should be written with a leading 0x to indicate this. But if this is done, while the value is interpreted correctly and the PMDs pinned as expected, a confusing warning message is also issued. This

[ovs-dev] [PATCH v6] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

Add Rx checksum offloading feature support on DPDK physical ports. By default, the Rx checksum offloading is enabled if NIC supports. However, the checksum offloading can be turned OFF either while adding a new DPDK physical port to OVS or at runtime. The rx checksum offloading can be turned off

[ovs-dev] [PATCH] dpdk: Fix abort on double free.

According to DPDK API (lib/librte_eal/common/include/rte_eal.h): "After the call to rte_eal_init(), all arguments argv[x] with x < ret may be modified and should not be accessed by the application." This means, that OVS must not free the arguments passed to DPDK. In

[ovs-dev] [PATCH] datapath-windows: fix return value in conntrack

'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type bool. Signed-off-by: Alin Gabriel Serdean Acked-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 14 -- 1 file changed, 8 insertions(+), 6

[ovs-dev] [PATCH] rhel: Support building python ovs package with native json impl

Since building python-openvswitch _json.so requires libopenvswitch.so a separate spec file is added which configures Open vSwitch with --enable-shared flag. The resulting RPM also includes the Open vSwitch shared library. $ rpm -qlp python-openvswitch-2.6.90-1.fc25.x86_64.rpm