Re: [ovs-dev] [RFC] Introducing experimental OVN integration for Mesos

2016-12-06 Thread Salvatore Orlando
I am unfortunately not very up-to-date with Mesos, but I reckon it is fair to assume that in the current status N/S connectivity to containers should be handled outside of mesos infrastructure, ie: OVN can define a topology that enables external users to reach the LSPs in the LS specified in the CN

Re: [ovs-dev] [PATCH] ovn: Fix the wrong return, otherwise it will cause the document more than one space.

2016-12-06 Thread Ben Pfaff
On Wed, Dec 07, 2016 at 02:07:05PM +0800, Guoshuai Li wrote: > Signed-off-by: Guoshuai Li > --- > IntegrationGuide.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/IntegrationGuide.rst b/IntegrationGuide.rst > index d34e9ed..11e77ba 100644 > --- a/IntegrationGuide

[ovs-dev] [PATCH 4/4] [RFC] ofproto-dpif: Make ofproto/trace output easier to read.

2016-12-06 Thread Ben Pfaff
"ovs-appctl ofproto/trace" is invaluable for debugging, but as the users of Open vSwitch have evolved it has failed to keep up with the times. It's pretty easy to design OpenFlow tables and pipelines that resubmit dozens of times. Each resubmit causes an additional tab of indentation, so the outp

[ovs-dev] [PATCH 3/4] ofproto-dpif: Break trace functionality into a separate source file.

2016-12-06 Thread Ben Pfaff
An upcoming commit will rewrite much of the ofproto/trace functionality. As the mechanism behind this grows and evolves, it makes sense to move it into its own file, especially since ofproto-dpif.c is too big anyway. Signed-off-by: Ben Pfaff --- ofproto/automake.mk | 2 + ofproto/ofpr

[ovs-dev] [PATCH 2/4] ofproto-dpif: Unhide structure contents.

2016-12-06 Thread Ben Pfaff
Until now, ofproto-dpif.c has hidden the definitions of several structures, such as struct ofproto_dpif and struct rule_dpif. This kind of information hiding is often beneficial, because it forces code outside the file with the definition to use the documented interfaces. However, in this case it

[ovs-dev] [PATCH 1/4] ofproto: Update access rules for 'flow_cookie'.

2016-12-06 Thread Ben Pfaff
The 'flow_cookie' member of struct rule is read during flow translation without holding a mutex, breaking the documented OVS_GUARDED access rule. However, the flow_cookie member is actually never modified after a rule is initialized, so this commit changes the access rules to reflect that. Signed-

[ovs-dev] [PATCH V3] python: Fix The SSL connection is not reconnected when the OVSDB Server is restarted

2016-12-06 Thread Guoshuai Li
the do_handshake() function throws the exception OpenSSL.SSL.SysCallError when the peer's SSL connection is closed, And the recv() function also throws the exception OpenSSL.SSL.SysCallError when the peer's SSL connection is abnormally closed, we need to catch the exception and return error's err

[ovs-dev] [PATCH] ovn: Fix the wrong return, otherwise it will cause the document more than one space.

2016-12-06 Thread Guoshuai Li
Signed-off-by: Guoshuai Li --- IntegrationGuide.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/IntegrationGuide.rst b/IntegrationGuide.rst index d34e9ed..11e77ba 100644 --- a/IntegrationGuide.rst +++ b/IntegrationGuide.rst @@ -240,8 +240,8 @@ Whenever the active serve

Re: [ovs-dev] [patch_v11] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
The commit message was a bit stale, so I sent a v12. On 12/6/16, 9:06 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball" wrote: This patch adds datapaths of interest support where only datapaths of local interest are monitored by the ovn-controller ovsdb client. The id

[ovs-dev] [patch_v12] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
This patch adds datapaths of interest support where only datapaths of local interest are monitored by the ovn-controller ovsdb client. The idea is to do a flood fill in ovn-controller of datapath associations calculated by northd. A new column is added to the SB database datapath_binding table - r

[ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

2016-12-06 Thread Guoshuai Li
When the master node's OVNDB process fails, the local node demote to the slave. Failure cause is that the OVNDB process is stop, So the need to re-run the process up. if return $OCF_NOT_RUNNING will not demote the node to slave. Signed-off-by: Guoshuai Li --- ovn/utilities/ovndb-servers.ocf | 2

[ovs-dev] [patch_v11] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
This patch adds datapaths of interest support where only datapaths of local interest are monitored by the ovn-controller ovsdb client. The idea is to do a flood fill in ovn-controller of datapath associations calculated by northd. A new column is added to the SB database datapath_binding table - r

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
On 12/6/16, 7:08 PM, "ovs-dev-boun...@openvswitch.org on behalf of Russell Bryant" wrote: On Tue, Dec 6, 2016 at 3:35 PM, Ben Pfaff wrote: > On Tue, Dec 06, 2016 at 02:45:19PM -0500, Russell Bryant wrote: > > On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff wrote: > > > > >

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
On 12/4/16, 9:48 PM, "ovs-dev-boun...@openvswitch.org on behalf of Mickey Spiegel" wrote: On Sun, Dec 4, 2016 at 4:13 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb cl

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Yang, Yi
On Tue, Dec 06, 2016 at 03:51:03PM +0100, Jiri Benc wrote: > On Tue, 6 Dec 2016 07:17:20 +, Yang, Yi Y wrote: > > So my advice about this is we can push patch [2] to Linux net-next > > first, then apply patch series > > https://mail.openvswitch.org/pipermail/ovs-dev/2016-June/316879.html > > fr

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Russell Bryant
On Tue, Dec 6, 2016 at 3:35 PM, Ben Pfaff wrote: > On Tue, Dec 06, 2016 at 02:45:19PM -0500, Russell Bryant wrote: > > On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff wrote: > > > > > On Sun, Dec 04, 2016 at 04:13:44PM -0800, Darrell Ball wrote: > > > > This patch adds datapaths of interest support wh

Re: [ovs-dev] [PATCH] windows: Change driver and MSI company name to LF

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 11:30:36PM +, Alin Serdean wrote: > Until now we used 'Open vSwitch' as the company/organization name. > > The project is now under The Linux Foundation ownership. > > This patch updates the MSI and driver attributes to reflect that ownership. > > Signed-off-by: Alin

Re: [ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

2016-12-06 Thread Andy Zhou
On Fri, Dec 2, 2016 at 11:38 PM, Guoshuai Li wrote: > PCS man page says role=Stopped/Started/Master/Slave. > A role can be master or slave (if no role is specified, it defaults to > 'started'). > > Command line "$pcs constraint colocation add ovndb_servers-master with > master VirtualIP" > means

Re: [ovs-dev] [PATCH 4/4] configure: Enable new warning options added in GCC 6.

2016-12-06 Thread Andy Zhou
On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff wrote: > -Wnull-dereference is also new in GCC 6 but upon testing it produces far > too many false positives to be usable for OVS. > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou ___ dev mailing list d...@

Re: [ovs-dev] [PATCH 3/4] configure: Enable new warning options added in GCC 5.

2016-12-06 Thread Andy Zhou
On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/4] configure: Use -Wformat-security with -Wformat.

2016-12-06 Thread Andy Zhou
On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff wrote: > GCC 6.1 warns that -Wformat-security has no effect without -Wformat, so > this commit fixes the problem. > > The change to _OVS_CHECK_CC_OPTION is needed so that the cache variable > name doesn't end up with a space in it, which obviously doesn't

Re: [ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

2016-12-06 Thread Andrew Beekhof
Based on the description, the amended constraint looks correct. On Tue, Dec 6, 2016 at 11:49 PM, Babu Shanmugam wrote: > + Andrew. > > Hi Andrew, > > Please see below. Your comments are most welcome. > > -- > > Babu > > On Saturday 03 December 2016 01:08 PM, Guoshuai Li wrote: >> >> PCS man page

[ovs-dev] Cómo Proteger sus Derechos

2016-12-06 Thread Devolución de Impuestos - En Línea
En línea y en Vivo / Para todo su Equipo con una sola Conexión Devolución de Impuestos Y Las Reacciones de las Autoridades fiscales Cómo proteger sus derechos en la PRODECON 21 de diciembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs Requerimientos EXCESIVOS, desistimient

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Yang, Yi
On Tue, Dec 06, 2016 at 03:51:03PM +0100, Jiri Benc wrote: > On Tue, 6 Dec 2016 07:17:20 +, Yang, Yi Y wrote: > > So my advice about this is we can push patch [2] to Linux net-next > > first, then apply patch series > > https://mail.openvswitch.org/pipermail/ovs-dev/2016-June/316879.html > > fr

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

2016-12-06 Thread Alin Serdean
Sounds good :). > -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Tuesday, December 6, 2016 8:53 PM > To: Alin Serdean ; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce > support for tracking related connec

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-06 Thread Alin Serdean
Unified code for the threading part sounds good. Can you please add an item to https://github.com/openvswitch/ovs-issues/issues so we can tackle it later on? I'm okay with leaving the init/cleanup as it is for the moment. Thanks, Alin. > -Original Message- > From: Sairam Venugopal [mai

[ovs-dev] [PATCH] windows: Change driver and MSI company name to LF

2016-12-06 Thread Alin Serdean
Until now we used 'Open vSwitch' as the company/organization name. The project is now under The Linux Foundation ownership. This patch updates the MSI and driver attributes to reflect that ownership. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/TunnelFilter.c| 2 +- data

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Yang, Yi
On Tue, Dec 06, 2016 at 09:38:09AM -0500, Eric Garver wrote: > On Tue, Dec 06, 2016 at 07:17:20AM +, Yang, Yi Y wrote: > > Hi, guys > > Hi Yi, > > > This patch isn't updated from June on, Cascardo said he/Eric is still > > working on this, but six months passed, we don't see any following >

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Yang, Yi
On Tue, Dec 06, 2016 at 09:46:04AM -0800, Pravin Shelar wrote: > > lib/dpif-netlink.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c > > index 0d03334..2286c3e 100644 > > --- a/lib/dpif-netlink.c > > +++ b/lib/dpif-netlink.c > > @@ -1062,

Re: [ovs-dev] [PATCH v2 18/19] dpif-netdev: Centralized threads and queues handling code.

2016-12-06 Thread Daniele Di Proietto
On 06/12/2016 04:48, "Ilya Maximets" wrote: >On 03.12.2016 05:14, Daniele Di Proietto wrote: >> +/* Assign pmds to queues. If 'pinned' is true, assign pmds to pinned >> + * queues and marks the pmds as isolated. Otherwise, assign non isolated >> + * pmds to unpinned queues. >> + * >> + * T

Re: [ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

2016-12-06 Thread Daniele Di Proietto
2016-12-06 11:27 GMT-08:00 Ben Pfaff : > On Tue, Dec 06, 2016 at 01:01:19AM -0800, nickcooper-zhangtonghao wrote: >> When the datapath, whose type is "netdev", processes packets >> in userspce action, it may cause a segmentation fault. In the >> dp_execute_userspace_action(), we pass the "wc" argum

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
On 12/6/16, 2:13 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball" wrote: On 12/6/16, 2:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Russell Bryant" wrote: On Sun, Dec 4, 2016 at 7:13 PM, Darrell Ball wrote: > This patch adds

Re: [ovs-dev] [PATCH] ovn: Fix pacemaker Master node does not monitor the OVSDB status

2016-12-06 Thread Andy Zhou
On Tue, Dec 6, 2016 at 4:35 AM, Guoshuai Li wrote: > OVSDB resource is multi-state resource, pacemaker monitor actions are > insufficient to monitor a multi-state resource. > the usual one will cover the slave role, so it is need to configure > monitoring for the master. > > http://clusterlabs.or

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
On 12/6/16, 2:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Russell Bryant" wrote: On Sun, Dec 4, 2016 at 7:13 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb cli

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Russell Bryant
On Sun, Dec 4, 2016 at 7:13 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea is to do a flood fill in ovn-controller of datapath associations > calculated by northd. A new

[ovs-dev] costo-beneficio de liquidar o continuar con su empresa

2016-12-06 Thread Disolución y Liquidación de Sociedades
Porque aun en la adversidad es indispensable cumplir con sus obligaciones Disolución y Liquidación de Sociedades 15 de diciembre - Zona Reforma (Ciudad de México) - 9:00 a 20:00 Imparte: M.A.N. Fernando García Zárate Debido a las épocas de crisis como en la que nos encontramos, es muy

Re: [ovs-dev] [PATCH 1/4] acinclude: Fix -Wstrict-prototypes and -Wold-style-definition detection.

2016-12-06 Thread Andy Zhou
On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff wrote: > AC_LANG_PROGRAM(,) uses a program like this: > > int main() { return 0; } > > but that triggers warnings for -Wstrict-prototypes and for > -Wold-style-definition, since this definition of main() lacks a prototype > and is therefore old-style.

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Russell Bryant
On Tue, Dec 6, 2016 at 3:36 PM, Ben Pfaff wrote: > On Tue, Dec 06, 2016 at 12:35:16PM -0800, Ben Pfaff wrote: > > On Tue, Dec 06, 2016 at 02:45:19PM -0500, Russell Bryant wrote: > > > On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff wrote: > > > > > > > On Sun, Dec 04, 2016 at 04:13:44PM -0800, Darrell

Re: [ovs-dev] [PATCH] dpctl: Fix usage for most dpctl commands.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 03:23:45PM -0500, Aaron Conole wrote: > Ben Pfaff writes: > > > The usage should not repeat the command name, but most of the dpctl > > commands' usage did repeat it. This fixes the problem. > > > > Signed-off-by: Ben Pfaff > > --- > > lib/dpctl.c | 20 ++---

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 12:35:16PM -0800, Ben Pfaff wrote: > On Tue, Dec 06, 2016 at 02:45:19PM -0500, Russell Bryant wrote: > > On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff wrote: > > > > > On Sun, Dec 04, 2016 at 04:13:44PM -0800, Darrell Ball wrote: > > > > This patch adds datapaths of interest s

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 02:45:19PM -0500, Russell Bryant wrote: > On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff wrote: > > > On Sun, Dec 04, 2016 at 04:13:44PM -0800, Darrell Ball wrote: > > > This patch adds datapaths of interest support where only datapaths of > > > local interest are monitored by

Re: [ovs-dev] [PATCH] dpctl: Fix usage for most dpctl commands.

2016-12-06 Thread Aaron Conole
Ben Pfaff writes: > The usage should not repeat the command name, but most of the dpctl > commands' usage did repeat it. This fixes the problem. > > Signed-off-by: Ben Pfaff > --- > lib/dpctl.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) I didn't build this,

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Russell Bryant
On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff wrote: > On Sun, Dec 04, 2016 at 04:13:44PM -0800, Darrell Ball wrote: > > This patch adds datapaths of interest support where only datapaths of > > local interest are monitored by the ovn-controller ovsdb client. The > > idea is to do a flood fill in ov

[ovs-dev] [PATCH] dpctl: Fix usage for most dpctl commands.

2016-12-06 Thread Ben Pfaff
The usage should not repeat the command name, but most of the dpctl commands' usage did repeat it. This fixes the problem. Signed-off-by: Ben Pfaff --- lib/dpctl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index bdccce7.

Re: [ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 01:01:19AM -0800, nickcooper-zhangtonghao wrote: > When the datapath, whose type is "netdev", processes packets > in userspce action, it may cause a segmentation fault. In the > dp_execute_userspace_action(), we pass the "wc" argument to > dp_netdev_upcall() using NULL. In t

Re: [ovs-dev] [PATCH 2/4] ovs-sandbox: add '-u, --disable-dummy' options.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 01:01:20AM -0800, nickcooper-zhangtonghao wrote: > The ovs-sandbox runs in the "dummy mode" by default. > In this mode of testing, no packets travel across > physical or virtual networks. But sometimes, we may > create veth network devices and add them to ovs bridge > for de

Re: [ovs-dev] [PATCH 4/4] ovs-appctl: Add usage content to "upcall/set-flow-limit" command.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 01:01:22AM -0800, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao Applied to master, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/4] ovs-appctl: Add usage content to "dpctl/*" command.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 01:01:21AM -0800, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao Applied to master, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/3] ovn: support ssl connections to nb/sb dbs

2016-12-06 Thread Russell Bryant
On Thu, Dec 1, 2016 at 10:37 AM, Lance Richardson wrote: > This series adds support for SSL connections to the northbound > and southbound OVN database servers and removes the previous > default TCP connection type. > > Lance Richardson (3): > ovn-nb: remote connection management in nb db > o

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-06 Thread Sairam Venugopal
I feel that these additional threads that are spawned for the lifetime of the driver ought to be visible in the Driver load/unload functions. This will be beneficial for both debugging and lifecycle management. I agree that encapsulating it under Conntrack.c will make the code contained, but might

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

2016-12-06 Thread Sairam Venugopal
Alin, Thanks for the review. Yes, my main intent was to introduce something simple that we can iterate on. I did look at the safe-string functions. Unfortunately, I couldn¹t find Rtl* functions that I could reuse here. That¹s the reason why I had to introduce the two str functions. I will apply

Re: [ovs-dev] [PATCH 2/4] datapath-windows: Cleanup Conntrack definitions and introduce related entries

2016-12-06 Thread Sairam Venugopal
is used by the CONTAINER_OF macro. More specifically by the offsetof macro - https://msdn.microsoft.com/en-us/library/dz4y9b9a(v=vs.120).aspx I will remove the NetProto.h include. On 12/5/16, 8:11 AM, "Alin Serdean" wrote: >Looks good, but I have a question regarding the includes. Do you need

Re: [ovs-dev] [PATCH] Fix compiling error in netbsd

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 12:11:04PM -0500, Hui Kang wrote: > On Tue, Dec 6, 2016 at 12:01 PM, Ben Pfaff wrote: > > On Tue, Dec 06, 2016 at 12:04:00AM -0500, Hui Kang wrote: > >> In some netbsd version, RTF_LLINFO is undefined > >> > >> Signed-off-by: Hui Kang > > > > Applied to master, thanks! > >

Re: [ovs-dev] [PATCH] ofproto: Incorrect statistics will be increased

2016-12-06 Thread Ben Pfaff
Thanks for the clarification. I agree that there is a bug in 2.5.1. I applied this patch to branch-2.5. On Tue, Dec 06, 2016 at 05:38:31PM +, Ken Ajiro wrote: > > Ben, > > Sorry, it was my mistake. I met this issue with OVS 2.5.1. > In OVS 2.5.1, packet_in scheduling is implemented

[ovs-dev] Devolución de Impuestos - En Línea

2016-12-06 Thread Cómo Proteger sus Derechos
En línea y en Vivo / Para todo su Equipo con una sola Conexión Devolución de Impuestos Y Las Reacciones de las Autoridades fiscales Cómo proteger sus derechos en la PRODECON 21 de diciembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs Requerimientos EXCESIVOS, desistimientos

Re: [ovs-dev] [PATCH] ovn-trace: Add output format options to usage message.

2016-12-06 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 08:36:13PM -0500, Russell Bryant wrote: > On Mon, Dec 5, 2016 at 8:01 PM, Ben Pfaff wrote: > > > On Sun, Oct 23, 2016 at 11:25:02AM -0700, Ben Pfaff wrote: > > > Also adjust the indentation of the option explanations so that they line > > up > > > better. > > > > > > Signe

Re: [ovs-dev] [PATCH 2/2] tests: Add tracing to "ovn -- 2 HVs, 4 lports/HV, localnet ports" test.

2016-12-06 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 08:39:57PM -0500, Russell Bryant wrote: > On Sun, Oct 23, 2016 at 1:50 PM, Ben Pfaff wrote: > > > Adding ovn-trace calls makes failures easier to understand and diagnose. > > > > Signed-off-by: Ben Pfaff > > --- > > tests/ovn.at | 96 ++ > > ++

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Pravin Shelar
On Mon, Dec 5, 2016 at 11:17 PM, Yang, Yi Y wrote: > Hi, guys > > This patch isn't updated from June on, Cascardo said he/Eric is still working > on this, but six months passed, we don't see any following patch for this, > now I have time to revisit it, for case 3 Pravin mentioned, I can make it

[ovs-dev] please review Github PR #163

2016-12-06 Thread Ben Pfaff
I posted Github PR #163 because the moderator for this list still hasn't released my equivalent patch, which appeared to trigger some kind of filter. Please review: https://github.com/openvswitch/ovs/pull/163 Thanks, Ben. ___ dev mailing list

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Don't use dev->vhost_id without mutex.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 09:45:07AM +0300, Ilya Maximets wrote: > The copy should be used here. > Additionally, 'strlen' changed to the faster check. > > Fixes: 821b86649a90 ("netdev-dpdk: Don't try to unregister empty vhost_id.") > Signed-off-by: Ilya Maximets > --- > Version 2: > * 'strlen

Re: [ovs-dev] [PATCH] ofproto: Incorrect statistics will be increased

2016-12-06 Thread Ken Ajiro
Ben, Sorry, it was my mistake. I met this issue with OVS 2.5.1. In OVS 2.5.1, packet_in scheduling is implemented as follows in schedule_packet_in(), /* Make OFPT_PACKET_IN and hand over to packet scheduler. */ pinsched_send(ofconn->schedulers[pin.up.reason == OFPR_NO_MATCH ? 0

Re: [ovs-dev] [PATCH 6/9] ovn-controller: Handle only relevant ports and flows.

2016-12-06 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 05:45:15PM -0800, Mickey Spiegel wrote: > On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > > > On a particular hypervisor, ovn-controller only needs to handle ports > > and datapaths that have some relationship with it, that is, the > > ports that actually reside on the

Re: [ovs-dev] [PATCH 5/9] lport: Add index for logical datapaths.

2016-12-06 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 06:30:17PM -0800, Mickey Spiegel wrote: > On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > > > This will have its first real user in an upcoming commit. > > > > I am not sure this is really necessary. See my comments on patch 6. OK, I'll read those comments in patch 6

Re: [ovs-dev] [PATCH] Fix compiling error in netbsd

2016-12-06 Thread Hui Kang
On Tue, Dec 6, 2016 at 12:01 PM, Ben Pfaff wrote: > On Tue, Dec 06, 2016 at 12:04:00AM -0500, Hui Kang wrote: >> In some netbsd version, RTF_LLINFO is undefined >> >> Signed-off-by: Hui Kang > > Applied to master, thanks! > > Should I backport this to OVS 2.6? Yes, I think so. (Although I test o

Re: [ovs-dev] [PATCH] ofproto: Incorrect statistics will be increased

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 04:55:11AM +, Ken Ajiro wrote: > > When using controller packet-in rate limiting (controller_rate_limit in > controller table), incorrect statistics will be increased. This patch > fixes this issue. > > Signed-off-by: Ken Ajiro > --- > ofproto/connmgr.c |2 +- >

Re: [ovs-dev] [PATCH] Fix compiling error in netbsd

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 12:04:00AM -0500, Hui Kang wrote: > In some netbsd version, RTF_LLINFO is undefined > > Signed-off-by: Hui Kang Applied to master, thanks! Should I backport this to OVS 2.6? (Are you the same Hui Kang already listed in AUTHORS.rst? Should we update your email address?)

Re: [ovs-dev] [PATCH] tests/bundle: Use active_backup algorithm for up/down test.

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 02:48:43PM +0300, Ilya Maximets wrote: > HRW algorithm uses hash function which is dependent from the build > environment. This leads to constant fails of the testsuite > with CFLAGS='-march=native' if CPU supports hashing instructions: Thanks, applied to master. __

Re: [ovs-dev] [PATCH] ovn: Fix the duplicate code: start) ovsdb_server_start; ;

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 07:36:09PM +0800, Guoshuai Li wrote: > In 341 line already have this code Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] request for assistance with Debian maintenance

2016-12-06 Thread Ben Pfaff
I've been doing a bad job as Debian maintainer for Open vSwitch. I'd very much appreciate help from a co-maintainer who can invest more time in doing a good job with Debian uploads and bug tracking. Thanks, Ben. ___ dev mailing list d...@openvswitch.or

Re: [ovs-dev] [RFC] Introducing experimental OVN integration for Mesos

2016-12-06 Thread Ben Pfaff
On Tue, Dec 06, 2016 at 07:55:36AM -0800, Guru Shetty wrote: > On 5 December 2016 at 13:59, Ben Pfaff wrote: > > > Guru, did you ever have a look at this? It's always nice to integrate > > with more systems. > > > > Right. I did work with Nimay to get this patch sent to the mailing list as > a

Re: [ovs-dev] [RFC] Introducing experimental OVN integration for Mesos

2016-12-06 Thread Guru Shetty
On 5 December 2016 at 13:59, Ben Pfaff wrote: > Guru, did you ever have a look at this? It's always nice to integrate > with more systems. > Right. I did work with Nimay to get this patch sent to the mailing list as a RFC. The main reason it was a RFC was because of the following: > +Note on N

Re: [ovs-dev] [PATCH] dpdk: Fix abort on double free.

2016-12-06 Thread Aaron Conole
Daniele Di Proietto writes: > On 29/11/2016 07:57, "Aaron Conole" wrote: > >>Hi Ilya, >> >>Ilya Maximets writes: >> >>> On 28.11.2016 21:55, Aaron Conole wrote: Ilya Maximets writes: > According to DPDK API (lib/librte_eal/common/include/rte_eal.h): > > "After the call

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-12-06 Thread Loftus, Ciara
> > Thanks for the patch. > > I experience a crash with this patch applied by starting ovs and > immediately adding a vhostuserclient port. It's not reproducible 100% > of the times. > > Program received signal SIGSEGV, Segmentation fault. > rte_eth_xstats_get (port_id=3 '\003', xstats=xstats@e

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Eric Garver
On Tue, Dec 06, 2016 at 07:17:20AM +, Yang, Yi Y wrote: > Hi, guys Hi Yi, > This patch isn't updated from June on, Cascardo said he/Eric is still > working on this, but six months passed, we don't see any following Work is still ongoing. There was delay due to some debate about how and when

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-12-06 Thread Jiri Benc
On Tue, 6 Dec 2016 07:17:20 +, Yang, Yi Y wrote: > So my advice about this is we can push patch [2] to Linux net-next > first, then apply patch series > https://mail.openvswitch.org/pipermail/ovs-dev/2016-June/316879.html > from Cascardo and apply [1], that can cover all the cases Pravin > ment

Re: [ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

2016-12-06 Thread Babu Shanmugam
+ Andrew. Hi Andrew, Please see below. Your comments are most welcome. -- Babu On Saturday 03 December 2016 01:08 PM, Guoshuai Li wrote: PCS man page says role=Stopped/Started/Master/Slave. A role can be master or slave (if no role is specified, it defaults to 'started'). Command line "$pc

Re: [ovs-dev] [PATCH v2 18/19] dpif-netdev: Centralized threads and queues handling code.

2016-12-06 Thread Ilya Maximets
On 03.12.2016 05:14, Daniele Di Proietto wrote: > +/* Assign pmds to queues. If 'pinned' is true, assign pmds to pinned > + * queues and marks the pmds as isolated. Otherwise, assign non isolated > + * pmds to unpinned queues. > + * > + * The function doesn't touch the pmd threads, it just stores

[ovs-dev] [PATCH] ovn: Fix pacemaker Master node does not monitor the OVSDB status

2016-12-06 Thread Guoshuai Li
OVSDB resource is multi-state resource, pacemaker monitor actions are insufficient to monitor a multi-state resource. the usual one will cover the slave role, so it is need to configure monitoring for the master. http://clusterlabs.org/doc/en-US/Pacemaker/1.1-pcs/html/Pacemaker_Explained/_monito

[ovs-dev] Processed: user debian...@lists.debian.org, usertagging 831924, found 831924 in 2.6.1+git20161123-1 ...

2016-12-06 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > user debian...@lists.debian.org Setting user to debian...@lists.debian.org (was a...@debian.org). > usertags 831924 piuparts Usertags were: qa-ftbfs-20160720 qa-indep qa-ftbfs. Usertags are now: qa-ftbfs-20160720 qa-indep piuparts qa-ftbfs. > foun

[ovs-dev] [PATCH] tests/bundle: Use active_backup algorithm for up/down test.

2016-12-06 Thread Ilya Maximets
HRW algorithm uses hash function which is dependent from the build environment. This leads to constant fails of the testsuite with CFLAGS='-march=native' if CPU supports hashing instructions: [---] ./bundle.at:233: ovs-appctl ofproto

[ovs-dev] [PATCH] ovn: Fix the duplicate code: start) ovsdb_server_start; ;

2016-12-06 Thread Guoshuai Li
In 341 line already have this code --- ovn/utilities/ovndb-servers.ocf | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/utilities/ovndb-servers.ocf b/ovn/utilities/ovndb-servers.ocf index 72c0cf4..1cf6f20 100755 --- a/ovn/utilities/ovndb-servers.ocf +++ b/ovn/utilities/ovndb-servers.ocf @@ -

Re: [ovs-dev] [RFC PATCH] Pipeline packet processing in OVS using FVL flow director.

2016-12-06 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Monday, December 5, 2016 7:44 PM > To: Chandran, Sugesh > Cc: d...@openvswitch.org; ro...@mellanox.com; ktray...@redhat.com; > fla...@flaviof.com > Subject: Re: [ovs-dev] [RFC PATCH] Pipeline packet pro

[ovs-dev] [PATCH 2/4] ovs-sandbox: add '-u, --disable-dummy' options.

2016-12-06 Thread nickcooper-zhangtonghao
The ovs-sandbox runs in the "dummy mode" by default. In this mode of testing, no packets travel across physical or virtual networks. But sometimes, we may create veth network devices and add them to ovs bridge for developing and testing. It's necessary to add an option. Signed-off-by: nickcooper-z

[ovs-dev] [PATCH 4/4] ovs-appctl: Add usage content to "upcall/set-flow-limit" command.

2016-12-06 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- ofproto/ofproto-dpif-upcall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 84f1de2..6cb9c2e 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dp

[ovs-dev] [PATCH 3/4] ovs-appctl: Add usage content to "dpctl/*" command.

2016-12-06 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- lib/dpctl.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index edccb7f..bdccce7 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -1780,8 +1780,12 @@ dpctl_unixctl_register(void) for (p = all_comm

[ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

2016-12-06 Thread nickcooper-zhangtonghao
When the datapath, whose type is "netdev", processes packets in userspce action, it may cause a segmentation fault. In the dp_execute_userspace_action(), we pass the "wc" argument to dp_netdev_upcall() using NULL. In the dp_netdev_upcall() call tree, the "wc" will be used. For example, dp_netdev_up