Thanks Daniele for addressing the issue and fixing the inconsistency.
Best Regards,
--Sridhar.
On Wed, Dec 21, 2016 at 2:05 AM, Daniele Di Proietto
wrote:
> 2016-12-19 21:25 GMT-08:00 Darrell Ball :
> >
> >
> > From: Jarno Rajahalme
> > Date: Monday, December 19, 2016 at 2:30 PM
> > To: Darrel
I posted a new version of this series that should be ready for review:
https://mail.openvswitch.org/pipermail/ovs-dev/2016-December/326549.html
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
"ovs-appctl ofproto/trace" is invaluable for debugging, but as the users of
Open vSwitch have evolved it has failed to keep up with the times. It's
pretty easy to design OpenFlow tables and pipelines that resubmit dozens of
times. Each resubmit causes an additional tab of indentation, so the
outp
An upcoming commit will rewrite much of the ofproto/trace functionality.
As the mechanism behind this grows and evolves, it makes sense to move it
into its own file, especially since ofproto-dpif.c is too big anyway.
Signed-off-by: Ben Pfaff
---
ofproto/automake.mk | 2 +
ofproto/ofpr
Until now, ofproto-dpif.c has hidden the definitions of several structures,
such as struct ofproto_dpif and struct rule_dpif. This kind of information
hiding is often beneficial, because it forces code outside the file with
the definition to use the documented interfaces. However, in this case it
This series seeks to make the output of ofproto/trace easier to read,
especially in complicated situations.
v1->v2:
- Patch 4 extended and revised to make it suitable for review
and no longer RFC.
I hope that this series pleases many users.
Ben Pfaff (4):
ofproto: Update access rule
The 'flow_cookie' member of struct rule is read during flow translation
without holding a mutex, breaking the documented OVS_GUARDED access rule.
However, the flow_cookie member is actually never modified after a rule is
initialized, so this commit changes the access rules to reflect that.
Signed-
On Tue, Dec 20, 2016 at 01:23:46PM -0800, Mickey Spiegel wrote:
> With recent OVN commits, the logic for a chassis to claim
> or release a logical port was consolidated. This is a
> good thing. However, there was a logic change that
> resulted in VLOG_INFO being generated every time on the
> ovn-
On Tue, Dec 20, 2016 at 06:49:24PM -0800, Daniele Di Proietto wrote:
> When the add-port command fails, vsctl reports the failure and just
> suggests to check the logs for more details.
>
> ovs-vswitchd fills the error column in the Interface table with a
> description of the error, so it might be
On Tue, Dec 20, 2016 at 07:32:58PM -0500, Lance Richardson wrote:
>
>
> - Original Message -
> > From: "Ben Pfaff"
> > To: d...@openvswitch.org
> > Cc: "Ben Pfaff" , "Lance Richardson"
> > Sent: Tuesday, December 20, 2016 7:17:31 PM
> > Subject: [PATCH] ovsdb-idlc: Initialize nonnull st
On 12/20/16, 5:37 PM, "Daniele Di Proietto" wrote:
On 20/12/2016 14:46, "Darrell Ball" wrote:
>
>
>On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of
Daniele Di Proietto" wrote:
>
>The userspace connection tracker tr
2016-12-20 14:08 GMT-08:00 Kevin Traynor :
> On 12/15/2016 11:54 AM, Ciara Loftus wrote:
>> 'dpdk' ports no longer have naming restrictions. Now, instead of
>> specifying the dpdk port ID as part of the name, the PCI address of the
>> device must be specified via the 'dpdk-devargs' option. eg.
>>
>
When the add-port command fails, vsctl reports the failure and just
suggests to check the logs for more details.
ovs-vswitchd fills the error column in the Interface table with a
description of the error, so it might be helpful to print that.
This is useful especially for dpdk devices, because th
2016-12-20 16:49 GMT-08:00 Joo Kim :
> (changed the subj)
>
> Could anybody help confirm about pmd->flow_table below? -Thanks-
>
> -- Forwarded message --
> From: Joo Kim
> Date: Mon, Dec 19, 2016 at 4:35 PM
> Subject: Re: [ovs-dev] relationship between dpcls_rule and dp_netdev_f
On 20/12/2016 17:14, "Joe Stringer" wrote:
>On 20 December 2016 at 14:46, Darrell Ball wrote:
>>
>>
>> On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele
>> Di Proietto" > diproiet...@vmware.com> wrote:
>> @@ -864,25 +896,32 @@ extract_l4_icmp6(struct conn_key
On 20/12/2016 14:46, "Darrell Ball" wrote:
>
>
>On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele
>Di Proietto" diproiet...@vmware.com> wrote:
>
>The userspace connection tracker treats Neighbor Discovery packets
>as invalid, because they're not checked ag
On 20 December 2016 at 14:46, Darrell Ball wrote:
>
>
> On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele
> Di Proietto" diproiet...@vmware.com> wrote:
> @@ -864,25 +896,32 @@ extract_l4_icmp6(struct conn_key *key, const void
> *data, size_t size,
>
This makes these examples easier to cut and paste into a terminal, and
makes them consistent with the other examples.
Signed-off-by: Ben Pfaff
---
Documentation/tutorials/ovs-advanced.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/tutorials/ovs-advanc
(changed the subj)
Could anybody help confirm about pmd->flow_table below? -Thanks-
-- Forwarded message --
From: Joo Kim
Date: Mon, Dec 19, 2016 at 4:35 PM
Subject: Re: [ovs-dev] relationship between dpcls_rule and dp_netdev_flow
To: Jarno Rajahalme
Cc: ovs-dev@openvswitch.or
On Tue, Dec 20, 2016 at 04:32:05PM -0800, Joe Stringer wrote:
> On 20 December 2016 at 16:28, Ben Pfaff wrote:
> > On Tue, Dec 20, 2016 at 03:18:43PM -0800, Joe Stringer wrote:
> >> On 20 December 2016 at 13:16, Ben Pfaff wrote:
> >> > A previous patch fixed double rebuilds when running tests in
Hi Joe,
Thanks I will take a look.
William
On Tue, Dec 20, 2016 at 10:25 AM, Joe Stringer wrote:
> On 18 December 2016 at 00:18, Ben Pfaff wrote:
>> From: William Tu
>>
>> This patch adds OpenFlow clone action with syntax as below:
>> "clone([action][,action...])". The clone() action makes a c
- Original Message -
> From: "Ben Pfaff"
> To: d...@openvswitch.org
> Cc: "Ben Pfaff" , "Lance Richardson"
> Sent: Tuesday, December 20, 2016 7:17:31 PM
> Subject: [PATCH] ovsdb-idlc: Initialize nonnull string columns for inserted
> rows.
>
> When a schema column has type "exactly one
On 20 December 2016 at 16:28, Ben Pfaff wrote:
> On Tue, Dec 20, 2016 at 03:18:43PM -0800, Joe Stringer wrote:
>> On 20 December 2016 at 13:16, Ben Pfaff wrote:
>> > A previous patch fixed double rebuilds when running tests in some cases.
>> > That patch removed dependencies from targets in tests
On Tue, Dec 20, 2016 at 03:18:43PM -0800, Joe Stringer wrote:
> On 20 December 2016 at 13:16, Ben Pfaff wrote:
> > A previous patch fixed double rebuilds when running tests in some cases.
> > That patch removed dependencies from targets in tests/automake.mk that
> > were redundant because the "all
On Tue, Dec 20, 2016 at 01:59:02PM -0500, Lance Richardson wrote:
> I've been investigating a crash in ovn-northd. This is very easy to
> reproduce by inserting a row into the NB Logical_Switch_Port table
> without setting the "name" column, e.g.:
>
> ovn-nbctl ls-add ls0
> ovn-nbctl --id=@foo cre
When a schema column has type "exactly one string", the corresponding
struct member has type "char *" and the documented and expected behavior
is that the string should always be nonnull. (The code generator even
adds a comment /* Always nonnull. */ in the struct definition.) In the
case where a
Póliza de Indispensable para los Responsables de Compras
12 conferencias en cada póliza, pregrabadas, inéditas, para capacitar a todo su
personal.
Al adquirir la Póliza de Capacitación, usted obtiene acceso a 12 temas
enfocados al área de Compras; temas especializados que han sido cuidadosament
> On Dec 19, 2016, at 2:43 PM, antonio.fische...@intel.com wrote:
>
> This patch skips the chunk comprising of dp_hash and in_port in the
> subtable mask when the dpcls refers to a physical port. This will
> slightly speed up the hash computation as one expensive function call
> to hash_add64()
On 20 December 2016 at 13:16, Ben Pfaff wrote:
> A previous patch fixed double rebuilds when running tests in some cases.
> That patch removed dependencies from targets in tests/automake.mk that
> were redundant because the "all" target already depended on them. A
> dependency on tests/atlocal wa
Yep, I'd be happy to.
--Justin
> On Dec 20, 2016, at 2:44 PM, Ben Pfaff wrote:
>
> Justin, I'd like to get this feature into OVS 2.7. Will you review
> these patches?
>
> Thanks,
>
> Ben.
>
> On Tue, Dec 20, 2016 at 08:07:49AM -0800, Ben Pfaff wrote:
>> v1->v2:
>> - Patch 1 in v1 was comm
On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele Di
Proietto"
wrote:
The userspace connection tracker treats Neighbor Discovery packets
as invalid, because they're not checked against any connection.
This in inconsistent with the kernel connection
On Tue, Dec 20, 2016 at 08:21:28AM -0800, Guru Shetty wrote:
> On 19 December 2016 at 21:26, Ben Pfaff wrote:
> > > -ct->zone_src.field = mf_from_id(MFF_LOG_CT_ZONE);
> > > +ct->zone_src.field = ep->is_switch ? mf_from_id(MFF_LOG_CT_ZONE)
> > > +: mf_from_id(MFF
Justin, I'd like to get this feature into OVS 2.7. Will you review
these patches?
Thanks,
Ben.
On Tue, Dec 20, 2016 at 08:07:49AM -0800, Ben Pfaff wrote:
> v1->v2:
> - Patch 1 in v1 was committed and therefore dropped from the series.
> - Patch 2 in v2 is new.
>
> v2->v3:
> - Rebase to f
On 12/15/2016 11:54 AM, Ciara Loftus wrote:
> 'dpdk' ports no longer have naming restrictions. Now, instead of
> specifying the dpdk port ID as part of the name, the PCI address of the
> device must be specified via the 'dpdk-devargs' option. eg.
>
> ovs-vsctl add-port br0 my-port
> ovs-vsctl set
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 898
1 file changed, 449 insertions(+), 449 deletions(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 14fbf4518fdf..8e424c56031c 100644
--- a/tests/system-traffic.at
The kernel datapath provides support for TFTP helpers, so add support
for this ALG to the commandline and OpenFlow encoding/decoding.
Signed-off-by: Joe Stringer
---
Documentation/intro/install/general.rst | 2 +
NEWS| 1 +
Vagrantfile
Signed-off-by: Joe Stringer
---
tests/system-ovn.at | 2 ++
tests/system-traffic.at | 3 +++
2 files changed, 5 insertions(+)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 7b35e84a43d2..022dc63f22c2 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -1,3 +1,5 @@
+AT
All of the commands starting L7 servers duplicate detailed specifics
which inhibits readability, and makes it difficult to ensure that the
servers are ready before the test proceeds. Add a new macro that
provides simpler semantics from the test perspective and hide the
details in the macro. A follo
Use OVS_WAIT_UNTIL() with netstat to ensure servers are listening before
sending requests to them. This allows us to drop --retry-connrefused on
wget, needed before we can switch to curl.
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 4 --
> From: "Lance Richardson"
> To: "ovs dev"
> Sent: Tuesday, December 20, 2016 1:59:02 PM
> Subject: [ovs-dev] ovn-northd: ovsdb idl question
>
> I've been investigating a crash in ovn-northd. This is very easy to
> reproduce by inserting a row into the NB Logical_Switch_Port table
> without sett
With recent OVN commits, the logic for a chassis to claim
or release a logical port was consolidated. This is a
good thing. However, there was a logic change that
resulted in VLOG_INFO being generated every time on the
ovn-controller. This patch changes the logic so that
VLOG_INFO is only genera
A previous patch fixed double rebuilds when running tests in some cases.
That patch removed dependencies from targets in tests/automake.mk that
were redundant because the "all" target already depended on them. A
dependency on tests/atlocal was also removed in the belief that "all"
depended on test
On Tue, Dec 20, 2016 at 8:27 AM, Guru Shetty wrote:
>
>
> On 15 December 2016 at 05:35, Andy Zhou wrote:
>
>> The goal of this series is to make it easier to set up OVN in
>> a larger setup, i.e. not having all services running on a single host.
>>
>> Currently ovn-central package starts and sto
2016-12-19 21:25 GMT-08:00 Darrell Ball :
>
>
> From: Jarno Rajahalme
> Date: Monday, December 19, 2016 at 2:30 PM
> To: Darrell Ball
> Cc: Sridhar Gaddam , "ovs-dev@openvswitch.org"
> , Srikanth Vavilapalli
>
> Subject: Re: [ovs-dev] OVS2.6+dpdk IPv6 Conntrack support
>
>
> On Dec 19, 2016, a
The userspace connection tracker treats Neighbor Discovery packets
as invalid, because they're not checked against any connection.
This in inconsistent with the kernel connection tracker which always
returns 'CS_NEW'.
Therefore, this commit makes the userspace connection tracker conforming
with t
ICMP error packets (e.g. destination unreachable messages) are
considered 'related' to another connection and are treated as part of
that.
However:
* We shouldn't create new entries in the connection table if the
original connection is not found. This is consistent with what the
kernel does.
On 20 December 2016 at 11:42, Alin Serdean
wrote:
> From: Alin Serdean
>
> This patch updates the documentation on how to set up OVS with multiple
> NICs.
>
> Also update the documentation to show users how new internal ports are
> created
>
> Signed-off-by: Alin Gabriel Serdean
> Acked-by: Pau
12 conferencias pregrabadas / Durante 3 meses
Póliza indispensable para
los responsables de COMPRAS
12 conferencias en cada póliza, pregrabadas, inéditas,
para capacitar a todo su personal
Al adquirir la Póliza de Capacitación, usted obtiene acceso a 12 temas
enfocados al área de C
Acked-by: Sairam Venugopal
On 12/20/16, 11:41 AM, "Alin Serdean"
wrote:
>From: Alin Serdean
>
>This patch updates the following commands in the vswitch:
> ovs-vsctl add-br br-test
> ovs-vsctl del-br br-test
>
>ovs-vsctl add-br br-test:
>This command will now create an internal port on the
Acked-by: Sairam Venugopal
On 12/20/16, 11:42 AM, "Alin Serdean"
wrote:
>From: Alin Serdean
>
>This patch updates the documentation on how to set up OVS with multiple
>NICs.
>
>Also update the documentation to show users how new internal ports are
>created
>
>Signed-off-by: Alin Gabriel Serde
Acked-by: Sairam Venugopal
On 12/20/16, 11:42 AM, "Alin Serdean"
wrote:
>
>This patch adds multiple internal ports support to the windows datapath.
>All tunnels types have been updated to accommodate this new functionality.
>
>Signed-off-by: Alin Gabriel Serdean
>Co-authored-by: Sorin Vinturi
From: Alin Serdean
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
Acked-by: Sairam Venugopal
---
v8: rebase, add acked-by
v7:
This patch adds multiple internal ports support to the windows datapath.
All tunnels types have been updated to accommodate this new functionality.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Sorin Vinturis
Signed-off-by: Sorin Vinturis
Acked-by: Paul Boca
---
v8: Rebase
v7: Rebase
v6
From: Alin Serdean
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagem
I've been investigating a crash in ovn-northd. This is very easy to
reproduce by inserting a row into the NB Logical_Switch_Port table
without setting the "name" column, e.g.:
ovn-nbctl ls-add ls0
ovn-nbctl --id=@foo create logical_switch_port type='localnet' -- add
logical_switch ls0 ports @foo
On 16 December 2016 at 12:47, YiHung Wei wrote:
> Acked-by: Yi-Hung Wei
Thanks, applied.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Dec 20, 2016 at 12:06 AM, Ben Pfaff wrote:
> On Sun, Dec 18, 2016 at 12:18:18AM -0800, Ben Pfaff wrote:
> > v1->v2:
> >- Fixed some bugs reported by Mickey throughout the series.
> >- Patches 1 and 2 are new.
> >- Patch 3 is modified in various ways, most notably to avoid usin
Please ignore this patch.
- Hui
On Tue, Dec 20, 2016 at 1:24 PM, Hui Kang wrote:
> In some netbsd version, RTF_LLINFO is undefined
>
> Signed-off-by: Hui Kang
> ---
> lib/netdev-bsd.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
> index 75a33
- test ovs on netbsd 7.0.2
- use gmake to compile and install
Signed-off-by: Hui Kang
---
Documentation/intro/install/netbsd.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/intro/install/netbsd.rst
b/Documentation/intro/install/netbsd.rst
index b32da20
On 18 December 2016 at 00:18, Ben Pfaff wrote:
> From: William Tu
>
> This patch adds OpenFlow clone action with syntax as below:
> "clone([action][,action...])". The clone() action makes a copy of the
> current packet and executes the list of actions against the packet,
> without affecting the
In some netbsd version, RTF_LLINFO is undefined
Signed-off-by: Hui Kang
---
lib/netdev-bsd.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 75a330b..94c515d 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -1357,7 +1357,11 @@ netdev_bsd_a
On 16 December 2016 at 14:28, Sairam Venugopal wrote:
> Enable the support for tracking FTP connections in the Connection tracker.
> This checks an incoming ftp control connection to extract the related data
> connection. When a matching data connection arrives, it would then update
> the connect
On 15 December 2016 at 18:50, Alin Serdean
wrote:
> Unfortunately, WSAPoll misbehaves on Windows please view detailed behavior
> on: https://github.com/openvswitch/ovs-issues/issues/117
>
> We replace the WSAPoll with select looking only for errors and write
> events.
>
> Signed-off-by: Alin Gabr
On 15 December 2016 at 11:39, Alin Serdean
wrote:
>
> This patch adds multiple internal ports support to the windows datapath.
> All tunnels types have been updated to accommodate this new functionality.
>
> Signed-off-by: Alin Gabriel Serdean
> Co-authored-by: Sorin Vinturis
>
This needs a Si
Thanks for the series!
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Saturday, December 17, 2016 12:28 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v3 0/4] datapath-windows: Enable
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Saturday, December 17, 2016 12:28 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v3 4/4] datapath-windo
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Saturday, December 17, 2016 12:28 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v3 3/4] datapath-windo
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Saturday, December 17, 2016 12:28 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v3 2/4] datapath-windo
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Saturday, December 17, 2016 12:28 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v3 1/4] datapath-windo
On 15 December 2016 at 05:35, Andy Zhou wrote:
> The goal of this series is to make it easier to set up OVN in
> a larger setup, i.e. not having all services running on a single host.
>
> Currently ovn-central package starts and stop all three services
> northbound-db, northd and southbound-db on
On 19 December 2016 at 21:26, Ben Pfaff wrote:
> On Mon, Dec 19, 2016 at 04:12:17AM -0800, Gurucharan Shetty wrote:
> > The gateway router was using the ct_next action to
> > reassemble packets. But ct_next action by default would
> > use the zone allocated for a logical port and in case of
> >
Sometimes seeing the OpenFlow flows that back a given logical flow can
provide additional insight. This commit adds a new --ovs option to
ovn-trace that makes it connect to Open vSwitch over OpenFlow and retrieve
and print the OpenFlow flows behind each logical flow encountered during
a trace.
Si
This makes it easy to find the logical flow that generated a particular
OpenFlow flow, by running "ovn-sbctl dump-flows ".
Later, this can be refined (and automated for "ofproto/trace"), but this
is still a significant advance.
Signed-off-by: Ben Pfaff
---
lib/uuid.c | 22 +++
v1->v2:
- Patch 1 in v1 was committed and therefore dropped from the series.
- Patch 2 in v2 is new.
v2->v3:
- Rebase to fix patch rejects.
Ben Pfaff (2):
ovn-controller: Tie OpenFlow and logical flows using OpenFlow cookie.
ovn-trace: New --ovs option to also print OpenFlow flows.
NE
On 20.12.2016 15:19, Bodireddy, Bhanuprakash wrote:
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>> Sent: Tuesday, December 20, 2016 8:09 AM
>> To: Bodireddy, Bhanuprakash ; Aaron
>> Conole
>> Cc: d...@openvswitch.org; Daniele Di Proietto ;
>> Thadeu Lima de
>-Original Message-
>From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>Sent: Tuesday, December 20, 2016 8:09 AM
>To: Bodireddy, Bhanuprakash ; Aaron
>Conole
>Cc: d...@openvswitch.org; Daniele Di Proietto ;
>Thadeu Lima de Souza Cascardo ; Fischetti, Antonio
>; Markus Magnusson
>
>Subjec
I have posted an updated version of this patch at:
https://patchwork.ozlabs.org/patch/707398/
On Fri, Dec 16, 2016 at 4:55 PM, Andy Zhou wrote:
> When generating conditional monitoring update request, current code
> failed to update idl's 'request-id'. This bug causes the reply
> message of th
To allow client to know when the conditional monitoring changes
has been accepted by the OVSDB server and the 'idl' contents has
been updated to match the new conditions.
Signed-off-by: Andy Zhou
---
lib/ovsdb-idl.c| 49 ++---
lib/ovsdb-idl.h|
From: andy zhou
When generating conditional monitoring update request, current code
failed to update idl's 'request-id'. This bug causes the reply
message of the update request, regardless an ACK or a NACK, be
logged as an unexpected message at the debug level and ignored by
the core idl logic.
In case connection is reset when there are buffered but unsent
conditions, these conditions will be sent as the new "monitor_cond"
message that will be sent after the idl reconnects.
Without this patch, those conditions will be unnecessarily sent again
with following monitoring condition update me
On 19.12.2016 21:05, Bodireddy, Bhanuprakash wrote:
> Thanks Ilya and Aaron for reviewing this patch and providing your comments,
> my reply inline.
>
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>> Sent: Monday, December 19, 2016 8:41 AM
>> To: Aaron Cono
81 matches
Mail list logo
