Re: [ovs-dev] clone action is broken in the master

On Thu, Mar 9, 2017 at 7:31 PM, Numan Siddique wrote: > > > On Fri, Mar 10, 2017 at 4:35 AM, Andy Zhou wrote: >> >> On Thu, Mar 9, 2017 at 2:34 AM, Numan Siddique >> wrote: >> > Hi Andy and All, >> > >> > The clone action is broken after

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Avoid using sample action when nesting level is low

On Fri, Mar 10, 2017 at 5:10 PM, Joe Stringer wrote: > On 10 March 2017 at 16:51, Joe Stringer wrote: >> On 9 March 2017 at 14:50, Andy Zhou wrote: >>> When datapath sample action only allow a small number of nested actions >>> (i.e. less than 3), do

Re: [ovs-dev] [PATCH 2/3] ofproto: Probe for sample nesting level.

On Fri, Mar 10, 2017 at 4:48 PM, Joe Stringer wrote: > On 9 March 2017 at 14:50, Andy Zhou wrote: >> Add logics to detect the max level of nesting allowed by the >> sample action implemented in the datapath. >> >> Future patch allows xlate code to generate different

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Avoid using sample action when nesting level is low

On 10 March 2017 at 16:51, Joe Stringer wrote: > On 9 March 2017 at 14:50, Andy Zhou wrote: >> When datapath sample action only allow a small number of nested actions >> (i.e. less than 3), do not translate the OpenFlow's 'clone' action >> into datapath 'sample'

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Avoid using sample action when nesting level is low

On 9 March 2017 at 14:50, Andy Zhou wrote: > When datapath sample action only allow a small number of nested actions > (i.e. less than 3), do not translate the OpenFlow's 'clone' action > into datapath 'sample' action, since such translation would cause > datapath to reject the

Re: [ovs-dev] [PATCH 2/3] ofproto: Probe for sample nesting level.

On 9 March 2017 at 14:50, Andy Zhou wrote: > Add logics to detect the max level of nesting allowed by the > sample action implemented in the datapath. > > Future patch allows xlate code to generate different odp actions > based on this information. > > Signed-off-by: Andy Zhou

Re: [ovs-dev] [PATCH 1/3] dpif: Refactor dpif_probe_feature()

On 9 March 2017 at 14:50, Andy Zhou wrote: > Allow actions to be part of the probe. No functional changes. > Future patch will make use this new API. > > Signed-off-by: Andy Zhou Acked-by: Joe Stringer ___

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Add ref counting for variable length mf_fields.

On 9 March 2017 at 10:25, Yi-Hung Wei wrote: > Currently, a controller may potentially trigger a segmentation fault if it > accidentally removes a TLV mapping that is still used by an active flow. > To resolve this issue, in this patch, we maintain reference counting for

[ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

Commit daf4d3c18da4("odp: Support conntrack orig tuple key.") introduced new fields in struct 'pkt_metadata'. pkt_metadata_init() is called for every packet in the userspace datapath. When testing a simple single flow case with DPDK, we observe a lower throughput after the above commit (it was

Re: [ovs-dev] [PATCH v2 branch-2.6] docs: Use DPDK 16.07.2 stable release

2017-03-10 3:47 GMT-08:00 Ian Stokes : > DPDK now provides a stable release branch. Modify dpdk docs and travis > linux build script to use the DPDK 16.07.2 stable branch to benefit from > most recent bug fixes. > > Signed-off-by: Ian Stokes Thanks,

Re: [ovs-dev] [PATCH v2] docs: Use DPDK 16.11.1 stable release.

2017-03-10 3:47 GMT-08:00 Ian Stokes : > DPDK now provides a stable release branch. Modify dpdk docs and travis linux > build script to use the DPDK 16.11.1 stable branch to benefit from most > recent bug fixes. > > Signed-off-by: Ian Stokes Thanks,

[ovs-dev] [PATCH v3 3/3] ofp-actions: Add limit to learn action.

This commit adds a new feature to the learn actions: the possibility to limit the number of learned flows. To be compatible with users of the old learn action, a new structure is introduced as well as a new OpenFlow raw action number. There's a small corner case when we have to delete the ukey.

[ovs-dev] [PATCH v3 2/3] ofp-actions: Factor out decode_LEARN_{common, spec}().

No functional change, they will be used by next commit. Signed-off-by: Daniele Di Proietto --- lib/ofp-actions.c | 58 ++- 1 file changed, 40 insertions(+), 18 deletions(-) diff --git a/lib/ofp-actions.c

[ovs-dev] [PATCH v3 1/3] ofproto-dpif-xlate: Create XC_LEARN entry after learning.

This will be useful in a separate commit, because learning can fail. Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git

[ovs-dev] [PATCH v3 0/3] Learn action limit

This series implements the possibility to have a limit on the number of flows learned by a learn action. After the learn action execution the pipeline can read the result (to know if the limit was exceeded). v2->v3: * When the learned rule expired and there are no packets, instead of

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

On Fri, Mar 10, 2017 at 2:35 PM, Russell Bryant wrote: > On Thu, Mar 9, 2017 at 11:52 PM, Numan Siddique wrote: >> Thanks for the review. Please see inline. >> >> >> On Fri, Mar 10, 2017 at 1:44 AM, Russell Bryant wrote: >>> >>> On Mon, Feb

Re: [ovs-dev] [PATCH 2/2] ofproto: Add ref counting for variable length mf_fields.

On 10 March 2017 at 11:34, Joe Stringer wrote: > On 9 March 2017 at 10:22, Yi-Hung Wei wrote: >> On Wed, Mar 8, 2017 at 11:40 AM, Joe Stringer wrote: > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index e844008f6294..bef5aad768a3 100644 >

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

On Thu, Mar 9, 2017 at 11:52 PM, Numan Siddique wrote: > Thanks for the review. Please see inline. > > > On Fri, Mar 10, 2017 at 1:44 AM, Russell Bryant wrote: >> >> On Mon, Feb 27, 2017 at 12:59 AM, wrote: >> > From: Numan Siddique

Re: [ovs-dev] [PATCH v2 1/2] nx-match: Use vl_mff_map to parse match field.

On 9 March 2017 at 10:24, Yi-Hung Wei wrote: > vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix variable > length meta-flow OXMs") to account variable length mf_field, and it is used > to decode variable length mf_field in ofp_action. In this patch,

Re: [ovs-dev] [PATCH] ofproto: Add some examples for 'ofproto/trace' in ovs-vswitchd man page

On Fri, Mar 10, 2017 at 07:17:28PM +0100, Timothy Redaelli wrote: > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1339097 > Signed-off-by: Timothy Redaelli Thanks for the examples! These first two look a little odd. It wouldn't normally make sense to include a

Re: [ovs-dev] [PATCH] ovn-controller: Don't bind non-existent interfaces.

On 8 March 2017 at 09:42, Russell Bryant wrote: > On Wed, Mar 8, 2017 at 2:18 AM, Gurucharan Shetty wrote: > > There are multiple reasons why a interface can exist > > in the Open vSwitch database but not exist in the system. > > For e.g, a restart of a host after

Re: [ovs-dev] [PATCH] ovn-controller: Don't bind non-existent interfaces.

On 8 March 2017 at 09:42, Russell Bryant wrote: > On Wed, Mar 8, 2017 at 2:18 AM, Gurucharan Shetty wrote: > > There are multiple reasons why a interface can exist > > in the Open vSwitch database but not exist in the system. > > For e.g, a restart of a host after

[ovs-dev] [PATCH] ofproto: Add some examples for 'ofproto/trace' in ovs-vswitchd man page

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1339097 Signed-off-by: Timothy Redaelli --- ofproto/ofproto-unixctl.man | 34 ++ 1 file changed, 34 insertions(+) diff --git a/ofproto/ofproto-unixctl.man b/ofproto/ofproto-unixctl.man

[ovs-dev] [PATCH 2/2] ovn-util: Allow /32 IP addresses for router ports.

On Google cloud, a VM gets a /32 IP address. When OVN is deployed on such VMs, the OVN gateway router's IP address becomes a /32 IP address. This commit allows such a configuration. Signed-off-by: Gurucharan Shetty --- ovn/lib/ovn-util.c | 7 +--- tests/ovn.at | 100

[ovs-dev] [PATCH 1/2] ovn-northd: Allow static routes with nexthop in different subnet.

There are cases where the default gateway of a interface is in a different subnet than its IP address. Linux allows such configuration. For e.g, one could set the IP address of a Linux interface as 172.16.1.2/32 and then give it a default gateway of 172.16.1.1. This can be done for e.g. by

Re: [ovs-dev] [PATCH] tests: Fix mcast test on slow systems

On Wed, Mar 08, 2017 at 02:31:56PM +, Alin Serdean wrote: > On slow systems(or which start processes slow) the test: > `testing mcast - delete the port mdb when port destroyed` > is influenced by the running time. > i.e.: >

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

On Fri, Mar 10, 2017 at 10:22 AM, Numan Siddique wrote: > Thanks for the review. Please see inline. > > > On Fri, Mar 10, 2017 at 1:44 AM, Russell Bryant wrote: > >> On Mon, Feb 27, 2017 at 12:59 AM, wrote: >> > From: Numan Siddique

Re: [ovs-dev] [PATCH] docs: Use DPDK 16.11.1 stable release.

> 2017-03-09 13:15 GMT-08:00 Ian Stokes : > > DPDK now provides a stable release branch. Modify dpdk docs and travis > > linux build script to use the DPDK 16.11.1 stable branch to benefit > > from most recent bug fixes. > > > > Signed-off-by: Ian Stokes

[ovs-dev] [PATCH v2] docs: Use DPDK 16.11.1 stable release.

DPDK now provides a stable release branch. Modify dpdk docs and travis linux build script to use the DPDK 16.11.1 stable branch to benefit from most recent bug fixes. Signed-off-by: Ian Stokes --- v1 -> v2 * Set correct path to DPDK stable branch for EXTRA_OPTS in travis

[ovs-dev] [PATCH v2 branch-2.6] docs: Use DPDK 16.07.2 stable release

DPDK now provides a stable release branch. Modify dpdk docs and travis linux build script to use the DPDK 16.07.2 stable branch to benefit from most recent bug fixes. Signed-off-by: Ian Stokes --- v1 -> v2 * Set correct path to DPDK stable branch for EXTRA_OPTS in travis

Re: [ovs-dev] Documentation: Report errors for use of features not in Sphinx 1.1.3.

I've sent the patch for removing highlighting at all here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329651.html Only 'windows.rst' uses this functionality. So, I think, it's better to just remove it and forbid the highlighting to avoid any issues with external dependencies. Best

[ovs-dev] [PATCH] Documentation: Remove external dependence on pygments.

Current documentation uses syntax highlighting in 'sphinx' via 'pygments' library. This leads to build failures on the systems with old version of this library. In fact that only 'windows.rst' uses highlighting it's a very simple change. This helps us to avoid build issues on different systems

Re: [ovs-dev] [PATCH ovs V3 00/25] Introducing HW offload support for openvswitch

On Wed, Feb 08, 2017 at 05:29:13PM +0200, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are able to