Re: [ovs-dev] [PATCH] patch: Check the right variable for null.

On Thu, Jun 01, 2017 at 04:57:42PM -0700, Justin Pettit wrote: > > > On May 26, 2017, at 10:55 PM, Ben Pfaff wrote: > > > > This function tried to check 'iface_peer' for null, but it actually > > checked its always-nonnull 'peer' argument instead. This fixes the > > problem. > >

[ovs-dev] [PATCH 2/2] ovn-northd: Fix ping failure of vlan networks.

There are two computer node, each have one vm. And the two vms in indifferent vlan networks. The ping between the vms is not success. The reason is that, acl of to-localnet port or from-localnet port is signed to contrack. So the pair of icmp request and reply have different zone id in one ovs

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: Fix severe memory leak in ipfix_send_template_msgs().

> On May 26, 2017, at 9:14 PM, Ben Pfaff wrote: > > This fixes a seemingly severe memory leak in ipfix_send_template_msgs(). > This function was setting up a buffer with a stub, but only the first 4 > or 8 bytes of the stub were actually used because the "sizeof" call used > to

Re: [ovs-dev] [PATCH] test-cmap: Avoid shift by full width of type in find_batch().

> On May 26, 2017, at 9:52 PM, Ben Pfaff wrote: > > In C, it is undefined to shift an N-bit value by N. This fixes the > problem in find_batch() for the case where i == 0. > > Found by Coverity. > > Reported-at: >

Re: [ovs-dev] [PATCH] extract-ofp-errors: Avoid unintentional sign extension in generated code.

> On May 26, 2017, at 8:59 PM, Ben Pfaff wrote: > > Code generated by this program includes constructs like this: > >switch (((uint64_t) vendor << 32) | (type << 16) | code) > > with variables uint32_t vendor, uint16_t type, uint16_t code. By C rules, > "type << 16" has

Re: [ovs-dev] [PATCH] ofp-util: Mask config value as intended in ofputil_decode_port_mod().

> On May 26, 2017, at 8:39 PM, Ben Pfaff wrote: > > The code in ofputil_decode_port_mod() was originally meant to mask > the returned 'config' value against 'mask'. That is, only bits that are > marked in 'mask' as to be modified can be set to 1-bits in the returned > 'config'

Re: [ovs-dev] [PATCH] ofp-util: Remove dead code from ofputil_encode_get_async_reply().

> On May 26, 2017, at 8:30 PM, Ben Pfaff wrote: > > Found by Coverity. > > Reported-at: > https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762682=4304823=180423 > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH] checkpatch: Also exempt Makefile.am from leading whitespace checks.

On Thu, Jun 01, 2017 at 10:10:02AM -0700, Greg Rose wrote: > On Thu, 2017-06-01 at 07:36 -0700, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > utilities/checkpatch.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/utilities/checkpatch.py

[ovs-dev] New Pricelist 01-06-2017

Click here for our latest pricelist for June Click here for all offers... If you no longer wish to receive mail from us, you can unsubscribe

Re: [ovs-dev] [PATCH] netdev: Fix netdev_open() to adhere to class type if given

On Thu, Jun 01, 2017 at 11:13:48AM -0700, Greg Rose wrote: > On Thu, 2017-06-01 at 14:38 +0200, Eelco Chaudron wrote: > > When trying to configure a system port as type=internal it could start > > an infinite port creation loop. When this happens you will see the > > following log messages: > > >

Re: [ovs-dev] [PATCH] netdev: Fix netdev_open() to adhere to class type if given

On Thu, 2017-06-01 at 14:38 +0200, Eelco Chaudron wrote: > When trying to configure a system port as type=internal it could start > an infinite port creation loop. When this happens you will see the > following log messages: > > 2017-06-01T09:00:17.900Z|02813|dpif|WARN|system@ovs-system: failed

[ovs-dev] [PATCH] system-traffic: 802.1ad: Add double VLAN match test case

Test case to match outer, pop outer, then match inner VLAN. Signed-off-by: Eric Garver --- tests/system-traffic.at | 35 +++ 1 file changed, 35 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index

Re: [ovs-dev] 回复： [PATCH] ovn-northd: Add logical flows to reply ICMP echo requests for all the other router ports connected to one switch

On Thu, Jun 1, 2017 at 4:28 AM, 钢锁0918 wrote: > that is for this problem[ovs-dev] [ovs-discuss] ovn: unsnat handling error > for Distributed Gatewayhttps://mail.openvswitch.org/pipermail/ovs- > dev/2017-April/330536.html I don't understand why this workaround is a good

Re: [ovs-dev] 回复： [PATCH] ovn-northd: Add logical flows to reply ICMP echo requests for all the other router ports connected to one switch

IMO, following that discuss mail chain, it ends up here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331200.html I did not see any update to the test case to reproduce the problem. On 1 June 2017 at 04:28, 钢锁0918 wrote: > that is for this problem[ovs-dev]

Re: [ovs-dev] [BUG] ovs-ofctl version 2.5.0 will crash with OFPFMFC_BAD_COMMAND

On Tue, May 16, 2017 at 12:07:38PM +0800, ychen wrote: > I can reproduce this problem with the script supported by vguntaka in both > ovs version 2.5 and ovs version 2.6. > > 1. Add bridge > > ovs-vsctl add-br br0 > > > > 2. Add vm port > > ovs-vsctl add-port br0 tap0 – set

Re: [ovs-dev] [PATCH] bfd: Detect Multiplier configuration

On Thu, Jun 01, 2017 at 04:00:10PM +0200, Gabor Szucs wrote: > > hereby I'm sending an implementation of configurable BFD Detect Multiplier. Hi, thanks for the patch. This doesn't apply; in fact, every single hunk is a reject against master. Maybe you should submit it as a pull request via

Re: [ovs-dev] [PATCH V9 02/31] tc: Introduce tc module

On 30/05/2017 11:07, Simon Horman wrote: On Sun, May 28, 2017 at 02:59:44PM +0300, Roi Dayan wrote: Add tc module to expose tc operations to be used by other modules. Move some tc related functions from netdev-linux.c to tc.c This patch doesn't change any functionality. Signed-off-by: Paul

[ovs-dev] [PATCH] checkpatch: Fix typo for use as filter.

ovs_checkpatch_parse() takes 2 arguments, not sys.exit(). Oops. Fixes: 95bd35d3db19 ("checkpatch: Implement -f option more usefully.") Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py

[ovs-dev] [PATCH] checkpatch: Also exempt Makefile.am from leading whitespace checks.

Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 1c83b2965cbd..3ebd53ad06b7 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -200,7

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: Incremental addition/deletion of PMD threads.

>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] >On Behalf Of >Ilya Maximets >Sent: Tuesday, May 30, 2017 3:12 PM >To: d...@openvswitch.org; Darrell Ball >Cc: Heetae Ahn ; Ilya Maximets >

Re: [ovs-dev] [PATCH v3] Replace most uses of and references to "ifconfig" by "ip".

On Thu, Jun 01, 2017 at 09:08:45AM +0200, Matthias May wrote: > On 31/05/17 18:29, Greg Rose wrote: > > On Wed, 2017-05-31 at 08:32 -0700, Ben Pfaff wrote: > >> On Wed, May 31, 2017 at 11:39:28AM +0200, Matthias May wrote: > >>> On 27/05/17 04:29, Hunt Xu wrote: > On Fri, May 26, 2017 at

Re: [ovs-dev] [PATCH v4] Replace most uses of and references to "ifconfig" by "ip".

On Thu, Jun 01, 2017 at 04:55:41AM -0700, Greg Rose wrote: > On Wed, 2017-05-31 at 16:08 -0700, Greg Rose wrote: > > On Wed, 2017-05-31 at 14:32 -0700, Ben Pfaff wrote: > > > On Wed, May 31, 2017 at 02:13:31PM -0700, Greg Rose wrote: > > > > > > > > [snip] > > > > > > They both seem to be

[ovs-dev] [PATCH] bfd: Detect Multiplier configuration

Hi, hereby I'm sending an implementation of configurable BFD Detect Multiplier. Mult value (bfd.DetectMult in RFC5880) is hard-coded and equal to 3 in current openvswitch. As a consequence remote and local mult is the same. In this commit the mult (Detect Multiplier/bfd.DetectMult/Detect Mult)

[ovs-dev] [PATCH] netdev: Fix netdev_open() to adhere to class type if given

When trying to configure a system port as type=internal it could start an infinite port creation loop. When this happens you will see the following log messages: 2017-06-01T09:00:17.900Z|02813|dpif|WARN|system@ovs-system: failed to add ve01_1 as port: File exists

Re: [ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: multi-segment mbuf jumbo frame support

>From: Darrell Ball [mailto:db...@vmware.com] >Sent: Thursday, June 1, 2017 1:14 AM >To: Kavanagh, Mark B ; Chandran, Sugesh >; ovs-dev@openvswitch.org; qiud...@chinac.com >Subject: Re: [ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: multi-segment

Re: [ovs-dev] [PATCH v4] Replace most uses of and references to "ifconfig" by "ip".

On Wed, 2017-05-31 at 16:08 -0700, Greg Rose wrote: > On Wed, 2017-05-31 at 14:32 -0700, Ben Pfaff wrote: > > On Wed, May 31, 2017 at 02:13:31PM -0700, Greg Rose wrote: > > > > > [snip] > > > > They both seem to be broken SFAICT. > > > > > > I'll work on fixing them up. > > > > Thank you! >

[ovs-dev] 回复： [PATCH] ovn-northd: Add logical flows to reply ICMP echo requests for all the other router ports connected to one switch

that is for this problem[ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gatewayhttps://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330536.html *RTFSC* --发件人：Ben Pfaff

[ovs-dev] oferta de empréstimo

Dia bom, Nós NORTON FINANCE COMPANY baseados no Reino Unido pelas operações e boa base de clientes em todo o mundo. Nós fornecemos vários tipos de empréstimos (empréstimos de curto e longo prazo, empréstimos pessoais, empréstimos a empresas, etc.) por taxa de juros de 3%. Emitemos

[ovs-dev] oferta de empréstimo

Dia bom, Nós NORTON FINANCE COMPANY baseados no Reino Unido pelas operações e boa base de clientes em todo o mundo. Nós fornecemos vários tipos de empréstimos (empréstimos de curto e longo prazo, empréstimos pessoais, empréstimos a empresas, etc.) por taxa de juros de 3%. Emitemos

Re: [ovs-dev] [PATCH v2] Update relevant artifacts to add support for DPDK 17.05.

On 06/01/2017 08:57 AM, Weglicki, MichalX wrote: > Hello, > > Thank all for your comments, my answers inline. > > Br, > Michal. > >> -Original Message- >> From: Darrell Ball [mailto:db...@vmware.com] >> Sent: Thursday, June 1, 2017 4:41 AM >> To: Kavanagh, Mark B