Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-10 Thread Ben Pfaff
On Sun, Jul 09, 2017 at 10:53:52PM +, Darrell Ball wrote: > I went thru. this patch and see the merits of the objective. > I also did various testing with it. > I had one comment inline. > > However, I would feel more comfortable if Ben possibly could take a look as > well. Thanks a lot, I

Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-10 Thread Ben Pfaff
On Thu, Jun 22, 2017 at 10:10:49PM +0100, Bhanuprakash Bodireddy wrote: > pkt_metadata_init() is called for every packet in userspace datapath and > initializes few members in pkt_metadata. Before this the members that > needs to be initialized are prefetched using pkt_metadata_prefetch_init(). >

[ovs-dev] [PATCH v2 2/2] packets: Reorganize the pkt_metdata structure.

2017-07-10 Thread Ben Pfaff
From: Bhanuprakash Bodireddy pkt_metadata_init() is called for every packet in userspace datapath and initializes few members in pkt_metadata. Before this the members that needs to be initialized are prefetched using pkt_metadata_prefetch_init(). The above

[ovs-dev] [PATCH v2 1/2] util: Make PADDED_MEMBERS work more than once per struct.

2017-07-10 Thread Ben Pfaff
Until now, if the PADDED_MEMBERS macro was used more than once in a struct, it caused Clang and GCC warnings because of multiple definition of a member named "pad". This commit fixes the problem by giving each of these a unique name. MSVC, Clang, and GCC all support the __COUNTER__ macro,

Re: [ovs-dev] [PATCH v2 2/3] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

2017-07-10 Thread Darrell Ball
On 7/10/17, 12:41 AM, "Ilya Maximets" wrote: On 07.07.2017 21:09, Darrell Ball wrote: > > > On 7/6/17, 11:11 PM, "Ilya Maximets" wrote: > > On 07.07.2017 08:08, Darrell Ball wrote: > > > > >

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-10 Thread Darrell Ball
On 7/10/17, 2:44 AM, "Kavanagh, Mark B" wrote: >From: Darrell Ball [mailto:db...@vmware.com] >Sent: Saturday, July 8, 2017 10:34 PM >To: Kavanagh, Mark B ; Chandran, Sugesh >;

[ovs-dev] [PATCH] Fixes: 3f5b5f7b4115 ("db-ctl-base: Always support all tables in schema.")

2017-07-10 Thread ZhiPeng Lu
This fixes an assertion failure in command "ovs-vsctl list netflow br0", if bridge br0 without any netflows. $ovs-vsctl list netflow br0 ovs-vsctl: lib/ovsdb-idl.c:2407: assertion column_idx < class->n_columns failed in ovsdb_idl_read() Aborted Get_row_by_id() shoudle return NULL if not find by

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-10 Thread Darrell Ball
Hi Sugesh For future reference, the naming guidelines are actually pretty flexible in this regard. Note that the cover letter will not get merged anyways, so it is moot. Can you 1) Split out all the changes to the dp-packet module as Patch 1. You can say the new ‘*_bad’ APIs will get their

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-10 Thread Chandran, Sugesh
Hi Darell, Ilya Regards _Sugesh > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Monday, July 10, 2017 5:53 PM > To: Ilya Maximets ; ovs-dev@openvswitch.org; > Ben Pfaff > Cc: Chandran, Sugesh ;

Re: [ovs-dev] [PATCH] tests: use full option name in bridge tests

2017-07-10 Thread Ben Pfaff
On Mon, Jul 10, 2017 at 01:57:13PM -0400, Lance Richardson wrote: > GNU getopt_long() accepts abbreviated long option names that are > unambiguous, but other implemenations (notably musl libc) do not. > > Avoid issues with non-GNU implementations by using the full option > name. > >

Re: [ovs-dev] [PATCH v1 3/6] ovn: extend expr symbols for ND

2017-07-10 Thread Ben Pfaff
On Thu, Jun 15, 2017 at 02:08:39PM +0530, nusid...@redhat.com wrote: > From: Zong Kai LI > > This patch updates ND symbols in logical-fields - "nd", "nd.target", > "nd.sll" and "nd.tll" to describe more clear about "icmp6.type" > predicate. > > It adds new symbols: > -

Re: [ovs-dev] [PATCH v1 2/6] packets: Fix the reset dp_packet buffer issue in packet_put_ra_prefix_opt

2017-07-10 Thread Ben Pfaff
On Thu, Jun 15, 2017 at 02:08:15PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > packet_put_ra_prefix_opt() resets the dp_packet buffer incorrectly. > > Fixes: b24ab67c2dfd ("packets: add compose_nd_ra") > Signed-off-by: Numan Siddique

Re: [ovs-dev] [PATCH v1 1/6] ofproto-dpif: Fix the clone issue with continuation

2017-07-10 Thread Ben Pfaff
On Thu, Jun 15, 2017 at 02:07:59PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > When the clone action is composed and if the inner clone actions > modifies any of the metadata fields, the updated values are not > preserved when xlate_clone() returns. This

Re: [ovs-dev] OVSDB Replication: Clarifications required

2017-07-10 Thread Andy Zhou
On Tue, Jul 4, 2017 at 10:52 PM, Arunkumar Rg wrote: > Hi, > > Got few clarifications on OVSDB replication. Please let me know your inputs > on it. > > 1. From the ovsdb-server code(main_loop()), it seems that the standby > ovsdb-server becomes 'Active' if the JSONRPC

[ovs-dev] Notice..

2017-07-10 Thread www
I am Quinton Wells. I need you to handle a Monetary deal respond to (quintonwel...@gmail.com) for more details ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 10/10] system-layer3-tunnels: Add basic GRE ping test case

2017-07-10 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-layer3-tunnels.at | 49 ++ 1 file changed, 49 insertions(+) diff --git a/tests/system-layer3-tunnels.at b/tests/system-layer3-tunnels.at index 585b63d94d5f..db64e231da8b 100644 ---

[ovs-dev] [PATCH 09/10] system-common-macros: Add macro to check for L3 GRE support

2017-07-10 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-common-macros.at | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 77f09f8d7018..6f0ed2d7f42e 100644 --- a/tests/system-common-macros.at +++

[ovs-dev] [PATCH 07/10] system-common-macros: Add macro to check for VXLAN-GPE support

2017-07-10 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-common-macros.at | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 667390e61dec..77f09f8d7018 100644 --- a/tests/system-common-macros.at +++

[ovs-dev] [PATCH 08/10] system-layer3-tunnels: Add basic VXLAN-GPE ping test case

2017-07-10 Thread Eric Garver
This also adds a new autotest file specifically for layer3 tunnels. Signed-off-by: Eric Garver --- tests/automake.mk | 1 + tests/system-kmod-testsuite.at | 1 + tests/system-layer3-tunnels.at | 50 +

[ovs-dev] [PATCH 06/10] system-common-macros: Add macro to check for ip-route encap support

2017-07-10 Thread Eric Garver
This is used for native layer3 tunnels. Signed-off-by: Eric Garver --- tests/system-common-macros.at | 4 1 file changed, 4 insertions(+) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 4408eaada9da..667390e61dec 100644 ---

[ovs-dev] [PATCH 05/10] system-common-macros: Allow passing config to ADD_OVS_TUNNEL

2017-07-10 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-common-macros.at | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 3cb6b11ea44f..4408eaada9da 100644 --- a/tests/system-common-macros.at +++

[ovs-dev] [PATCH 04/10] dpif-netlink-rtnl: Support layer3 GRE

2017-07-10 Thread Eric Garver
Add support for creating layer3 GRE. Signed-off-by: Eric Garver --- lib/dpif-netlink-rtnl.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c index f02fe37e9a6a..32e220fc135c 100644 ---

[ovs-dev] [PATCH 03/10] dpif-netlink-rtnl: Support VXLAN-GPE

2017-07-10 Thread Eric Garver
Add support for creating VXLAN tunnels with GPE. This enables layer3 VXLAN tunnels with kernel datapath. Signed-off-by: Eric Garver --- lib/dpif-netlink-rtnl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netlink-rtnl.c

[ovs-dev] [PATCH 02/10] dpif-netlink: For non-Ethernet, use Ethertype from packet_type

2017-07-10 Thread Eric Garver
For non-Ethernet flows, when fixing up the netlink message we need make sure to pass down a valid Ethertype. The kernel does not understand packet_type so it's implicitly encoded by the absence of _ETHERNET and exact match of _ETHERTYPE. Without this change match_validate in the kernel complains

[ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-10 Thread Eric Garver
This series enables support for layer3 tunnels VXLAN-GPE and GRE in the kernel datapath. It includes new system-traffic test cases. The first two patches fix an issue translating packet_type from flows for the kernel. Note: VXLAN-GPE depends on a fix recently posted to the list.

Re: [ovs-dev] [PATCH v2 2/3] ovn-controller: readonly mode binding_run and get_br_int

2017-07-10 Thread Han Zhou
On Mon, Jul 10, 2017 at 11:05 AM, Ben Pfaff wrote: > > On Wed, Jun 07, 2017 at 09:32:46AM -0700, Han Zhou wrote: > > This change is to prepare for the future change for multi-threading. > > Both binding_run() and get_br_int() are needed by pinctrl thread, > > but we don't want to

Re: [ovs-dev] [PATCH 1/2] tc: Fix compile with Glibc < 2.24 and Linux > 4.5.

2017-07-10 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 02:33:22PM -0700, Joe Stringer wrote: > linux/pkt_cls.h indirectly includes linux/stddef.h, which may define > __always_inline when using Linux kernel headers 4.6 or later. > > netinet/in.h indirectly includes sys/cdefs.h, which before Glibc 2.24 > would unconditionally

Re: [ovs-dev] [RFC PATCH v2] make logs not readable by other

2017-07-10 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 04:50:21PM +0200, Timothy Redaelli wrote: > The Open vSwitch log directory and files are currently set world readable. > > However, since only Open vSwitch users and processes need to access this > directory and these files there is no need to allow the world to access

Re: [ovs-dev] [RFC PATCH 3/3] dpif-netdev: Add rxq prioritization

2017-07-10 Thread Ben Pfaff
On Fri, Jun 16, 2017 at 05:00:48PM +0100, Billy O'Mahony wrote: > If an rxq is marked as 'prioritized' then keep reading from this queue until > there are no packets available. Only then proceed to other queues. > > Signed-off-by: Billy O'Mahony This idea seems like it

Re: [ovs-dev] [RFC PATCH 1/3] netdev: Add set_ingress_sched to netdev api

2017-07-10 Thread Ben Pfaff
On Fri, Jun 16, 2017 at 05:00:46PM +0100, Billy O'Mahony wrote: > Passes ingress_sched config item from other_config column of Interface > table to the netdev. > > Signed-off-by: Billy O'Mahony Seems like a reasonable idea to me. This adds a new configuration option

Re: [ovs-dev] [PATCH v2 2/2] ovn-controller: Use separate thread for packet-in processing.

2017-07-10 Thread Han Zhou
On Mon, Jul 10, 2017 at 11:09 AM, Ben Pfaff wrote: > > On Wed, Jun 07, 2017 at 09:32:47AM -0700, Han Zhou wrote: > > This patch introduces multi-threading for ovn-controller and use > > dedicated thread for packet-in processing as a start. It decouples > > packet-in processing and

Re: [ovs-dev] [PATCH v2] datapath-windows: Add validations in fragmentation module

2017-07-10 Thread Ben Pfaff
On Fri, Jun 09, 2017 at 07:54:45PM -0700, Anand Kumar wrote: > - Minimum valid fragment size is 400 bytes, any fragment smaller > is likely to be intentionally crafted (CVE-2000-0305). > > - Validate maximum length of an Ip datagram > > - Added counters to keep track of number of fragments for a

Re: [ovs-dev] [PATCH v2 2/2] ovn-controller: Use separate thread for packet-in processing.

2017-07-10 Thread Ben Pfaff
On Wed, Jun 07, 2017 at 09:32:47AM -0700, Han Zhou wrote: > This patch introduces multi-threading for ovn-controller and use > dedicated thread for packet-in processing as a start. It decouples > packet-in processing and ovs flow computing, so that packet-in inputs > won't trigger flow

Re: [ovs-dev] [PATCH v2 2/3] ovn-controller: readonly mode binding_run and get_br_int

2017-07-10 Thread Ben Pfaff
On Wed, Jun 07, 2017 at 09:32:46AM -0700, Han Zhou wrote: > This change is to prepare for the future change for multi-threading. > Both binding_run() and get_br_int() are needed by pinctrl thread, > but we don't want to update SB DB or create bridges in that scenario, > so need "readonly" mode for

[ovs-dev] [PATCH] tests: use full option name in bridge tests

2017-07-10 Thread Lance Richardson
GNU getopt_long() accepts abbreviated long option names that are unambiguous, but other implemenations (notably musl libc) do not. Avoid issues with non-GNU implementations by using the full option name. Signed-off-by: Lance Richardson --- tests/bridge.at | 4 ++-- 1 file

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-10 Thread Russell Bryant
On Mon, Jul 10, 2017 at 5:38 AM, Miguel Angel Ajo Pelayo wrote: > > > On Fri, Jul 7, 2017 at 9:09 PM, Russell Bryant wrote: >> >> review part 2 of this one ... >> >> On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo >> wrote: >> > This

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-10 Thread Darrell Ball
On 7/10/17, 1:37 AM, "Ilya Maximets" wrote: > ‘chceksum’ is misspelled > > Since these patches really only affect ‘dpdk’, the module name ‘dpdk’ may more accurately > reflect the real effect of these patches. Please, don't do that. Only

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-10 Thread Darrell Ball
On 7/10/17, 3:28 AM, "Chandran, Sugesh" wrote: Regards _Sugesh > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, July 10, 2017 9:37 AM > To: ovs-dev@openvswitch.org; Darrell

Re: [ovs-dev] [PATCH] gitignore: Ignore some generated files.

2017-07-10 Thread Justin Pettit
> On Jul 10, 2017, at 5:03 AM, Lance Richardson wrote: > > Hi Justin, > > I posted a similar patch recently: > > https://patchwork.ozlabs.org/patch/782880/ > > It ignores these as well as some valgrind output files. Sorry I missed that. I merged your patch into

Re: [ovs-dev] [PATCH] treewide: .gitignore updates

2017-07-10 Thread Justin Pettit
> On Jun 30, 2017, at 7:28 AM, Lance Richardson wrote: > > Signed-off-by: Lance Richardson > --- > ovn/utilities/.gitignore | 2 ++ > tests/.gitignore | 2 ++ > vtep/.gitignore | 1 + > 3 files changed, 5 insertions(+) Thanks, Lance. I

Re: [ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

2017-07-10 Thread Zoltán Balogh
Hi Darrell, Thank you for the log and the investigation. Unfortunately, I wasn't able to reproduce the fault. I used two systems: - Ubuntu 17.04 Linux host1 4.10.0-26-generic #30-Ubuntu SMP Tue Jun 27 09:30:12 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux - Ubuntu 14.04.5 LTS Linux host2

[ovs-dev] Amazon users’ list.

2017-07-10 Thread alana . nelson
Hi,   To get good leads it’s important to have reliable source. We provide contacts from across the globe. We have recently updated our Amazon users’ list and thought you might be interested in it.   We provide 100% verified and opt-in contacts. We can provide you with tailor-made list

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-10 Thread Miguel Angel Ajo Pelayo
On Mon, Jul 10, 2017 at 11:38 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > > > On Fri, Jul 7, 2017 at 9:09 PM, Russell Bryant wrote: > >> review part 2 of this one ... >> >> On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo >> wrote: >> > This

Re: [ovs-dev] [PATCH v2] dpif-netlink: convert packet_type netlink attribute

2017-07-10 Thread Eric Garver
On Mon, Jul 10, 2017 at 09:30:22AM +, Zoltán Balogh wrote: > Hi Eric, > > Thank you for fixing this. I'm fine with your solution. Tests do pass. Thanks for verifying. I'll add the patches below to my series and post it ASAP. > > Best regards, > Zoltan > > > This still did not do the

[ovs-dev] [PATCH v10] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread Billy O'Mahony
Previously if there is no available (non-isolated) pmd on the numa node for a port then the port is not polled at all. This can result in a non-operational system until such time as nics are physically repositioned. It is preferable to operate with a pmd on the 'wrong' numa node albeit with lower

[ovs-dev] [PATCH v4 2/2] conntrack : Use Rx checksum offload feature on DPDK ports for conntrack.

2017-07-10 Thread Sugesh Chandran
Avoiding checksum validation in conntrack module if it is already verified in DPDK physical NIC ports. Signed-off-by: Sugesh Chandran --- lib/conntrack.c | 63 - lib/dp-packet.h | 22 2 files

[ovs-dev] [PATCH v4 1/2] dp-packet : Update the rx checksum validation to use DPDK checksum masks.

2017-07-10 Thread Sugesh Chandran
DPDK ports use masks while reporting rx checksum flags. OVS should use these mask along with reported checksum flag while validating the rx checksum. Signed-off-by: Sugesh Chandran Suggested-by: Darrell Ball --- lib/dp-packet.h | 6 -- 1 file

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

2017-07-10 Thread Eelco Chaudron
On 10/07/17 14:03, Thadeu Lima de Souza Cascardo wrote: On Mon, Jul 10, 2017 at 06:47:21AM -0300, Thadeu Lima de Souza Cascardo wrote: ... However the interface ports for VXLAN have to be unique on the same destination port, i.e. they need a different VNI. Looking at the datapath code (only

Re: [ovs-dev] [PATCH] gitignore: Ignore some generated files.

2017-07-10 Thread Lance Richardson
> From: "Justin Pettit" > To: d...@openvswitch.org > Sent: Monday, 10 July, 2017 2:51:39 AM > Subject: [ovs-dev] [PATCH] gitignore: Ignore some generated files. > > "ovn-docker-overlay-driver", "ovn-docker-underlay-driver", and > "ovs-vtep" are generated, so they should be

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

2017-07-10 Thread Thadeu Lima de Souza Cascardo
On Mon, Jul 10, 2017 at 06:47:21AM -0300, Thadeu Lima de Souza Cascardo wrote: > On Mon, Jul 10, 2017 at 10:19:49AM +0200, Eelco Chaudron wrote: > > On 07/07/2017 08:32 PM, Ben Pfaff wrote: > > > On Fri, Jun 09, 2017 at 11:09:08AM +0200, Eelco Chaudron wrote: > > > > This is a follow up patch for

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread O Mahony, Billy
Thanks everybody. Will post v10 after lunch. /Billy > -Original Message- > From: Stokes, Ian > Sent: Monday, July 10, 2017 12:02 PM > To: Ilya Maximets ; O Mahony, Billy > ; d...@openvswitch.org > Cc: db...@vmare.com > Subject: RE:

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread Stokes, Ian
> On 10.07.2017 13:42, O Mahony, Billy wrote: > > > > > >> -Original Message- > >> From: Stokes, Ian > >> Sent: Monday, July 10, 2017 10:41 AM > >> To: Ilya Maximets ; O Mahony, Billy > >> ; d...@openvswitch.org > >> Cc: db...@vmare.com >

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread Stokes, Ian
> > -Original Message- > > From: Stokes, Ian > > Sent: Monday, July 10, 2017 10:41 AM > > To: Ilya Maximets ; O Mahony, Billy > > ; d...@openvswitch.org > > Cc: db...@vmare.com > > Subject: RE: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread Ilya Maximets
On 10.07.2017 13:42, O Mahony, Billy wrote: > > >> -Original Message- >> From: Stokes, Ian >> Sent: Monday, July 10, 2017 10:41 AM >> To: Ilya Maximets ; O Mahony, Billy >> ; d...@openvswitch.org >> Cc: db...@vmare.com >> Subject: RE:

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread O Mahony, Billy
> -Original Message- > From: Stokes, Ian > Sent: Monday, July 10, 2017 10:41 AM > To: Ilya Maximets ; O Mahony, Billy > ; d...@openvswitch.org > Cc: db...@vmare.com > Subject: RE: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on

Re: [ovs-dev] [PATCH v3 2/2] conntrack : Use Rx checksum offload feature on DPDK ports for conntrack.

2017-07-10 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Sunday, July 9, 2017 5:37 PM > To: Chandran, Sugesh ; d...@openvswitch.org > Subject: Re: [PATCH v3 2/2] conntrack : Use Rx checksum offload feature on > DPDK ports

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-10 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, July 10, 2017 9:37 AM > To: ovs-dev@openvswitch.org; Darrell Ball ; Ben Pfaff > > Cc: Chandran, Sugesh ; Traynor, Kevin

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

2017-07-10 Thread Thadeu Lima de Souza Cascardo
On Mon, Jul 10, 2017 at 10:19:49AM +0200, Eelco Chaudron wrote: > On 07/07/2017 08:32 PM, Ben Pfaff wrote: > > On Fri, Jun 09, 2017 at 11:09:08AM +0200, Eelco Chaudron wrote: > > > This is a follow up patch for an earlier patch send by Cascardo, > > > however I think this patch might not be

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-10 Thread Kavanagh, Mark B
>From: Darrell Ball [mailto:db...@vmware.com] >Sent: Saturday, July 8, 2017 10:34 PM >To: Kavanagh, Mark B ; Chandran, Sugesh >; ovs-dev@openvswitch.org; Varghese, Vipin >; acon...@redhat.com >Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread Stokes, Ian
> On 08.07.2017 22:09, Stokes, Ian wrote: > >> Previously if there is no available (non-isolated) pmd on the numa > >> node for a port then the port is not polled at all. This can result > >> in a non- operational system until such time as nics are physically > >> repositioned. It is preferable to

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-10 Thread Miguel Angel Ajo Pelayo
On Fri, Jul 7, 2017 at 9:09 PM, Russell Bryant wrote: > review part 2 of this one ... > > On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo > wrote: > > This patch handles multiple gateway_chassis with in chassisredirect > > ports, any gateway with a chassis

Re: [ovs-dev] [PATCH v2] dpif-netlink: convert packet_type netlink attribute

2017-07-10 Thread Zoltán Balogh
Hi Eric, Thank you for fixing this. I'm fine with your solution. Tests do pass. Best regards, Zoltan > This still did not do the trick. The ETHERTYPE is placed at the same > level of the message as OVS_FLOW_ATTR_MASK, rather than being place > _inside_ OVS_FLOW_ATTR_MASK. > > Below is what I

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-10 Thread Ilya Maximets
> ‘chceksum’ is misspelled > > Since these patches really only affect ‘dpdk’, the module name ‘dpdk’ may > more accurately > reflect the real effect of these patches. Please, don't do that. Only patches that changes lib/dpdk.{c,h} should have 'dpdk' prefix in subject line. All other patches

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

2017-07-10 Thread Eelco Chaudron
On 07/07/2017 08:32 PM, Ben Pfaff wrote: On Fri, Jun 09, 2017 at 11:09:08AM +0200, Eelco Chaudron wrote: This is a follow up patch for an earlier patch send by Cascardo, however I think this patch might not be needed... This patch will make sure VXLAN tunnels with and without the group based

Re: [ovs-dev] [PATCH v9] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-07-10 Thread Ilya Maximets
On 08.07.2017 22:09, Stokes, Ian wrote: >> Previously if there is no available (non-isolated) pmd on the numa node >> for a port then the port is not polled at all. This can result in a non- >> operational system until such time as nics are physically repositioned. It >> is preferable to operate

Re: [ovs-dev] [PATCH v2 2/3] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

2017-07-10 Thread Ilya Maximets
On 07.07.2017 21:09, Darrell Ball wrote: > > > On 7/6/17, 11:11 PM, "Ilya Maximets" wrote: > > On 07.07.2017 08:08, Darrell Ball wrote: > > > > > > On 5/30/17, 7:12 AM, "Ilya Maximets" wrote: > > > >

[ovs-dev] [PATCH] ofproto.at: Fix minor typo in test.

2017-07-10 Thread Justin Pettit
Signed-off-by: Justin Pettit --- tests/ofproto.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index 9e6acfad653d..c7ea31a77ce9 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -3430,7 +3430,7 @@

[ovs-dev] [PATCH] vlog: Make "vlog/set" without args set everything to "dbg".

2017-07-10 Thread Justin Pettit
The documentation stated that "ovs-appctl vlog/set" without any arguments should set every module and destination to debug level. Signed-off-by: Justin Pettit --- lib/vlog.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/vlog.c b/lib/vlog.c index

[ovs-dev] [PATCH] dpif-netdev: Initialize 'tun_md' member of match.

2017-07-10 Thread Justin Pettit
Found by valgrind. --- lib/dpif-netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 6bae4acd0dd9..bf923fa9bee8 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -2430,6 +2430,7 @@ dp_netdev_flow_add(struct dp_netdev_pmd_thread *pmd,

[ovs-dev] [PATCH] gitignore: Ignore some generated files.

2017-07-10 Thread Justin Pettit
"ovn-docker-overlay-driver", "ovn-docker-underlay-driver", and "ovs-vtep" are generated, so they should be ignored. Signed-off-by: Justin Pettit --- ovn/utilities/.gitignore | 2 ++ vtep/.gitignore | 1 + 2 files changed, 3 insertions(+) diff --git