Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

On 9/26/17, 8:27 PM, "Yuanhan Liu" wrote: On Wed, Sep 27, 2017 at 03:13:33AM +, Darrell Ball wrote: > > > On 9/26/17, 6:25 PM, "Yuanhan Liu" wrote: > > On Tue, Sep 26, 2017 at 09:58:16PM +, Darrell Ball wrote:

Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

On Wed, Sep 27, 2017 at 03:13:33AM +, Darrell Ball wrote: > > > On 9/26/17, 6:25 PM, "Yuanhan Liu" wrote: > > On Tue, Sep 26, 2017 at 09:58:16PM +, Darrell Ball wrote: > > The second major change is there is a thread introduced to do the > real >

Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

On 9/26/17, 6:25 PM, "Yuanhan Liu" wrote: On Tue, Sep 26, 2017 at 09:58:16PM +, Darrell Ball wrote: > The second major change is there is a thread introduced to do the real > flow offload. This is for diminishing the overhead by hw flow offload

Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

On Wed, Sep 27, 2017 at 09:24:54AM +0800, Yuanhan Liu wrote: > > The support needed would be in some drivers and seems reasonably doable. > > Moreover, this was discussed in the last dpdk meeting and the support was > > indicated as existing?, although I only verified the MLX code, myself. > >

Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

On Tue, Sep 26, 2017 at 09:58:16PM +, Darrell Ball wrote: > The second major change is there is a thread introduced to do the real > flow offload. This is for diminishing the overhead by hw flow offload > installation/deletion at data path. See patch 9 for more detailed info. > >

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Wed, Sep 27, 2017 at 04:59:36AM +0800, Eric Garver wrote: > On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > > + > > > > + length =

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 10:42:40PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 21:52:41 +0800, Yang, Yi wrote: > > > + return ((ret != 0) ? false : true); > > > > But I don't think this is a problematic line from my understanding, > > Why not: > > return ((ret != 0 == true) ? false :

Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when remove rev_conn.

On 9/23/17, 2:36 AM, "ovs-dev-boun...@openvswitch.org on behalf of wangyunjian" wrote: We use hping3 to send random tcp, udp from VM1 to VM2. We met a issue that conn_lookup( ) will find rev_conn->conn_type =

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Use separate thread for packet-in processing.

This is very useful to me. I found a problem in my use: In the ovn-controller and the south of the database connection，when the ovn-controller as a passive service, the SB as a client, such as configured to ovs-vsctl set Open_vSwitch . external-ids:ovn-remote=ptcp:6644:0.0.0.0 ovn-sbctl

Re: [ovs-dev] [branch-2.8 2/2] Prepare for 2.8.2.

On Tue, Sep 26, 2017 at 01:37:37PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.8 1/2] Set release date for 2.8.1.

On Tue, Sep 26, 2017 at 01:37:36PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] 2.7.3 release?

On Tue, Sep 26, 2017 at 10:34:07PM +, Darrell Ball wrote: > > > On 9/25/17, 12:41 PM, "Ben Pfaff" wrote: > > On Mon, Sep 25, 2017 at 06:37:29PM +, Darrell Ball wrote: > > > > > > On 9/25/17, 11:31 AM, "Ben Pfaff" wrote: > > > >

Re: [ovs-dev] [patch v3 1/5] conntrack: Create nat_conn_keys_insert().

On Mon, Sep 25, 2017 at 08:51:42PM -0700, Darrell Ball wrote: > Create a separate function from existing code, so the > code can be reused in a subsequent patch; no change > in functionality. > > Acked-by: Bhanuprakash Bodireddy > Signed-off-by: Darrell Ball

Re: [ovs-dev] [branch 2.8 1/2] dp-packet: Refactor DPDK packet initialization.

On Mon, Sep 25, 2017 at 07:01:35PM -0700, Darrell Ball wrote: > DPDK uses dp-packet pools and manages the mbuf portion of > each packet. When a pool is created, partial initialization is > also done on the OVS portion (i.e. non-mbuf). Since packet > memory is reused, this is not very useful for

Re: [ovs-dev] 2.7.3 release?

On 9/25/17, 12:41 PM, "Ben Pfaff" wrote: On Mon, Sep 25, 2017 at 06:37:29PM +, Darrell Ball wrote: > > > On 9/25/17, 11:31 AM, "Ben Pfaff" wrote: > > On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote: > > >

Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

On 9/25/17, 10:37 PM, "Yuanhan Liu" wrote: Some hightlights in v3 == Here is the v3, with 2 major changes and further testings (including many flows). This took more effort than I thought, thus v3 publication has been delayed

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > + > > > + length = nsh_hdr_len(nsh_hdr); > > > + skb_pull(skb, length); > > > > Do you need to verify you can

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.1.

Signed-off-by: Justin Pettit --- NEWS | 5 +++-- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 7e9c0f63a90b..ef3abd56b7f2 100644 --- a/NEWS +++ b/NEWS @@ -1,8 +1,9 @@ -v2.8.1 - xx xxx

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.2.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index ef3abd56b7f2..669d4ac8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.8.2 -

Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: log an err message when a mempool name is empty.

On 9/26/17, 8:06 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: Log an error message when the creation of a name for a new mempool fails. CC: Ciara Loftus

Re: [ovs-dev] [PATCH 1/4] netdev-dpdk: fix mempool management with vhu client.

On 9/26/17, 12:58 PM, "Darrell Ball" wrote: On 9/26/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: In a PVP test where

Re: [ovs-dev] [PATCH 2/4] netdev-dpdk: if mempool already exists don't reinit packet areas.

On 9/26/17, 8:05 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: Skip initialization of mempool objects if this was already done in a previous call to dpdk_mp_create.

Re: [ovs-dev] [PATCH 1/4] netdev-dpdk: fix mempool management with vhu client.

On 9/26/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: In a PVP test where vhostuser ports are configured as clients, OvS crashes when QEMU is launched. This

[ovs-dev] (no subject)

hi Dev http://bit.ly/2fr4D80 Best Wishes Rick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.7 2/2] Prepare for 2.7.4.

> On Sep 26, 2017, at 8:45 AM, Ben Pfaff wrote: > > On Mon, Sep 25, 2017 at 11:32:50PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed the series to branch-2.7. --Justin

Re: [ovs-dev] Help to Modify OVS Source Code

You can look at the "handle_packet_out" function at "ofproto.c" which handles the "PACKET_OUT" message from the controller. (where you can check for the LLDP eth type in the packet) On Tue, Sep 26, 2017 at 9:56 AM, Mohammed Kamel wrote: > Hello, > > I am new at mining and

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

On Mon, 25 Sep 2017 14:42:48 -0400 Aaron Conole wrote: > Flavio Leitner writes: > > > On Fri, 22 Sep 2017 09:44:18 -0400 > > Aaron Conole wrote: > > > >> When the logrotate script runs, and Open vSwitch is running as a non-root > >>

Re: [ovs-dev] Help to Modify OVS Source Code

Hello, I am new at mining and OVS. I need help with modifying the OVS source code to make the following: I want to print a message on the counsel each time the OVS switch receive a LLDP packet from the controller. and how to use this modified code in the mininet?? I really need your help with

[ovs-dev] New Production Norwegian Mackerels

  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28jxb2oatrf.html )     [ ]( http://r.newsletter.bonescamail.nl/track/click/vp48y7p7xaoatrd )    New production Purse Seined Norwegian Mackerels, we are loading this week for arrival Holland end next week :   Topquality fish,

Re: [ovs-dev] [branch-2.7 2/2] Prepare for 2.7.4.

On Mon, Sep 25, 2017 at 11:32:50PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.3.

On Mon, Sep 25, 2017 at 11:32:49PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] Proposal for enabling dp_hash irrespective of OF version

Hi Ben, As usual there is a trade-off scalability vs. max performance: The dp_hash selection method avoids the upcalls and micro-megaflows for the price of an additional recirculation. I guess that is why Jarno didn't want to make it the default selection method in the first place. It might

[ovs-dev] [PATCH 4/4] netdev-dpdk: Reword mp_size as n_mbufs.

The mp_size parameter to be passed to rte mempool creation functions is meant to contain the number of elements inside the requested mempool. So it is renamed as n_mbufs. CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole

[ovs-dev] [PATCH 3/4] netdev-dpdk: log an err message when a mempool name is empty.

Log an error message when the creation of a name for a new mempool fails. CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole Signed-off-by: Antonio Fischetti --- lib/netdev-dpdk.c | 3 +++ 1 file

[ovs-dev] [PATCH 2/4] netdev-dpdk: if mempool already exists don't reinit packet areas.

Skip initialization of mempool objects if this was already done in a previous call to dpdk_mp_create. CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole Signed-off-by: Antonio Fischetti ---

[ovs-dev] [PATCH 1/4] netdev-dpdk: fix mempool management with vhu client.

In a PVP test where vhostuser ports are configured as clients, OvS crashes when QEMU is launched. This patch avoids the repeated calls to netdev_change_seq_changed after the requested mempool is already acquired. CC: Ciara Loftus CC: Kevin Traynor

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, 26 Sep 2017 21:52:41 +0800, Yang, Yi wrote: > > + return ((ret != 0) ? false : true); > > But I don't think this is a problematic line from my understanding, Why not: return ((ret != 0 == true) ? false : true) == true; ? Sigh. This is equal to: return !ret; which

Re: [ovs-dev] [PATCH v3 2/4] netdev: Remove unused may_steal.

On 25.09.2017 18:23, Bodireddy, Bhanuprakash wrote: >> Not needed anymore because 'may_steal' already handled on dpif-netdev >> layer and always true; > > LGTM. > 'may_steal' is still used by QoS policer in netdev layer. I am not familiar > with Policer functionality but > Just wondering

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Output packet batching.

On 25.09.2017 18:07, Bodireddy, Bhanuprakash wrote: > Hi Ilya, > > This series needs to be rebased. Few comments below. Hi. Thanks for review. I just returned from vacation and starting working on this. Comments inline. Best regards, Ilya Maximets. > >> While processing incoming batch of

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

On 09/22/2017 03:44 PM, Aaron Conole wrote: > When the logrotate script runs, and Open vSwitch is running as a non-root > user, the /var/log/openvswitch directory doesn't have other rx bits set. > This means the reopen attempt will fail with "permission denied", even though > the default logrotate

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 07:05:34PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 12:47:16 +0800, Yi Yang wrote: > > + return ((ret != 0) ? false : true); Jiri, I appriciate your review very carefully and professionally from my heart for 10 versions, that is really very very big effort. I

Re: [ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

Wow, great :) Having random cap times within a range sounds like a nice improvement, that's a good idea. On Mon, Sep 25, 2017 at 2:34 PM, Ben Pfaff wrote: > OVS has that already too, but the retry time caps out at 8 seconds > currently. It goes from 1 to 2 to 4 to 8 seconds.

[ovs-dev] [PATCH v2 4/4] conntrack: read current nr of connections.

Example: ovs-appctl dpctl/ct-get-glbl-cfg totconn CC: Kevin Traynor Signed-off-by: Antonio Fischetti --- lib/conntrack.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/conntrack.c b/lib/conntrack.c index 684e468..b04ffb9

[ovs-dev] [PATCH v2 2/4] conntrack: add commands to r/w CT parameters.

Add infrastructure to implement: - dpctl/ct-get-glbl-cfg to read a current value of available conntrack parameters. - dpctl/ct-set-glbl-cfg to set a value to the available conntrack parameters. CC: Kevin Traynor Signed-off-by: Antonio Fischetti

[ovs-dev] [PATCH v2 3/4] conntrack: r/w upper limit connection value.

Read/Write the upper limit value for connections. Example: # set a new upper limit ovs-appctl dpctl/ct-set-glbl-cfg maxconn=100 # display cur upper limit ovs-appctl dpctl/ct-get-glbl-cfg maxconn CC: Kevin Traynor Signed-off-by: Antonio Fischetti

[ovs-dev] [PATCH v2 1/4] dpctl: Add a comment to functions retrieving the datapath name.

Signed-off-by: Antonio Fischetti --- lib/dpctl.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 8951d6e..b6eecf0 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -825,6 +825,9 @@

[ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT parameters.

This series adds two new commands to allow read/write of some of the CT configuration parameters. This could be used for maintenance purposes or to find a better tuning of the current setup. V2: Reworked based on comments. V1: First implementation. Fischetti, Antonio (4): dpctl: Add a comment

[ovs-dev] [PATCH v4 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

Extend flow key part of data record to include following Information Elements: - ingressInterface - ingressInterfaceType - egressInterface - egressInterfaceType - interfaceName - interfaceDescription In case of input sampling we don't have information about egress port. Define templates depending

[ovs-dev] [PATCH v4 1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr

This commit extends netdev_dpdk_get_status API to include additional driver-related information: if_type and if_descr. v2->v3: Code rebase. v3->v4: Minor comments applied. Co-authored-by: Michal Weglicki Signed-off-by: Michal Weglicki

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, 26 Sep 2017 12:47:16 +0800, Yi Yang wrote: > + return ((ret != 0) ? false : true); I'm not going to review this version but this caught my eye - I pointed out this silly construct in my review of v9. I can understand that working late in the night and rewriting the code back and

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, 26 Sep 2017 12:47:16 +0800, Yi Yang wrote: > v9->v10 > - Change struct ovs_key_nsh to >struct ovs_nsh_key_base base; >__be32 context[NSH_MD1_CONTEXT_SIZE]; > - Fix new comments for v9 NAK, we haven't finished the discussion for v9 yet. It's not appropriate to send a new

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: > After push_nsh, the packet won't be recirculated to flow pipeline, so > key->eth.type must be set explicitly here, but for pop_nsh, the packet > will be recirculated to flow pipeline, it will be reparsed, so > key->eth.type will be set in

[ovs-dev] [PATCH v2 3/3] Update ovn.at to add multipath testcase

1. Add multipath testcase in ovn testsuites. It simulates dispatching packets in router by consuming multipath feature in Logical_Router_Static_Route. Signed-off-by: Zhenyu Gao --- tests/ovn.at | 229 +++ 1 file

[ovs-dev] [PATCH v2 2/3] Add multipath support in ovn-controller and ovn-trace

1. Update actions.h, actions.c to handle multipath action in ovn-controller. 2. Update ovn-trace to simulate action of multipath. It helps multipath debugging. Signed-off-by: Zhenyu Gao --- include/ovn/actions.h | 32 - ovn/lib/actions.c | 168

[ovs-dev] [PATCH v2 1/3] Add multipath static router in OVN northd and north-db

1. ovn-nb.ovsschema was updated output_port field. Change the max entry number from 1 to unlimited. 2. Add multipath feature in ovn-northd part. northd generates multipath flows to dispatch traffic by using packet's IP dst address if route's output_port contains two or more ports. 3. Add new

Re: [ovs-dev] [PATCH v2] dpctl: manage ret value when dumping CT entries.

Actually I forgot to add in the commit message Reviewed-by: Greg Rose Can this please be added later? Thanks, Antonio > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] > On Behalf Of antonio.fische...@intel.com

[ovs-dev] [PATCH v2] dpctl: manage ret value when dumping CT entries.

Manage error value returned by ct_dpif_dump_next. Signed-off-by: Antonio Fischetti --- lib/dpctl.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 8951d6e..d229c97 100644 ---

Re: [ovs-dev] [PATCH 1/2] dpctl: manage ret value when dumping CT entries.

Thanks Darrell, comments inline. I'll post a v2 based on your suggestions. -Antonio > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Monday, September 25, 2017 8:31 PM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable.

> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Monday, September 25, 2017 8:35 PM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable. > > > > On 9/25/17, 2:51 AM,

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

On 22/09/17 23:47, Flavio Leitner wrote: > On Fri, 22 Sep 2017 09:44:18 -0400 > Aaron Conole wrote: > >> When the logrotate script runs, and Open vSwitch is running as a non-root >> user, the /var/log/openvswitch directory doesn't have other rx bits set. >> This means the

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.3.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 3ceb55f4c623..2a8cc734ae4d 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.7.3 - xx xxx +v2.7.3 - 26 Sep