The RHEL 7 kernels expect the secret timer interval to be initialized
before calling the inet_frags_init() function. By not initializing it
the inet_frags_secret_rebuild() function was running on every tick
rather than on the expected interval. This caused occasional panics
from page faults when
Signed-off-by: aginwala
On Thu, Jul 19, 2018 at 4:01 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Add 'connection-status' command to ovs-appctl utility in order to check
> if a given chassis is currently connected to SB db
>
> Co-authored-by: aginwala
> Signed-off-by: Lorenzo
Thanks for the work.
Signed-off-by: Yifeng Sun
On Thu, Jul 19, 2018 at 11:34 AM, Alin Gabriel Serdean
wrote:
> The line "ovs_stt_cleanup_module();" was unreachable.
> Found using static analysis tools.
>
> Signed-off-by: Alin Gabriel Serdean
> Co-authored-by: Yifeng Sun
> ---
> v2: Remove
> Subiect: Re: [ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable
> code and goto labels
>
> I think the correct fix may be as follows, do you mind rechecking it?
> Thanks.
>
> diff --git a/datapath/vport.c b/datapath/vport.c index
> 02f6b56d3243..fcf0fea0a245 100644
> ---
The line "ovs_stt_cleanup_module();" was unreachable.
Found using static analysis tools.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Yifeng Sun
---
v2: Remove unreachable code only.
---
datapath/vport.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/datapath/vport.c
Thanks for starting the discussion, Mark.
On Thu, 19 Jul 2018 12:26:24 -0400
Mark Michelson wrote:
> On 07/19/2018 09:51 AM, Jakub Sitnicki wrote:
(...)
> > The changes are functional to the point that all test cases in the ovn-nbctl
> > test suite (tests/ovn-nbctl.at) and OVN test suite
This is a continuation of an earlier series that aims to replace calls to
ctl_fatal() in command handlers in ovn-nbctl. The motivation is to handle errors
gracefully when running commands in daemon mode because as a long-lived process
we shouldn't terminate on errors that we can recover from.
> On 19 Jul 2018, at 20:42, Ben Pfaff wrote:
>
> On Thu, Jul 19, 2018 at 07:39:42PM +0300, Alin Gabriel Serdean wrote:
>> The command: `make check-tabs` fails on Windows due to line ending
>> conversions
>> caused by the following setting: `git config --global core.autocrlf true`
>> (the
On 7/13/2018 5:56 PM, Ian Stokes wrote:
Hi Ben,
The following changes since commit
89dd5819cf181a741271d297bc99fea4760f7ba5:
rhel: support kmod-openvswitch build against multiple kernels, rhel6
(2018-07-12 17:42:07 -0700)
are available in the git repository at:
This patch backports the commit from the latest OVS master to OVS-2.9.
Configuring flow control at ixgbe netdev-init is throwing error in port
start.
For eg: without this fix, user cannot configure flow control on ixgbe dpdk
port as below,
"
ovs-vsctl add-port br0 dpdk0 -- set Interface
On Thu, Jul 19, 2018 at 07:39:42PM +0300, Alin Gabriel Serdean wrote:
> The command: `make check-tabs` fails on Windows due to line ending conversions
> caused by the following setting: `git config --global core.autocrlf true`
> (the whitelist `build-aux/initial-tab-whitelist` becomes a blacklist)
Alin Gabriel Serdean writes:
> The command: `make check-tabs` fails on Windows due to line ending conversions
> caused by the following setting: `git config --global core.autocrlf true`
> (the whitelist `build-aux/initial-tab-whitelist` becomes a blacklist)
>
> This patch adds a .gittatribute
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
ERROR:
On Tue, Jul 17, 2018 at 03:26:20PM +0300, Alin Gabriel Serdean wrote:
> The command: `make check-tabs` fails on Windows due to line ending conversions
> caused by the following setting: `git config --global core.autocrlf true`
> (the whitelist `build-aux/initial-tab-whitelist` becomes a blacklist)
> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Aaron Conole
> Trimis: Wednesday, July 18, 2018 6:02 PM
> Către: Alin Gabriel Serdean
> Cc: d...@openvswitch.org
> Subiect: Re: [ovs-dev] build: Add gitattribute file to build-aux
>
> Hi Alin,
The command: `make check-tabs` fails on Windows due to line ending conversions
caused by the following setting: `git config --global core.autocrlf true`
(the whitelist `build-aux/initial-tab-whitelist` becomes a blacklist)
This patch adds a .gittatribute file to build-aux to force LF endings
on
On 07/19/2018 09:51 AM, Jakub Sitnicki wrote:
This series extends ovn-nbctl tool with support for the daemon mode, where
ovn-nbctl acts a long-lived process that accepts commands over a UNIX socket.
The daemon can be started the same way as any other OVS/OVN server:
ovn-nbctl --detach
Get a private loan today @ 3% interest rate. We offer a friendly
service.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Ben/Aaron/All,
Kindly review the patch and let me know your views.
On Thu, Jul 12, 2018 at 11:34 PM, Aravind Prasad S
wrote:
> Currently, rule_insert() API does not have return value. There are some
> possible
> scenarios where rule insertions can fail at run-time even though the static
>
Preparatory work for getting rid of ctl_fatal() in command parser.
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 76 ++
1 file changed, 76 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 4e6986a5e..ffbd2a140
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 585967568..4e6986a5e 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1403,3 +1403,24 @@ AT_CHECK([ovn-nbctl
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 73a61a4be..585967568 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1382,3 +1382,24 @@ inactivity_probe:
Make ovn-nbctl act as a unixctl server if we were asked to detach. This
turns ovn-nbctl into a long-lived process that acts a proxy for
interacting with NB DB. The main difference to regular mode of ovn-nbctl
is that in the daemon mode, a local copy of database contents has to be
obtained only
Will be reused when parsing options in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index
Will be reused for parsing options in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index ca0f71300..490577238 100644
---
Provide a handler for options that change how the main loop behaves.
This will allow code reuse for option parsing in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 136 --
1 file changed, 84 insertions(+), 52 deletions(-)
This will allow us to direct oneline-formatted output to other sinks
than stdout if needed. Preparatory work for daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 53 ++-
1 file changed, 34 insertions(+), 19 deletions(-)
diff
Extend the main loop and the command runner so that the caller can
specify a timeout for poll_block(). This will allow us to break out of
the main loop when waiting on IDL, like in the blocked '--wait=sb/hv
sync' case.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 27
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the prerequisites runner in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git
Let the caller handle the errors instead of reporting it and
terminating. Prepare for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff
Let the caller decide how to handle the error. Prepare for using the
parser in ovn-nbctl daemon mode.
Signed-off-by: Jakub Sitnicki
---
lib/db-ctl-base.c | 30 +-
lib/db-ctl-base.h | 6 +++---
ovn/utilities/ovn-nbctl.c | 7 +--
Let the caller handle the error. Needed for ovn-nbctl daemon mode.
Signed-off-by: Jakub Sitnicki
---
lib/db-ctl-base.c | 63 +--
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index
Reset the global state, if transaction succeeded. Otherwise nbctl_exit()
callback will try to clean up on any fatal error.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index
Introduce an output parameter for the flag that signals need to retry
running the command. This leaves the return value for error reporting.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20 +---
1 file
Destroy IDL resources in the routine where we allocated them.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Split out a routine for the main ovn-nbctl loop.
Preparatory work for introducing daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Having a constant in addition to the constant expression for the default
table style allows us to reset 'struct table_style' variables to default
style.
Signed-off-by: Jakub Sitnicki
---
lib/table.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/table.h b/lib/table.h
index
If IDL was created with monitoring and alerts turned on by default for
all columns, then there is no harm in allowing the API users to ask
again for monitoring and alerts to be enabled for any given column.
This allows us to run prerequisites handlers for db-ctl and ovn-nbctl
commands once the
This series extends ovn-nbctl tool with support for the daemon mode, where
ovn-nbctl acts a long-lived process that accepts commands over a UNIX socket.
The daemon can be started the same way as any other OVS/OVN server:
ovn-nbctl --detach --pidfile --log-file
While commands can be issued to
0-day Robot writes:
> Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have
> tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> ERROR: Too many signoffs; are you missing
This patch had some compilation errors. It may be due to changes in
master since this patchset was posted:
ovn/controller/pinctrl.c: In function ‘send_garp_run’:
ovn/controller/pinctrl.c:2303:48: error: passing argument 8 of
‘get_nat_addresses_and_keys’ discards ‘const’ qualifier from pointer
On Thu, 19 Jul 2018 09:15:14 -0400
0-day Robot wrote:
(...)
> ovn/utilities/ovn-nbctl.c: In function ‘main’:
> ovn/utilities/ovn-nbctl.c:133:11: error: redefinition of ‘error’
> char *error = main_loop(args, commands, n_commands, idl);
>^
> ovn/utilities/ovn-nbctl.c:116:11:
I've had a look through and have some notes in-line. I know some of them
will be a bit nit-picky, but...sometimes that's just how I am :)
On 06/25/2018 03:53 PM, vkomm...@redhat.com wrote:
From: venkata anil
When a vm on a vlan tenant network sends traffic to an external network,
it is
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
/bin/sh ./libtool --tag=CC --mode=link gcc -std=gnu99 -Wstrict-prototypes
-Wall -Wextra
Preparatory work for getting rid of ctl_fatal() in command parser.
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 76 ++
1 file changed, 76 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 4e6986a5e..ffbd2a140
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 73a61a4be..585967568 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1382,3 +1382,24 @@ inactivity_probe:
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 585967568..4e6986a5e 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1403,3 +1403,24 @@ AT_CHECK([ovn-nbctl
Make ovn-nbctl act as a unixctl server if we were asked to detach. This
turns ovn-nbctl into a long-lived process that acts a proxy for
interacting with NB DB. The main difference to regular mode of ovn-nbctl
is that in the daemon mode, a local copy of database contents has to be
obtained only
Will be reused when parsing options in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index
Will be reused for parsing options in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index a9113b9e0..339a182e8 100644
---
Provide a handler for options that change how the main loop behaves.
This will allow code reuse for option parsing in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 136 --
1 file changed, 84 insertions(+), 52 deletions(-)
This will allow us to direct oneline-formatted output to other sinks
than stdout if needed. Preparatory work for daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 53 ++-
1 file changed, 34 insertions(+), 19 deletions(-)
diff
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the prerequisites runner in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git
Extend the main loop and the command runner so that the caller can
specify a timeout for poll_block(). This will allow us to break out of
the main loop when waiting on IDL, like in the blocked '--wait=sb/hv
sync' case.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 27
Let the caller handle the errors instead of reporting it and
terminating. Prepare for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff
Let the caller decide how to handle the error. Prepare for using the
parser in ovn-nbctl daemon mode.
Signed-off-by: Jakub Sitnicki
---
lib/db-ctl-base.c | 30 +-
lib/db-ctl-base.h | 6 +++---
ovn/utilities/ovn-nbctl.c | 7 +--
Let the caller handle the error. Needed for ovn-nbctl daemon mode.
Signed-off-by: Jakub Sitnicki
---
lib/db-ctl-base.c | 63 +--
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index
If transaction succeeded reset the state. Otherwise nbctl_exit()
callback will try to clean up on any fatal error.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index
Introduce an output parameter for the flag that signals need to retry
running the command. This leaves the return value for error reporting.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20 +---
1 file
Split out a routine for the main ovn-nbctl loop.
Preparatory work for introducing daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Destroy commands in the same routine where they were allocated.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
If IDL was created with monitoring and alerts turned on by default for
all columns, then there is no harm in allowing the API users to ask
again for monitoring and alerts to be enabled for any given column.
This allows us to run prerequisites handlers for db-ctl and ovn-nbctl
commands once the
Having a constant in addition to the constant expression for the default
table style allows us to reset 'struct table_style' variables to default
style.
Signed-off-by: Jakub Sitnicki
---
lib/table.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/table.h b/lib/table.h
index
This series extends ovn-nbctl tool with support for the daemon mode, where
ovn-nbctl acts a long-lived process that accepts commands over a UNIX socket.
The daemon can be started the same way as any other OVS/OVN server:
ovn-nbctl --detach --pidfile --log-file
While commands can be issued to
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
ERROR:
Add 'connection-status' command to ovs-appctl utility in order to check
if a given chassis is currently connected to SB db
Co-authored-by: aginwala
Signed-off-by: Lorenzo Bianconi
---
lib/jsonrpc.c | 6 ++
lib/jsonrpc.h | 1 +
lib/ovsdb-idl.c
LOL!, I need more coffee, ignore my last message.
It's a very old patch, not sure how I got to it, but I thought it was
related to answering also DHCP
requests on the provider networks.
For example, to server DHCP requests in the case of mixing SR-IOV with OVN
using VLANs
On Thu, Jul 19, 2018
Nice, I’ve been thinking about this last week.
One question, are we able to limit which chassis will respond to the DHCP
requests?
I say this, because, otherwise, if we have a lot of chassis, a single
request on
the network would be responded by all chassis which have connectivity to
such
On Wed, Jul 18, 2018 at 9:12 AM, Stephen Hemminger
wrote:
> The call to nla_nest_start when forming packet messages can lead to a NULL
> return so it's possible for attr to become NULL and we can potentially
> get a NULL pointer dereference on attr. Fix this by checking for
> a NULL return.
>
>
On Wed, Jul 18, 2018 at 9:12 AM, Stephen Hemminger
wrote:
> The call to nla_nest_start in conntrack can lead to a NULL
> return so it's possible for attr to become NULL and we can potentially
> get a NULL pointer dereference on attr. Fix this by checking for
> a NULL return.
>
> Bugzilla:
72 matches
Mail list logo
